63491 2011-06-27 15:57:57 -0700 [EFL] Remove IconDatabase initialization in _ewk_init_body() 2011-07-14 23:07:47 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) All Linux RESOLVED FIXED P2 Normal --- 0 ljaehun.lim webkit-unassigned gyuyoung.kim gyuyoung.kim lucas.de.marchi rakuco ryuan.choi webkit.review.bot oldest_to_newest 428410 0 ljaehun.lim 2011-06-27 15:57:57 -0700 IconDatabase is an optional feature. But EFL port enables it in _ewk_init_body() as default. So, when an application enables IconDatabse after ewk_init(), WebKit prints an warning message. (See another bugs, 60361, 60148, 59238) I think it's better that an application should decide whether to use IconDatabase or not, and be responsible for using IconDatabase. 428430 1 98811 ljaehun.lim 2011-06-27 16:22:01 -0700 Created attachment 98811 Proposed patch 428435 2 ryuan.choi 2011-06-27 16:29:50 -0700 View in context: https://bugs.webkit.org/attachment.cgi?id=98811&action=review > Source/WebKit/efl/ewk/ewk_settings.cpp:156 > if (directory) { > + if (WebCore::iconDatabase().isEnabled()) { > + ERR("IconDatabase is enabled already: %s", _ewk_icon_database_path); > + return EINA_FALSE; > + } If then, can we close iconDatabase? Does we need to update comments? 428455 3 ljaehun.lim 2011-06-27 17:07:10 -0700 (In reply to comment #2) > View in context: https://bugs.webkit.org/attachment.cgi?id=98811&action=review > > > Source/WebKit/efl/ewk/ewk_settings.cpp:156 > > if (directory) { > > + if (WebCore::iconDatabase().isEnabled()) { > > + ERR("IconDatabase is enabled already: %s", _ewk_icon_database_path); > > + return EINA_FALSE; > > + } > > If then, can we close iconDatabase? > Does we need to update comments? If there is no directory value, we can close. 428482 4 gyuyoung.kim 2011-06-27 17:32:21 -0700 (In reply to comment #0) > IconDatabase is an optional feature. But EFL port enables it in _ewk_init_body() as default. > > So, when an application enables IconDatabse after ewk_init(), WebKit prints an warning message. > (See another bugs, 60361, 60148, 59238) > > I think it's better that an application should decide whether to use IconDatabase or not, > and be responsible for using IconDatabase. Then, when we start to open IconDatabase ? 428486 5 98827 ljaehun.lim 2011-06-27 17:35:02 -0700 Created attachment 98827 Change API comments 428491 6 ljaehun.lim 2011-06-27 17:41:17 -0700 (In reply to comment #4) > (In reply to comment #0) > > IconDatabase is an optional feature. But EFL port enables it in _ewk_init_body() as default. > > > > So, when an application enables IconDatabse after ewk_init(), WebKit prints an warning message. > > (See another bugs, 60361, 60148, 59238) > > > > I think it's better that an application should decide whether to use IconDatabase or not, > > and be responsible for using IconDatabase. > > Then, when we start to open IconDatabase ? After this patch, icon database must be fully managed by an application. If an application doesn't want to use icon database, nothing to do for it. But if another application wants to use favicon feature, just call ewk_settings_icon_database_path_set() with directory path. 428493 7 ljaehun.lim 2011-06-27 17:41:50 -0700 (In reply to comment #2) > View in context: https://bugs.webkit.org/attachment.cgi?id=98811&action=review > > > Source/WebKit/efl/ewk/ewk_settings.cpp:156 > > if (directory) { > > + if (WebCore::iconDatabase().isEnabled()) { > > + ERR("IconDatabase is enabled already: %s", _ewk_icon_database_path); > > + return EINA_FALSE; > > + } > > If then, can we close iconDatabase? > Does we need to update comments? I chnaged API's comments. 428518 8 ljaehun.lim 2011-06-27 17:58:30 -0700 After discussion with ryuan, we concludes that icondatabase APIs need to be changed. When I prepare, I'll make another bug. This patch is the first step. 428520 9 98811 lucas.de.marchi 2011-06-27 17:59:19 -0700 Comment on attachment 98811 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=98811&action=review > Source/WebKit/efl/ChangeLog:11 > +2011-06-27 Jaehun Lim <ljaehun.lim@samsung.com> > + > + Reviewed by NOBODY (OOPS!). > + > + [EFL] Remove IconDatabase initialization in _ewk_init_body() > + https://bugs.webkit.org/show_bug.cgi?id=63491 > + > + IconDatabase is an optional feature. But EFL port enables it in _ewk_init_body() > + as default. > + This patch removes IconDatabase enabling while ewk initialzation and > + prevents an application from re-opening IconDatabase. I think a better description would be: Make IconDatabase feature optional by removing its initialization from _ewk_init_body(). Now IconDatabase must be fully managed by an application: if it doesn't want to use it, there's nothing to do. Otherwise, just call ewk_settings_icon_database_path_set() with the directory path. > Source/WebKit/efl/ewk/ewk_main.cpp:-201 > ewk_settings_web_database_path_set(wkdir.utf8().data()); > - ewk_settings_icon_database_path_set(wkdir.utf8().data()); What do you think about taking the same approach for web database? 428527 10 98835 ljaehun.lim 2011-06-27 18:07:00 -0700 Created attachment 98835 Change patch description. 428540 11 ljaehun.lim 2011-06-27 18:20:57 -0700 (In reply to comment #9) > (From update of attachment 98811 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=98811&action=review > > > Source/WebKit/efl/ChangeLog:11 > > +2011-06-27 Jaehun Lim <ljaehun.lim@samsung.com> > > + > > + Reviewed by NOBODY (OOPS!). > > + > > + [EFL] Remove IconDatabase initialization in _ewk_init_body() > > + https://bugs.webkit.org/show_bug.cgi?id=63491 > > + > > + IconDatabase is an optional feature. But EFL port enables it in _ewk_init_body() > > + as default. > > + This patch removes IconDatabase enabling while ewk initialzation and > > + prevents an application from re-opening IconDatabase. > > I think a better description would be: > > Make IconDatabase feature optional by removing its initialization from _ewk_init_body(). Now IconDatabase must be fully managed by an application: if it doesn't want to use it, there's nothing to do. Otherwise, just call ewk_settings_icon_database_path_set() with the directory path. I changed, thanks. > > > Source/WebKit/efl/ewk/ewk_main.cpp:-201 > > ewk_settings_web_database_path_set(wkdir.utf8().data()); > > - ewk_settings_icon_database_path_set(wkdir.utf8().data()); > > What do you think about taking the same approach for web database? I made this patch because of IconDatabase's re-opening problem. I didn't care about web database. At a glance, it looks no problem to take the same approach. After I analyze more, I'll try to do 428817 12 rakuco 2011-06-28 05:40:09 -0700 > Source/WebKit/efl/ewk/ewk_settings.cpp:144 > + * database was opened already, this funciton returns EINA_FALSE. was opened already -> is already open funciton -> function EINA_FALSE -> @c EINA_FALSE > Source/WebKit/efl/ewk/ewk_settings.cpp:157 > + ERR("IconDatabase is enabled already: %s", _ewk_icon_database_path); enabled already -> already enabled 429199 13 98984 ljaehun.lim 2011-06-28 15:41:26 -0700 Created attachment 98984 Fix comments Fix comments. Thanks. 429552 14 rakuco 2011-06-29 06:10:16 -0700 Almost there :) > Source/WebKit/efl/ewk/ewk_settings.cpp:143 > + * Icon database must be opened only once. If you try to set a path when icon when icon -> when the icon > Source/WebKit/efl/ewk/ewk_settings.cpp:144 > + * database is already opend, this function returns @c EINA_FALSE. opend -> open > Source/WebKit/efl/ewk/ewk_settings.cpp:157 > + ERR("IconDatabase is already opened: %s", _ewk_icon_database_path); opened -> open 429946 15 99167 ljaehun.lim 2011-06-29 15:59:48 -0700 Created attachment 99167 Modified patch Fix it. Thanks again. 431923 16 rakuco 2011-07-04 07:20:07 -0700 LGTM. 437535 17 ljaehun.lim 2011-07-14 21:53:53 -0700 Could anyone review this patch? 437576 18 99167 webkit.review.bot 2011-07-14 23:07:41 -0700 Comment on attachment 99167 Modified patch Clearing flags on attachment: 99167 Committed r91051: <http://trac.webkit.org/changeset/91051> 437577 19 webkit.review.bot 2011-07-14 23:07:47 -0700 All reviewed patches have been landed. Closing bug. 98811 2011-06-27 16:22:01 -0700 2011-06-27 17:59:19 -0700 Proposed patch patch.diff text/plain 2089 ljaehun.lim ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCA4YjgzN2EyLi5mY2VmZDliIDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTEtMDYtMjcgIEphZWh1biBMaW0gIDxsamFlaHVuLmxpbUBzYW1z dW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbRUZMXSBSZW1vdmUgSWNvbkRhdGFiYXNlIGluaXRpYWxpemF0aW9uIGluIF9ld2tfaW5pdF9i b2R5KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYz NDkxCisKKyAgICAgICAgSWNvbkRhdGFiYXNlIGlzIGFuIG9wdGlvbmFsIGZlYXR1cmUuIEJ1dCBF RkwgcG9ydCBlbmFibGVzIGl0IGluIF9ld2tfaW5pdF9ib2R5KCkKKyAgICAgICAgYXMgZGVmYXVs dC4KKyAgICAgICAgVGhpcyBwYXRjaCByZW1vdmVzIEljb25EYXRhYmFzZSBlbmFibGluZyB3aGls ZSBld2sgaW5pdGlhbHphdGlvbiBhbmQKKyAgICAgICAgcHJldmVudHMgYW4gYXBwbGljYXRpb24g ZnJvbSByZS1vcGVuaW5nIEljb25EYXRhYmFzZS4KKworICAgICAgICAqIGV3ay9ld2tfbWFpbi5j cHA6CisgICAgICAgIChfZXdrX2luaXRfYm9keSk6CisgICAgICAgICogZXdrL2V3a19zZXR0aW5n cy5jcHA6CisgICAgICAgIChld2tfc2V0dGluZ3NfaWNvbl9kYXRhYmFzZV9wYXRoX3NldCk6CisK IDIwMTEtMDYtMjcgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEFudG9uaW8gR29tZXMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L2VmbC9ld2svZXdrX21haW4uY3BwIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19tYWluLmNw cAppbmRleCA4MGRmYzg4Li43NTE5NTViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9l d2svZXdrX21haW4uY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfbWFpbi5jcHAK QEAgLTE5OCw3ICsxOTgsNiBAQCBFaW5hX0Jvb2wgX2V3a19pbml0X2JvZHkodm9pZCkKICAgICBX VEY6OlN0cmluZyB3a2RpciA9IGhvbWUgKyAiLy53ZWJraXQiOwogICAgIGlmIChXZWJDb3JlOjpt YWtlQWxsRGlyZWN0b3JpZXMod2tkaXIpKSB7CiAgICAgICAgIGV3a19zZXR0aW5nc193ZWJfZGF0 YWJhc2VfcGF0aF9zZXQod2tkaXIudXRmOCgpLmRhdGEoKSk7Ci0gICAgICAgIGV3a19zZXR0aW5n c19pY29uX2RhdGFiYXNlX3BhdGhfc2V0KHdrZGlyLnV0ZjgoKS5kYXRhKCkpOwogCiAjaWYgRU5B QkxFKE9GRkxJTkVfV0VCX0FQUExJQ0FUSU9OUykKICAgICAgICAgZXdrX3NldHRpbmdzX2NhY2hl X2RpcmVjdG9yeV9wYXRoX3NldCh3a2Rpci51dGY4KCkuZGF0YSgpKTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2V0dGluZ3MuY3BwIGIvU291cmNlL1dlYktpdC9lZmwv ZXdrL2V3a19zZXR0aW5ncy5jcHAKaW5kZXggMjM1MDRmMi4uMzhmY2E2NCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19zZXR0aW5ncy5jcHAKKysrIGIvU291cmNlL1dlYktp dC9lZmwvZXdrL2V3a19zZXR0aW5ncy5jcHAKQEAgLTE1MCw2ICsxNTAsMTEgQEAgRWluYV9Cb29s IGV3a19zZXR0aW5nc19pY29uX2RhdGFiYXNlX3BhdGhfc2V0KGNvbnN0IGNoYXIgKmRpcmVjdG9y eSkKICAgICBXZWJDb3JlOjpJY29uRGF0YWJhc2U6OmRlbGF5RGF0YWJhc2VDbGVhbnVwKCk7CiAK ICAgICBpZiAoZGlyZWN0b3J5KSB7CisgICAgICAgIGlmIChXZWJDb3JlOjppY29uRGF0YWJhc2Uo KS5pc0VuYWJsZWQoKSkgeworICAgICAgICAgICAgRVJSKCJJY29uRGF0YWJhc2UgaXMgZW5hYmxl ZCBhbHJlYWR5OiAlcyIsIF9ld2tfaWNvbl9kYXRhYmFzZV9wYXRoKTsKKyAgICAgICAgICAgIHJl dHVybiBFSU5BX0ZBTFNFOworICAgICAgICB9CisKICAgICAgICAgc3RydWN0IHN0YXQgc3Q7CiAK ICAgICAgICAgaWYgKHN0YXQoZGlyZWN0b3J5LCAmc3QpKSB7Cg== 98827 2011-06-27 17:35:02 -0700 2011-06-27 18:07:00 -0700 Change API comments patch.diff text/plain 2527 ljaehun.lim ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCA4YjgzN2EyLi4zMDRhYWMwIDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTEtMDYtMjcgIEphZWh1biBMaW0gIDxsamFlaHVuLmxpbUBzYW1z dW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbRUZMXSBSZW1vdmUgSWNvbkRhdGFiYXNlIGluaXRpYWxpemF0aW9uIGluIF9ld2tfaW5pdF9i b2R5KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYz NDkxCisKKyAgICAgICAgSWNvbkRhdGFiYXNlIGlzIGFuIG9wdGlvbmFsIGZlYXR1cmUuCisgICAg ICAgIEJ1dCBFRkwgcG9ydCBlbmFibGVzIGl0IGluIF9ld2tfaW5pdF9ib2R5KCkgYnkgZGVmYXVs dC4KKyAgICAgICAgVGhpcyBwYXRjaCByZW1vdmVzIEljb25EYXRhYmFzZSBlbmFibGluZyB3aGls ZSBld2sgaW5pdGlhbHphdGlvbiBhbmQKKyAgICAgICAgcHJldmVudHMgYW4gYXBwbGljYXRpb24g ZnJvbSByZS1vcGVuaW5nIEljb25EYXRhYmFzZS4KKworICAgICAgICAqIGV3ay9ld2tfbWFpbi5j cHA6CisgICAgICAgIChfZXdrX2luaXRfYm9keSk6CisgICAgICAgICogZXdrL2V3a19zZXR0aW5n cy5jcHA6CisgICAgICAgIChld2tfc2V0dGluZ3NfaWNvbl9kYXRhYmFzZV9wYXRoX3NldCk6CisK IDIwMTEtMDYtMjcgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEFudG9uaW8gR29tZXMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L2VmbC9ld2svZXdrX21haW4uY3BwIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19tYWluLmNw cAppbmRleCA4MGRmYzg4Li43NTE5NTViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9l d2svZXdrX21haW4uY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfbWFpbi5jcHAK QEAgLTE5OCw3ICsxOTgsNiBAQCBFaW5hX0Jvb2wgX2V3a19pbml0X2JvZHkodm9pZCkKICAgICBX VEY6OlN0cmluZyB3a2RpciA9IGhvbWUgKyAiLy53ZWJraXQiOwogICAgIGlmIChXZWJDb3JlOjpt YWtlQWxsRGlyZWN0b3JpZXMod2tkaXIpKSB7CiAgICAgICAgIGV3a19zZXR0aW5nc193ZWJfZGF0 YWJhc2VfcGF0aF9zZXQod2tkaXIudXRmOCgpLmRhdGEoKSk7Ci0gICAgICAgIGV3a19zZXR0aW5n c19pY29uX2RhdGFiYXNlX3BhdGhfc2V0KHdrZGlyLnV0ZjgoKS5kYXRhKCkpOwogCiAjaWYgRU5B QkxFKE9GRkxJTkVfV0VCX0FQUExJQ0FUSU9OUykKICAgICAgICAgZXdrX3NldHRpbmdzX2NhY2hl X2RpcmVjdG9yeV9wYXRoX3NldCh3a2Rpci51dGY4KCkuZGF0YSgpKTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2V0dGluZ3MuY3BwIGIvU291cmNlL1dlYktpdC9lZmwv ZXdrL2V3a19zZXR0aW5ncy5jcHAKaW5kZXggMjM1MDRmMi4uMTg4NTM0YSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19zZXR0aW5ncy5jcHAKKysrIGIvU291cmNlL1dlYktp dC9lZmwvZXdrL2V3a19zZXR0aW5ncy5jcHAKQEAgLTE0MCw2ICsxNDAsOSBAQCBjb25zdCBjaGFy ICpld2tfc2V0dGluZ3Nfd2ViX2RhdGFiYXNlX3BhdGhfZ2V0KHZvaWQpCiAvKioKICAqIFNldHMg ZGlyZWN0b3J5IHdoZXJlIHRvIHN0b3JlIGljb24gZGF0YWJhc2UsIG9wZW5pbmcgb3IgY2xvc2lu ZyBkYXRhYmFzZS4KICAqCisgKiBJY29uIGRhdGFiYXNlIG11c3QgYmUgb3BlbmVkIG9ubHkgb25j ZS4gSWYgeW91IHRyeSB0byBzZXQgYSBwYXRoIHdoZW4gaWNvbgorICogZGF0YWJhc2Ugd2FzIG9w ZW5lZCBhbHJlYWR5LCB0aGlzIGZ1bmNpdG9uIHJldHVybnMgRUlOQV9GQUxTRS4KKyAqCiAgKiBA cGFyYW0gZGlyZWN0b3J5IHdoZXJlIHRvIHN0b3JlIGljb24gZGF0YWJhc2UsIG11c3QgYmUKICAq ICAgICAgICB3cml0ZS1hYmxlLCBpZiBAYyAwIGlzIGdpdmVuLCB0aGVuIGRhdGFiYXNlIGlzIGNs b3NlZAogICoKQEAgLTE1MCw2ICsxNTMsMTEgQEAgRWluYV9Cb29sIGV3a19zZXR0aW5nc19pY29u X2RhdGFiYXNlX3BhdGhfc2V0KGNvbnN0IGNoYXIgKmRpcmVjdG9yeSkKICAgICBXZWJDb3JlOjpJ Y29uRGF0YWJhc2U6OmRlbGF5RGF0YWJhc2VDbGVhbnVwKCk7CiAKICAgICBpZiAoZGlyZWN0b3J5 KSB7CisgICAgICAgIGlmIChXZWJDb3JlOjppY29uRGF0YWJhc2UoKS5pc0VuYWJsZWQoKSkgewor ICAgICAgICAgICAgRVJSKCJJY29uRGF0YWJhc2UgaXMgZW5hYmxlZCBhbHJlYWR5OiAlcyIsIF9l d2tfaWNvbl9kYXRhYmFzZV9wYXRoKTsKKyAgICAgICAgICAgIHJldHVybiBFSU5BX0ZBTFNFOwor ICAgICAgICB9CisKICAgICAgICAgc3RydWN0IHN0YXQgc3Q7CiAKICAgICAgICAgaWYgKHN0YXQo ZGlyZWN0b3J5LCAmc3QpKSB7Cg== 98835 2011-06-27 18:07:00 -0700 2011-06-28 15:41:26 -0700 Change patch description. patch.diff text/plain 2595 ljaehun.lim ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCA4YjgzN2EyLi4zN2M5ZTgyIDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTEtMDYtMjcgIEphZWh1biBMaW0gIDxsamFlaHVuLmxpbUBzYW1z dW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbRUZMXSBSZW1vdmUgSWNvbkRhdGFiYXNlIGluaXRpYWxpemF0aW9uIGluIF9ld2tfaW5pdF9i b2R5KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYz NDkxCisKKyAgICAgICAgTWFrZSBJY29uRGF0YWJhc2UgZmVhdHVyZSBvcHRpb25hbCBieSByZW1v dmluZyBpdHMgaW5pdGlhbGl6YXRpb24gZnJvbSBfZXdrX2luaXRfYm9keSgpLgorICAgICAgICBO b3cgSWNvbkRhdGFiYXNlIG11c3QgYmUgZnVsbHkgbWFuYWdlZCBieSBhbiBhcHBsaWNhdGlvbjoK KyAgICAgICAgaWYgaXQgZG9lc24ndCB3YW50IHRvIHVzZSBpdCwgdGhlcmUncyBub3RoaW5nIHRv IGRvLiBPdGhlcndpc2UsIGp1c3QgY2FsbAorICAgICAgICBld2tfc2V0dGluZ3NfaWNvbl9kYXRh YmFzZV9wYXRoX3NldCgpIHdpdGggdGhlIGRpcmVjdG9yeSBwYXRoLgorCisgICAgICAgICogZXdr L2V3a19tYWluLmNwcDoKKyAgICAgICAgKF9ld2tfaW5pdF9ib2R5KToKKyAgICAgICAgKiBld2sv ZXdrX3NldHRpbmdzLmNwcDoKKyAgICAgICAgKGV3a19zZXR0aW5nc19pY29uX2RhdGFiYXNlX3Bh dGhfc2V0KToKKwogMjAxMS0wNi0yNyAgUnl1YW4gQ2hvaSAgPHJ5dWFuLmNob2lAc2Ftc3VuZy5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW50b25pbyBHb21lcy4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfbWFpbi5jcHAgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2sv ZXdrX21haW4uY3BwCmluZGV4IDgwZGZjODguLjc1MTk1NWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvZWZsL2V3ay9ld2tfbWFpbi5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3 a19tYWluLmNwcApAQCAtMTk4LDcgKzE5OCw2IEBAIEVpbmFfQm9vbCBfZXdrX2luaXRfYm9keSh2 b2lkKQogICAgIFdURjo6U3RyaW5nIHdrZGlyID0gaG9tZSArICIvLndlYmtpdCI7CiAgICAgaWYg KFdlYkNvcmU6Om1ha2VBbGxEaXJlY3Rvcmllcyh3a2RpcikpIHsKICAgICAgICAgZXdrX3NldHRp bmdzX3dlYl9kYXRhYmFzZV9wYXRoX3NldCh3a2Rpci51dGY4KCkuZGF0YSgpKTsKLSAgICAgICAg ZXdrX3NldHRpbmdzX2ljb25fZGF0YWJhc2VfcGF0aF9zZXQod2tkaXIudXRmOCgpLmRhdGEoKSk7 CiAKICNpZiBFTkFCTEUoT0ZGTElORV9XRUJfQVBQTElDQVRJT05TKQogICAgICAgICBld2tfc2V0 dGluZ3NfY2FjaGVfZGlyZWN0b3J5X3BhdGhfc2V0KHdrZGlyLnV0ZjgoKS5kYXRhKCkpOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19zZXR0aW5ncy5jcHAgYi9Tb3VyY2Uv V2ViS2l0L2VmbC9ld2svZXdrX3NldHRpbmdzLmNwcAppbmRleCAyMzUwNGYyLi4xODg1MzRhIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3NldHRpbmdzLmNwcAorKysgYi9T b3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3NldHRpbmdzLmNwcApAQCAtMTQwLDYgKzE0MCw5IEBA IGNvbnN0IGNoYXIgKmV3a19zZXR0aW5nc193ZWJfZGF0YWJhc2VfcGF0aF9nZXQodm9pZCkKIC8q KgogICogU2V0cyBkaXJlY3Rvcnkgd2hlcmUgdG8gc3RvcmUgaWNvbiBkYXRhYmFzZSwgb3Blbmlu ZyBvciBjbG9zaW5nIGRhdGFiYXNlLgogICoKKyAqIEljb24gZGF0YWJhc2UgbXVzdCBiZSBvcGVu ZWQgb25seSBvbmNlLiBJZiB5b3UgdHJ5IHRvIHNldCBhIHBhdGggd2hlbiBpY29uCisgKiBkYXRh YmFzZSB3YXMgb3BlbmVkIGFscmVhZHksIHRoaXMgZnVuY2l0b24gcmV0dXJucyBFSU5BX0ZBTFNF LgorICoKICAqIEBwYXJhbSBkaXJlY3Rvcnkgd2hlcmUgdG8gc3RvcmUgaWNvbiBkYXRhYmFzZSwg bXVzdCBiZQogICogICAgICAgIHdyaXRlLWFibGUsIGlmIEBjIDAgaXMgZ2l2ZW4sIHRoZW4gZGF0 YWJhc2UgaXMgY2xvc2VkCiAgKgpAQCAtMTUwLDYgKzE1MywxMSBAQCBFaW5hX0Jvb2wgZXdrX3Nl dHRpbmdzX2ljb25fZGF0YWJhc2VfcGF0aF9zZXQoY29uc3QgY2hhciAqZGlyZWN0b3J5KQogICAg IFdlYkNvcmU6Okljb25EYXRhYmFzZTo6ZGVsYXlEYXRhYmFzZUNsZWFudXAoKTsKIAogICAgIGlm IChkaXJlY3RvcnkpIHsKKyAgICAgICAgaWYgKFdlYkNvcmU6Omljb25EYXRhYmFzZSgpLmlzRW5h YmxlZCgpKSB7CisgICAgICAgICAgICBFUlIoIkljb25EYXRhYmFzZSBpcyBlbmFibGVkIGFscmVh ZHk6ICVzIiwgX2V3a19pY29uX2RhdGFiYXNlX3BhdGgpOworICAgICAgICAgICAgcmV0dXJuIEVJ TkFfRkFMU0U7CisgICAgICAgIH0KKwogICAgICAgICBzdHJ1Y3Qgc3RhdCBzdDsKIAogICAgICAg ICBpZiAoc3RhdChkaXJlY3RvcnksICZzdCkpIHsK 98984 2011-06-28 15:41:26 -0700 2011-06-29 15:59:48 -0700 Fix comments patch.diff text/plain 2595 ljaehun.lim ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCA4YjgzN2EyLi4zN2M5ZTgyIDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTEtMDYtMjcgIEphZWh1biBMaW0gIDxsamFlaHVuLmxpbUBzYW1z dW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbRUZMXSBSZW1vdmUgSWNvbkRhdGFiYXNlIGluaXRpYWxpemF0aW9uIGluIF9ld2tfaW5pdF9i b2R5KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYz NDkxCisKKyAgICAgICAgTWFrZSBJY29uRGF0YWJhc2UgZmVhdHVyZSBvcHRpb25hbCBieSByZW1v dmluZyBpdHMgaW5pdGlhbGl6YXRpb24gZnJvbSBfZXdrX2luaXRfYm9keSgpLgorICAgICAgICBO b3cgSWNvbkRhdGFiYXNlIG11c3QgYmUgZnVsbHkgbWFuYWdlZCBieSBhbiBhcHBsaWNhdGlvbjoK KyAgICAgICAgaWYgaXQgZG9lc24ndCB3YW50IHRvIHVzZSBpdCwgdGhlcmUncyBub3RoaW5nIHRv IGRvLiBPdGhlcndpc2UsIGp1c3QgY2FsbAorICAgICAgICBld2tfc2V0dGluZ3NfaWNvbl9kYXRh YmFzZV9wYXRoX3NldCgpIHdpdGggdGhlIGRpcmVjdG9yeSBwYXRoLgorCisgICAgICAgICogZXdr L2V3a19tYWluLmNwcDoKKyAgICAgICAgKF9ld2tfaW5pdF9ib2R5KToKKyAgICAgICAgKiBld2sv ZXdrX3NldHRpbmdzLmNwcDoKKyAgICAgICAgKGV3a19zZXR0aW5nc19pY29uX2RhdGFiYXNlX3Bh dGhfc2V0KToKKwogMjAxMS0wNi0yNyAgUnl1YW4gQ2hvaSAgPHJ5dWFuLmNob2lAc2Ftc3VuZy5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW50b25pbyBHb21lcy4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfbWFpbi5jcHAgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2sv ZXdrX21haW4uY3BwCmluZGV4IDgwZGZjODguLjc1MTk1NWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvZWZsL2V3ay9ld2tfbWFpbi5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3 a19tYWluLmNwcApAQCAtMTk4LDcgKzE5OCw2IEBAIEVpbmFfQm9vbCBfZXdrX2luaXRfYm9keSh2 b2lkKQogICAgIFdURjo6U3RyaW5nIHdrZGlyID0gaG9tZSArICIvLndlYmtpdCI7CiAgICAgaWYg KFdlYkNvcmU6Om1ha2VBbGxEaXJlY3Rvcmllcyh3a2RpcikpIHsKICAgICAgICAgZXdrX3NldHRp bmdzX3dlYl9kYXRhYmFzZV9wYXRoX3NldCh3a2Rpci51dGY4KCkuZGF0YSgpKTsKLSAgICAgICAg ZXdrX3NldHRpbmdzX2ljb25fZGF0YWJhc2VfcGF0aF9zZXQod2tkaXIudXRmOCgpLmRhdGEoKSk7 CiAKICNpZiBFTkFCTEUoT0ZGTElORV9XRUJfQVBQTElDQVRJT05TKQogICAgICAgICBld2tfc2V0 dGluZ3NfY2FjaGVfZGlyZWN0b3J5X3BhdGhfc2V0KHdrZGlyLnV0ZjgoKS5kYXRhKCkpOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19zZXR0aW5ncy5jcHAgYi9Tb3VyY2Uv V2ViS2l0L2VmbC9ld2svZXdrX3NldHRpbmdzLmNwcAppbmRleCAyMzUwNGYyLi4xODg1MzRhIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3NldHRpbmdzLmNwcAorKysgYi9T b3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3NldHRpbmdzLmNwcApAQCAtMTQwLDYgKzE0MCw5IEBA IGNvbnN0IGNoYXIgKmV3a19zZXR0aW5nc193ZWJfZGF0YWJhc2VfcGF0aF9nZXQodm9pZCkKIC8q KgogICogU2V0cyBkaXJlY3Rvcnkgd2hlcmUgdG8gc3RvcmUgaWNvbiBkYXRhYmFzZSwgb3Blbmlu ZyBvciBjbG9zaW5nIGRhdGFiYXNlLgogICoKKyAqIEljb24gZGF0YWJhc2UgbXVzdCBiZSBvcGVu ZWQgb25seSBvbmNlLiBJZiB5b3UgdHJ5IHRvIHNldCBhIHBhdGggd2hlbiBpY29uCisgKiBkYXRh YmFzZSBpcyBhbHJlYWR5IG9wZW5kLCB0aGlzIGZ1bmN0aW9uIHJldHVybnMgQGMgRUlOQV9GQUxT RS4KKyAqCiAgKiBAcGFyYW0gZGlyZWN0b3J5IHdoZXJlIHRvIHN0b3JlIGljb24gZGF0YWJhc2Us IG11c3QgYmUKICAqICAgICAgICB3cml0ZS1hYmxlLCBpZiBAYyAwIGlzIGdpdmVuLCB0aGVuIGRh dGFiYXNlIGlzIGNsb3NlZAogICoKQEAgLTE1MCw2ICsxNTMsMTEgQEAgRWluYV9Cb29sIGV3a19z ZXR0aW5nc19pY29uX2RhdGFiYXNlX3BhdGhfc2V0KGNvbnN0IGNoYXIgKmRpcmVjdG9yeSkKICAg ICBXZWJDb3JlOjpJY29uRGF0YWJhc2U6OmRlbGF5RGF0YWJhc2VDbGVhbnVwKCk7CiAKICAgICBp ZiAoZGlyZWN0b3J5KSB7CisgICAgICAgIGlmIChXZWJDb3JlOjppY29uRGF0YWJhc2UoKS5pc0Vu YWJsZWQoKSkgeworICAgICAgICAgICAgRVJSKCJJY29uRGF0YWJhc2UgaXMgYWxyZWFkeSBvcGVu ZWQ6ICVzIiwgX2V3a19pY29uX2RhdGFiYXNlX3BhdGgpOworICAgICAgICAgICAgcmV0dXJuIEVJ TkFfRkFMU0U7CisgICAgICAgIH0KKwogICAgICAgICBzdHJ1Y3Qgc3RhdCBzdDsKIAogICAgICAg ICBpZiAoc3RhdChkaXJlY3RvcnksICZzdCkpIHsK 99167 2011-06-29 15:59:48 -0700 2011-07-14 23:07:41 -0700 Modified patch patch.diff text/plain 2620 ljaehun.lim ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCA2ZTk2NDg5Li5jYzU5ZDZiIDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTEtMDYtMjkgIEphZWh1biBMaW0gIDxsamFlaHVuLmxpbUBzYW1z dW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbRUZMXSBSZW1vdmUgSWNvbkRhdGFiYXNlIGluaXRpYWxpemF0aW9uIGluIF9ld2tfaW5pdF9i b2R5KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYz NDkxCisKKyAgICAgICAgTWFrZSBJY29uRGF0YWJhc2UgZmVhdHVyZSBvcHRpb25hbCBieSByZW1v dmluZyBpdHMgaW5pdGlhbGl6YXRpb24gZnJvbSBfZXdrX2luaXRfYm9keSgpLgorICAgICAgICBO b3cgSWNvbkRhdGFiYXNlIG11c3QgYmUgZnVsbHkgbWFuYWdlZCBieSBhbiBhcHBsaWNhdGlvbjoK KyAgICAgICAgaWYgaXQgZG9lc24ndCB3YW50IHRvIHVzZSBpdCwgdGhlcmUncyBub3RoaW5nIHRv IGRvLiBPdGhlcndpc2UsIGp1c3QgY2FsbAorICAgICAgICBld2tfc2V0dGluZ3NfaWNvbl9kYXRh YmFzZV9wYXRoX3NldCgpIHdpdGggdGhlIGRpcmVjdG9yeSBwYXRoLgorCisgICAgICAgICogZXdr L2V3a19tYWluLmNwcDoKKyAgICAgICAgKF9ld2tfaW5pdF9ib2R5KToKKyAgICAgICAgKiBld2sv ZXdrX3NldHRpbmdzLmNwcDoKKyAgICAgICAgKGV3a19zZXR0aW5nc19pY29uX2RhdGFiYXNlX3Bh dGhfc2V0KToKKwogMjAxMS0wNi0yOCAgTWljaGFsIFBha3VsYSB2ZWwgUnV0a2EgIDxtLnBha3Vs YUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlz dGlhbnNlbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfbWFpbi5jcHAg Yi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX21haW4uY3BwCmluZGV4IDgwZGZjODguLjc1MTk1 NWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfbWFpbi5jcHAKKysrIGIv U291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19tYWluLmNwcApAQCAtMTk4LDcgKzE5OCw2IEBAIEVp bmFfQm9vbCBfZXdrX2luaXRfYm9keSh2b2lkKQogICAgIFdURjo6U3RyaW5nIHdrZGlyID0gaG9t ZSArICIvLndlYmtpdCI7CiAgICAgaWYgKFdlYkNvcmU6Om1ha2VBbGxEaXJlY3Rvcmllcyh3a2Rp cikpIHsKICAgICAgICAgZXdrX3NldHRpbmdzX3dlYl9kYXRhYmFzZV9wYXRoX3NldCh3a2Rpci51 dGY4KCkuZGF0YSgpKTsKLSAgICAgICAgZXdrX3NldHRpbmdzX2ljb25fZGF0YWJhc2VfcGF0aF9z ZXQod2tkaXIudXRmOCgpLmRhdGEoKSk7CiAKICNpZiBFTkFCTEUoT0ZGTElORV9XRUJfQVBQTElD QVRJT05TKQogICAgICAgICBld2tfc2V0dGluZ3NfY2FjaGVfZGlyZWN0b3J5X3BhdGhfc2V0KHdr ZGlyLnV0ZjgoKS5kYXRhKCkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3 a19zZXR0aW5ncy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3NldHRpbmdzLmNwcApp bmRleCAyMzUwNGYyLi44NDVkMTQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2sv ZXdrX3NldHRpbmdzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3NldHRpbmdz LmNwcApAQCAtMTQwLDYgKzE0MCw5IEBAIGNvbnN0IGNoYXIgKmV3a19zZXR0aW5nc193ZWJfZGF0 YWJhc2VfcGF0aF9nZXQodm9pZCkKIC8qKgogICogU2V0cyBkaXJlY3Rvcnkgd2hlcmUgdG8gc3Rv cmUgaWNvbiBkYXRhYmFzZSwgb3BlbmluZyBvciBjbG9zaW5nIGRhdGFiYXNlLgogICoKKyAqIElj b24gZGF0YWJhc2UgbXVzdCBiZSBvcGVuZWQgb25seSBvbmNlLiBJZiB5b3UgdHJ5IHRvIHNldCBh IHBhdGggd2hlbiB0aGUgaWNvbgorICogZGF0YWJhc2UgaXMgYWxyZWFkeSBvcGVuLCB0aGlzIGZ1 bmN0aW9uIHJldHVybnMgQGMgRUlOQV9GQUxTRS4KKyAqCiAgKiBAcGFyYW0gZGlyZWN0b3J5IHdo ZXJlIHRvIHN0b3JlIGljb24gZGF0YWJhc2UsIG11c3QgYmUKICAqICAgICAgICB3cml0ZS1hYmxl LCBpZiBAYyAwIGlzIGdpdmVuLCB0aGVuIGRhdGFiYXNlIGlzIGNsb3NlZAogICoKQEAgLTE1MCw2 ICsxNTMsMTEgQEAgRWluYV9Cb29sIGV3a19zZXR0aW5nc19pY29uX2RhdGFiYXNlX3BhdGhfc2V0 KGNvbnN0IGNoYXIgKmRpcmVjdG9yeSkKICAgICBXZWJDb3JlOjpJY29uRGF0YWJhc2U6OmRlbGF5 RGF0YWJhc2VDbGVhbnVwKCk7CiAKICAgICBpZiAoZGlyZWN0b3J5KSB7CisgICAgICAgIGlmIChX ZWJDb3JlOjppY29uRGF0YWJhc2UoKS5pc0VuYWJsZWQoKSkgeworICAgICAgICAgICAgRVJSKCJJ Y29uRGF0YWJhc2UgaXMgYWxyZWFkeSBvcGVuOiAlcyIsIF9ld2tfaWNvbl9kYXRhYmFzZV9wYXRo KTsKKyAgICAgICAgICAgIHJldHVybiBFSU5BX0ZBTFNFOworICAgICAgICB9CisKICAgICAgICAg c3RydWN0IHN0YXQgc3Q7CiAKICAgICAgICAgaWYgKHN0YXQoZGlyZWN0b3J5LCAmc3QpKSB7Cg==