63488 2011-06-27 15:07:28 -0700 Stop using deprecated SkDeviceFactory API 2011-07-01 13:28:04 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 reed reed alokp bsalomon jamesr senorblanco webkit.review.bot oldest_to_newest 428356 0 reed 2011-06-27 15:07:28 -0700 Stop using deprecated SkDeviceFactory API 428359 1 98798 reed 2011-06-27 15:08:19 -0700 Created attachment 98798 Patch 428389 2 98798 eric 2011-06-27 15:36:12 -0700 Comment on attachment 98798 Patch LGTM. If you need someone with skia-skills to review, you should seek a second opinion. 428911 3 98798 alokp 2011-06-28 08:43:35 -0700 Comment on attachment 98798 Patch lgtm Brian had a patch to fix this too - https://bugs.webkit.org/show_bug.cgi?id=62995 430371 4 bsalomon 2011-06-30 06:47:47 -0700 LGTM (unofficial), I will close https://bugs.webkit.org/show_bug.cgi?id=62995. 431161 5 bsalomon 2011-07-01 08:04:08 -0700 *** Bug 62995 has been marked as a duplicate of this bug. *** 431311 6 99498 reed 2011-07-01 12:02:59 -0700 Created attachment 99498 Patch 431313 7 reed 2011-07-01 12:03:18 -0700 rebaselined. no code changes 431329 8 99498 jamesr 2011-07-01 12:16:41 -0700 Comment on attachment 99498 Patch OK 431398 9 99498 webkit.review.bot 2011-07-01 13:28:00 -0700 Comment on attachment 99498 Patch Clearing flags on attachment: 99498 Committed r90270: <http://trac.webkit.org/changeset/90270> 431399 10 webkit.review.bot 2011-07-01 13:28:04 -0700 All reviewed patches have been landed. Closing bug. 98798 2011-06-27 15:08:19 -0700 2011-07-01 12:02:54 -0700 Patch bug-63488-20110627180818.patch text/plain 3463 reed SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg5ODY0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDYtMjcgIE1pa2UgUmVl ZCAgPHJlZWRAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBTdG9wIHVzaW5nIGRlcHJlY2F0ZWQgU2tEZXZpY2VGYWN0b3J5IEFQSQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjM0ODgKKwor ICAgICAgICBObyBuZXcgdGVzdHMuIENoZWNrLXBvaW50IGZvciByZW1vdmluZyBGYWN0b3J5IEFQ SSBmcm9tIFNraWEKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVy VGV4dHVyZVVwZGF0ZXJDYW52YXMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5ZXJUZXh0dXJl VXBkYXRlclNrUGljdHVyZTo6Y3JlYXRlRnJhbWVCdWZmZXIpOgorICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL3NraWEvUGxhdGZvcm1Db250ZXh0U2tpYS5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpQbGF0Zm9ybUNvbnRleHRTa2lhOjpzZXRTaGFyZWRHcmFwaGljc0NvbnRleHQzRCk6CisKIDIw MTEtMDYtMjcgIExldmkgV2VpbnRyYXViICA8bGV2aXdAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJUZXh0dXJlVXBkYXRlckNhbnZhcy5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJUZXh0 dXJlVXBkYXRlckNhbnZhcy5jcHAJKHJldmlzaW9uIDg5ODQ0KQorKysgU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJUZXh0dXJlVXBkYXRlckNhbnZhcy5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTI0MCwxMCArMjQwLDggQEAgYm9vbCBMYXllclRleHR1cmVVcGRh dGVyU2tQaWN0dXJlOjpjcmVhdAogICAgIHRhcmdldERlc2MuZlN0ZW5jaWxCaXRzID0gODsKICAg ICB0YXJnZXREZXNjLmZQbGF0Zm9ybVJlbmRlclRhcmdldCA9IG1fZmJvOwogICAgIFNrQXV0b1RV bnJlZjxHclJlbmRlclRhcmdldD4gdGFyZ2V0KHN0YXRpY19jYXN0PEdyUmVuZGVyVGFyZ2V0Kj4o bV9za2lhQ29udGV4dC0+Y3JlYXRlUGxhdGZvcm1TdXJmYWNlKHRhcmdldERlc2MpKSk7Ci0gICAg U2tBdXRvVFVucmVmPFNrRGV2aWNlRmFjdG9yeT4gZmFjdG9yeShuZXcgU2tHcHVEZXZpY2VGYWN0 b3J5KG1fc2tpYUNvbnRleHQsIHRhcmdldC5nZXQoKSkpOwotICAgIFNrQXV0b1RVbnJlZjxTa0Rl dmljZT4gZGV2aWNlKGZhY3RvcnkuZ2V0KCktPm5ld0RldmljZSgwLCBTa0JpdG1hcDo6a0FSR0Jf ODg4OF9Db25maWcsIG1fYnVmZmVyU2l6ZS53aWR0aCgpLCBtX2J1ZmZlclNpemUuaGVpZ2h0KCks IGZhbHNlLCBmYWxzZSkpOyAgICAgICAgCi0gICAgbV9jYW52YXMgPSBhZG9wdFB0cihuZXcgU2tD YW52YXMoZmFjdG9yeS5nZXQoKSkpOwotICAgIG1fY2FudmFzLT5zZXREZXZpY2UoZGV2aWNlLmdl dCgpKTsKKyAgICBTa0F1dG9UVW5yZWY8U2tEZXZpY2U+IGRldmljZShuZXcgU2tHcHVEZXZpY2Uo bV9za2lhQ29udGV4dCwgdGFyZ2V0LmdldCgpKSk7CisgICAgbV9jYW52YXMgPSBhZG9wdFB0cihu ZXcgU2tDYW52YXMoZGV2aWNlLmdldCgpKSk7CiAKICAgICBjb250ZXh0KCktPmJpbmRGcmFtZWJ1 ZmZlcihHcmFwaGljc0NvbnRleHQzRDo6RlJBTUVCVUZGRVIsIDApOwogICAgIHJldHVybiB0cnVl OwpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QbGF0Zm9ybUNv bnRleHRTa2lhLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9za2lhL1BsYXRmb3JtQ29udGV4dFNraWEuY3BwCShyZXZpc2lvbiA4OTg0NCkKKysrIFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvUGxhdGZvcm1Db250ZXh0U2tpYS5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTc0MCwxNyArNzQwLDggQEAgdm9pZCBQbGF0Zm9ybUNvbnRl eHRTa2lhOjpzZXRTaGFyZWRHcmFwaAogCiAgICAgICAgICAgICBHclBsYXRmb3JtU3VyZmFjZURl c2MgZHJhd0J1ZkRlc2M7CiAgICAgICAgICAgICBkcmF3aW5nQnVmZmVyLT5nZXRHclBsYXRmb3Jt U3VyZmFjZURlc2MoJmRyYXdCdWZEZXNjKTsKLSAgICAgICAgICAgIEdyVGV4dHVyZSogZHJhd0J1 ZlRleCA9IHN0YXRpY19jYXN0PEdyVGV4dHVyZSo+KGdyLT5jcmVhdGVQbGF0Zm9ybVN1cmZhY2Uo ZHJhd0J1ZkRlc2MpKTsKLSAgICAgICAgICAgIC8vIEZJWE1FOiBUaGlzIHNob3VsZCB1c2UgYSBz bWFydCBwb2ludGVyLgotICAgICAgICAgICAgU2tEZXZpY2VGYWN0b3J5KiBmYWN0b3J5ID0gbmV3 IFNrR3B1RGV2aWNlRmFjdG9yeShnciwgZHJhd0J1ZlRleCk7Ci0gICAgICAgICAgICAvLyBGSVhN RTogVGhpcyBzaG91bGQgdXNlIGEgc21hcnQgcG9pbnRlci4KLSAgICAgICAgICAgIGRyYXdCdWZU ZXgtPnVucmVmKCk7Ci0KLSAgICAgICAgICAgIC8vIEZJWE1FOiBUaGlzIHNob3VsZCB1c2UgYSBz bWFydCBwb2ludGVyLgotICAgICAgICAgICAgU2tEZXZpY2UqIGRldmljZSA9IGZhY3RvcnktPm5l d0RldmljZShtX2NhbnZhcywgU2tCaXRtYXA6OmtBUkdCXzg4ODhfQ29uZmlnLCBkcmF3aW5nQnVm ZmVyLT5zaXplKCkud2lkdGgoKSwgZHJhd2luZ0J1ZmZlci0+c2l6ZSgpLmhlaWdodCgpLCBmYWxz ZSwgZmFsc2UpOwotICAgICAgICAgICAgLy8gRklYTUU6IFRoaXMgc2hvdWxkIHVzZSBhIHNtYXJ0 IHBvaW50ZXIuCi0gICAgICAgICAgICBtX2NhbnZhcy0+c2V0RGV2aWNlKGRldmljZSktPnVucmVm KCk7Ci0gICAgICAgICAgICBtX2NhbnZhcy0+c2V0RGV2aWNlRmFjdG9yeShmYWN0b3J5KS0+dW5y ZWYoKTsKKyAgICAgICAgICAgIFNrQXV0b1RVbnJlZjxHclRleHR1cmU+IGRyYXdCdWZUZXgoc3Rh dGljX2Nhc3Q8R3JUZXh0dXJlKj4oZ3ItPmNyZWF0ZVBsYXRmb3JtU3VyZmFjZShkcmF3QnVmRGVz YykpKTsKKyAgICAgICAgICAgIG1fY2FudmFzLT5zZXREZXZpY2UobmV3IFNrR3B1RGV2aWNlKGdy LCBkcmF3QnVmVGV4LmdldCgpKSktPnVucmVmKCk7CiAgICAgICAgIH0gZWxzZQogICAgICAgICAg ICAgbV9hY2NlbGVyYXRpb25Nb2RlID0gR1BVOwogICAgIH0gZWxzZSB7Cg== 99498 2011-07-01 12:02:59 -0700 2011-07-01 13:28:00 -0700 Patch bug-63488-20110701150258.patch text/plain 3457 reed SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkwMjU2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDctMDEgIE1pa2UgUmVl ZCAgPHJlZWRAZ29vZ2xlLmNvbT4KKworICAgICAgICBTdG9wIHVzaW5nIGRlcHJlY2F0ZWQgU2tE ZXZpY2VGYWN0b3J5IEFQSQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NjM0ODgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBObyBuZXcgdGVzdHMuIENoZWNrLXBvaW50IGZvciByZW1vdmluZyBGYWN0b3J5IEFQ SSBmcm9tIFNraWEKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVy VGV4dHVyZVVwZGF0ZXJDYW52YXMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5ZXJUZXh0dXJl VXBkYXRlclNrUGljdHVyZTo6Y3JlYXRlRnJhbWVCdWZmZXIpOgorICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL3NraWEvUGxhdGZvcm1Db250ZXh0U2tpYS5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpQbGF0Zm9ybUNvbnRleHRTa2lhOjpzZXRTaGFyZWRHcmFwaGljc0NvbnRleHQzRCk6CisKIDIw MTEtMDctMDEgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBPamFuIFZhZmFpLgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvY2hyb21pdW0vTGF5ZXJUZXh0dXJlVXBkYXRlckNhbnZhcy5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJUZXh0dXJlVXBk YXRlckNhbnZhcy5jcHAJKHJldmlzaW9uIDkwMjU1KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJUZXh0dXJlVXBkYXRlckNhbnZhcy5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTI0MCwxMCArMjQwLDggQEAgYm9vbCBMYXllclRleHR1cmVVcGRhdGVyU2tQ aWN0dXJlOjpjcmVhdAogICAgIHRhcmdldERlc2MuZlN0ZW5jaWxCaXRzID0gODsKICAgICB0YXJn ZXREZXNjLmZQbGF0Zm9ybVJlbmRlclRhcmdldCA9IG1fZmJvOwogICAgIFNrQXV0b1RVbnJlZjxH clJlbmRlclRhcmdldD4gdGFyZ2V0KHN0YXRpY19jYXN0PEdyUmVuZGVyVGFyZ2V0Kj4obV9za2lh Q29udGV4dC0+Y3JlYXRlUGxhdGZvcm1TdXJmYWNlKHRhcmdldERlc2MpKSk7Ci0gICAgU2tBdXRv VFVucmVmPFNrRGV2aWNlRmFjdG9yeT4gZmFjdG9yeShuZXcgU2tHcHVEZXZpY2VGYWN0b3J5KG1f c2tpYUNvbnRleHQsIHRhcmdldC5nZXQoKSkpOwotICAgIFNrQXV0b1RVbnJlZjxTa0RldmljZT4g ZGV2aWNlKGZhY3RvcnkuZ2V0KCktPm5ld0RldmljZSgwLCBTa0JpdG1hcDo6a0FSR0JfODg4OF9D b25maWcsIG1fYnVmZmVyU2l6ZS53aWR0aCgpLCBtX2J1ZmZlclNpemUuaGVpZ2h0KCksIGZhbHNl LCBmYWxzZSkpOyAgICAgICAgCi0gICAgbV9jYW52YXMgPSBhZG9wdFB0cihuZXcgU2tDYW52YXMo ZmFjdG9yeS5nZXQoKSkpOwotICAgIG1fY2FudmFzLT5zZXREZXZpY2UoZGV2aWNlLmdldCgpKTsK KyAgICBTa0F1dG9UVW5yZWY8U2tEZXZpY2U+IGRldmljZShuZXcgU2tHcHVEZXZpY2UobV9za2lh Q29udGV4dCwgdGFyZ2V0LmdldCgpKSk7CisgICAgbV9jYW52YXMgPSBhZG9wdFB0cihuZXcgU2tD YW52YXMoZGV2aWNlLmdldCgpKSk7CiAKICAgICBjb250ZXh0KCktPmJpbmRGcmFtZWJ1ZmZlcihH cmFwaGljc0NvbnRleHQzRDo6RlJBTUVCVUZGRVIsIDApOwogICAgIHJldHVybiB0cnVlOwpJbmRl eDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QbGF0Zm9ybUNvbnRleHRT a2lhLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9z a2lhL1BsYXRmb3JtQ29udGV4dFNraWEuY3BwCShyZXZpc2lvbiA5MDI1NSkKKysrIFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvUGxhdGZvcm1Db250ZXh0U2tpYS5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTc0MCwxNyArNzQwLDggQEAgdm9pZCBQbGF0Zm9ybUNvbnRleHRTa2lh OjpzZXRTaGFyZWRHcmFwaAogCiAgICAgICAgICAgICBHclBsYXRmb3JtU3VyZmFjZURlc2MgZHJh d0J1ZkRlc2M7CiAgICAgICAgICAgICBkcmF3aW5nQnVmZmVyLT5nZXRHclBsYXRmb3JtU3VyZmFj ZURlc2MoJmRyYXdCdWZEZXNjKTsKLSAgICAgICAgICAgIEdyVGV4dHVyZSogZHJhd0J1ZlRleCA9 IHN0YXRpY19jYXN0PEdyVGV4dHVyZSo+KGdyLT5jcmVhdGVQbGF0Zm9ybVN1cmZhY2UoZHJhd0J1 ZkRlc2MpKTsKLSAgICAgICAgICAgIC8vIEZJWE1FOiBUaGlzIHNob3VsZCB1c2UgYSBzbWFydCBw b2ludGVyLgotICAgICAgICAgICAgU2tEZXZpY2VGYWN0b3J5KiBmYWN0b3J5ID0gbmV3IFNrR3B1 RGV2aWNlRmFjdG9yeShnciwgZHJhd0J1ZlRleCk7Ci0gICAgICAgICAgICAvLyBGSVhNRTogVGhp cyBzaG91bGQgdXNlIGEgc21hcnQgcG9pbnRlci4KLSAgICAgICAgICAgIGRyYXdCdWZUZXgtPnVu cmVmKCk7Ci0KLSAgICAgICAgICAgIC8vIEZJWE1FOiBUaGlzIHNob3VsZCB1c2UgYSBzbWFydCBw b2ludGVyLgotICAgICAgICAgICAgU2tEZXZpY2UqIGRldmljZSA9IGZhY3RvcnktPm5ld0Rldmlj ZShtX2NhbnZhcywgU2tCaXRtYXA6OmtBUkdCXzg4ODhfQ29uZmlnLCBkcmF3aW5nQnVmZmVyLT5z aXplKCkud2lkdGgoKSwgZHJhd2luZ0J1ZmZlci0+c2l6ZSgpLmhlaWdodCgpLCBmYWxzZSwgZmFs c2UpOwotICAgICAgICAgICAgLy8gRklYTUU6IFRoaXMgc2hvdWxkIHVzZSBhIHNtYXJ0IHBvaW50 ZXIuCi0gICAgICAgICAgICBtX2NhbnZhcy0+c2V0RGV2aWNlKGRldmljZSktPnVucmVmKCk7Ci0g ICAgICAgICAgICBtX2NhbnZhcy0+c2V0RGV2aWNlRmFjdG9yeShmYWN0b3J5KS0+dW5yZWYoKTsK KyAgICAgICAgICAgIFNrQXV0b1RVbnJlZjxHclRleHR1cmU+IGRyYXdCdWZUZXgoc3RhdGljX2Nh c3Q8R3JUZXh0dXJlKj4oZ3ItPmNyZWF0ZVBsYXRmb3JtU3VyZmFjZShkcmF3QnVmRGVzYykpKTsK KyAgICAgICAgICAgIG1fY2FudmFzLT5zZXREZXZpY2UobmV3IFNrR3B1RGV2aWNlKGdyLCBkcmF3 QnVmVGV4LmdldCgpKSktPnVucmVmKCk7CiAgICAgICAgIH0gZWxzZQogICAgICAgICAgICAgbV9h Y2NlbGVyYXRpb25Nb2RlID0gR1BVOwogICAgIH0gZWxzZSB7Cg==