63487 2011-06-27 15:01:35 -0700 Web process always pauses on launch 2011-06-28 07:46:38 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 jeffm jeffm aroben jhoneycutt webkit.review.bot oldest_to_newest 428345 0 jeffm 2011-06-27 15:01:35 -0700 The fix for bug 63335 in r89865 regressed the logic used to pause the web process. The web process now always pauses on launch when the the shift and alt keys were not held down, which means it almost always pauses. 428349 1 98795 jeffm 2011-06-27 15:03:24 -0700 Created attachment 98795 Patch 428355 2 webkit.review.bot 2011-06-27 15:07:22 -0700 Attachment 98795 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 428360 3 jeffm 2011-06-27 15:08:30 -0700 (In reply to comment #2) > Attachment 98795 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 > > Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] > Total errors found: 1 in 2 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. Whoops, I'll add the bug number before landing. 428362 4 jeffm 2011-06-27 15:12:33 -0700 Committed r89865: <http://trac.webkit.org/changeset/89865> 428488 5 jhoneycutt 2011-06-27 17:35:34 -0700 This regressed in <http://trac.webkit.org/changeset/89685>, not <http://trac.webkit.org/changeset/89865>. That's where this was fixed! 428875 6 98795 aroben 2011-06-28 07:46:38 -0700 Comment on attachment 98795 Patch Thanks for fixing this! 98795 2011-06-27 15:03:24 -0700 2011-06-28 07:46:37 -0700 Patch file.patch text/plain 1827 jeffm SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg5ODYzKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDYtMjcgIEplZmYgTWls bGVyICA8amVmZm1AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEluIHRoZSBhYnNlbmNlIG9mIHRoZSBXRUJLSVQyX1BBVVNFX1dFQl9Q Uk9DRVNTX09OX0xBVU5DSCBlbnZpcm9ubWVudCB2YXJpYWJsZSwgb25seSBwYXVzZSB0aGUgd2Vi IHByb2Nlc3Mgb24KKyAgICAgICAgbGF1bmNoIGlmIHRoZSBzaGlmdCwgY29udHJvbCwgYW5kIGFs dCBrZXlzIGFyZSBhbGwgaGVsZCBkb3duLiBUaGlzIHJlZ3Jlc3NlZCBpbiByODk4NjUsIHdoaWNo IGFsd2F5cyBjYXVzZWQgdGhlCisgICAgICAgIHdlYiBwcm9jZXNzIHRvIHBhdXNlIGlmIHRoZSBz aGlmdCBhbmQgYWx0IGtleXMgd2VyZSBub3QgaGVsZCBkb3duLgorCisgICAgICAgICogV2ViUHJv Y2Vzcy9XZWJLaXRNYWluLmNwcDoKKyAgICAgICAgKHBhdXNlUHJvY2Vzc0lmTmVlZGVkKTogQWRk IHNvbWUgcGFyZW50aGVzZXMuCisKIDIwMTEtMDYtMjcgIEh1YW5nIERvbmdzdW5nICA8bHV4dGVs bGFAY29tcGFueTEwMC5uZXQ+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBD aHJpc3RpYW5zZW4uCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYktpdE1haW4u Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViS2l0TWFpbi5j cHAJKHJldmlzaW9uIDg5ODQ3KQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJLaXRN YWluLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTUwLDcgKzE1MCw3IEBAIHN0YXRpYyB2b2lkIHBh dXNlUHJvY2Vzc0lmTmVlZGVkKEhNT0RVTEUKICAgICAvLyBTaG93IGFuIGFsZXJ0IHdoZW4gQ3Ry bC1BbHQtU2hpZnQgaXMgaGVsZCBkb3duIGR1cmluZyBsYXVuY2ggdG8gZ2l2ZSB0aGUgdXNlciB0 aW1lIHRvIGF0dGFjaCBhCiAgICAgLy8gZGVidWdnZXIuIFRoaXMgaXMgdXNlZnVsIGZvciBkZWJ1 Z2dpbmcgcHJvYmxlbXMgdGhhdCBoYXBwZW4gZWFybHkgaW4gdGhlIHdlYiBwcm9jZXNzJ3MgbGlm ZXRpbWUuCiAgICAgY29uc3QgdW5zaWduZWQgc2hvcnQgaGlnaEJpdE1hc2tTaG9ydCA9IDB4ODAw MDsKLSAgICBpZiAoIWdldGVudigiV0VCS0lUMl9QQVVTRV9XRUJfUFJPQ0VTU19PTl9MQVVOQ0gi KSAmJiAhKDo6R2V0S2V5U3RhdGUoVktfQ09OVFJPTCkgJiBoaWdoQml0TWFza1Nob3J0KSAmJiAo OjpHZXRLZXlTdGF0ZShWS19NRU5VKSAmIGhpZ2hCaXRNYXNrU2hvcnQpICYmICg6OkdldEtleVN0 YXRlKFZLX1NISUZUKSAmIGhpZ2hCaXRNYXNrU2hvcnQpKQorICAgIGlmICghZ2V0ZW52KCJXRUJL SVQyX1BBVVNFX1dFQl9QUk9DRVNTX09OX0xBVU5DSCIpICYmICEoKDo6R2V0S2V5U3RhdGUoVktf Q09OVFJPTCkgJiBoaWdoQml0TWFza1Nob3J0KSAmJiAoOjpHZXRLZXlTdGF0ZShWS19NRU5VKSAm IGhpZ2hCaXRNYXNrU2hvcnQpICYmICg6OkdldEtleVN0YXRlKFZLX1NISUZUKSAmIGhpZ2hCaXRN YXNrU2hvcnQpKSkKICAgICAgICAgcmV0dXJuOwogCiAgICAgd2NoYXJfdCBwYXRoW01BWF9QQVRI XTsK