63486 2011-06-27 15:01:07 -0700 Fix filesystem-no-callback-null-ptr-crash.html test to reference proper file api methods 2011-06-28 10:40:07 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 adamk adamk abarth kinuko skylined webkit.review.bot oldest_to_newest 428342 0 adamk 2011-06-27 15:01:07 -0700 Fix filesystem-no-callback-null-ptr-crash.html test to reference proper file api methods 428344 1 98794 adamk 2011-06-27 15:01:28 -0700 Created attachment 98794 Patch 428351 2 adamk 2011-06-27 15:03:42 -0700 This test was correct when written, but the names of these methods has since changed. However, that wasn't being noticed because they're wrapped in "try {} catch(e) {}". 428382 3 98794 webkit.review.bot 2011-06-27 15:31:49 -0700 Comment on attachment 98794 Patch Clearing flags on attachment: 98794 Committed r89870: <http://trac.webkit.org/changeset/89870> 428383 4 webkit.review.bot 2011-06-27 15:31:53 -0700 All reviewed patches have been landed. Closing bug. 428747 5 kinuko 2011-06-28 02:15:52 -0700 Thanks a lot Adam for fixing this!! 428959 6 adamk 2011-06-28 10:40:07 -0700 (In reply to comment #5) > Thanks a lot Adam for fixing this!! No problem. However, it still doesn't explain the flakiness in http://webkit.org/b/61936 (though I think this test is unlikely to be the culprit there). 98794 2011-06-27 15:01:28 -0700 2011-06-27 15:31:49 -0700 Patch bug-63486-20110627150127.patch text/plain 1666 adamk U3VidmVyc2lvbiBSZXZpc2lvbjogODk3MDUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA3OWI5MTIxOWE3NjgzYjk3YmI1MmY5 MDIzYTA0YTIyNDNlMTA4ZDZhLi45N2FkZGEzNjU5MmUwYmM1NmZjOTFjYTc1MGI5MzlhN2JkMzAy YjYwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDYtMjcgIEFkYW0gS2xlaW4gIDxhZGFt a0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgRml4IGZpbGVzeXN0ZW0tbm8tY2FsbGJhY2stbnVsbC1wdHItY3Jhc2guaHRtbCB0 ZXN0IHRvIHJlZmVyZW5jZSBwcm9wZXIgZmlsZSBhcGkgbWV0aG9kcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjM0ODYKKworICAgICAgICAqIGZhc3Qv ZmlsZXN5c3RlbS9maWxlc3lzdGVtLW5vLWNhbGxiYWNrLW51bGwtcHRyLWNyYXNoLmh0bWw6CisK IDIwMTEtMDYtMjQgIEFiaGlzaGVrIEFyeWEgIDxpbmZlcm5vQGNocm9taXVtLm9yZz4KIAogICAg ICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zh c3QvZmlsZXN5c3RlbS9maWxlc3lzdGVtLW5vLWNhbGxiYWNrLW51bGwtcHRyLWNyYXNoLmh0bWwg Yi9MYXlvdXRUZXN0cy9mYXN0L2ZpbGVzeXN0ZW0vZmlsZXN5c3RlbS1uby1jYWxsYmFjay1udWxs LXB0ci1jcmFzaC5odG1sCmluZGV4IDFhMDNhYzhkYmU1OWMwMDA5NjZhMWUzNjVjYTZkMmJjNTli ZTk3ODMuLmEwYTA2ZDdiMmM2M2QwZmExNDg2NDJiZWNkNmExYzMyMjI4MmIzZWMgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL2Zhc3QvZmlsZXN5c3RlbS9maWxlc3lzdGVtLW5vLWNhbGxiYWNrLW51 bGwtcHRyLWNyYXNoLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9maWxlc3lzdGVtL2ZpbGVz eXN0ZW0tbm8tY2FsbGJhY2stbnVsbC1wdHItY3Jhc2guaHRtbApAQCAtNiw4ICs2LDEwIEBACiA8 c2NyaXB0PgogICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQogICAgICAgbGF5b3V0 VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOwotICAvLyBUaGVzZSB0d28gY2FsbHMgc28gbm90 IGNhdXNlIGEgTlVMTCBwb2ludGVyIGNyYXNoOgotICB0cnkgeyB3aW5kb3cucmVxdWVzdEZpbGVT eXN0ZW0oMTApOyB9IGNhdGNoIChlKSB7fQotICB0cnkgeyB3aW5kb3cucmVzb2x2ZUxvY2FsRmls ZVN5c3RlbVVSSSgpOyB9IGNhdGNoIChlKSB7fQotICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgn bG9nJykuaW5uZXJIVE1MID0gIlBBU1MiOworICBpZiAod2luZG93LndlYmtpdFJlcXVlc3RGaWxl U3lzdGVtKSB7CisgICAgICAvLyBUaGVzZSB0d28gY2FsbHMgc2hvdWxkIG5vdCBjYXVzZSBhIE5V TEwgcG9pbnRlciBjcmFzaDoKKyAgICAgIHdlYmtpdFJlcXVlc3RGaWxlU3lzdGVtKFRFTVBPUkFS WSwgMTAwKTsKKyAgICAgIHdlYmtpdFJlc29sdmVMb2NhbEZpbGVTeXN0ZW1VUkwoJycpOworICAg ICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2xvZycpLmlubmVySFRNTCA9ICJQQVNTIjsKKyAg fQogPC9zY3JpcHQ+Cg==