63484 2011-06-27 14:44:53 -0700 [Windows, WinCairo] Don't Attempt to Create Zero-Size DIB 2011-06-28 08:42:31 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 bfulgham bfulgham aroben eric jhoneycutt oldest_to_newest 428326 0 bfulgham 2011-06-27 14:44:53 -0700 While investigating a separate issue, I noticed that I was hitting an assertion in the Cairo drawing layer because it was attempting to use an invalid HBITMAP created in the WebNodeHighlight::update method. The underlying issue was that the CreateDIBSection function was failing, because it was being requested to create a section of zero height. I think the attached patch would be safe for the CoreGraphics and Cairo ports, but wanted to see if anyone knew of a reason why it would be bad to exit early in the case of a zero height (or zero width) paint region. 428334 1 98790 bfulgham 2011-06-27 14:51:38 -0700 Created attachment 98790 Patch 428889 2 98790 aroben 2011-06-28 08:10:55 -0700 Comment on attachment 98790 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98790&action=review > Source/WebKit/win/WebNodeHighlight.cpp:155 > + ASSERT_WITH_MESSAGE(hbmp.get(), "::CreateDIBSection failed with error %lu", ::GetLastError()); No need for the .get() here. 428910 3 bfulgham 2011-06-28 08:42:31 -0700 Committed r89932: <http://trac.webkit.org/changeset/89932> 98790 2011-06-27 14:51:38 -0700 2011-06-28 08:10:54 -0700 Patch bug-63484-20110627145137.patch text/plain 1500 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg5ODYzKQorKysgU291cmNlL1dlYktpdC93 aW4vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDYtMjcg IEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEF2b2lkIGF0dGVtcHRpbmcgdG8gY3JlYXRl IGEgemVyby1zaXplIERJQi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTYzNDg0LgorCisgICAgICAgICogV2ViTm9kZUhpZ2hsaWdodC5jcHA6CisgICAg ICAgIChXZWJOb2RlSGlnaGxpZ2h0Ojp1cGRhdGUpOiBDaGVjayBmb3IgemVyby1oZWlnaHQgKG9y IHplcm8td2lkdGgpCisgICAgICAgIHJlZ2lvbiBmb3IgRElCLCBhbmQgZXhpdCBlYXJseSBpZiBh dHRlbXB0aW5nIHRvIGNyZWF0ZSBhIHplcm8tc2l6ZQorICAgICAgICBESUIvQklUTUFQLgorCiAy MDExLTA2LTI0ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgQW5kZXJzIENhcmxzc29uLgpJbmRleDogU291cmNlL1dlYktpdC93aW4vV2ViTm9k ZUhpZ2hsaWdodC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC93aW4vV2ViTm9kZUhp Z2hsaWdodC5jcHAJKHJldmlzaW9uIDg5MTgwKQorKysgU291cmNlL1dlYktpdC93aW4vV2ViTm9k ZUhpZ2hsaWdodC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE0NSwxMCArMTQ1LDE0IEBAIHZvaWQg V2ViTm9kZUhpZ2hsaWdodDo6dXBkYXRlKCkKICAgICBzaXplLmN4ID0gd2ViVmlld1JlY3Qucmln aHQgLSB3ZWJWaWV3UmVjdC5sZWZ0OwogICAgIHNpemUuY3kgPSB3ZWJWaWV3UmVjdC5ib3R0b20g LSB3ZWJWaWV3UmVjdC50b3A7CiAKKyAgICBpZiAoIXNpemUuY3ggfHwgIXNpemUuY3kpCisgICAg ICAgIHJldHVybjsKKwogICAgIEJpdG1hcEluZm8gYml0bWFwSW5mbyA9IEJpdG1hcEluZm86OmNy ZWF0ZUJvdHRvbVVwKEludFNpemUoc2l6ZSkpOwogCiAgICAgdm9pZCogcGl4ZWxzID0gMDsKICAg ICBPd25QdHI8SEJJVE1BUD4gaGJtcCA9IGFkb3B0UHRyKDo6Q3JlYXRlRElCU2VjdGlvbihoZGMs ICZiaXRtYXBJbmZvLCBESUJfUkdCX0NPTE9SUywgJnBpeGVscywgMCwgMCkpOworICAgIEFTU0VS VF9XSVRIX01FU1NBR0UoaGJtcC5nZXQoKSwgIjo6Q3JlYXRlRElCU2VjdGlvbiBmYWlsZWQgd2l0 aCBlcnJvciAlbHUiLCA6OkdldExhc3RFcnJvcigpKTsKIAogICAgIDo6U2VsZWN0T2JqZWN0KGhk YywgaGJtcC5nZXQoKSk7CiAK