63475 2011-06-27 13:14:57 -0700 Use specific headers includes rather than full system headers. 2011-06-27 14:23:48 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 menard menard darin eric.carlson sam webkit.review.bot oldest_to_newest 428214 0 menard 2011-06-27 13:14:57 -0700 Use specific headers includes rather than full system headers. 428219 1 98773 menard 2011-06-27 13:18:15 -0700 Created attachment 98773 Patch 428222 2 98773 darin 2011-06-27 13:28:25 -0700 Comment on attachment 98773 Patch Is there a concrete benefit to this change? I ask, because due to the way precompiled headers and such work, the other teams at Apple have told us that best practice is to include the complete header, not the specific headers, for system frameworks like these. 428225 3 menard 2011-06-27 13:30:54 -0700 (In reply to comment #2) > (From update of attachment 98773 [details]) > Is there a concrete benefit to this change? I ask, because due to the way precompiled headers and such work, the other teams at Apple have told us that best practice is to include the complete header, not the specific headers, for system frameworks like these. Quoting Sam Weinig who send me an email : "The inclusion of <Cocoa/Cocoa.h> in header files seems really suspect here. I have been trying to remove as many full system header inclusions as possible, and this seems like a step in the wrong direction." 428230 4 98773 darin 2011-06-27 13:33:43 -0700 Comment on attachment 98773 Patch OK. If Sam says this is the right thing to do, I guess that’s OK. 428301 5 98773 webkit.review.bot 2011-06-27 14:23:44 -0700 Comment on attachment 98773 Patch Clearing flags on attachment: 98773 Committed r89858: <http://trac.webkit.org/changeset/89858> 428302 6 webkit.review.bot 2011-06-27 14:23:48 -0700 All reviewed patches have been landed. Closing bug. 98773 2011-06-27 13:18:15 -0700 2011-06-27 14:23:44 -0700 Patch bug-63475-20110627171813.patch text/plain 3025 menard SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg5ODQ2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDYtMjcgIEFsZXhpcyBN ZW5hcmQgIDxhbGV4aXMubWVuYXJkQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIHNwZWNpZmljIGhlYWRlcnMgaW5jbHVk ZXMgcmF0aGVyIHRoYW4gZnVsbCBzeXN0ZW0gaGVhZGVycy4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYzNDc1CisKKyAgICAgICAgVXNlIG9ubHkgbmVl ZGVkIGhlYWRlcnMgcmF0aGVyIHRoYW4gc3lzdGVtIGhlYWRlcnMuCisKKyAgICAgICAgTm8gbmV3 IHRlc3RzLCBpdCdzIGp1c3QgYSBsaXR0bGUgY29zbWV0aWMgY2hhbmdlLgorCisgICAgICAgICog cGxhdGZvcm0vbWFjL1dlYlZpZGVvRnVsbHNjcmVlbkNvbnRyb2xsZXIuaDoKKyAgICAgICAgKiBw bGF0Zm9ybS9tYWMvV2ViVmlkZW9GdWxsc2NyZWVuSFVEV2luZG93Q29udHJvbGxlci5oOgorCiAy MDExLTA2LTI3ICBKdXN0aW4gR2FyY2lhICA8anVzdGluLmdhcmNpYUBhcHBsZS5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgUnlvc3VrZSBOaXdhLgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbWFjL1dlYlZpZGVvRnVsbHNjcmVlbkNvbnRyb2xsZXIuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvV2ViVmlkZW9GdWxsc2NyZWVuQ29udHJvbGxlci5o CShyZXZpc2lvbiA4OTg0NSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJWaWRl b0Z1bGxzY3JlZW5Db250cm9sbGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTI1LDcgKzI1LDkgQEAK IAogI2lmIEVOQUJMRShWSURFTykKIAotI2ltcG9ydCA8Q29jb2EvQ29jb2EuaD4KKyNpbXBvcnQg PEFwcEtpdC9OU1dpbmRvd0NvbnRyb2xsZXIuaD4KKyNpbXBvcnQgPEFwcEtpdC9OU1NjcmVlbi5o PgorI2ltcG9ydCA8Rm91bmRhdGlvbi9OU1RpbWVyLmg+CiAjaW1wb3J0IDx3dGYvUmVmUHRyLmg+ CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21h Yy9XZWJWaWRlb0Z1bGxzY3JlZW5IVURXaW5kb3dDb250cm9sbGVyLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1dlYlZpZGVvRnVsbHNjcmVlbkhVRFdpbmRvd0Nv bnRyb2xsZXIuaAkocmV2aXNpb24gODk4NDUpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9t YWMvV2ViVmlkZW9GdWxsc2NyZWVuSFVEV2luZG93Q29udHJvbGxlci5oCSh3b3JraW5nIGNvcHkp CkBAIC0yNSw3ICsyNSwxMSBAQAogCiAjaWYgRU5BQkxFKFZJREVPKQogCi0jaW1wb3J0IDxDb2Nv YS9Db2NvYS5oPgorI2ltcG9ydCA8QXBwS2l0L05TQnV0dG9uLmg+CisjaW1wb3J0IDxBcHBLaXQv TlNDb250cm9sLmg+CisjaW1wb3J0IDxBcHBLaXQvTlNUZXh0RmllbGQuaD4KKyNpbXBvcnQgPEFw cEtpdC9OU1RyYWNraW5nQXJlYS5oPgorI2ltcG9ydCA8QXBwS2l0L05TV2luZG93Q29udHJvbGxl ci5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgY2xhc3MgSFRNTE1lZGlhRWxlbWVudDsK SW5kZXg6IFNvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQvcXQvQ2hhbmdlTG9nCShyZXZpc2lvbiA4OTg0NikKKysrIFNvdXJjZS9XZWJLaXQvcXQv Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDYtMjcgIEFs ZXhpcyBNZW5hcmQgIDxhbGV4aXMubWVuYXJkQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIHNwZWNpZmljIGhlYWRlcnMg aW5jbHVkZXMgcmF0aGVyIHRoYW4gZnVsbCBzeXN0ZW0gaGVhZGVycy4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYzNDc1CisKKyAgICAgICAgVXNlIG9u bHkgbmVlZGVkIGhlYWRlcnMgcmF0aGVyIHRoYW4gc3lzdGVtIGhlYWRlcnMuCisKKyAgICAgICAg KiBXZWJDb3JlU3VwcG9ydC9RVEtpdEZ1bGxTY3JlZW5WaWRlb0hhbmRsZXIubW06CisKIDIwMTEt MDYtMjcgIEFsZXhpcyBNZW5hcmQgIDxhbGV4aXMubWVuYXJkQG9wZW5ib3NzYS5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCkluZGV4OiBTb3Vy Y2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L1FUS2l0RnVsbFNjcmVlblZpZGVvSGFuZGxlci5t bQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L1FUS2l0RnVs bFNjcmVlblZpZGVvSGFuZGxlci5tbQkocmV2aXNpb24gODk4NDUpCisrKyBTb3VyY2UvV2ViS2l0 L3F0L1dlYkNvcmVTdXBwb3J0L1FUS2l0RnVsbFNjcmVlblZpZGVvSGFuZGxlci5tbQkod29ya2lu ZyBjb3B5KQpAQCAtMjIsOCArMjIsNiBAQAogCiAjaW5jbHVkZSAiUVRLaXRGdWxsU2NyZWVuVmlk ZW9IYW5kbGVyLmgiCiAKLSNpbXBvcnQgPENvY29hL0NvY29hLmg+Ci0KICNpbmNsdWRlICJIVE1M VmlkZW9FbGVtZW50LmgiCiAjaW5jbHVkZSAiV2ViVmlkZW9GdWxsc2NyZWVuQ29udHJvbGxlci5o IgogCg==