63462 2011-06-27 08:57:21 -0700 [EFL] Add ewk_frame_text_selection_type_get function 2011-06-29 07:13:13 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED P4 Enhancement --- 0 mpakulavelrutka webkit-unassigned antognolli+webkit gyuyoung.kim kenneth leandro lucas.de.marchi rakuco tonikitoo webkit.review.bot oldest_to_newest 427984 0 mpakulavelrutka 2011-06-27 08:57:21 -0700 A function to obtain current WebCore::VisibleSelection text selection type. 427986 1 98737 mpakulavelrutka 2011-06-27 09:01:42 -0700 Created attachment 98737 proposed patch 428400 2 98737 tonikitoo 2011-06-27 15:48:59 -0700 Comment on attachment 98737 proposed patch Is it up for review? I am wondering how would this API be used? 428485 3 98737 gyuyoung.kim 2011-06-27 17:34:41 -0700 Comment on attachment 98737 proposed patch It seems Michal miss to request review and cq. I request them instead of him. 428494 4 98737 gyuyoung.kim 2011-06-27 17:41:54 -0700 Comment on attachment 98737 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=98737&action=review > Source/WebKit/efl/ewk/ewk_frame.cpp:1536 > + EWK_FRAME_SD_GET_OR_RETURN(o, sd, EWK_TEXT_SELECTION_NONE); I'm not sure if we can use above usage. There is similar usage on Bug 63229. If there are no problems, I think this usage is good. > Source/WebKit/efl/ewk/ewk_frame.cpp:1537 > + EINA_SAFETY_ON_NULL_RETURN_VAL(sd->frame, EWK_TEXT_SELECTION_NONE); ditto. > Source/WebKit/efl/ewk/ewk_frame.cpp:1541 > + return EWK_TEXT_SELECTION_NONE; Adhere indentation. if (!controller) return XXX > Source/WebKit/efl/ewk/ewk_frame.cpp:1547 > + type = EWK_TEXT_SELECTION_CARET; Adhere indentation. We need to use 4 spaces. case WebCore::XXX type = EWK_XXX > Source/WebKit/efl/ewk/ewk_frame.cpp:1550 > + type = EWK_TEXT_SELECTION_RANGE; ditto. > Source/WebKit/efl/ewk/ewk_frame.cpp:1553 > + type = EWK_TEXT_SELECTION_NONE; ditto. > Source/WebKit/efl/ewk/ewk_frame.cpp:1555 > + default: ditto. > Source/WebKit/efl/ewk/ewk_frame.h:158 > + EWK_TEXT_SELECTION_NONE, ditto. 428776 5 mpakulavelrutka 2011-06-28 03:12:34 -0700 (In reply to comment #2) > (From update of attachment 98737 [details]) > Is it up for review? I am wondering how would this API be used? Sorry, forgot to set the flag as Gyuyoung said. This API can be used by webview to determine text selection changes. Here: https://bugs.webkit.org/show_bug.cgi?id=63525 I proposed a method of informing webview of selection changes. 428778 6 98737 mpakulavelrutka 2011-06-28 03:20:18 -0700 Comment on attachment 98737 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=98737&action=review >> Source/WebKit/efl/ewk/ewk_frame.cpp:1541 >> + return EWK_TEXT_SELECTION_NONE; > > Adhere indentation. > > if (!controller) > return XXX I think that indentation here is OK, no tabs used, only spaces: 4 before if 8 before return >> Source/WebKit/efl/ewk/ewk_frame.cpp:1547 >> + type = EWK_TEXT_SELECTION_CARET; > > Adhere indentation. We need to use 4 spaces. > > case WebCore::XXX > type = EWK_XXX So here do you want me to match 'type' indentation with 'case'? 428821 7 rakuco 2011-06-28 05:52:49 -0700 > Source/WebKit/efl/ewk/ewk_frame.cpp:1543 > + Ewk_Text_Selection_Type type; You could return directly in the switch statement and get rid of this variable. 428904 8 98929 mpakulavelrutka 2011-06-28 08:31:48 -0700 Created attachment 98929 second patch set 428905 9 mpakulavelrutka 2011-06-28 08:33:36 -0700 (In reply to comment #7) > > Source/WebKit/efl/ewk/ewk_frame.cpp:1543 > > + Ewk_Text_Selection_Type type; > > You could return directly in the switch statement and get rid of this variable. Done. I left case WebCore::VisibleSelection::NoSelection with the same return value as default one because of warnings when it is removed. 428940 10 98929 leandro 2011-06-28 10:03:19 -0700 Comment on attachment 98929 second patch set View in context: https://bugs.webkit.org/attachment.cgi?id=98929&action=review > Source/WebKit/efl/ChangeLog:9 > + This patch adds a method to obtain current WebCore::VisibleSelection > + text selection type. No need to say 'This patch'; just begin the sentence with 'Add a method to...'. > Source/WebKit/efl/ewk/ewk_frame.cpp:1548 > + case WebCore::VisibleSelection::NoSelection: default: > Source/WebKit/efl/ewk/ewk_frame.cpp:1552 > + return EWK_TEXT_SELECTION_NONE; Delete this line. > Source/WebKit/efl/ewk/ewk_frame.h:162 > +enum _Ewk_Text_Selection_Type { > + EWK_TEXT_SELECTION_NONE, > + EWK_TEXT_SELECTION_CARET, > + EWK_TEXT_SELECTION_RANGE > +}; > +typedef enum _Ewk_Text_Selection_Type Ewk_Text_Selection_Type; typedef enum { ... } Ewk_Text_Selection_Type; 429462 11 99049 mpakulavelrutka 2011-06-29 00:36:51 -0700 Created attachment 99049 another patch 429556 12 98929 mpakulavelrutka 2011-06-29 06:15:26 -0700 Comment on attachment 98929 second patch set View in context: https://bugs.webkit.org/attachment.cgi?id=98929&action=review >> Source/WebKit/efl/ChangeLog:9 >> + text selection type. > > No need to say 'This patch'; just begin the sentence with 'Add a method to...'. fixed >> Source/WebKit/efl/ewk/ewk_frame.cpp:1548 >> + case WebCore::VisibleSelection::NoSelection: > > default: fixed >> Source/WebKit/efl/ewk/ewk_frame.cpp:1552 >> + return EWK_TEXT_SELECTION_NONE; > > Delete this line. fixed >> Source/WebKit/efl/ewk/ewk_frame.h:162 >> +typedef enum _Ewk_Text_Selection_Type Ewk_Text_Selection_Type; > > typedef enum { ... } Ewk_Text_Selection_Type; fixed 429557 13 rakuco 2011-06-29 06:16:12 -0700 LGTM. 429561 14 99049 kenneth 2011-06-29 06:32:27 -0700 Comment on attachment 99049 another patch LGTM 429581 15 99049 webkit.review.bot 2011-06-29 07:13:07 -0700 Comment on attachment 99049 another patch Clearing flags on attachment: 99049 Committed r90015: <http://trac.webkit.org/changeset/90015> 429582 16 webkit.review.bot 2011-06-29 07:13:13 -0700 All reviewed patches have been landed. Closing bug. 98737 2011-06-27 09:01:42 -0700 2011-06-28 08:31:48 -0700 proposed patch patch.diff text/plain 3205 mpakulavelrutka ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBlNmI2MjQ2Li44YzA4ODczIDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTEtMDYtMjcgIE1pY2hhbCBQYWt1bGEgdmVsIFJ1dGthICA8bS5w YWt1bGFAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgW0VGTF0gQWRkIGV3a19mcmFtZV90ZXh0X3NlbGVjdGlvbl90eXBlX2dldCBm dW5jdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NjM0NjIKKworICAgICAgICBUaGlzIHBhdGNoIGFkZHMgYSBtZXRob2QgdG8gb2J0YWluIGN1cnJl bnQgV2ViQ29yZTo6VmlzaWJsZVNlbGVjdGlvbiB0ZXh0IHNlbGVjdGlvbiB0eXBlLgorCisgICAg ICAgICogZXdrL2V3a19mcmFtZS5jcHA6CisgICAgICAgIChld2tfZnJhbWVfdGV4dF9zZWxlY3Rp b25fdHlwZV9nZXQpOgorICAgICAgICAqIGV3ay9ld2tfZnJhbWUuaDoKKwogMjAxMS0wNi0yNyAg Sm9uZ3Nlb2sgWWFuZyAgPGpzNDUueWFuZ0BzYW1zdW5nLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBLZW50IFRhbXVyYS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tf ZnJhbWUuY3BwIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19mcmFtZS5jcHAKaW5kZXggMWE0 MTUwYy4uZDAwMzNkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19mcmFt ZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19mcmFtZS5jcHAKQEAgLTE1MjUs NiArMTUyNSw0MCBAQCBFaW5hX0Jvb2wgZXdrX2ZyYW1lX2ZlZWRfa2V5X3VwKEV2YXNfT2JqZWN0 KiBvLCBjb25zdCBFdmFzX0V2ZW50X0tleV9VcCogZXYpCiAgICAgcmV0dXJuIHNkLT5mcmFtZS0+ ZXZlbnRIYW5kbGVyKCktPmtleUV2ZW50KGV2ZW50KTsKIH0KIAorLyoqCisgKiBSZXR1cm5zIGN1 cnJlbnQgdGV4dCBzZWxlY3Rpb24gdHlwZS4KKyAqCisgKiBAcGFyYW0gbyBhIGZyYW1lIG9iamVj dCB0byBjaGVjayBzZWxlY3Rpb24gdHlwZQorICogQHJldHVybiBDdXJyZW50IHRleHQgc2VsZWN0 aW9uIHR5cGUgb24gc3VjY2VzcyBvciBubyBzZWxlY3Rpb24gb3RoZXJ3aXNlCisgKi8KK0V3a19U ZXh0X1NlbGVjdGlvbl9UeXBlIGV3a19mcmFtZV90ZXh0X3NlbGVjdGlvbl90eXBlX2dldChFdmFz X09iamVjdCAqbykKK3sKKyAgICBFV0tfRlJBTUVfU0RfR0VUX09SX1JFVFVSTihvLCBzZCwgRVdL X1RFWFRfU0VMRUNUSU9OX05PTkUpOworICAgIEVJTkFfU0FGRVRZX09OX05VTExfUkVUVVJOX1ZB TChzZC0+ZnJhbWUsIEVXS19URVhUX1NFTEVDVElPTl9OT05FKTsKKworICAgIFdlYkNvcmU6OkZy YW1lU2VsZWN0aW9uKiBjb250cm9sbGVyID0gc2QtPmZyYW1lLT5zZWxlY3Rpb24oKTsKKyAgICBp ZiAoIWNvbnRyb2xsZXIpCisgICAgICAgIHJldHVybiBFV0tfVEVYVF9TRUxFQ1RJT05fTk9ORTsK KworICAgIEV3a19UZXh0X1NlbGVjdGlvbl9UeXBlIHR5cGU7CisKKyAgICBzd2l0Y2ggKGNvbnRy b2xsZXItPnNlbGVjdGlvblR5cGUoKSkgeworICAgIGNhc2UgV2ViQ29yZTo6VmlzaWJsZVNlbGVj dGlvbjo6Q2FyZXRTZWxlY3Rpb246CisgICAgICAgIHR5cGUgPSBFV0tfVEVYVF9TRUxFQ1RJT05f Q0FSRVQ7CisgICAgICAgIGJyZWFrOworICAgIGNhc2UgV2ViQ29yZTo6VmlzaWJsZVNlbGVjdGlv bjo6UmFuZ2VTZWxlY3Rpb246CisgICAgICAgIHR5cGUgPSBFV0tfVEVYVF9TRUxFQ1RJT05fUkFO R0U7CisgICAgICAgIGJyZWFrOworICAgIGNhc2UgV2ViQ29yZTo6VmlzaWJsZVNlbGVjdGlvbjo6 Tm9TZWxlY3Rpb246CisgICAgICAgIHR5cGUgPSBFV0tfVEVYVF9TRUxFQ1RJT05fTk9ORTsKKyAg ICAgICAgYnJlYWs7CisgICAgZGVmYXVsdDoKKyAgICAgICAgdHlwZSA9IEVXS19URVhUX1NFTEVD VElPTl9OT05FOworICAgIH0KKworICAgIHJldHVybiB0eXBlOworfQorCiAvKiBpbnRlcm5hbCBt ZXRob2RzICoqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KiovCiAKIC8qKgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19mcmFtZS5o IGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19mcmFtZS5oCmluZGV4IGUwOTI3YmYuLjQ5NmJh ZmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfZnJhbWUuaAorKysgYi9T b3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX2ZyYW1lLmgKQEAgLTE1NCw2ICsxNTQsMTMgQEAgc3Ry dWN0IF9Fd2tfVG91Y2hfUG9pbnQgewogICAgIEV3a19Ub3VjaF9Qb2ludF9UeXBlIHN0YXRlOyAv Kio8IHN0YXRlIG9mIHRoZSB0b3VjaCBldmVudCAqLwogfTsKIAorZW51bSBfRXdrX1RleHRfU2Vs ZWN0aW9uX1R5cGUgeworICAgIEVXS19URVhUX1NFTEVDVElPTl9OT05FLAorICAgIEVXS19URVhU X1NFTEVDVElPTl9DQVJFVCwKKyAgICBFV0tfVEVYVF9TRUxFQ1RJT05fUkFOR0UKK307Cit0eXBl ZGVmIGVudW0gX0V3a19UZXh0X1NlbGVjdGlvbl9UeXBlIEV3a19UZXh0X1NlbGVjdGlvbl9UeXBl OworCiBFQVBJIEV2YXNfT2JqZWN0ICpld2tfZnJhbWVfdmlld19nZXQoY29uc3QgRXZhc19PYmpl Y3QgKm8pOwogCiBFQVBJIEVpbmFfSXRlcmF0b3IgKmV3a19mcmFtZV9jaGlsZHJlbl9pdGVyYXRv cl9uZXcoRXZhc19PYmplY3QgKm8pOwpAQCAtMjI1LDYgKzIzMiw4IEBAIEVBUEkgRWluYV9Cb29s ICAgIGV3a19mcmFtZV9mZWVkX3RvdWNoX2V2ZW50KEV2YXNfT2JqZWN0KiBvLCBFd2tfVG91Y2hf RXZlbnRfVHlwCiBFQVBJIEVpbmFfQm9vbCAgICBld2tfZnJhbWVfZmVlZF9rZXlfZG93bihFdmFz X09iamVjdCAqbywgY29uc3QgRXZhc19FdmVudF9LZXlfRG93biAqZXYpOwogRUFQSSBFaW5hX0Jv b2wgICAgZXdrX2ZyYW1lX2ZlZWRfa2V5X3VwKEV2YXNfT2JqZWN0ICpvLCBjb25zdCBFdmFzX0V2 ZW50X0tleV9VcCAqZXYpOwogCitFQVBJIEV3a19UZXh0X1NlbGVjdGlvbl9UeXBlIGV3a19mcmFt ZV90ZXh0X3NlbGVjdGlvbl90eXBlX2dldChFdmFzX09iamVjdCogbyk7CisKIAogI2lmZGVmIF9f Y3BsdXNwbHVzCiB9Cg== 98929 2011-06-28 08:31:48 -0700 2011-06-29 06:15:26 -0700 second patch set selection_patch.diff text/plain 3187 mpakulavelrutka ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCA2ZTk2NDg5Li45YmM3NzFmIDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDUgKzEsMTkgQEAKIDIwMTEtMDYtMjggIE1pY2hhbCBQYWt1bGEgdmVsIFJ1dGthICA8bS5w YWt1bGFAc2Ftc3VuZy5jb20+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgW0VGTF0gQWRkIGV3a19mcmFtZV90ZXh0X3NlbGVjdGlvbl90eXBlX2dldCBm dW5jdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NjM0NjIKKworICAgICAgICBUaGlzIHBhdGNoIGFkZHMgYSBtZXRob2QgdG8gb2J0YWluIGN1cnJl bnQgV2ViQ29yZTo6VmlzaWJsZVNlbGVjdGlvbgorICAgICAgICB0ZXh0IHNlbGVjdGlvbiB0eXBl LgorCisgICAgICAgICogZXdrL2V3a19mcmFtZS5jcHA6CisgICAgICAgIChld2tfZnJhbWVfdGV4 dF9zZWxlY3Rpb25fdHlwZV9nZXQpOgorICAgICAgICAqIGV3ay9ld2tfZnJhbWUuaDoKKworMjAx MS0wNi0yOCAgTWljaGFsIFBha3VsYSB2ZWwgUnV0a2EgIDxtLnBha3VsYUBzYW1zdW5nLmNvbT4K KwogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbi4KIAogICAg ICAgICBbRUZMXSBJbXBsZW1lbnQgRWRpdG9yQ2xpZW50RWZsOjpyZXNwb25kVG9DaGFuZ2VkU2Vs ZWN0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX2ZyYW1lLmNwcCBi L1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfZnJhbWUuY3BwCmluZGV4IDM1MzhhYjguLmY4NjAz NzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfZnJhbWUuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfZnJhbWUuY3BwCkBAIC0xNTI1LDYgKzE1MjUsMzMg QEAgRWluYV9Cb29sIGV3a19mcmFtZV9mZWVkX2tleV91cChFdmFzX09iamVjdCogbywgY29uc3Qg RXZhc19FdmVudF9LZXlfVXAqIGV2KQogICAgIHJldHVybiBzZC0+ZnJhbWUtPmV2ZW50SGFuZGxl cigpLT5rZXlFdmVudChldmVudCk7CiB9CiAKKy8qKgorICogUmV0dXJucyBjdXJyZW50IHRleHQg c2VsZWN0aW9uIHR5cGUuCisgKgorICogQHBhcmFtIG8gYSBmcmFtZSBvYmplY3QgdG8gY2hlY2sg c2VsZWN0aW9uIHR5cGUKKyAqIEByZXR1cm4gQ3VycmVudCB0ZXh0IHNlbGVjdGlvbiB0eXBlIG9u IHN1Y2Nlc3Mgb3Igbm8gc2VsZWN0aW9uIG90aGVyd2lzZQorICovCitFd2tfVGV4dF9TZWxlY3Rp b25fVHlwZSBld2tfZnJhbWVfdGV4dF9zZWxlY3Rpb25fdHlwZV9nZXQoRXZhc19PYmplY3QgKm8p Cit7CisgICAgRVdLX0ZSQU1FX1NEX0dFVF9PUl9SRVRVUk4obywgc2QsIEVXS19URVhUX1NFTEVD VElPTl9OT05FKTsKKyAgICBFSU5BX1NBRkVUWV9PTl9OVUxMX1JFVFVSTl9WQUwoc2QtPmZyYW1l LCBFV0tfVEVYVF9TRUxFQ1RJT05fTk9ORSk7CisKKyAgICBXZWJDb3JlOjpGcmFtZVNlbGVjdGlv biogY29udHJvbGxlciA9IHNkLT5mcmFtZS0+c2VsZWN0aW9uKCk7CisgICAgaWYgKCFjb250cm9s bGVyKQorICAgICAgICByZXR1cm4gRVdLX1RFWFRfU0VMRUNUSU9OX05PTkU7CisKKyAgICBzd2l0 Y2ggKGNvbnRyb2xsZXItPnNlbGVjdGlvblR5cGUoKSkgeworICAgIGNhc2UgV2ViQ29yZTo6Vmlz aWJsZVNlbGVjdGlvbjo6Q2FyZXRTZWxlY3Rpb246CisgICAgICAgIHJldHVybiBFV0tfVEVYVF9T RUxFQ1RJT05fQ0FSRVQ7CisgICAgY2FzZSBXZWJDb3JlOjpWaXNpYmxlU2VsZWN0aW9uOjpSYW5n ZVNlbGVjdGlvbjoKKyAgICAgICAgcmV0dXJuIEVXS19URVhUX1NFTEVDVElPTl9SQU5HRTsKKyAg ICBjYXNlIFdlYkNvcmU6OlZpc2libGVTZWxlY3Rpb246Ok5vU2VsZWN0aW9uOgorICAgICAgICBy ZXR1cm4gRVdLX1RFWFRfU0VMRUNUSU9OX05PTkU7CisgICAgfQorCisgICAgcmV0dXJuIEVXS19U RVhUX1NFTEVDVElPTl9OT05FOworfQorCiAvKiBpbnRlcm5hbCBtZXRob2RzICoqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKiovCiAKIC8qKgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19mcmFtZS5oIGIvU291cmNlL1dlYktpdC9l ZmwvZXdrL2V3a19mcmFtZS5oCmluZGV4IGUwOTI3YmYuLjQ5NmJhZmMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfZnJhbWUuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9l d2svZXdrX2ZyYW1lLmgKQEAgLTE1NCw2ICsxNTQsMTMgQEAgc3RydWN0IF9Fd2tfVG91Y2hfUG9p bnQgewogICAgIEV3a19Ub3VjaF9Qb2ludF9UeXBlIHN0YXRlOyAvKio8IHN0YXRlIG9mIHRoZSB0 b3VjaCBldmVudCAqLwogfTsKIAorZW51bSBfRXdrX1RleHRfU2VsZWN0aW9uX1R5cGUgeworICAg IEVXS19URVhUX1NFTEVDVElPTl9OT05FLAorICAgIEVXS19URVhUX1NFTEVDVElPTl9DQVJFVCwK KyAgICBFV0tfVEVYVF9TRUxFQ1RJT05fUkFOR0UKK307Cit0eXBlZGVmIGVudW0gX0V3a19UZXh0 X1NlbGVjdGlvbl9UeXBlIEV3a19UZXh0X1NlbGVjdGlvbl9UeXBlOworCiBFQVBJIEV2YXNfT2Jq ZWN0ICpld2tfZnJhbWVfdmlld19nZXQoY29uc3QgRXZhc19PYmplY3QgKm8pOwogCiBFQVBJIEVp bmFfSXRlcmF0b3IgKmV3a19mcmFtZV9jaGlsZHJlbl9pdGVyYXRvcl9uZXcoRXZhc19PYmplY3Qg Km8pOwpAQCAtMjI1LDYgKzIzMiw4IEBAIEVBUEkgRWluYV9Cb29sICAgIGV3a19mcmFtZV9mZWVk X3RvdWNoX2V2ZW50KEV2YXNfT2JqZWN0KiBvLCBFd2tfVG91Y2hfRXZlbnRfVHlwCiBFQVBJIEVp bmFfQm9vbCAgICBld2tfZnJhbWVfZmVlZF9rZXlfZG93bihFdmFzX09iamVjdCAqbywgY29uc3Qg RXZhc19FdmVudF9LZXlfRG93biAqZXYpOwogRUFQSSBFaW5hX0Jvb2wgICAgZXdrX2ZyYW1lX2Zl ZWRfa2V5X3VwKEV2YXNfT2JqZWN0ICpvLCBjb25zdCBFdmFzX0V2ZW50X0tleV9VcCAqZXYpOwog CitFQVBJIEV3a19UZXh0X1NlbGVjdGlvbl9UeXBlIGV3a19mcmFtZV90ZXh0X3NlbGVjdGlvbl90 eXBlX2dldChFdmFzX09iamVjdCogbyk7CisKIAogI2lmZGVmIF9fY3BsdXNwbHVzCiB9Cg== 99049 2011-06-29 00:36:51 -0700 2011-06-29 07:13:07 -0700 another patch selection_patch2.diff text/plain 2973 mpakulavelrutka ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCA2ZTk2NDg5Li5hMWNmM2EwIDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTEtMDYtMjkgIE1pY2hhbCBQYWt1bGEgdmVsIFJ1dGthICA8bS5w YWt1bGFAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgW0VGTF0gQWRkIGV3a19mcmFtZV90ZXh0X3NlbGVjdGlvbl90eXBlX2dldCBm dW5jdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NjM0NjIKKworICAgICAgICBBZGQgYSBtZXRob2QgdG8gb2J0YWluIGN1cnJlbnQgV2ViQ29yZTo6 VmlzaWJsZVNlbGVjdGlvbiB0ZXh0CisgICAgICAgIHNlbGVjdGlvbiB0eXBlLgorCisgICAgICAg ICogZXdrL2V3a19mcmFtZS5jcHA6CisgICAgICAgIChld2tfZnJhbWVfdGV4dF9zZWxlY3Rpb25f dHlwZV9nZXQpOgorICAgICAgICAqIGV3ay9ld2tfZnJhbWUuaDoKKwogMjAxMS0wNi0yOCAgTWlj aGFsIFBha3VsYSB2ZWwgUnV0a2EgIDxtLnBha3VsYUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbi4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvZWZsL2V3ay9ld2tfZnJhbWUuY3BwIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3 a19mcmFtZS5jcHAKaW5kZXggMzUzOGFiOC4uODU4MzRjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9lZmwvZXdrL2V3a19mcmFtZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3 a19mcmFtZS5jcHAKQEAgLTE1MjUsNiArMTUyNSwzMSBAQCBFaW5hX0Jvb2wgZXdrX2ZyYW1lX2Zl ZWRfa2V5X3VwKEV2YXNfT2JqZWN0KiBvLCBjb25zdCBFdmFzX0V2ZW50X0tleV9VcCogZXYpCiAg ICAgcmV0dXJuIHNkLT5mcmFtZS0+ZXZlbnRIYW5kbGVyKCktPmtleUV2ZW50KGV2ZW50KTsKIH0K IAorLyoqCisgKiBSZXR1cm5zIGN1cnJlbnQgdGV4dCBzZWxlY3Rpb24gdHlwZS4KKyAqCisgKiBA cGFyYW0gbyBhIGZyYW1lIG9iamVjdCB0byBjaGVjayBzZWxlY3Rpb24gdHlwZQorICogQHJldHVy biBDdXJyZW50IHRleHQgc2VsZWN0aW9uIHR5cGUgb24gc3VjY2VzcyBvciBubyBzZWxlY3Rpb24g b3RoZXJ3aXNlCisgKi8KK0V3a19UZXh0X1NlbGVjdGlvbl9UeXBlIGV3a19mcmFtZV90ZXh0X3Nl bGVjdGlvbl90eXBlX2dldChFdmFzX09iamVjdCAqbykKK3sKKyAgICBFV0tfRlJBTUVfU0RfR0VU X09SX1JFVFVSTihvLCBzZCwgRVdLX1RFWFRfU0VMRUNUSU9OX05PTkUpOworICAgIEVJTkFfU0FG RVRZX09OX05VTExfUkVUVVJOX1ZBTChzZC0+ZnJhbWUsIEVXS19URVhUX1NFTEVDVElPTl9OT05F KTsKKworICAgIFdlYkNvcmU6OkZyYW1lU2VsZWN0aW9uKiBjb250cm9sbGVyID0gc2QtPmZyYW1l LT5zZWxlY3Rpb24oKTsKKyAgICBpZiAoIWNvbnRyb2xsZXIpCisgICAgICAgIHJldHVybiBFV0tf VEVYVF9TRUxFQ1RJT05fTk9ORTsKKworICAgIHN3aXRjaCAoY29udHJvbGxlci0+c2VsZWN0aW9u VHlwZSgpKSB7CisgICAgY2FzZSBXZWJDb3JlOjpWaXNpYmxlU2VsZWN0aW9uOjpDYXJldFNlbGVj dGlvbjoKKyAgICAgICAgcmV0dXJuIEVXS19URVhUX1NFTEVDVElPTl9DQVJFVDsKKyAgICBjYXNl IFdlYkNvcmU6OlZpc2libGVTZWxlY3Rpb246OlJhbmdlU2VsZWN0aW9uOgorICAgICAgICByZXR1 cm4gRVdLX1RFWFRfU0VMRUNUSU9OX1JBTkdFOworICAgIGRlZmF1bHQ6CisgICAgICAgIHJldHVy biBFV0tfVEVYVF9TRUxFQ1RJT05fTk9ORTsKKyAgICB9Cit9CisKIC8qIGludGVybmFsIG1ldGhv ZHMgKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKi8K IAogLyoqCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX2ZyYW1lLmggYi9T b3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX2ZyYW1lLmgKaW5kZXggZTA5MjdiZi4uZDY3NDQzYyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19mcmFtZS5oCisrKyBiL1NvdXJj ZS9XZWJLaXQvZWZsL2V3ay9ld2tfZnJhbWUuaApAQCAtMTU0LDYgKzE1NCwxMiBAQCBzdHJ1Y3Qg X0V3a19Ub3VjaF9Qb2ludCB7CiAgICAgRXdrX1RvdWNoX1BvaW50X1R5cGUgc3RhdGU7IC8qKjwg c3RhdGUgb2YgdGhlIHRvdWNoIGV2ZW50ICovCiB9OwogCit0eXBlZGVmIGVudW0geworICAgIEVX S19URVhUX1NFTEVDVElPTl9OT05FLAorICAgIEVXS19URVhUX1NFTEVDVElPTl9DQVJFVCwKKyAg ICBFV0tfVEVYVF9TRUxFQ1RJT05fUkFOR0UKK30gRXdrX1RleHRfU2VsZWN0aW9uX1R5cGU7CisK IEVBUEkgRXZhc19PYmplY3QgKmV3a19mcmFtZV92aWV3X2dldChjb25zdCBFdmFzX09iamVjdCAq byk7CiAKIEVBUEkgRWluYV9JdGVyYXRvciAqZXdrX2ZyYW1lX2NoaWxkcmVuX2l0ZXJhdG9yX25l dyhFdmFzX09iamVjdCAqbyk7CkBAIC0yMjUsNiArMjMxLDggQEAgRUFQSSBFaW5hX0Jvb2wgICAg ZXdrX2ZyYW1lX2ZlZWRfdG91Y2hfZXZlbnQoRXZhc19PYmplY3QqIG8sIEV3a19Ub3VjaF9FdmVu dF9UeXAKIEVBUEkgRWluYV9Cb29sICAgIGV3a19mcmFtZV9mZWVkX2tleV9kb3duKEV2YXNfT2Jq ZWN0ICpvLCBjb25zdCBFdmFzX0V2ZW50X0tleV9Eb3duICpldik7CiBFQVBJIEVpbmFfQm9vbCAg ICBld2tfZnJhbWVfZmVlZF9rZXlfdXAoRXZhc19PYmplY3QgKm8sIGNvbnN0IEV2YXNfRXZlbnRf S2V5X1VwICpldik7CiAKK0VBUEkgRXdrX1RleHRfU2VsZWN0aW9uX1R5cGUgZXdrX2ZyYW1lX3Rl eHRfc2VsZWN0aW9uX3R5cGVfZ2V0KEV2YXNfT2JqZWN0KiBvKTsKKwogCiAjaWZkZWYgX19jcGx1 c3BsdXMKIH0K