63452 2011-06-27 06:55:52 -0700 webkit-patch doesn't like UTF-8 characters in reviewers names 2012-11-22 03:54:31 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P1 Blocker --- 50843 1 ossy tomz abarth abecsi eric galpeter ossy tomz vestbo webkit.review.bot oldest_to_newest 427903 0 ossy 2011-06-27 06:55:52 -0700 https://bugs.webkit.org/show_bug.cgi?id=46714#c5 https://bugs.webkit.org/show_bug.cgi?id=61890#c12 Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 1 Logging in as webkit.review.bot@gmail.com... Fetching: https://bugs.webkit.org/attachment.cgi?id=97789&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=61890&ctype=xml Processing 1 patch from 1 bug. Processing patch 97789 from bug 61890. Traceback (most recent call last): File "./Tools/Scripts/webkit-patch", line 66, in <module> main() File "./Tools/Scripts/webkit-patch", line 61, in main WebKitPatch(__file__).main() File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 308, in main result = command.check_arguments_and_execute(options, args, self) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 117, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/commands/download.py", line 152, in execute self._process_patch(patch, options, args, tool) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/commands/download.py", line 171, in _process_patch self._main_sequence.run_and_handle_errors(tool, options, state) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 70, in run_and_handle_errors self._run(tool, options, state) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run step(tool, options).run(state) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py", line 40, in run ApplyPatch.run(self, state) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/applypatch.py", line 43, in run self._tool.checkout().apply_patch(state["patch"], force=self._options.non_interactive or self._options.force_patch) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/checkout/checkout.py", line 163, in apply_patch run_command(args, input=patch.contents()) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 102, in run_command return Executive().run_command(*args, **kwargs) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 382, in run_command close_fds=self._should_close_fds()) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 438, in popen return subprocess.Popen(*args, **kwargs) File "/usr/lib/python2.6/subprocess.py", line 623, in __init__ errread, errwrite) File "/usr/lib/python2.6/subprocess.py", line 1141, in _execute_child raise child_exception TypeError: execv() arg 2 must contain only strings 427904 1 ossy 2011-06-27 06:57:30 -0700 Kristóf, could you check this bug, please? 428044 2 eric 2011-06-27 10:15:59 -0700 I believe this is related to us setting LANG=ascii on the bots to work around a gcc issue. See bug 50843. 444626 3 ossy 2011-08-01 03:08:44 -0700 I set it to P1 blocker, because webkit-patch and CQ can't land patches reviewed by myself. :( 444627 4 ossy 2011-08-01 03:09:34 -0700 Peter, could you check this bug with Kristof ASAP? 448041 5 eric 2011-08-08 09:29:11 -0700 Sigh. I thought this had gone away. I can take another look. A test case (patch) would be most helpful. 463250 6 ossy 2011-09-07 02:30:00 -0700 Guys wasn't able to reproduce it locally, but unfortunately it is still valid on the commit queue machine: https://bugs.webkit.org/show_bug.cgi?id=67646#c2 Eric or someone else who has access to this bot, could you check it, please? It is so annoying that we can't land patches reviewed by me with the commit queue. :( 463503 7 eric 2011-09-07 11:38:06 -0700 It's on the (growing) list of bugs I'd like to fix. :( 463514 8 abarth 2011-09-07 11:43:24 -0700 @Eric: time to create a meta bug and burn through these? 473952 9 108853 tomz 2011-09-27 08:48:31 -0700 Created attachment 108853 Patch 473956 10 tomz 2011-09-27 08:52:52 -0700 I'm not sure how to set up a regression test for this. I can test that the mod (wrapping stdio with a codec) works in a standalone unit-test, but it's a lot more invasive to try to force unicode text through the output of webkit-patch itself. 474012 11 abarth 2011-09-27 09:53:48 -0700 Eric is probably your best reviewer here. Generally, it's hard to test changes to the webkit-patch script self (as opposed to the webkitpy library). I suspec this change wi'll have somewhat wide-ranging effects that will be difficult to predict, but we shouldn't let that stop us! 474119 12 108876 tomz 2011-09-27 11:49:57 -0700 Created attachment 108876 Test case to show Uploading an example script to demonstrate the problem/solution in a minimal case. To see the issue, run the script and redirect/tee the output. 474140 13 108853 eric 2011-09-27 12:21:46 -0700 Comment on attachment 108853 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108853&action=review > Tools/Scripts/webkit-patch:41 > +sys.stdout = codecs.lookup('utf-8')[-1](sys.stdout) Please add a (brief) comment explaing why we do this, and linking to this bug. You should also consider linking from this bug or your ChangeLog to places on the web where they explain why this is the right way to fix this. Just some sort of paper trail so that someone can understand later why this change was made. 474161 14 108885 tomz 2011-09-27 12:51:44 -0700 Created attachment 108885 Patch 474165 15 tomz 2011-09-27 12:56:16 -0700 For more information, see "Python Cookbook 2nd Ed., recipe 1.22" and http://docs.python.org/library/codecs.html#module-codecs. 474212 16 108885 eric 2011-09-27 14:01:48 -0700 Comment on attachment 108885 Patch Thanks. 474268 17 108885 webkit.review.bot 2011-09-27 15:03:27 -0700 Comment on attachment 108885 Patch Clearing flags on attachment: 108885 Committed r96161: <http://trac.webkit.org/changeset/96161> 474269 18 webkit.review.bot 2011-09-27 15:03:32 -0700 All reviewed patches have been landed. Closing bug. 474931 19 ossy 2011-09-28 12:55:49 -0700 Unfortunately CQ still hates me. :( 474963 20 ossy 2011-09-28 13:29:26 -0700 (In reply to comment #19) > Unfortunately CQ still hates me. :( I missed to add the URL: https://bugs.webkit.org/show_bug.cgi?id=69004#c4 497380 21 eric 2011-11-07 12:36:10 -0800 Another reproduction: webkit-patch apply-attachment 113861 That doesn't repro on my local machine, but I suspect it will repro on our EWS instances. I'll figure out how to SSH into one and try it. 497426 22 eric 2011-11-07 13:28:11 -0800 The EC2 instances use some environment variables to work around fancy-quotes in GCC causing unicode decoding exceptions during other parts of processing. Those environment variables are what's causing the problem here. We may need to revisit which ones we set. The following invocation of the command will reproduce this bug *on ec2* it still does not reproduce locally on my mac. LANG=en_US.US-ASCII LC_ALL=C PYTHONIOENCODING=utf_8 ./Tools/Scripts/webkit-patch apply-attachment 113861 773816 23 ossy 2012-11-22 03:54:31 -0800 CQ works fine nowadays with patches reviewed by myself or Tor Arne :) 108853 2011-09-27 08:48:31 -0700 2011-09-27 12:51:40 -0700 Patch bug-63452-20110927084827.patch text/plain 1340 tomz U3VidmVyc2lvbiBSZXZpc2lvbjogOTU5OTAKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2MTJlYjA1MDYxOTI3OWIyMTJkN2Q0N2RiNzY1NTExZjhi MGMxMTNjLi44ODliNjhlZjVhMTU0MDhkMjQ0Yjk5ZmMxMzYwYjBjNzkyNzAwZjFiIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMDktMjcgIFRvbSBaYWtyYWpzZWsgIDx0b216QGNvZGVhdXJvcmEub3JnPgorCisg ICAgICAgIHdlYmtpdC1wYXRjaCBkb2Vzbid0IGxpa2UgVVRGLTggY2hhcmFjdGVycyBpbiByZXZp ZXdlcnMgbmFtZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTYzNDUyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBTY3JpcHRzL3dlYmtpdC1wYXRjaDoKKwogMjAxMS0wOS0yNiAgQWRhbSBSb2JlbiAgPGFy b2JlbkBhcHBsZS5jb20+CiAKICAgICAgICAgQ2xlYW4gdXAgY29kZSBpbXBvcnRlZCBmcm9tIFdl YktpdEFQSVRlc3QKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0LXBhdGNoIGIvVG9v bHMvU2NyaXB0cy93ZWJraXQtcGF0Y2gKaW5kZXggMTU5OTg1ZjhhMDA0ZDFjYmEyMjNhZmZjYjA1 MTQ0NmE0ZjgyMWY3ZS4uMDUxNDMzNDVlOGQ2YTI1ODkwMGI4YTExMDY5OTM5ODRkNjcxNWM1OSAx MDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXQtcGF0Y2gKKysrIGIvVG9vbHMvU2NyaXB0 cy93ZWJraXQtcGF0Y2gKQEAgLTEsNCArMSw1IEBACiAjIS91c3IvYmluL2VudiBweXRob24KKyMg Q29weXJpZ2h0IChjKSAyMDExIENvZGUgQXVyb3JhIEZvcnVtLiBBbGwgcmlnaHRzIHJlc2VydmVk LgogIyBDb3B5cmlnaHQgKGMpIDIwMTAgR29vZ2xlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4K ICMgQ29weXJpZ2h0IChjKSAyMDA5IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICMg Q29weXJpZ2h0IChDKSAyMDEwIENocmlzIEplcmRvbmVrIChjamVyZG9uZWtAd2Via2l0Lm9yZykK QEAgLTM1LDYgKzM2LDkgQEAgaW1wb3J0IGxvZ2dpbmcKIGltcG9ydCBvcwogaW1wb3J0IHNpZ25h bAogaW1wb3J0IHN5cworaW1wb3J0IGNvZGVjcworCitzeXMuc3Rkb3V0ID0gY29kZWNzLmxvb2t1 cCgndXRmLTgnKVstMV0oc3lzLnN0ZG91dCkKIAogZnJvbSB3ZWJraXRweS5jb21tb24uc3lzdGVt LmxvZ3V0aWxzIGltcG9ydCBjb25maWd1cmVfbG9nZ2luZwogaW1wb3J0IHdlYmtpdHB5LnB5dGhv bjI0LnZlcnNpb25pbmcgYXMgdmVyc2lvbmluZwo= 108876 2011-09-27 11:49:57 -0700 2011-09-27 11:49:57 -0700 Test case to show unicode_io_unittest.py text/x-python 405 tomz IyBDb3B5cmlnaHQgZ29lcyBoZXJlCgppbXBvcnQgc3lzCmltcG9ydCBjb2RlY3MKCnV0ZXh0ID0g dSIiIjIwMDktMDgtMTcgIFRvciBBcm5lIFZlc3RiXHhmOCAgPHZlc3Rib0B3ZWJraXQub3JnPiIi IgoKdHJ5OgogICAgcHJpbnQgdXRleHQKZXhjZXB0IFVuaWNvZGVFbmNvZGVFcnJvcjoKICAgIHBy aW50ICJleGNlcHRpb24gb2NjdXJlZCBhcyBleHBlY3RlZDogVW5pY29kZUVuY29kZUVycm9yIgoK c3lzLnN0ZG91dCA9IGNvZGVjcy5sb29rdXAoJ3V0Zi04JylbLTFdKHN5cy5zdGRvdXQpCgp0cnk6 CiAgICBwcmludCB1dGV4dApleGNlcHQgVW5pY29kZUVuY29kZUVycm9yOgogICAgcHJpbnQgIkVy cm9yOiBleGNlcHRpb24gc3RpbGwgb2NjdXJlZCB3aXRoIGZpbHRlcjogVW5pY29kZUVuY29kZUVy cm9yIgoK 108885 2011-09-27 12:51:44 -0700 2011-09-27 15:03:27 -0700 Patch bug-63452-20110927125142.patch text/plain 1626 tomz U3VidmVyc2lvbiBSZXZpc2lvbjogOTU5OTAKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2MTJlYjA1MDYxOTI3OWIyMTJkN2Q0N2RiNzY1NTExZjhi MGMxMTNjLi44ODliNjhlZjVhMTU0MDhkMjQ0Yjk5ZmMxMzYwYjBjNzkyNzAwZjFiIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMDktMjcgIFRvbSBaYWtyYWpzZWsgIDx0b216QGNvZGVhdXJvcmEub3JnPgorCisg ICAgICAgIHdlYmtpdC1wYXRjaCBkb2Vzbid0IGxpa2UgVVRGLTggY2hhcmFjdGVycyBpbiByZXZp ZXdlcnMgbmFtZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTYzNDUyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBTY3JpcHRzL3dlYmtpdC1wYXRjaDoKKwogMjAxMS0wOS0yNiAgQWRhbSBSb2JlbiAgPGFy b2JlbkBhcHBsZS5jb20+CiAKICAgICAgICAgQ2xlYW4gdXAgY29kZSBpbXBvcnRlZCBmcm9tIFdl YktpdEFQSVRlc3QKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0LXBhdGNoIGIvVG9v bHMvU2NyaXB0cy93ZWJraXQtcGF0Y2gKaW5kZXggMTU5OTg1ZjhhMDA0ZDFjYmEyMjNhZmZjYjA1 MTQ0NmE0ZjgyMWY3ZS4uOTFlNGMwZjlhYTQ1NWUzNTljYmUwMWQ3NDk4NzQ1YmUzMmE5MDg0NyAx MDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXQtcGF0Y2gKKysrIGIvVG9vbHMvU2NyaXB0 cy93ZWJraXQtcGF0Y2gKQEAgLTEsNCArMSw1IEBACiAjIS91c3IvYmluL2VudiBweXRob24KKyMg Q29weXJpZ2h0IChjKSAyMDExIENvZGUgQXVyb3JhIEZvcnVtLiBBbGwgcmlnaHRzIHJlc2VydmVk LgogIyBDb3B5cmlnaHQgKGMpIDIwMTAgR29vZ2xlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4K ICMgQ29weXJpZ2h0IChjKSAyMDA5IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICMg Q29weXJpZ2h0IChDKSAyMDEwIENocmlzIEplcmRvbmVrIChjamVyZG9uZWtAd2Via2l0Lm9yZykK QEAgLTM1LDYgKzM2LDEzIEBAIGltcG9ydCBsb2dnaW5nCiBpbXBvcnQgb3MKIGltcG9ydCBzaWdu YWwKIGltcG9ydCBzeXMKK2ltcG9ydCBjb2RlY3MKKworIyBCeSBkZWZhdWx0LCBzeXMuc3Rkb3V0 IGFzc3VtZXMgYXNjaWkgZW5jb2RpbmcuICBTaW5jZSBvdXIgbWVzc2FnZXMgY2FuCisjIGNvbnRh aW4gdW5pY29kZSBzdHJpbmdzIChhcyB3aXRoIHNvbWUgcGVvcGxlcycgbmFtZXMpIHdlIG5lZWQg dG8gYXBwbHkKKyMgdGhlIHV0Zi04IGNvZGVjIHRvIHByZXZlbnQgdGhyb3dpbmcgYW5kIGV4Y2Vw dGlvbi4KKyMgTm90IGhhdmluZyB0aGlzIHdhcyB0aGUgY2F1c2Ugb2YgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYzNDUyLgorc3lzLnN0ZG91dCA9IGNvZGVjcy5sb29r dXAoJ3V0Zi04JylbLTFdKHN5cy5zdGRvdXQpCiAKIGZyb20gd2Via2l0cHkuY29tbW9uLnN5c3Rl bS5sb2d1dGlscyBpbXBvcnQgY29uZmlndXJlX2xvZ2dpbmcKIGltcG9ydCB3ZWJraXRweS5weXRo b24yNC52ZXJzaW9uaW5nIGFzIHZlcnNpb25pbmcK