63441 2011-06-27 03:13:44 -0700 [EFL] Remove unnecessary header files from EWebKit_HEADERS. 2011-06-27 07:36:24 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi gyuyoung.kim gyuyoung.kim kenneth leandro lucas.de.marchi rakuco tonikitoo webkit.review.bot oldest_to_newest 427826 0 ryuan.choi 2011-06-27 03:13:44 -0700 Now, all header files except ewk_private.h are included as header files. However, I think 1. ewk_tiled_private.h is not public. 2. functions should not be public API, which are in ewk_tiled_backing_store.h and ewk_tiled_matrix.h. And ewk_auth_soup.h should be installed when libsoup is enabled. 427829 1 98695 ryuan.choi 2011-06-27 03:33:55 -0700 Created attachment 98695 Patch 427831 2 gyuyoung.kim 2011-06-27 03:40:20 -0700 Informal r+ on my side. 427891 3 rakuco 2011-06-27 06:31:24 -0700 Informal r+ from my side. 427925 4 98695 webkit.review.bot 2011-06-27 07:36:19 -0700 Comment on attachment 98695 Patch Clearing flags on attachment: 98695 Committed r89818: <http://trac.webkit.org/changeset/89818> 427926 5 webkit.review.bot 2011-06-27 07:36:24 -0700 All reviewed patches have been landed. Closing bug. 98695 2011-06-27 03:33:55 -0700 2011-06-27 07:36:19 -0700 Patch bug-63441-20110627193230.patch text/plain 1874 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogODk4MTAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L0NNYWtlTGlzdHNFZmwudHh0IGIvU291cmNlL1dlYktpdC9lZmwvQ01ha2VMaXN0c0VmbC50eHQK aW5kZXggNzQwZTc2Y2QxYzU5NGRhNDk1MmNhZGM3ZmEzYzAyOWRjOTE5MDg4Yy4uNWE4NzljYWNm YzhmZDYzYzA1ZWI5YTgyNzVhNDhjZjQ4ZmI4NmVjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9lZmwvQ01ha2VMaXN0c0VmbC50eHQKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ01ha2VMaXN0 c0VmbC50eHQKQEAgLTIxNiw2ICsyMTYsMTQgQEAgVU5TRVQoTElCU19QUklWQVRFKQogCiBGSUxF KEdMT0IgRVdlYktpdF9IRUFERVJTICIke0NNQUtFX0NVUlJFTlRfU09VUkNFX0RJUn0vZWZsL2V3 ay8qLmgiKQogTElTVChSRU1PVkVfSVRFTSBFV2ViS2l0X0hFQURFUlMgIiR7Q01BS0VfQ1VSUkVO VF9TT1VSQ0VfRElSfS9lZmwvZXdrL2V3a19wcml2YXRlLmgiKQorTElTVChSRU1PVkVfSVRFTSBF V2ViS2l0X0hFQURFUlMgIiR7Q01BS0VfQ1VSUkVOVF9TT1VSQ0VfRElSfS9lZmwvZXdrL2V3a190 aWxlZF9wcml2YXRlLmgiKQorTElTVChSRU1PVkVfSVRFTSBFV2ViS2l0X0hFQURFUlMgIiR7Q01B S0VfQ1VSUkVOVF9TT1VSQ0VfRElSfS9lZmwvZXdrL2V3a190aWxlZF9iYWNraW5nX3N0b3JlLmgi KQorTElTVChSRU1PVkVfSVRFTSBFV2ViS2l0X0hFQURFUlMgIiR7Q01BS0VfQ1VSUkVOVF9TT1VS Q0VfRElSfS9lZmwvZXdrL2V3a190aWxlZF9tYXRyaXguaCIpCitMSVNUKFJFTU9WRV9JVEVNIEVX ZWJLaXRfSEVBREVSUyAiJHtDTUFLRV9DVVJSRU5UX1NPVVJDRV9ESVJ9L2VmbC9ld2svZXdrX3Rp bGVkX21vZGVsLmgiKQorCitJRiAoTk9UIFdURl9VU0VfU09VUCkKKyAgICBMSVNUKFJFTU9WRV9J VEVNIEVXZWJLaXRfSEVBREVSUyAiJHtDTUFLRV9DVVJSRU5UX1NPVVJDRV9ESVJ9L2VmbC9ld2sv ZXdrX2F1dGhfc291cC5oIikKK0VORElGICgpCiAKIElOU1RBTEwoRklMRVMgJHtFV2ViS2l0X0hF QURFUlN9CiAgICAgICAgIERFU1RJTkFUSU9OIGluY2x1ZGUvJHtXZWJLaXRfTElCUkFSWV9OQU1F fS0ke1BST0pFQ1RfVkVSU0lPTl9NQUpPUn0pCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggMmIyOTYzNGM3 NDE0ZjFkYzFmN2RhZWY2NDM1ZjU3N2Y2YTcwZDM4Ny4uOTM4NTgwMDJmNmY0ZThiZGM2YjdhNTBk MTc1ZGRjNjQzYmNiYzMzMiAxMDA3NTUKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEx LTA2LTI3ICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbRUZMXSBSZW1vdmUgcHJpdmF0 ZSBoZWFkZXIgZmlsZXMgZnJvbSBFV2ViS2l0X0hFQURFUlMuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MzQ0MQorCisgICAgICAgIFJlbW92ZSBld2tf dGlsZWRfcHJpdmF0ZS5oLCBld2tfdGlsZWRfYmFja2luZ19zdG9yZS5oLCBld2tfdGlsZWRfbWF0 cml4LmgsCisgICAgICAgIGV3a190aWxlZF9tb2RlbC5oIGFuZCBjaGVjayBXVEZfVVNFX1NPVVAg dG8gcmVtb3ZlIGV3a19hdXRoX3NvdXAuaC4KKworICAgICAgICAqIENNYWtlTGlzdHNFZmwudHh0 OgorCiAyMDExLTA2LTI3ICBLd2FuZ0h5dWsgS2ltICA8aHl1a2kua2ltQHNhbXN1bmcuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgo=