63437 2011-06-27 01:10:20 -0700 [EFL] Remove ewk_tile_matrix_tile_update. 2012-08-23 19:44:53 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi antognolli+webkit gyuyoung.kim gyuyoung.kim hyuki.kim leandro lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 427758 0 ryuan.choi 2011-06-27 01:10:20 -0700 While investigating eina_tiler, I found unused code, ewk_tile_matrix_tile_update and ewk_tile_matrix_tile_update_full. This code is not used and it looks covered by ewk_tile_matrix_update. 687553 1 156549 ryuan.choi 2012-08-04 20:29:23 -0700 Created attachment 156549 Patch 687557 2 rakuco 2012-08-04 20:38:39 -0700 Yeah, since the code passed in the EWS I guess calling functions have either been changed or this code was already dead when upstreamed. LGTM. 703619 3 156549 gyuyoung.kim 2012-08-23 18:01:58 -0700 Comment on attachment 156549 Patch Looks fine too. 703672 4 156549 webkit.review.bot 2012-08-23 19:44:49 -0700 Comment on attachment 156549 Patch Clearing flags on attachment: 156549 Committed r126527: <http://trac.webkit.org/changeset/126527> 703673 5 webkit.review.bot 2012-08-23 19:44:53 -0700 All reviewed patches have been landed. Closing bug. 156549 2012-08-04 20:29:23 -0700 2012-08-23 19:44:49 -0700 Patch bug-63437-20120805122900.patch text/plain 4358 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0NzA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggZGE5YWVjMDcz NWUwMWZlYmQyYjJiNzY3YmVmMzZhNzE1YzMwMDkxMS4uMzcyMmU3Zjk5ZmQzYjc0MjY0YzFkY2E0 Yjg2YmViYzdiODk4ZjdjMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEy LTA4LTA0ICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBb RUZMXSBSZW1vdmUgZXdrX3RpbGVfbWF0cml4X3RpbGVfdXBkYXRlLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjM0MzcKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGV3ay9ld2tfdGlsZWRfbWF0cml4LmNw cDoKKyAgICAgICAgUmVtb3ZlZCBld2tfdGlsZV9tYXRyaXhfdGlsZV91cGRhdGUgYW5kIGV3a190 aWxlX21hdHJpeF90aWxlX3VwZGF0ZV9mdWxsCisgICAgICAgIHdoaWNoIGFyZSBkZWFkIGNvZGUu CisgICAgICAgICogZXdrL2V3a190aWxlZF9tYXRyaXhfcHJpdmF0ZS5oOiBEaXR0by4KKwogMjAx Mi0wOC0wMSAgUnl1YW4gQ2hvaSAgPHJ5dWFuLmNob2lAc2Ftc3VuZy5jb20+CiAKICAgICAgICAg W0VGTF1bUmVncmVzc2lvbl0gQnVpbGQgYnJlYWsgd2l0aCBORVRTQ0FQRV9QTFVHSU5fQVBJIGFm dGVyIHIxMjM2MDQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdGlsZWRf bWF0cml4LmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdGlsZWRfbWF0cml4LmNwcApp bmRleCBhMTRhMWQ3ZTUwODAyOTQ0OTMzZDc3OTA5ODk5NDEzOTAyOGJiMTg2Li5mOTM3NjRmZTU1 ZWFmZmM3MTQ0Mzc5NDc0M2ZiODgzMjg1ZjY4ZWQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2VmbC9ld2svZXdrX3RpbGVkX21hdHJpeC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdr L2V3a190aWxlZF9tYXRyaXguY3BwCkBAIC01MjMsNTkgKzUyMyw2IEBAIEVpbmFfQm9vbCBld2tf dGlsZV9tYXRyaXhfdGlsZV9wdXQoRXdrX1RpbGVfTWF0cml4KiB0aWxlTWF0cml4LCBFd2tfVGls ZSogdGlsZSwKICAgICByZXR1cm4gZXdrX3RpbGVfdW51c2VkX2NhY2hlX3RpbGVfcHV0KHRpbGVN YXRyaXgtPnRpbGVVbnVzZWRDYWNoZSwgdGlsZSwgX2V3a190aWxlX21hdHJpeF90aWxlX2ZyZWUs IHRpbGVNYXRyaXgpOwogfQogCi1FaW5hX0Jvb2wgZXdrX3RpbGVfbWF0cml4X3RpbGVfdXBkYXRl KEV3a19UaWxlX01hdHJpeCogdGlsZU1hdHJpeCwgdW5zaWduZWQgbG9uZyBjb2wsIHVuc2lnbmVk IGxvbmcgcm93LCBjb25zdCBFaW5hX1JlY3RhbmdsZSogdXBkYXRlKQotewotICAgIEVpbmFfUmVj dGFuZ2xlIG5ld1VwZGF0ZTsKLSAgICBFSU5BX1NBRkVUWV9PTl9OVUxMX1JFVFVSTl9WQUwodGls ZU1hdHJpeCwgZmFsc2UpOwotICAgIEVJTkFfU0FGRVRZX09OX05VTExfUkVUVVJOX1ZBTCh1cGRh dGUsIGZhbHNlKTsKLQotICAgIG1lbWNweSgmbmV3VXBkYXRlLCB1cGRhdGUsIHNpemVvZihuZXdV cGRhdGUpKTsKLSAgICAvLyBjaGVjayB1cGRhdGUgaXMgdmFsaWQsIG90aGVyd2lzZSByZXR1cm4g ZmFsc2UKLSAgICBpZiAodXBkYXRlLT54IDwgMCB8fCB1cGRhdGUtPnkgPCAwIHx8IHVwZGF0ZS0+ dyA8PSAwIHx8IHVwZGF0ZS0+aCA8PSAwKSB7Ci0gICAgICAgIEVSUigiaW52YWxpZCB1cGRhdGUg cmVnaW9uLiIpOwotICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgfQotCi0gICAgaWYgKHVwZGF0 ZS0+eCArIHVwZGF0ZS0+dyAtIDEgPj0gdGlsZU1hdHJpeC0+dGlsZS53aWR0aCkKLSAgICAgICAg bmV3VXBkYXRlLncgPSB0aWxlTWF0cml4LT50aWxlLndpZHRoIC0gdXBkYXRlLT54OwotICAgIGlm ICh1cGRhdGUtPnkgKyB1cGRhdGUtPmggLSAxID49IHRpbGVNYXRyaXgtPnRpbGUuaGVpZ2h0KQot ICAgICAgICBuZXdVcGRhdGUuaCA9IHRpbGVNYXRyaXgtPnRpbGUuaGVpZ2h0IC0gdXBkYXRlLT55 OwotCi0gICAgRXdrX1RpbGUqIHRpbGUgPSBzdGF0aWNfY2FzdDxFd2tfVGlsZSo+KGVpbmFfbWF0 cml4c3BhcnNlX2RhdGFfaWR4X2dldCh0aWxlTWF0cml4LT5tYXRyaXgsIHJvdywgY29sKSk7Ci0g ICAgaWYgKCF0aWxlKQotICAgICAgICByZXR1cm4gdHJ1ZTsKLQotICAgIGlmICghdGlsZS0+dXBk YXRlcyAmJiAhdGlsZS0+c3RhdHMuZnVsbF91cGRhdGUpCi0gICAgICAgIHRpbGVNYXRyaXgtPnVw ZGF0ZXMgPSBlaW5hX2xpc3RfYXBwZW5kKHRpbGVNYXRyaXgtPnVwZGF0ZXMsIHRpbGUpOwotICAg IGV3a190aWxlX3VwZGF0ZV9hcmVhKHRpbGUsICZuZXdVcGRhdGUpOwotCi0gICAgcmV0dXJuIHRy dWU7Ci19Ci0KLUVpbmFfQm9vbCBld2tfdGlsZV9tYXRyaXhfdGlsZV91cGRhdGVfZnVsbChFd2tf VGlsZV9NYXRyaXgqIHRpbGVNYXRyaXgsIHVuc2lnbmVkIGxvbmcgY29sdW1uLCB1bnNpZ25lZCBs b25nIHJvdykKLXsKLSAgICBFaW5hX01hdHJpeHNwYXJzZV9DZWxsKiBjZWxsOwotICAgIEVJTkFf U0FGRVRZX09OX05VTExfUkVUVVJOX1ZBTCh0aWxlTWF0cml4LCBmYWxzZSk7Ci0KLSAgICBpZiAo IWVpbmFfbWF0cml4c3BhcnNlX2NlbGxfaWR4X2dldCh0aWxlTWF0cml4LT5tYXRyaXgsIHJvdywg Y29sdW1uLCAmY2VsbCkpCi0gICAgICAgIHJldHVybiBmYWxzZTsKLQotICAgIGlmICghY2VsbCkK LSAgICAgICAgcmV0dXJuIHRydWU7Ci0KLSAgICBFd2tfVGlsZSogdGlsZSA9IHN0YXRpY19jYXN0 PEV3a19UaWxlKj4oZWluYV9tYXRyaXhzcGFyc2VfY2VsbF9kYXRhX2dldChjZWxsKSk7Ci0gICAg aWYgKCF0aWxlKSB7Ci0gICAgICAgIENSSVRJQ0FMKCJtYXRyaXggY2VsbCB3aXRoIG5vIHRpbGUh Iik7Ci0gICAgICAgIHJldHVybiB0cnVlOwotICAgIH0KLQotICAgIGlmICghdGlsZS0+dXBkYXRl cyAmJiAhdGlsZS0+c3RhdHMuZnVsbF91cGRhdGUpCi0gICAgICAgIHRpbGVNYXRyaXgtPnVwZGF0 ZXMgPSBlaW5hX2xpc3RfYXBwZW5kKHRpbGVNYXRyaXgtPnVwZGF0ZXMsIHRpbGUpOwotICAgIGV3 a190aWxlX3VwZGF0ZV9mdWxsKHRpbGUpOwotCi0gICAgcmV0dXJuIHRydWU7Ci19Ci0KIHZvaWQg ZXdrX3RpbGVfbWF0cml4X3RpbGVfdXBkYXRlc19jbGVhcihFd2tfVGlsZV9NYXRyaXgqIHRpbGVN YXRyaXgsIEV3a19UaWxlKiB0aWxlKQogewogICAgIEVJTkFfU0FGRVRZX09OX05VTExfUkVUVVJO KHRpbGVNYXRyaXgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a190aWxl ZF9tYXRyaXhfcHJpdmF0ZS5oIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a190aWxlZF9tYXRy aXhfcHJpdmF0ZS5oCmluZGV4IGIzNzkzYjVjNzRiMjk5YTUzZWY4YmNhZTY0ZWExZmQzMjgwY2Ux NzEuLjE1MWViYjBiN2IzOTVkMzQ3YTNmMzk1ODAzOGYyMDE4MDkzNDg1ZDEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdGlsZWRfbWF0cml4X3ByaXZhdGUuaAorKysgYi9T b3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3RpbGVkX21hdHJpeF9wcml2YXRlLmgKQEAgLTQ0LDgg KzQ0LDYgQEAgRXdrX1RpbGUgKmV3a190aWxlX21hdHJpeF90aWxlX25lYXJlc3RfZ2V0KEV3a19U aWxlX01hdHJpeCAqdG0sIHVuc2lnbmVkIGxvbmcgY28KIEV3a19UaWxlICpld2tfdGlsZV9tYXRy aXhfdGlsZV9uZXcoRXdrX1RpbGVfTWF0cml4ICp0bSwgRXZhcyAqZXZhcywgdW5zaWduZWQgbG9u ZyBjb2wsIHVuc2lnbmVkIGxvbmcgcm93LCBmbG9hdCB6b29tKTsKIEVpbmFfQm9vbCBld2tfdGls ZV9tYXRyaXhfdGlsZV9wdXQoRXdrX1RpbGVfTWF0cml4ICp0bSwgRXdrX1RpbGUgKnQsIGRvdWJs ZSBsYXN0X3VzZWQpOwogCi1FaW5hX0Jvb2wgZXdrX3RpbGVfbWF0cml4X3RpbGVfdXBkYXRlKEV3 a19UaWxlX01hdHJpeCAqdG0sIHVuc2lnbmVkIGxvbmcgY29sLCB1bnNpZ25lZCBsb25nIHJvdywg Y29uc3QgRWluYV9SZWN0YW5nbGUgKnVwZGF0ZSk7Ci1FaW5hX0Jvb2wgZXdrX3RpbGVfbWF0cml4 X3RpbGVfdXBkYXRlX2Z1bGwoRXdrX1RpbGVfTWF0cml4ICp0bSwgdW5zaWduZWQgbG9uZyBjb2ws IHVuc2lnbmVkIGxvbmcgcm93KTsKIHZvaWQgZXdrX3RpbGVfbWF0cml4X3RpbGVfdXBkYXRlc19j bGVhcihFd2tfVGlsZV9NYXRyaXggKnRtLCBFd2tfVGlsZSAqdCk7CiAKIEVpbmFfQm9vbCBld2tf dGlsZV9tYXRyaXhfdXBkYXRlKEV3a19UaWxlX01hdHJpeCAqdG0sIGNvbnN0IEVpbmFfUmVjdGFu Z2xlICp1cGRhdGUsIGZsb2F0IHpvb20pOwo=