63430 2011-06-27 00:21:23 -0700 Remove evil uses of hasattr 2011-06-27 01:42:12 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eric eric abarth webkit.review.bot oldest_to_newest 427717 0 eric 2011-06-27 00:21:23 -0700 Remove evil uses of hasattr 427720 1 98673 eric 2011-06-27 00:27:50 -0700 Created attachment 98673 Patch 427722 2 98673 abarth 2011-06-27 00:29:25 -0700 Comment on attachment 98673 Patch Ok. I assume you ran the unit tests. We should also be watching the Chromium canaries to see if we're breaking them. 427773 3 98673 webkit.review.bot 2011-06-27 01:42:07 -0700 Comment on attachment 98673 Patch Clearing flags on attachment: 98673 Committed r89808: <http://trac.webkit.org/changeset/89808> 427774 4 webkit.review.bot 2011-06-27 01:42:12 -0700 All reviewed patches have been landed. Closing bug. 98673 2011-06-27 00:27:50 -0700 2011-06-27 01:42:07 -0700 Patch bug-63430-20110627002749.patch text/plain 3729 eric U3VidmVyc2lvbiBSZXZpc2lvbjogODk3ODMKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3ODExYzNmMWY0OGYxMzkxY2VkM2Y2OTkxM2U5YmQ2YjU0 OTUzZTU2Li5hYmU3NDJjMGI3ZTVhMTJkNmJiMjJjZmYyYzI2ZmYzOWE3MjJhYTEzIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTEtMDYtMjcgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBldmlsIHVzZXMg b2YgaGFzYXR0cgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NjM0MzAKKworICAgICAgICBGb3Igc29tZSByZWFzb24gdGhlc2UgY2xhc3NlcyBiZWxpZXZl IHRoYXQgdGhleSBtYXkgYmUgY2FsbGVkIHdpdGgKKyAgICAgICAgdmFyaW91cyBmbGF2b3JzIG9m ICJvcHRpb24iIGVsZW1lbnRzIGFuZCBzbyBjYXJlZnVsbHkgY2hlY2sgdG8gbWFrZQorICAgICAg ICBzdXJlIHRoYXQgdGhlIG9wdGlvbnMgZWxlbWVudCBoYXMgdGhlaXIgb3B0aW9uIGJlZm9yZSBj aGVja2luZyBpdC4KKworICAgICAgICBXZSBoYWQgYSBzZXRfb3B0aW9uX2RlZmF1bHQgbWV0aG9k IHdoaWNoIHdhcyBuZXZlciBjYWxsZWQsIHNvIEkgbWFkZSBpdAorICAgICAgICBkbyB3aGF0IGNh bGxzaXRlcyBzZWVtZWQgdG8gd2FudCBpdCB0byBkbyBhbmQgcmVwbGFjZWQgMyBjYWxsZXJzCisg ICAgICAgIHdobyBwcmV2aW91c2x5IHVzZWQgaGFzYXR0ciBtYW51YWxseSB0byB1c2Ugc2V0X29w dGlvbl9kZWZhdWx0IGluc3RlYWQuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9wb3J0L2Jhc2UucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcG9ydC93ZWJraXQucHk6CisKIDIwMTEtMDYtMjUgIE5hb2tpIFRha2FubyAgPGhvbnRl bkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYg LS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Jhc2UucHkg Yi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Jhc2UucHkKaW5kZXgg NTllNTBhNDY3YTcxNjc0ZmY0NjJkNjIxYjQyOTc2YzQwMjRjNDUyMy4uNmU4ZDA3M2U1NjExYzU3 OWVkMzU0YTk2OTRmYjc4ZjI1ZDllYjNhNyAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvcG9ydC9iYXNlLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL3BvcnQvYmFzZS5weQpAQCAtMTM2LDE0ICsxMzYsMTEgQEAgY2xhc3Mg UG9ydChvYmplY3QpOgogICAgICAgICAgICAgImJ1Z3Mud2Via2l0Lm9yZyIsICJQcmV0dHlQYXRj aCIsICJwcmV0dGlmeS5yYiIpCiAgICAgICAgIHNlbGYuX3ByZXR0eV9wYXRjaF9hdmFpbGFibGUg PSBOb25lCiAKLSAgICAgICAgaWYgbm90IGhhc2F0dHIoc2VsZi5fb3B0aW9ucywgJ2NvbmZpZ3Vy YXRpb24nKSBvciBzZWxmLl9vcHRpb25zLmNvbmZpZ3VyYXRpb24gaXMgTm9uZToKLSAgICAgICAg ICAgIHNlbGYuX29wdGlvbnMuY29uZmlndXJhdGlvbiA9IHNlbGYuZGVmYXVsdF9jb25maWd1cmF0 aW9uKCkKKyAgICAgICAgc2VsZi5zZXRfb3B0aW9uX2RlZmF1bHQoJ2NvbmZpZ3VyYXRpb24nLCBz ZWxmLmRlZmF1bHRfY29uZmlndXJhdGlvbigpKQogICAgICAgICBzZWxmLl90ZXN0X2NvbmZpZ3Vy YXRpb24gPSBOb25lCiAgICAgICAgIHNlbGYuX211bHRpcHJvY2Vzc2luZ19pc19hdmFpbGFibGUg PSAobXVsdGlwcm9jZXNzaW5nIGlzIG5vdCBOb25lKQogICAgICAgICBzZWxmLl9yZXN1bHRzX2Rp cmVjdG9yeSA9IE5vbmUKLQotICAgICAgICBpZiBub3QgaGFzYXR0cihzZWxmLl9vcHRpb25zLCAn dXNlX2FwYWNoZScpIG9yIHNlbGYuX29wdGlvbnMudXNlX2FwYWNoZSBpcyBOb25lOgotICAgICAg ICAgICAgc2VsZi5fb3B0aW9ucy51c2VfYXBhY2hlID0gc2VsZi5fZGVmYXVsdF90b19hcGFjaGUo KQorICAgICAgICBzZWxmLnNldF9vcHRpb25fZGVmYXVsdCgndXNlX2FwYWNoZScsIHNlbGYuX2Rl ZmF1bHRfdG9fYXBhY2hlKCkpCiAKICAgICBkZWYgd2RpZmZfYXZhaWxhYmxlKHNlbGYpOgogICAg ICAgICBpZiBzZWxmLl93ZGlmZl9hdmFpbGFibGUgaXMgTm9uZToKQEAgLTU4Miw3ICs1NzksOSBA QCBjbGFzcyBQb3J0KG9iamVjdCk6CiAgICAgICAgIHJldHVybiBkZWZhdWx0X3ZhbHVlCiAKICAg ICBkZWYgc2V0X29wdGlvbl9kZWZhdWx0KHNlbGYsIG5hbWUsIGRlZmF1bHRfdmFsdWUpOgotICAg ICAgICBpZiBub3QgaGFzYXR0cihzZWxmLl9vcHRpb25zLCBuYW1lKToKKyAgICAgICAgIyBGSVhN RTogQ2FsbGVycyBjb3VsZCBhbHNvIHVzZSBvcHRwYXJzZV9wYXJzZXIuVmFsdWVzLmVuc3VyZV92 YWx1ZSwKKyAgICAgICAgIyBzaW5jZSB0aGlzIHNob3VsZCBhbHdheXMgYmUgYSBvcHRwYXJzZV9w YXJzZXIuVmFsdWVzIG9iamVjdC4KKyAgICAgICAgaWYgbm90IGhhc2F0dHIoc2VsZi5fb3B0aW9u cywgbmFtZSkgb3IgZ2V0YXR0cihzZWxmLl9vcHRpb25zLCBuYW1lKSBpcyBOb25lOgogICAgICAg ICAgICAgcmV0dXJuIHNldGF0dHIoc2VsZi5fb3B0aW9ucywgbmFtZSwgZGVmYXVsdF92YWx1ZSkK IAogICAgIGRlZiBwYXRoX2Zyb21fd2Via2l0X2Jhc2Uoc2VsZiwgKmNvbXBzKToKZGlmZiAtLWdp dCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5IGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJraXQucHkKaW5kZXgg NGJhNzkyYWM2NWQ4Nzk3NzEyMjFlMTAyNTBmYjdkN2ExMDQyY2QzMy4uZjExOWE1MDk0ZWNhODlj Mzc0OTFlMGY0YTkyNjUwOWM1MGJjNTg4YSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJraXQucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJraXQucHkKQEAgLTU1LDEwICs1NSw4IEBAIGNsYXNz IFdlYktpdFBvcnQoYmFzZS5Qb3J0KToKICAgICAgICAgYmFzZS5Qb3J0Ll9faW5pdF9fKHNlbGYs ICoqa3dhcmdzKQogICAgICAgICBzZWxmLl9jYWNoZWRfYXBhY2hlX3BhdGggPSBOb25lCiAKLSAg ICAgICAgIyBGSVhNRTogZGlzYWJsZSBwaXhlbCB0ZXN0cyB1bnRpbCB0aGV5IGFyZSBydW4gYnkg ZGVmYXVsdCBvbiB0aGUKLSAgICAgICAgIyBidWlsZCBtYWNoaW5lcy4KLSAgICAgICAgaWYgbm90 IGhhc2F0dHIoc2VsZi5fb3B0aW9ucywgInBpeGVsX3Rlc3RzIikgb3Igc2VsZi5fb3B0aW9ucy5w aXhlbF90ZXN0cyA9PSBOb25lOgotICAgICAgICAgICAgc2VsZi5fb3B0aW9ucy5waXhlbF90ZXN0 cyA9IEZhbHNlCisgICAgICAgICMgRklYTUU6IGRpc2FibGUgcGl4ZWwgdGVzdHMgdW50aWwgdGhl eSBhcmUgcnVuIGJ5IGRlZmF1bHQgb24gdGhlIGJ1aWxkIG1hY2hpbmVzLgorICAgICAgICBzZWxm LnNldF9vcHRpb25fZGVmYXVsdCgicGl4ZWxfdGVzdHMiLCBGYWxzZSkKIAogICAgIGRlZiBiYXNl bGluZV9zZWFyY2hfcGF0aChzZWxmKToKICAgICAgICAgcmV0dXJuIFtzZWxmLl93ZWJraXRfYmFz ZWxpbmVfcGF0aChzZWxmLl9uYW1lKV0K