63416 2011-06-26 20:17:33 -0700 Remove LegacyDefaultOptionalArguments from WebAudio IDL files 2011-06-26 23:49:34 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth crogers eric pilgrim webkit.review.bot oldest_to_newest 427622 0 abarth 2011-06-26 20:17:33 -0700 Remove LegacyDefaultOptionalArguments from WebAudio IDL files 427623 1 98657 abarth 2011-06-26 20:20:54 -0700 Created attachment 98657 Patch 427624 2 abarth 2011-06-26 20:22:04 -0700 Are there any tests for WebAudio? I didn't see any in the LayoutTests directory. 427641 3 crogers 2011-06-26 21:07:32 -0700 They're coming soon. 90% of the work has been finished for DRT and run-webkit-tests. I have seven tests ready to go - more to follow. 427642 4 abarth 2011-06-26 21:11:14 -0700 > They're coming soon. 90% of the work has been finished for DRT and run-webkit-tests. I have seven tests ready to go - more to follow. How does this patch look to you? (I'm happy to add tests for this change once there are some tests to use as templates.) 427647 5 crogers 2011-06-26 21:43:17 -0700 Looking over this it seems fine. I'll keep an eye out in the next day or so after landing just to be sure that everthing is ok. 427653 6 crogers 2011-06-26 21:52:16 -0700 Concerning: // FIXME: Why does this method need to be Custom? [Custom] void connect(in AudioNode destination, in [Optional] unsigned long output, in [Optional] unsigned long input) raises(DOMException); When this was originally landed, either the IDL generation didn't support the optional arguments, or I didn't know about it :) This is an important method, so we'll have to be careful to test it correctly before removing the custom bindings. 427656 7 abarth 2011-06-26 22:09:53 -0700 Yep, which is why I didn't make the change in this patch :) 427663 8 98657 eric 2011-06-26 23:04:47 -0700 Comment on attachment 98657 Patch OK. 427694 9 98657 webkit.review.bot 2011-06-26 23:49:29 -0700 Comment on attachment 98657 Patch Clearing flags on attachment: 98657 Committed r89789: <http://trac.webkit.org/changeset/89789> 427695 10 webkit.review.bot 2011-06-26 23:49:34 -0700 All reviewed patches have been landed. Closing bug. 98657 2011-06-26 20:20:54 -0700 2011-06-26 23:49:29 -0700 Patch bug-63416-20110626202053.patch text/plain 7776 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg5Nzc4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTEtMDYtMjYgIEFkYW0gQmFy dGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBSZW1vdmUgTGVnYWN5RGVmYXVsdE9wdGlvbmFsQXJndW1lbnRzIGZy b20gV2ViQXVkaW8gSURMIGZpbGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD02MzQxNgorCisgICAgICAgIFdlYkF1ZGlvIGlzbid0IHRoYXQgd2lkZWx5 IHVzZWQsIHNvIGl0J3Mgc2VlbXMgc29tZXdoYXQgc2FmZSB0byByZW1vdmUKKyAgICAgICAgbGVn YWN5IGNvZGUgZ2VuZXJhdGlvbiBoYWNrcy4gIEknbSBub3QgYW4gZXhwZXJ0IG9uIFdlYkF1ZGlv LCBidXQgdGhlCisgICAgICAgIEFQSSBkb2Vzbid0IGFwcGVhciB0byBuZWVkIG1hbnkgb3B0aW9u YWwgYXJndW1lbnRzLgorCisgICAgICAgIFRoZXJlIGFyZSBhIGJ1bmNoIG9mIEFQSXMgdGhhdCBo YXZlIGN1c3RvbSBiaW5kaW5ncyB0aGF0IGxvb2sgbGlrZSB0aGV5CisgICAgICAgIGNvdWxkIGJl IGF1dG9nZW5lcmF0ZWQuICBJJ3ZlIGFkZGVkIEZJWE1FIGNvbW1lbnRzIHdoZXJlIGFwcHJvcHJp YXRlLgorCisgICAgICAgICogd2ViYXVkaW8vQXVkaW9CdWZmZXIuaWRsOgorICAgICAgICAqIHdl YmF1ZGlvL0F1ZGlvQ29udGV4dC5pZGw6CisgICAgICAgICogd2ViYXVkaW8vQXVkaW9MaXN0ZW5l ci5pZGw6CisgICAgICAgICogd2ViYXVkaW8vQXVkaW9Ob2RlLmlkbDoKKyAgICAgICAgKiB3ZWJh dWRpby9BdWRpb1Bhbm5lck5vZGUuaWRsOgorICAgICAgICAqIHdlYmF1ZGlvL0F1ZGlvUGFyYW0u aWRsOgorICAgICAgICAqIHdlYmF1ZGlvL1JlYWx0aW1lQW5hbHlzZXJOb2RlLmlkbDoKKwogMjAx MS0wNi0yNiAgRGltaXRyaSBHbGF6a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCkluZGV4OiBTb3VyY2UvV2ViQ29yZS93ZWJhdWRp by9BdWRpb0J1ZmZlci5pZGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvd2ViYXVkaW8v QXVkaW9CdWZmZXIuaWRsCShyZXZpc2lvbiA4OTc3NykKKysrIFNvdXJjZS9XZWJDb3JlL3dlYmF1 ZGlvL0F1ZGlvQnVmZmVyLmlkbAkod29ya2luZyBjb3B5KQpAQCAtMjgsNyArMjgsNiBAQAogCiBt b2R1bGUgYXVkaW8gewogICAgIGludGVyZmFjZSBbCi0gICAgICAgIExlZ2FjeURlZmF1bHRPcHRp b25hbEFyZ3VtZW50cywKICAgICAgICAgQ29uZGl0aW9uYWw9V0VCX0FVRElPCiAgICAgXSBBdWRp b0J1ZmZlciB7CiAgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBsb25nIGxlbmd0aDsgLy8gaW4g c2FtcGxlLWZyYW1lcwpJbmRleDogU291cmNlL1dlYkNvcmUvd2ViYXVkaW8vQXVkaW9Db250ZXh0 LmlkbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS93ZWJhdWRpby9BdWRpb0NvbnRleHQu aWRsCShyZXZpc2lvbiA4OTc3NykKKysrIFNvdXJjZS9XZWJDb3JlL3dlYmF1ZGlvL0F1ZGlvQ29u dGV4dC5pZGwJKHdvcmtpbmcgY29weSkKQEAgLTI1LDcgKzI1LDYgQEAKIAogbW9kdWxlIHdlYmF1 ZGlvIHsKICAgICBpbnRlcmZhY2UgWwotICAgICAgICBMZWdhY3lEZWZhdWx0T3B0aW9uYWxBcmd1 bWVudHMsCiAgICAgICAgIENvbmRpdGlvbmFsPVdFQl9BVURJTywKICAgICAgICAgQWN0aXZlRE9N T2JqZWN0LAogICAgICAgICBDYW5CZUNvbnN0cnVjdGVkLApAQCAtNDgsMTEgKzQ3LDEyIEBAIG1v ZHVsZSB3ZWJhdWRpbyB7CiAgICAgICAgIC8vIEFsbCBwYW5uaW5nIGlzIHJlbGF0aXZlIHRvIHRo aXMgbGlzdGVuZXIuCiAgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBBdWRpb0xpc3RlbmVyIGxp c3RlbmVyOwogCisgICAgICAgIC8vIEZJWE1FOiBTd2l0Y2ggZnJvbSBbQ3VzdG9tXSB0byB1c2lu ZyBJREwgb3ZlcmxvYWRzLgogICAgICAgICAvLyBBdWRpb0J1ZmZlciBjcmVhdGVCdWZmZXIoaW4g dW5zaWduZWQgbG9uZyBudW1iZXJPZkNoYW5uZWxzLCBpbiB1bnNpZ25lZCBsb25nIG51bWJlck9m RnJhbWVzLCBpbiBmbG9hdCBzYW1wbGVSYXRlKTsKICAgICAgICAgLy8gQXVkaW9CdWZmZXIgY3Jl YXRlQnVmZmVyKGluIEFycmF5QnVmZmVyIGJ1ZmZlciwgaW4gYm9vbGVhbiBtaXhUb01vbm8pOwog ICAgICAgICBbQ3VzdG9tXSBBdWRpb0J1ZmZlciBjcmVhdGVCdWZmZXIoKQogICAgICAgICAgICAg cmFpc2VzKERPTUV4Y2VwdGlvbik7Ci0gICAgICAgICAgICAKKwogICAgICAgICAvLyBBc3luY2hy b25vdXMgYXVkaW8gZmlsZSBkYXRhIGRlY29kaW5nLgogICAgICAgICB2b2lkIGRlY29kZUF1ZGlv RGF0YShpbiBBcnJheUJ1ZmZlciBhdWRpb0RhdGEsIGluIFtDYWxsYmFja10gQXVkaW9CdWZmZXJD YWxsYmFjayBzdWNjZXNzQ2FsbGJhY2ssIGluIFtPcHRpb25hbCwgQ2FsbGJhY2tdIEF1ZGlvQnVm ZmVyQ2FsbGJhY2sgZXJyb3JDYWxsYmFjaykKICAgICAgICAgICAgIHJhaXNlcyhET01FeGNlcHRp b24pOwpAQCAtNzUsMTEgKzc1LDEwIEBAIG1vZHVsZSB3ZWJhdWRpbyB7CiAgICAgICAgIC8vIENo YW5uZWwgc3BsaXR0aW5nIGFuZCBtZXJnaW5nCiAgICAgICAgIEF1ZGlvQ2hhbm5lbFNwbGl0dGVy IGNyZWF0ZUNoYW5uZWxTcGxpdHRlcigpOwogICAgICAgICBBdWRpb0NoYW5uZWxNZXJnZXIgY3Jl YXRlQ2hhbm5lbE1lcmdlcigpOwotICAgICAgICAKKwogICAgICAgICAvLyBPZmZsaW5lIHJlbmRl cmluZwogICAgICAgICAvLyB2b2lkIHByZXBhcmVPZmZsaW5lQnVmZmVyUmVuZGVyaW5nKGluIHVu c2lnbmVkIGxvbmcgbnVtYmVyT2ZDaGFubmVscywgaW4gdW5zaWduZWQgbG9uZyBudW1iZXJPZkZy YW1lcywgaW4gZmxvYXQgc2FtcGxlUmF0ZSk7CiAgICAgICAgIGF0dHJpYnV0ZSBFdmVudExpc3Rl bmVyIG9uY29tcGxldGU7CiAgICAgICAgIHZvaWQgc3RhcnRSZW5kZXJpbmcoKTsKLSAgICAgICAg CiAgICAgfTsKIH0KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3dlYmF1ZGlvL0F1ZGlvTGlzdGVuZXIu aWRsCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3dlYmF1ZGlvL0F1ZGlvTGlzdGVuZXIu aWRsCShyZXZpc2lvbiA4OTc3NykKKysrIFNvdXJjZS9XZWJDb3JlL3dlYmF1ZGlvL0F1ZGlvTGlz dGVuZXIuaWRsCSh3b3JraW5nIGNvcHkpCkBAIC0yOCw3ICsyOCw2IEBACiAKIG1vZHVsZSBhdWRp byB7CiAgICAgaW50ZXJmYWNlIFsKLSAgICAgICAgTGVnYWN5RGVmYXVsdE9wdGlvbmFsQXJndW1l bnRzLAogICAgICAgICBDb25kaXRpb25hbD1XRUJfQVVESU8KICAgICBdIEF1ZGlvTGlzdGVuZXIg ewogICAgICAgICBhdHRyaWJ1dGUgZmxvYXQgZG9wcGxlckZhY3RvcjsgIC8vIHNhbWUgYXMgT3Bl bkFMIChkZWZhdWx0IDEuMCkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3dlYmF1ZGlvL0F1ZGlvTm9k ZS5pZGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvd2ViYXVkaW8vQXVkaW9Ob2RlLmlk bAkocmV2aXNpb24gODk3NzcpCisrKyBTb3VyY2UvV2ViQ29yZS93ZWJhdWRpby9BdWRpb05vZGUu aWRsCSh3b3JraW5nIGNvcHkpCkBAIC0yNCwxNyArMjQsMTggQEAKIAogbW9kdWxlIGF1ZGlvIHsK ICAgICBpbnRlcmZhY2UgWwotICAgICAgICBMZWdhY3lEZWZhdWx0T3B0aW9uYWxBcmd1bWVudHMs CiAgICAgICAgIENvbmRpdGlvbmFsPVdFQl9BVURJTwogICAgIF0gQXVkaW9Ob2RlIHsKICAgICAg ICAgcmVhZG9ubHkgYXR0cmlidXRlIEF1ZGlvQ29udGV4dCBjb250ZXh0OwogICAgICAgICByZWFk b25seSBhdHRyaWJ1dGUgdW5zaWduZWQgbG9uZyBudW1iZXJPZklucHV0czsKICAgICAgICAgcmVh ZG9ubHkgYXR0cmlidXRlIHVuc2lnbmVkIGxvbmcgbnVtYmVyT2ZPdXRwdXRzOwogCi0gICAgICAg IFtDdXN0b21dIHZvaWQgY29ubmVjdChpbiBBdWRpb05vZGUgZGVzdGluYXRpb24sIGluIHVuc2ln bmVkIGxvbmcgb3V0cHV0LCBpbiB1bnNpZ25lZCBsb25nIGlucHV0KQorICAgICAgICAvLyBGSVhN RTogV2h5IGRvZXMgdGhpcyBtZXRob2QgbmVlZCB0byBiZSBDdXN0b20/CisgICAgICAgIFtDdXN0 b21dIHZvaWQgY29ubmVjdChpbiBBdWRpb05vZGUgZGVzdGluYXRpb24sIGluIFtPcHRpb25hbF0g dW5zaWduZWQgbG9uZyBvdXRwdXQsIGluIFtPcHRpb25hbF0gdW5zaWduZWQgbG9uZyBpbnB1dCkK ICAgICAgICAgICAgIHJhaXNlcyhET01FeGNlcHRpb24pOwogCi0gICAgICAgIFtDdXN0b21dIHZv aWQgZGlzY29ubmVjdChpbiB1bnNpZ25lZCBsb25nIG91dHB1dCkKKyAgICAgICAgLy8gRklYTUU6 IFdoeSBkb2VzIHRoaXMgbWV0aG9kIG5lZWQgdG8gYmUgQ3VzdG9tPworICAgICAgICBbQ3VzdG9t XSB2b2lkIGRpc2Nvbm5lY3QoaW4gW09wdGlvbmFsXSB1bnNpZ25lZCBsb25nIG91dHB1dCkKICAg ICAgICAgICAgIHJhaXNlcyhET01FeGNlcHRpb24pOwogICAgIH07CiB9CkluZGV4OiBTb3VyY2Uv V2ViQ29yZS93ZWJhdWRpby9BdWRpb1Bhbm5lck5vZGUuaWRsCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL3dlYmF1ZGlvL0F1ZGlvUGFubmVyTm9kZS5pZGwJKHJldmlzaW9uIDg5Nzc3KQor KysgU291cmNlL1dlYkNvcmUvd2ViYXVkaW8vQXVkaW9QYW5uZXJOb2RlLmlkbAkod29ya2luZyBj b3B5KQpAQCAtMjQsNyArMjQsNiBAQAogCiBtb2R1bGUgYXVkaW8gewogICAgIGludGVyZmFjZSBb Ci0gICAgICAgIExlZ2FjeURlZmF1bHRPcHRpb25hbEFyZ3VtZW50cywKICAgICAgICAgQ29uZGl0 aW9uYWw9V0VCX0FVRElPLAogICAgICAgICBHZW5lcmF0ZUNvbnN0cnVjdG9yLAogICAgICAgICBH ZW5lcmF0ZVRvSlMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3dlYmF1ZGlvL0F1ZGlvUGFyYW0uaWRs Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3dlYmF1ZGlvL0F1ZGlvUGFyYW0uaWRsCShy ZXZpc2lvbiA4OTc3NykKKysrIFNvdXJjZS9XZWJDb3JlL3dlYmF1ZGlvL0F1ZGlvUGFyYW0uaWRs CSh3b3JraW5nIGNvcHkpCkBAIC0yOCwxOSArMjgsMTggQEAKIAogbW9kdWxlIHdlYmF1ZGlvIHsK ICAgICBpbnRlcmZhY2UgWwotICAgICAgICBMZWdhY3lEZWZhdWx0T3B0aW9uYWxBcmd1bWVudHMs CiAgICAgICAgIENvbmRpdGlvbmFsPVdFQl9BVURJTwogICAgIF0gQXVkaW9QYXJhbSB7CiAgICAg ICAgIGF0dHJpYnV0ZSBmbG9hdCB2YWx1ZTsKICAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIGZs b2F0IG1pblZhbHVlOwogICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgZmxvYXQgbWF4VmFsdWU7 CiAgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBmbG9hdCBkZWZhdWx0VmFsdWU7Ci0gICAgICAg IAorCiAgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBET01TdHJpbmcgbmFtZTsKIAogICAgICAg ICAvLyBGSVhNRTogQ291bGQgZGVmaW5lIHVuaXRzIGNvbnN0YW50cyBoZXJlIChzZWNvbmRzLCBk ZWNpYmVscywgY2VudHMsIGV0Yy4pLi4uCiAgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSB1bnNp Z25lZCBzaG9ydCB1bml0czsKLSAgICAgICAgCisKICAgICAgICAgLy8gUGFyYW1ldGVyIGF1dG9t YXRpb24uCiAgICAgICAgIHZvaWQgc2V0VmFsdWVBdFRpbWUoaW4gZmxvYXQgdmFsdWUsIGluIGZs b2F0IHRpbWUpOwogICAgICAgICB2b2lkIGxpbmVhclJhbXBUb1ZhbHVlQXRUaW1lKGluIGZsb2F0 IHZhbHVlLCBpbiBmbG9hdCB0aW1lKTsKQEAgLTUyLDkgKzUxLDggQEAgbW9kdWxlIHdlYmF1ZGlv IHsKICAgICAgICAgLy8gU2V0cyBhbiBhcnJheSBvZiBhcmJpdHJhcnkgcGFyYW1ldGVyIHZhbHVl cyBzdGFydGluZyBhdCB0aW1lIGZvciB0aGUgZ2l2ZW4gZHVyYXRpb24uCiAgICAgICAgIC8vIFRo ZSBudW1iZXIgb2YgdmFsdWVzIHdpbGwgYmUgc2NhbGVkIHRvIGZpdCBpbnRvIHRoZSBkZXNpcmVk IGR1cmF0aW9uLgogICAgICAgICB2b2lkIHNldFZhbHVlQ3VydmVBdFRpbWUoaW4gRmxvYXQzMkFy cmF5IHZhbHVlcywgaW4gZmxvYXQgdGltZSwgaW4gZmxvYXQgZHVyYXRpb24pOwotICAgICAgICAK KwogICAgICAgICAvLyBDYW5jZWxzIGFsbCBzY2hlZHVsZWQgcGFyYW1ldGVyIGNoYW5nZXMgd2l0 aCB0aW1lcyBncmVhdGVyIHRoYW4gb3IgZXF1YWwgdG8gc3RhcnRUaW1lLgogICAgICAgICB2b2lk IGNhbmNlbFNjaGVkdWxlZFZhbHVlcyhpbiBmbG9hdCBzdGFydFRpbWUpOwotCiAgICAgfTsKIH0K SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3dlYmF1ZGlvL1JlYWx0aW1lQW5hbHlzZXJOb2RlLmlkbAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS93ZWJhdWRpby9SZWFsdGltZUFuYWx5c2VyTm9k ZS5pZGwJKHJldmlzaW9uIDg5Nzc3KQorKysgU291cmNlL1dlYkNvcmUvd2ViYXVkaW8vUmVhbHRp bWVBbmFseXNlck5vZGUuaWRsCSh3b3JraW5nIGNvcHkpCkBAIC0yNCw3ICsyNCw2IEBACiAKIG1v ZHVsZSBhdWRpbyB7CiAgICAgaW50ZXJmYWNlIFsKLSAgICAgICAgTGVnYWN5RGVmYXVsdE9wdGlv bmFsQXJndW1lbnRzLAogICAgICAgICBDb25kaXRpb25hbD1XRUJfQVVESU8sCiAgICAgICAgIEdl bmVyYXRlVG9KUwogICAgIF0gUmVhbHRpbWVBbmFseXNlck5vZGUgOiBBdWRpb05vZGUgewpAQCAt MzQsMTAgKzMzLDEwIEBAIG1vZHVsZSBhdWRpbyB7CiAgICAgICAgIC8vIG1pbkRlY2liZWxzIC8g bWF4RGVjaWJlbHMgcmVwcmVzZW50IHRoZSByYW5nZSB0byBzY2FsZSB0aGUgRkZUIGFuYWx5c2lz IGRhdGEgZm9yIGNvbnZlcnNpb24gdG8gdW5zaWduZWQgYnl0ZSB2YWx1ZXMuCiAgICAgICAgIGF0 dHJpYnV0ZSBmbG9hdCBtaW5EZWNpYmVsczsKICAgICAgICAgYXR0cmlidXRlIGZsb2F0IG1heERl Y2liZWxzOwotICAgICAgICAKKwogICAgICAgICAvLyBBIHZhbHVlIGZyb20gMC4wIC0+IDEuMCB3 aGVyZSAwLjAgcmVwcmVzZW50cyBubyB0aW1lIGF2ZXJhZ2luZyB3aXRoIHRoZSBsYXN0IGFuYWx5 c2lzIGZyYW1lLgogICAgICAgICBhdHRyaWJ1dGUgZmxvYXQgc21vb3RoaW5nVGltZUNvbnN0YW50 OwotICAgICAgICAKKwogICAgICAgICAvLyBDb3BpZXMgdGhlIGN1cnJlbnQgZnJlcXVlbmN5IGRh dGEgaW50byB0aGUgcGFzc2VkIGFycmF5LgogICAgICAgICAvLyBJZiB0aGUgYXJyYXkgaGFzIGZl d2VyIGVsZW1lbnRzIHRoYW4gdGhlIGZyZXF1ZW5jeUJpbkNvdW50LCB0aGUgZXhjZXNzIGVsZW1l bnRzIHdpbGwgYmUgZHJvcHBlZC4KICAgICAgICAgdm9pZCBnZXRGbG9hdEZyZXF1ZW5jeURhdGEo aW4gRmxvYXQzMkFycmF5IGFycmF5KTsK