63405 2011-06-26 10:36:32 -0700 Web Inspector: [REGRESSION r84481] updateLayout called from DrawNodeHighlight 2011-06-27 04:54:48 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pfeldman apavlov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 427541 0 pfeldman 2011-06-26 10:36:32 -0700 Draw highlight should not update layout. Otherwise we hit an assertion: ASSERTION FAILED: !view() || (!view()->isInLayout() && !view()->isPainting()) WebKit/Source/WebCore/dom/Document.cpp(1572) : virtual void WebCore::Document::updateStyleIfNeeded() 1 WebCore::Document::updateStyleIfNeeded() 2 WebCore::Document::updateLayout() 3 WebCore::Document::updateLayoutIgnorePendingStylesheets() 4 WebCore::DOMNodeHighlighter::DrawNodeHighlight(WebCore::GraphicsContext&, WebCore::Node*, WebCore::DOMNodeHighlighter::HighlightMode) 5 WebCore::InspectorDOMAgent::drawNodeHighlight(WebCore::GraphicsContext&) const 6 WebCore::InspectorController::drawNodeHighlight(WebCore::GraphicsContext&) const 7 -[WebNodeHighlightView drawRect:] 8 -[NSView _drawRect:clip:] 9 -[NSView _recursiveDisplayAllDirtyWithLockFocus:visRect:] 10 -[NSView _recursiveDisplayAllDirtyWithLockFocus:visRect:] 11 -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] 12 -[NSNextStepFrame _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] 13 -[NSView _displayRectIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:] 14 -[NSView displayIfNeeded] 15 -[WebNodeHighlight setNeedsUpdateInTargetViewRect:] 16 -[WebHTMLView drawSingleRect:] 17 -[WebHTMLView drawRect:] 18 -[NSView _drawRect:clip:] 19 -[NSView _recursiveDisplayAllDirtyWithLockFocus:visRect:] 20 -[WebHTMLView(WebPrivate) _recursiveDisplayAllDirtyWithLockFocus:visRect:] 21 -[NSView _recursiveDisplayDescendantsInRect:] 22 -[NSView _recursiveDisplayAllDirtyWithLockFocus:visRect:] 23 -[NSView _recursiveDisplayDescendantsInRect:] 24 -[NSView _recursiveDisplayAllDirtyWithLockFocus:visRect:] 25 -[NSView _recursiveDisplayDescendantsInRect:] 26 -[NSView _recursiveDisplayAllDirtyWithLockFocus:visRect:] 27 -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] 28 -[NSView _displayRectIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:] 29 WebCore::Widget::paint(WebCore::GraphicsContext*, WebCore::IntRect const&) 30 WebCore::ScrollView::paint(WebCore::GraphicsContext*, WebCore::IntRect const&) 31 WebCore::RenderWidget::paint(WebCore::PaintInfo&, WebCore::IntPoint const&) Regressed in https://bugs.webkit.org/show_bug.cgi?id=58992 427820 1 98693 pfeldman 2011-06-27 02:50:50 -0700 Created attachment 98693 Patch 427846 2 98693 yurys 2011-06-27 04:52:02 -0700 Comment on attachment 98693 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98693&action=review > Source/WebCore/ChangeLog:7 > + Please a meaningful description of the change. 427850 3 pfeldman 2011-06-27 04:54:48 -0700 Committed r89815: <http://trac.webkit.org/changeset/89815> 98693 2011-06-27 02:50:50 -0700 2011-06-27 04:52:02 -0700 Patch bug-63405-20110627135048.patch text/plain 2930 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogODk4MDUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhOGQzM2UxNTA5OWM0NGU0 YmZjZTA0YjI2NDE0ZDFlYjlmNDcxMmFjLi5kYjg2YWZkYTUwYTc5OTEyMGE2NGFhZDllNTk2ZTI4 OTFiZTFhNTcyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDYtMjcgIFBhdmVs IEZlbGRtYW4gIDxwZmVsZG1hbkBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFtSRUdSRVNTSU9OIHI4NDQ4 MV0gdXBkYXRlTGF5b3V0IGNhbGxlZCBmcm9tIERyYXdOb2RlSGlnaGxpZ2h0CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MzQwNQorCisgICAgICAgICog aW5zcGVjdG9yL0RPTU5vZGVIaWdobGlnaHRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpET01O b2RlSGlnaGxpZ2h0ZXI6OmRyYXdOb2RlSGlnaGxpZ2h0KToKKyAgICAgICAgKiBpbnNwZWN0b3Iv RE9NTm9kZUhpZ2hsaWdodGVyLmg6CisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvckRPTUFn ZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckRPTUFnZW50OjpkcmF3Tm9kZUhp Z2hsaWdodCk6CisKIDIwMTEtMDYtMjYgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgWXVyeSBTZW1pa2hhdHNreS4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9ET01Ob2RlSGlnaGxpZ2h0ZXIuY3BwIGIvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0RPTU5vZGVIaWdobGlnaHRlci5jcHAKaW5kZXggMjVmOTY1 NDRmMzcyYzcyYTIyNjIwNTVlMjdjMDBjMWFlODk1MDQ1OS4uMTI2YTEzZmZiN2M2NGIzZDhkNTI1 M2M0MDc4ZjczMmE3YTRhZDQ3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L0RPTU5vZGVIaWdobGlnaHRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0RP TU5vZGVIaWdobGlnaHRlci5jcHAKQEAgLTIyMyw5ICsyMjMsOCBAQCB2b2lkIGRyYXdFbGVtZW50 VGl0bGUoR3JhcGhpY3NDb250ZXh0JiBjb250ZXh0LCBOb2RlKiBub2RlLCBjb25zdCBJbnRSZWN0 JiBib3VuZAogCiBuYW1lc3BhY2UgRE9NTm9kZUhpZ2hsaWdodGVyIHsKIAotdm9pZCBEcmF3Tm9k ZUhpZ2hsaWdodChHcmFwaGljc0NvbnRleHQmIGNvbnRleHQsIE5vZGUqIG5vZGUsIEhpZ2hsaWdo dE1vZGUgbW9kZSkKK3ZvaWQgZHJhd05vZGVIaWdobGlnaHQoR3JhcGhpY3NDb250ZXh0JiBjb250 ZXh0LCBOb2RlKiBub2RlLCBIaWdobGlnaHRNb2RlIG1vZGUpCiB7Ci0gICAgbm9kZS0+ZG9jdW1l bnQoKS0+dXBkYXRlTGF5b3V0SWdub3JlUGVuZGluZ1N0eWxlc2hlZXRzKCk7CiAgICAgUmVuZGVy T2JqZWN0KiByZW5kZXJlciA9IG5vZGUtPnJlbmRlcmVyKCk7CiAgICAgRnJhbWUqIGNvbnRhaW5p bmdGcmFtZSA9IG5vZGUtPmRvY3VtZW50KCktPmZyYW1lKCk7CiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9ET01Ob2RlSGlnaGxpZ2h0ZXIuaCBiL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9ET01Ob2RlSGlnaGxpZ2h0ZXIuaAppbmRleCBkNDgzMmRmMGVkYzcwN2RmMTYx NDQwNjRmMmZlZGFhM2I2MzQwZmQ0Li4yZWRlNTczZTQ0MjVlY2MxNGVjNjcxODAzOWE3NDRjOTBj MGJhOGViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvRE9NTm9kZUhpZ2hs aWdodGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0RPTU5vZGVIaWdobGlnaHRl ci5oCkBAIC00NCw3ICs0NCw3IEBAIGVudW0gSGlnaGxpZ2h0TW9kZSB7CiAgICAgSGlnaGxpZ2h0 TWFyZ2luCiB9OwogCi12b2lkIERyYXdOb2RlSGlnaGxpZ2h0KEdyYXBoaWNzQ29udGV4dCYsIE5v ZGUqLCBIaWdobGlnaHRNb2RlKTsKK3ZvaWQgZHJhd05vZGVIaWdobGlnaHQoR3JhcGhpY3NDb250 ZXh0JiwgTm9kZSosIEhpZ2hsaWdodE1vZGUpOwogCiB9IC8vIG5hbWVzcGFjZSBET01Ob2RlSGln aGxpZ2h0ZXIKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rv ckRPTUFnZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01BZ2Vu dC5jcHAKaW5kZXggMjIzNTg5MDU1ODIxMmEyZGIzZWU5MDBkNjhiOGYwOTgxYmY3YzlhNC4uOTI5 N2JjZGFmMzMwOGI0NzlhMTdlNzRkMmM2ZTBiZTk5NTdiMWI2YSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQuY3BwCkBAIC0xNDg4LDcgKzE0ODgsNyBA QCB2b2lkIEluc3BlY3RvckRPTUFnZW50OjpkcmF3Tm9kZUhpZ2hsaWdodChHcmFwaGljc0NvbnRl eHQmIGNvbnRleHQpIGNvbnN0CiAgICAgICAgIG1vZGUgPSBET01Ob2RlSGlnaGxpZ2h0ZXI6Okhp Z2hsaWdodEJvcmRlcjsKICAgICBlbHNlIGlmIChtX2hpZ2hsaWdodE1vZGUgPT0gIm1hcmdpbiIp CiAgICAgICAgIG1vZGUgPSBET01Ob2RlSGlnaGxpZ2h0ZXI6OkhpZ2hsaWdodE1hcmdpbjsKLSAg ICBET01Ob2RlSGlnaGxpZ2h0ZXI6OkRyYXdOb2RlSGlnaGxpZ2h0KGNvbnRleHQsIG1faGlnaGxp Z2h0ZWROb2RlLmdldCgpLCBtb2RlKTsKKyAgICBET01Ob2RlSGlnaGxpZ2h0ZXI6OmRyYXdOb2Rl SGlnaGxpZ2h0KGNvbnRleHQsIG1faGlnaGxpZ2h0ZWROb2RlLmdldCgpLCBtb2RlKTsKIH0KIAog fSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo=