63403 2011-06-26 09:45:05 -0700 Don't use a Mutex for protecting access to the connection queue clients 2011-06-26 10:18:10 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 427535 0 andersca 2011-06-26 09:45:05 -0700 Don't use a Mutex for protecting access to the connection queue clients 427536 1 98628 andersca 2011-06-26 09:49:00 -0700 Created attachment 98628 Patch 427540 2 andersca 2011-06-26 10:18:10 -0700 Committed r89771: <http://trac.webkit.org/changeset/89771> 98628 2011-06-26 09:49:00 -0700 2011-06-26 10:10:11 -0700 Patch bug-63403-20110626094859.patch text/plain 4325 andersca SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg5NzY5KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDYtMjYgIEFuZGVycyBD YXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBEb24ndCB1c2UgYSBNdXRleCBmb3IgcHJvdGVjdGluZyBh Y2Nlc3MgdG8gdGhlIGNvbm5lY3Rpb24gcXVldWUgY2xpZW50cworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjM0MDMKKworICAgICAgICBNYWtlIHN1cmUg dG8gb25seSBhY2Nlc3MgdGhlIHF1ZXVlIGNsaWVudCB2ZWN0b3IgZnJvbSB0aGUgY29ubmVjdGlv biB3b3JrIHF1ZXVlLgorICAgICAgICBUaGlzIGdldHMgcmlkIG9mIGEgbG9jayBhbmQgZW5zdXJl cyB0aGF0IGFkZGluZy9yZW1vdmluZyBjbGllbnRzIGZyb20gY2FsbGJhY2tzIHdvcmtzIGNvcnJl Y3RseS4KKworICAgICAgICAqIFBsYXRmb3JtL0NvcmVJUEMvQ29ubmVjdGlvbi5jcHA6CisgICAg ICAgIChDb3JlSVBDOjpDb25uZWN0aW9uOjphZGRRdWV1ZUNsaWVudCk6CisgICAgICAgIChDb3Jl SVBDOjpDb25uZWN0aW9uOjpyZW1vdmVRdWV1ZUNsaWVudCk6CisgICAgICAgIChDb3JlSVBDOjpD b25uZWN0aW9uOjphZGRRdWV1ZUNsaWVudE9uV29ya1F1ZXVlKToKKyAgICAgICAgKENvcmVJUEM6 OkNvbm5lY3Rpb246OnJlbW92ZVF1ZXVlQ2xpZW50T25Xb3JrUXVldWUpOgorICAgICAgICAoQ29y ZUlQQzo6Q29ubmVjdGlvbjo6cHJvY2Vzc0luY29taW5nTWVzc2FnZSk6CisgICAgICAgICogUGxh dGZvcm0vQ29yZUlQQy9Db25uZWN0aW9uLmg6CisKIDIwMTEtMDYtMjUgIEJyZW50IEZ1bGdoYW0g IDxiZnVsZ2hhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgY29ycmVj dGlvbiBhZnRlciByODk0MjYuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBD L0Nvbm5lY3Rpb24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0Nv cmVJUEMvQ29ubmVjdGlvbi5jcHAJKHJldmlzaW9uIDg5NzY5KQorKysgU291cmNlL1dlYktpdDIv UGxhdGZvcm0vQ29yZUlQQy9Db25uZWN0aW9uLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjM2LDE3 ICsyMzYsMjMgQEAgdm9pZCBDb25uZWN0aW9uOjpzZXRTaG91bGRFeGl0T25TeW5jTWVzcwogCiB2 b2lkIENvbm5lY3Rpb246OmFkZFF1ZXVlQ2xpZW50KFF1ZXVlQ2xpZW50KiBxdWV1ZUNsaWVudCkK IHsKLSAgICBNdXRleExvY2tlciBsb2NrZXIobV9jb25uZWN0aW9uUXVldWVDbGllbnRzTXV0ZXgp OwotICAgIEFTU0VSVCghbV9jb25uZWN0aW9uUXVldWVDbGllbnRzLmNvbnRhaW5zKHF1ZXVlQ2xp ZW50KSk7CisgICAgbV9jb25uZWN0aW9uUXVldWUuc2NoZWR1bGVXb3JrKFdvcmtJdGVtOjpjcmVh dGUodGhpcywgJkNvbm5lY3Rpb246OmFkZFF1ZXVlQ2xpZW50T25Xb3JrUXVldWUsIHF1ZXVlQ2xp ZW50KSk7Cit9CiAKK3ZvaWQgQ29ubmVjdGlvbjo6cmVtb3ZlUXVldWVDbGllbnQoUXVldWVDbGll bnQqIHF1ZXVlQ2xpZW50KQoreworICAgIG1fY29ubmVjdGlvblF1ZXVlLnNjaGVkdWxlV29yayhX b3JrSXRlbTo6Y3JlYXRlKHRoaXMsICZDb25uZWN0aW9uOjpyZW1vdmVRdWV1ZUNsaWVudE9uV29y a1F1ZXVlLCBxdWV1ZUNsaWVudCkpOworfQorCit2b2lkIENvbm5lY3Rpb246OmFkZFF1ZXVlQ2xp ZW50T25Xb3JrUXVldWUoUXVldWVDbGllbnQqIHF1ZXVlQ2xpZW50KQoreworICAgIEFTU0VSVCgh bV9jb25uZWN0aW9uUXVldWVDbGllbnRzLmNvbnRhaW5zKHF1ZXVlQ2xpZW50KSk7CiAgICAgbV9j b25uZWN0aW9uUXVldWVDbGllbnRzLmFwcGVuZChxdWV1ZUNsaWVudCk7CiB9CiAKLXZvaWQgQ29u bmVjdGlvbjo6cmVtb3ZlUXVldWVDbGllbnQoUXVldWVDbGllbnQqIHF1ZXVlQ2xpZW50KQordm9p ZCBDb25uZWN0aW9uOjpyZW1vdmVRdWV1ZUNsaWVudE9uV29ya1F1ZXVlKFF1ZXVlQ2xpZW50KiBx dWV1ZUNsaWVudCkKIHsKLSAgICBNdXRleExvY2tlciBsb2NrZXIobV9jb25uZWN0aW9uUXVldWVD bGllbnRzTXV0ZXgpOwogICAgIHNpemVfdCBpbmRleCA9IG1fY29ubmVjdGlvblF1ZXVlQ2xpZW50 cy5maW5kKHF1ZXVlQ2xpZW50KTsKLQogICAgIEFTU0VSVChpbmRleCAhPSBub3RGb3VuZCk7CiAg ICAgbV9jb25uZWN0aW9uUXVldWVDbGllbnRzLnJlbW92ZShpbmRleCk7CiB9CkBAIC01MzEsMTUg KzUzNywxMSBAQCB2b2lkIENvbm5lY3Rpb246OnByb2Nlc3NJbmNvbWluZ01lc3NhZ2UoCiAgICAg fQogCiAgICAgLy8gSGFuZCBvZmYgdGhlIG1lc3NhZ2UgdG8gdGhlIGNvbm5lY3Rpb24gcXVldWUg Y2xpZW50cy4KLSAgICB7Ci0gICAgICAgIE11dGV4TG9ja2VyIGxvY2tlcihtX2Nvbm5lY3Rpb25R dWV1ZUNsaWVudHNNdXRleCk7Ci0KLSAgICAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBtX2Nv bm5lY3Rpb25RdWV1ZUNsaWVudHMuc2l6ZSgpOyArK2kpIHsKLSAgICAgICAgICAgIGlmICghbV9j b25uZWN0aW9uUXVldWVDbGllbnRzW2ldLT53aWxsUHJvY2Vzc01lc3NhZ2VPbkNsaWVudFJ1bkxv b3AodGhpcywgaW5jb21pbmdNZXNzYWdlLm1lc3NhZ2VJRCgpLCBpbmNvbWluZ01lc3NhZ2UuYXJn dW1lbnRzKCkpKSB7Ci0gICAgICAgICAgICAgICAgLy8gQSBjb25uZWN0aW9uIHF1ZXVlIGNsaWVu dCBoYW5kbGVkIHRoZSBtZXNzYWdlLCBvdXIgd29yayBoZXJlIGlzIGRvbmUuCi0gICAgICAgICAg ICAgICAgaW5jb21pbmdNZXNzYWdlLnJlbGVhc2VBcmd1bWVudHMoKTsKLSAgICAgICAgICAgICAg ICByZXR1cm47Ci0gICAgICAgICAgICB9CisgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBtX2Nv bm5lY3Rpb25RdWV1ZUNsaWVudHMuc2l6ZSgpOyArK2kpIHsKKyAgICAgICAgaWYgKCFtX2Nvbm5l Y3Rpb25RdWV1ZUNsaWVudHNbaV0tPndpbGxQcm9jZXNzTWVzc2FnZU9uQ2xpZW50UnVuTG9vcCh0 aGlzLCBpbmNvbWluZ01lc3NhZ2UubWVzc2FnZUlEKCksIGluY29taW5nTWVzc2FnZS5hcmd1bWVu dHMoKSkpIHsKKyAgICAgICAgICAgIC8vIEEgY29ubmVjdGlvbiBxdWV1ZSBjbGllbnQgaGFuZGxl ZCB0aGUgbWVzc2FnZSwgb3VyIHdvcmsgaGVyZSBpcyBkb25lLgorICAgICAgICAgICAgaW5jb21p bmdNZXNzYWdlLnJlbGVhc2VBcmd1bWVudHMoKTsKKyAgICAgICAgICAgIHJldHVybjsKICAgICAg ICAgfQogICAgIH0KIApJbmRleDogU291cmNlL1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQQy9Db25u ZWN0aW9uLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQQy9D b25uZWN0aW9uLmgJKHJldmlzaW9uIDg5NzY5KQorKysgU291cmNlL1dlYktpdDIvUGxhdGZvcm0v Q29yZUlQQy9Db25uZWN0aW9uLmgJKHdvcmtpbmcgY29weSkKQEAgLTIxNiw2ICsyMTYsOSBAQCBw cml2YXRlOgogICAgIHZvaWQgcHJvY2Vzc0luY29taW5nTWVzc2FnZShNZXNzYWdlSUQsIFBhc3NP d25QdHI8QXJndW1lbnREZWNvZGVyPik7CiAgICAgdm9pZCBwcm9jZXNzSW5jb21pbmdTeW5jUmVw bHkoUGFzc093blB0cjxBcmd1bWVudERlY29kZXI+KTsKIAorICAgIHZvaWQgYWRkUXVldWVDbGll bnRPbldvcmtRdWV1ZShRdWV1ZUNsaWVudCopOworICAgIHZvaWQgcmVtb3ZlUXVldWVDbGllbnRP bldvcmtRdWV1ZShRdWV1ZUNsaWVudCopOworICAgIAogICAgIGJvb2wgY2FuU2VuZE91dGdvaW5n TWVzc2FnZXMoKSBjb25zdDsKICAgICBib29sIHBsYXRmb3JtQ2FuU2VuZE91dGdvaW5nTWVzc2Fn ZXMoKSBjb25zdDsKICAgICB2b2lkIHNlbmRPdXRnb2luZ01lc3NhZ2VzKCk7CkBAIC0yNDYsNyAr MjQ5LDYgQEAgcHJpdmF0ZToKICAgICBXb3JrUXVldWUgbV9jb25uZWN0aW9uUXVldWU7CiAgICAg UnVuTG9vcCogbV9jbGllbnRSdW5Mb29wOwogCi0gICAgTXV0ZXggbV9jb25uZWN0aW9uUXVldWVD bGllbnRzTXV0ZXg7CiAgICAgVmVjdG9yPFF1ZXVlQ2xpZW50Kj4gbV9jb25uZWN0aW9uUXVldWVD bGllbnRzOwogCiAgICAgdW5zaWduZWQgbV9pbkRpc3BhdGNoTWVzc2FnZUNvdW50Owo=