63382 2011-06-25 10:23:59 -0700 run-bindings-tests does not work on Chromium Windows. 2011-06-27 07:48:39 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dglazkov dglazkov abarth eric webkit.review.bot wsiegrist oldest_to_newest 427381 0 dglazkov 2011-06-25 10:23:59 -0700 run-bindings-tests does not work on Chromium Windows. 427382 1 98593 dglazkov 2011-06-25 10:24:51 -0700 Created attachment 98593 Patch 427383 2 98593 dglazkov 2011-06-25 10:25:43 -0700 Comment on attachment 98593 Patch Bill, the master needs to restart once this patch lands. 427384 3 dglazkov 2011-06-25 10:27:44 -0700 The "does not work" looks like this: Traceback (most recent call last): File "./Tools/Scripts/run-bindings-tests", line 139, in <module> sys.exit(main(sys.argv)) File "./Tools/Scripts/run-bindings-tests", line 111, in main current_scm = scm.detect_scm_system(os.curdir) File "E:\google-windows-2\chromium-win-release-tests\build\Tools\Scripts\webkitpy\common\checkout\scm\detection.py", line 79, in detect_scm_system return SVN(cwd=absolute_path, patch_directories=patch_directories) File "E:\google-windows-2\chromium-win-release-tests\build\Tools\Scripts\webkitpy\common\checkout\scm\svn.py", line 68, in __init__ SCM.__init__(self, cwd, executive) File "E:\google-windows-2\chromium-win-release-tests\build\Tools\Scripts\webkitpy\common\checkout\scm\scm.py", line 66, in __init__ self.checkout_root = self.find_checkout_root(self.cwd) File "E:\google-windows-2\chromium-win-release-tests\build\Tools\Scripts\webkitpy\common\checkout\scm\svn.py", line 99, in find_checkout_root uuid = SVN.find_uuid(path) File "E:\google-windows-2\chromium-win-release-tests\build\Tools\Scripts\webkitpy\common\checkout\scm\svn.py", line 86, in find_uuid return cls.value_from_svn_info(path, 'Repository UUID') File "E:\google-windows-2\chromium-win-release-tests\build\Tools\Scripts\webkitpy\common\checkout\scm\svn.py", line 91, in value_from_svn_info info_output = run_command(svn_info_args).rstrip() File "E:\google-windows-2\chromium-win-release-tests\build\Tools\Scripts\webkitpy\common\system\executive.py", line 102, in run_command return Executive().run_command(*args, **kwargs) File "E:\google-windows-2\chromium-win-release-tests\build\Tools\Scripts\webkitpy\common\system\executive.py", line 385, in run_command close_fds=self._should_close_fds()) File "E:\google-windows-2\chromium-win-release-tests\build\Tools\Scripts\webkitpy\common\system\executive.py", line 441, in popen return subprocess.Popen(*args, **kwargs) File "c:\Python26\lib\subprocess.py", line 623, in __init__ errread, errwrite) File "c:\Python26\lib\subprocess.py", line 833, in _execute_child startupinfo) WindowsError: [Error 2] The system cannot find the file specified 427394 4 98593 abarth 2011-06-25 11:12:45 -0700 Comment on attachment 98593 Patch dglazkov wins the prize for fixing a bug by changing only whitespace. 427395 5 dglazkov 2011-06-25 11:16:49 -0700 (In reply to comment #4) > (From update of attachment 98593 [details]) > dglazkov wins the prize for fixing a bug by changing only whitespace. I would like to thank the Academy and especially Python, who provided this glorious opportunity. 427401 6 98593 webkit.review.bot 2011-06-25 11:53:13 -0700 Comment on attachment 98593 Patch Clearing flags on attachment: 98593 Committed r89746: <http://trac.webkit.org/changeset/89746> 427402 7 webkit.review.bot 2011-06-25 11:53:17 -0700 All reviewed patches have been landed. Closing bug. 427930 8 wsiegrist 2011-06-27 07:48:39 -0700 Master updated. 98593 2011-06-25 10:24:51 -0700 2011-06-25 11:53:12 -0700 Patch bug-63382-20110625102450.patch text/plain 1452 dglazkov U3VidmVyc2lvbiBSZXZpc2lvbjogODk3NDMKZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcgYi9Ub29scy9CdWlsZFNs YXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnCmluZGV4IDQzNjdj NmNiZWJiYmQ0ZDhhYjg3NTYzOGExNDRkNWI2NjVhNDY3YzIuLjU1ZTc5NmMyMTJhZDk2ZWY4ZTJm NmQwM2JkZjQ5NTA0NzlmN2QwZDkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0 L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcKKysrIGIvVG9vbHMvQnVpbGRTbGF2 ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNmZwpAQCAtNTYzLDcgKzU2 Myw3IEBAIGNsYXNzIEJ1aWxkQW5kVGVzdEZhY3RvcnkoRmFjdG9yeSk6CiAgICAgICAgICMgZm9y IHJ1bm5pbmcgdGVzdHMuIFRoaXMgY2FuIGJlIHJlbW92ZWQgb25jZSBidWcgNDgxNjYgaXMgZml4 ZWQuCiAgICAgICAgIGlmIHBsYXRmb3JtICE9ICJjaHJvbWl1bS13aW4iOgogICAgICAgICAgICAg c2VsZi5hZGRTdGVwKFJ1blBlcmxUZXN0cykKLSAgICAgICAgc2VsZi5hZGRTdGVwKFJ1bkJpbmRp bmdzVGVzdHMpCisgICAgICAgICAgICBzZWxmLmFkZFN0ZXAoUnVuQmluZGluZ3NUZXN0cykKICAg ICAgICAgc2VsZi5hZGRTdGVwKEFyY2hpdmVUZXN0UmVzdWx0cykKICAgICAgICAgc2VsZi5hZGRT dGVwKFVwbG9hZFRlc3RSZXN1bHRzKQogICAgICAgICBzZWxmLmFkZFN0ZXAoc2VsZi5FeHRyYWN0 VGVzdFJlc3VsdHNDbGFzcykKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0No YW5nZUxvZwppbmRleCA2NjY3Y2MyZTZjOTMzZDFkYWViYzllY2Q3ZTdiYjNlZDUxZmMzMjkwLi45 Yzk4ZWYyNzNkZmM3NzQwNTYyN2QzNjBmYTFiZmI3MDgzZjEyYWUzIDEwMDY0NAotLS0gYS9Ub29s cy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEt MDYtMjUgIERpbWl0cmkgR2xhemtvdiAgPGRnbGF6a292QGNocm9taXVtLm9yZz4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBydW4tYmluZGluZ3MtdGVz dHMgZG9lcyBub3Qgd29yayBvbiBDaHJvbWl1bSBXaW5kb3dzLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjMzODIKKworICAgICAgICAqIEJ1aWxkU2xh dmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmc6IFJlbW92ZWQgcnVu LWJpbmRpbmdzLXRlc3RzIGFzIGEgYnVpbGQgc3RlcCBmb3IgY3Itd2luLgorCiAyMDExLTA2LTI1 ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgVHJ5IHRvIGZpeCB0 aGUgUXQgYW5kIENocm9taXVtIGJ1aWxkcy4K