63378 2011-06-24 23:15:01 -0700 SOFT_LINK_POINTER_OPTIONAL isn't optional. 2011-06-25 14:36:41 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jer.noble jer.noble webkit.review.bot oldest_to_newest 427320 0 jer.noble 2011-06-24 23:15:01 -0700 SOFT_LINK_POINTER_OPTIONAL isn't optional. 427321 1 jer.noble 2011-06-24 23:16:13 -0700 SOFT_LINK_POINTER_OPTIONAL was intended to be optional, but would crash if the requested symbol was not present in the passed in framework, in the same way SOFT_LINK_POINTER would. 427322 2 98582 jer.noble 2011-06-24 23:18:10 -0700 Created attachment 98582 Patch 427426 3 98582 mjs 2011-06-25 13:29:19 -0700 Comment on attachment 98582 Patch r=me 427427 4 98582 darin 2011-06-25 13:30:02 -0700 Comment on attachment 98582 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98582&action=review > Source/WebCore/platform/mac/SoftLinking.h:141 > - pointer##name = static_cast<type>(*pointer); \ > + if (pointer) \ > + pointer##name = static_cast<type>(*pointer); \ Looks OK. I guess that pointer##name is a global and so is guaranteed to be initialized to zero. 427434 5 98582 webkit.review.bot 2011-06-25 14:20:35 -0700 Comment on attachment 98582 Patch Clearing flags on attachment: 98582 Committed r89748: <http://trac.webkit.org/changeset/89748> 427435 6 webkit.review.bot 2011-06-25 14:20:39 -0700 All reviewed patches have been landed. Closing bug. 427440 7 98582 jer.noble 2011-06-25 14:36:41 -0700 Comment on attachment 98582 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98582&action=review >> Source/WebCore/platform/mac/SoftLinking.h:141 >> + pointer##name = static_cast<type>(*pointer); \ > > Looks OK. I guess that pointer##name is a global and so is guaranteed to be initialized to zero. Yup, global static. Thanks! 98582 2011-06-24 23:18:10 -0700 2011-06-25 14:36:41 -0700 Patch bug-63378-20110624231809.patch text/plain 1513 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogODk3MTcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAyNzM2YzEyOWUwMWU1NTNh MjY0NGE1ODc1ZTgxNmRkZjc1MzhiNTBhLi41M2VjMjY4YTU1N2E2ZDlmNzBlNmQ4MGU5NWU3NTQ5 OWM5MmIyZjhmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYgQEAKIDIwMTEtMDYtMjQgIEplciBO b2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgU09GVF9MSU5LX1BPSU5URVJfT1BUSU9OQUwgaXNuJ3Qgb3B0 aW9uYWwuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02 MzM3OAorCisgICAgICAgIENvbnRpbnVhdGlvbiBvZiByODk3MTguICBTT0ZUX0xJTktfUE9JTlRF Ul9PUFRJT05BTCBzaG91bGQgY2hlY2sgdGhlIHZhbHVlIHJldHVybmVkIGJ5IGRsc3ltIGJlZm9y ZSBkZXJlZmVyZW5jaW5nIGl0LgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL1NvZnRMaW5raW5n Lmg6CisKKzIwMTEtMDYtMjQgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKICAg ICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBDYXJsc29uLgogCiAgICAgICAgIFNhZmFyaSB3aWxsIHF1 aXQgdW5leHBlY3RlZGx5IHdoZW4gbGF1bmNoaW5nIFNhZmFyaSBpbiB0aGUgZmlyc3QgdGltZSAo Y3Jhc2ggaW4gaW5pdFFUU2VjdXJpdHlQb2xpY3lOb0xvY2FsVG9SZW1vdGVTaXRlQXR0cmlidXRl KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1NvZnRMaW5raW5nLmgg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvU29mdExpbmtpbmcuaAppbmRleCBlOWE2OTk2 OWJiYjc1YzYzODI1MmVhMTc2OWY4YzZiZjljYjVlOTkwLi5mZjE3ZGQxYzUyMjRkMzhkNDEwMzIy OGQwMGMzYTY2NWU2NzFiZGE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9t YWMvU29mdExpbmtpbmcuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvU29mdExp bmtpbmcuaApAQCAtMTM3LDcgKzEzNyw4IEBACiAgICAgc3RhdGljIHR5cGUgaW5pdCMjbmFtZSgp IFwKICAgICB7IFwKICAgICAgICAgdm9pZCoqIHBvaW50ZXIgPSBzdGF0aWNfY2FzdDx2b2lkKio+ KGRsc3ltKGZyYW1ld29yayMjTGlicmFyeSgpLCAjbmFtZSkpOyBcCi0gICAgICAgIHBvaW50ZXIj I25hbWUgPSBzdGF0aWNfY2FzdDx0eXBlPigqcG9pbnRlcik7IFwKKyAgICAgICAgaWYgKHBvaW50 ZXIpIFwKKyAgICAgICAgICAgIHBvaW50ZXIjI25hbWUgPSBzdGF0aWNfY2FzdDx0eXBlPigqcG9p bnRlcik7IFwKICAgICAgICAgZ2V0IyNuYW1lID0gbmFtZSMjRnVuY3Rpb247IFwKICAgICAgICAg cmV0dXJuIHBvaW50ZXIjI25hbWU7IFwKICAgICB9Cg==