63370 2011-06-24 17:55:03 -0700 [EFL] Remove ewk_frame_theme_get/set. 2011-06-24 18:33:58 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi gyuyoung.kim kenneth leandro lucas.de.marchi tonikitoo oldest_to_newest 427267 0 ryuan.choi 2011-06-24 17:55:03 -0700 Although we change theme for each frame, WebCore will use only last theme because RenderTheme is only created for Page. I believe that it should be removed to reduce confusion for developers. Developers should use ewk_view_theme_set instead of ewk_frame_theme_set. 427269 1 98568 ryuan.choi 2011-06-24 18:01:44 -0700 Created attachment 98568 Patch 427277 2 ryuan.choi 2011-06-24 18:21:39 -0700 Committed r89721: <http://trac.webkit.org/changeset/89721> 98568 2011-06-24 18:01:44 -0700 2011-06-24 18:33:58 -0700 Patch bug-63370-20110625100034.patch text/plain 4397 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogODk3MTIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCAwM2VjNjJhOWNm MjUwYTAxMTI3YjBlZmEyNDcyOThiZmY1YmFiMDVkLi40YTdhYzRmNGE0MTU3MDViODI4YWMyODVi ZWM5NDE4YzUxMzFhYzdiIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEt MDYtMjQgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtFRkxdIFJlbW92ZSBld2tfZnJh bWVfdGhlbWVfZ2V0L3NldC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTYzMzcwCisKKyAgICAgICAgUmVtb3ZlIGV3a19mcmFtZV90aGVtZV9nZXQvc2V0 IHRvIGF2b2lkIGNvbmZ1c2lvbi4KKyAgICAgICAgU2V0dGluZyB0aGVtZSBvbiBlYWNoIGZyYW1l IGlzIG1lYW5pbmdsZXNzIGFuZCBld2tfdmlld190aGplbWVfc2V0IGNhbgorICAgICAgICBkbyBz YW1lIHRoaW5nLgorCisgICAgICAgICogZXdrL2V3a19mcmFtZS5jcHA6CisgICAgICAgICogZXdr L2V3a19mcmFtZS5oOgorICAgICAgICAqIGV3ay9ld2tfdmlldy5jcHA6CisgICAgICAgIChld2tf dmlld190aGVtZV9zZXQpOgorCiAyMDExLTA2LTI0ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5r aW1Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VudCBUYW11cmEuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX2ZyYW1lLmNwcCBiL1NvdXJjZS9XZWJL aXQvZWZsL2V3ay9ld2tfZnJhbWUuY3BwCmluZGV4IDZhNDM4Mjg5YTczY2QxMGQ4MGYxMmRhNGIz ZWU0MTgzNzQ1ZjA0M2EuLjFhNDE1MGM3OGU1OTAyMTI1Yjc5ZGEyZTY1ZTcwZDg4ZDhiMWFkNGUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfZnJhbWUuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfZnJhbWUuY3BwCkBAIC00Miw3ICs0Miw2IEBACiAjaW5j bHVkZSAiUGxhdGZvcm1XaGVlbEV2ZW50LmgiCiAjaW5jbHVkZSAiUHJvZ3Jlc3NUcmFja2VyLmgi CiAjaW5jbHVkZSAiUmVmUHRyLmgiCi0jaW5jbHVkZSAiUmVuZGVyVGhlbWUuaCIKICNpbmNsdWRl ICJSZXNvdXJjZVJlcXVlc3QuaCIKICNpbmNsdWRlICJTY3JpcHRWYWx1ZS5oIgogI2luY2x1ZGUg IlNoYXJlZEJ1ZmZlci5oIgpAQCAtNjYsNyArNjUsNiBAQCBzdHJ1Y3QgRXdrX0ZyYW1lX1NtYXJ0 X0RhdGEgewogICAgIEV2YXNfT2JqZWN0KiByZWdpb247CiAjZW5kaWYKICAgICBXZWJDb3JlOjpG cmFtZSogZnJhbWU7Ci0gICAgY29uc3QgY2hhciogdGhlbWU7CiAgICAgY29uc3QgY2hhciogdGl0 bGU7CiAgICAgY29uc3QgY2hhciogdXJpOwogICAgIGNvbnN0IGNoYXIqIG5hbWU7CkBAIC0zMDIs NDUgKzMwMCw2IEBAIEV2YXNfT2JqZWN0KiBld2tfZnJhbWVfdmlld19nZXQoY29uc3QgRXZhc19P YmplY3QqIG8pCiB9CiAKIC8qKgotICogU2V0cyB0aGUgdGhlbWUgcGF0aCB0aGF0IHdpbGwgYmUg dXNlZCBieSB0aGlzIGZyYW1lLgotICoKLSAqIEZyYW1lcyBpbmhlcml0IHRoZW1lIGZyb20gdGhl aXIgcGFyZW50LCB0aGlzIHdpbGwgaGF2ZSBhbGwgZnJhbWVzCi0gKiB3aXRoIHVuc2V0IHRoZW1l IHRvIHVzZSB0aGlzIG9uZS4KLSAqCi0gKiBAcGFyYW0gbyBmcmFtZSBvYmplY3QgdG8gY2hhbmdl IHRoZW1lCi0gKiBAcGFyYW0gcGF0aCB0aGVtZSBwYXRoLCBtYXkgYmUgQGMgMCB0byByZXNldCB0 byBkZWZhdWx0IHRoZW1lCi0gKiAgICAgIG9yIGluaGVyaXQgcGFyZW50J3MgdGhlbWUuCi0gKgot ICogQHNlZSBld2tfZnJhbWVfdGhlbWVfZ2V0KCkKLSAqLwotdm9pZCBld2tfZnJhbWVfdGhlbWVf c2V0KEV2YXNfT2JqZWN0KiBvLCBjb25zdCBjaGFyKiBwYXRoKQotewotICAgIEVXS19GUkFNRV9T RF9HRVRfT1JfUkVUVVJOKG8sIHNkKTsKLSAgICBpZiAoIWVpbmFfc3RyaW5nc2hhcmVfcmVwbGFj ZSgmc2QtPnRoZW1lLCBwYXRoKSkKLSAgICAgICAgcmV0dXJuOwotICAgIGlmIChzZC0+ZnJhbWUg JiYgc2QtPmZyYW1lLT52aWV3KCkpIHsKLSAgICAgICAgc2QtPmZyYW1lLT52aWV3KCktPnNldEVk amVUaGVtZShXVEY6OlN0cmluZyhwYXRoKSk7Ci0gICAgICAgIHNkLT5mcmFtZS0+cGFnZSgpLT50 aGVtZSgpLT50aGVtZUNoYW5nZWQoKTsKLSAgICB9Ci19Ci0KLS8qKgotICogR2V0cyB0aGUgdGhl bWUgc2V0IG9uIHRoaXMgZnJhbWUuCi0gKgotICogVGhpcyByZXR1cm5zIHRoZSB2YWx1ZSBzZXQg YnkgZXdrX2ZyYW1lX3RoZW1lX3NldCgpLiBOb3RlIHRoYXQgaWYKLSAqIGl0IGlzIEBjIDAsIHRo ZSBmcmFtZSB3aWxsIGluaGVyaXQgcGFyZW50J3MgdGhlbWUuCi0gKgotICogQHBhcmFtIG8gZnJh bWUgb2JqZWN0IHRvIGdldCB0aGVtZSBwYXRoCi0gKgotICogQHJldHVybiB0aGVtZSBwYXRoLCBt YXkgYmUgQGMgMCBpZiBub3Qgc2V0Ci0gKi8KLWNvbnN0IGNoYXIqIGV3a19mcmFtZV90aGVtZV9n ZXQoRXZhc19PYmplY3QqIG8pCi17Ci0gICAgRVdLX0ZSQU1FX1NEX0dFVF9PUl9SRVRVUk4obywg c2QsIDApOwotICAgIHJldHVybiBzZC0+dGhlbWU7Ci19Ci0KLS8qKgogICogUmV0dXJucyBhIG5l dyBpdGVyYXRvciBvdmVyIGFsbCBkaXJlY3QgY2hpbGRyZW4gZnJhbWVzLgogICoKICAqIEtlZXAg ZnJhbWUgb2JqZWN0IGludGFjdCB3aGlsZSBpdGVyYXRpb24gaGFwcGVucyBvdGhlcndpc2UgZnJh bWUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfZnJhbWUuaCBiL1NvdXJj ZS9XZWJLaXQvZWZsL2V3ay9ld2tfZnJhbWUuaAppbmRleCA0OTMwMjAxZWUwNjc0ZjRmZjg1YTE2 YjE0NTVlZDI5NzRhM2VjODQ2Li5lMDkyN2JmNDcwNTExMjc5N2NkMTQ1ZGJhZDYyMmM4ZWEyMzZh YWU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX2ZyYW1lLmgKKysrIGIv U291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19mcmFtZS5oCkBAIC0xNTUsOCArMTU1LDYgQEAgc3Ry dWN0IF9Fd2tfVG91Y2hfUG9pbnQgewogfTsKIAogRUFQSSBFdmFzX09iamVjdCAqZXdrX2ZyYW1l X3ZpZXdfZ2V0KGNvbnN0IEV2YXNfT2JqZWN0ICpvKTsKLUVBUEkgdm9pZCAgICAgICAgIGV3a19m cmFtZV90aGVtZV9zZXQoRXZhc19PYmplY3QgKm8sIGNvbnN0IGNoYXIgKnBhdGgpOwotRUFQSSBj b25zdCBjaGFyICAqZXdrX2ZyYW1lX3RoZW1lX2dldChFdmFzX09iamVjdCAqbyk7CiAKIEVBUEkg RWluYV9JdGVyYXRvciAqZXdrX2ZyYW1lX2NoaWxkcmVuX2l0ZXJhdG9yX25ldyhFdmFzX09iamVj dCAqbyk7CiBFQVBJIEV2YXNfT2JqZWN0ICAgKmV3a19mcmFtZV9jaGlsZF9maW5kKEV2YXNfT2Jq ZWN0ICpvLCBjb25zdCBjaGFyICpuYW1lKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L2V3ay9ld2tfdmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCmlu ZGV4IDBmZjFkNDYzNDIyYmU4MDEyODhiNGQyN2ZlYzA4N2UzNjc0MDc5MmYuLjBkOGQ1Y2I2YWZl NmVlM2I5YWIxZjc4OGQ4MTE5MjgxMzg0YTA5Y2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv ZWZsL2V3ay9ld2tfdmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3 LmNwcApAQCAtNDMsNiArNDMsNyBAQAogI2luY2x1ZGUgIlBsYXRmb3JtTW91c2VFdmVudC5oIgog I2luY2x1ZGUgIlBvcHVwTWVudUNsaWVudC5oIgogI2luY2x1ZGUgIlByb2dyZXNzVHJhY2tlci5o IgorI2luY2x1ZGUgIlJlbmRlclRoZW1lLmgiCiAjaW5jbHVkZSAiZXdrX3ByaXZhdGUuaCIKIAog I2luY2x1ZGUgPEVjb3JlLmg+CkBAIC0xMTk5LDcgKzEyMDAsMTMgQEAgdm9pZCBld2tfdmlld190 aGVtZV9zZXQoRXZhc19PYmplY3QqIG8sIGNvbnN0IGNoYXIqIHBhdGgpCiAgICAgRVdLX1ZJRVdf UFJJVl9HRVRfT1JfUkVUVVJOKHNkLCBwcml2KTsKICAgICBpZiAoIWVpbmFfc3RyaW5nc2hhcmVf cmVwbGFjZSgmcHJpdi0+c2V0dGluZ3MudGhlbWUsIHBhdGgpKQogICAgICAgICByZXR1cm47Ci0g ICAgZXdrX2ZyYW1lX3RoZW1lX3NldChzZC0+bWFpbl9mcmFtZSwgcGF0aCk7CisKKyAgICBXZWJD b3JlOjpGcmFtZVZpZXcqIHZpZXcgPSBwcml2LT5tYWluX2ZyYW1lLT52aWV3KCk7CisgICAgaWYg KHZpZXcpIHsKKyAgICAgICAgdmlldy0+c2V0RWRqZVRoZW1lKFdURjo6U3RyaW5nKHBhdGgpKTsK KyAgICAgICAgcHJpdi0+cGFnZS0+dGhlbWUoKS0+dGhlbWVDaGFuZ2VkKCk7CisgICAgfQorCiB9 CiAKIC8qKgo=