63348 2011-06-24 13:30:31 -0700 Bugs filed from TestFailures page should include links to Trac for suspect revisions 2011-06-24 13:55:36 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED http://build.webkit.org/TestFailures/ P2 Normal --- 1 aroben webkit-unassigned ddkilzer oldest_to_newest 427072 0 aroben 2011-06-24 13:30:31 -0700 It would be handy for the bugs filed from the TestFailures page to include links to Trac for suspect revisions. 427077 1 98529 aroben 2011-06-24 13:34:57 -0700 Created attachment 98529 Include links to Trac in bugs filed from TestFailures 427088 2 98529 ddkilzer 2011-06-24 13:42:43 -0700 Comment on attachment 98529 Include links to Trac in bugs filed from TestFailures View in context: https://bugs.webkit.org/attachment.cgi?id=98529&action=review r=me > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:309 > + endOfFirstSentence += ' in r' + firstSuspectRevision + ' <' + this._trac.changesetURL(firstSuspectRevision) + '>'; Nit: I like revision links to include the "r", but maybe that's more trouble than it's worth. 427098 3 98529 aroben 2011-06-24 13:46:41 -0700 Comment on attachment 98529 Include links to Trac in bugs filed from TestFailures View in context: https://bugs.webkit.org/attachment.cgi?id=98529&action=review >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:309 >> + endOfFirstSentence += ' in r' + firstSuspectRevision + ' <' + this._trac.changesetURL(firstSuspectRevision) + '>'; > > Nit: I like revision links to include the "r", but maybe that's more trouble than it's worth. I'm not sure what you mean? This is just putting the URL into the description after the revision number. Something like: foo/bar/baz.html started failing on Windows 7 Release (Tests) in r12345 <http://trac.webkit.org/changeset/12345>. 427107 4 ddkilzer 2011-06-24 13:50:28 -0700 (In reply to comment #3) > (From update of attachment 98529 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=98529&action=review > > >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:309 > >> + endOfFirstSentence += ' in r' + firstSuspectRevision + ' <' + this._trac.changesetURL(firstSuspectRevision) + '>'; > > > > Nit: I like revision links to include the "r", but maybe that's more trouble than it's worth. > > I'm not sure what you mean? This is just putting the URL into the description after the revision number. Something like: > > foo/bar/baz.html started failing on Windows 7 Release (Tests) in r12345 <http://trac.webkit.org/changeset/12345>. Sorry, I thought it was doing something like this: r<a href="http://trac.webkit.org/changeset/12345">12345</a> That's fine. 427115 5 aroben 2011-06-24 13:55:36 -0700 Committed r89701: <http://trac.webkit.org/changeset/89701> 98529 2011-06-24 13:34:57 -0700 2011-06-24 13:46:41 -0700 Include links to Trac in bugs filed from TestFailures bug-63348-20110624163455.patch text/plain 5158 aroben U3VidmVyc2lvbiBSZXZpc2lvbjogODk2OTgKZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9U cmFjLmpzIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcv cHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL1RyYWMuanMKaW5kZXggYTU2OGVkZGZiMWZhMWRmNTE1 ZGI1ZDMwNmZmMWM0MWQwMWIxZWMyZC4uNjhlY2E2NDdkMTk1NzBmZjAzZGQwYTE1MjkxMzkwMDVj NDNlNTc0OCAxMDA2NDQKLS0tIGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0 Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL1RyYWMuanMKKysrIGIvVG9vbHMv QnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVz dEZhaWx1cmVzL1RyYWMuanMKQEAgLTI4LDYgKzI4LDEwIEBAIGZ1bmN0aW9uIFRyYWMoYmFzZVVS TCkgewogfQogCiBUcmFjLnByb3RvdHlwZSA9IHsKKyAgICBjaGFuZ2VzZXRVUkw6IGZ1bmN0aW9u KHJldmlzaW9uKSB7CisgICAgICAgIHJldHVybiB0aGlzLmJhc2VVUkwgKyAnY2hhbmdlc2V0Lycg KyByZXZpc2lvbjsKKyAgICB9LAorCiAgICAgbG9nVVJMOiBmdW5jdGlvbihwYXRoLCBzdGFydFJl dmlzaW9uLCBlbmRSZXZpc2lvbikgewogICAgICAgICByZXR1cm4gYWRkUXVlcnlQYXJhbWV0ZXJz VG9VUkwodGhpcy5iYXNlVVJMICsgJ2xvZy8nICsgcGF0aCwgeyByZXY6IGVuZFJldmlzaW9uLCBz dG9wX3Jldjogc3RhcnRSZXZpc2lvbiB9KTsKICAgICB9LApkaWZmIC0tZ2l0IGEvVG9vbHMvQnVp bGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZh aWx1cmVzL1ZpZXdDb250cm9sbGVyLmpzIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQu d2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL1ZpZXdDb250cm9sbGVy LmpzCmluZGV4IDk3NzZjYTdiMzhkOTkwYTZiZTc2Mjc3ZjBjMjZjODAwM2UyOGVmZGUuLjIwMzE3 ODYwMTUxODA1YzFkMjE0YTNjYmMwODE0ZjFkMzc5NDA2OTggMTAwNjQ0Ci0tLSBhL1Rvb2xzL0J1 aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RG YWlsdXJlcy9WaWV3Q29udHJvbGxlci5qcworKysgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9i dWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvVmlld0NvbnRy b2xsZXIuanMKQEAgLTI5OSwxOSArMjk5LDMxIEBAIFZpZXdDb250cm9sbGVyLnByb3RvdHlwZSA9 IHsKICAgICAgICAgICAgIHRpdGxlID0gdGl0bGVQcmVmaXggKyBmYWlsaW5nVGVzdHMubGVuZ3Ro ICsgJyB0ZXN0cycgKyB0aXRsZVN1ZmZpeDsKICAgICAgICAgY29uc29sZS5hc3NlcnQodGl0bGUu bGVuZ3RoIDw9IEJ1Z3ppbGxhLm1heGltdW1CdWdUaXRsZUxlbmd0aCk7CiAKKyAgICAgICAgdmFy IGZpcnN0U3VzcGVjdFJldmlzaW9uID0gcGFyc2VkUGFzc2luZ0J1aWxkTmFtZSA/IHBhcnNlZFBh c3NpbmdCdWlsZE5hbWUucmV2aXNpb24gKyAxIDogcGFyc2VkRmFpbGluZ0J1aWxkTmFtZS5yZXZp c2lvbjsKKyAgICAgICAgdmFyIGxhc3RTdXNwZWN0UmV2aXNpb24gPSBwYXJzZWRGYWlsaW5nQnVp bGROYW1lLnJldmlzaW9uOworCisgICAgICAgIHZhciBlbmRPZkZpcnN0U2VudGVuY2U7CisgICAg ICAgIGlmIChwYXNzaW5nQnVpbGROYW1lKSB7CisgICAgICAgICAgICBlbmRPZkZpcnN0U2VudGVu Y2UgPSAnc3RhcnRlZCBmYWlsaW5nIG9uICcgKyB0ZXN0ZXIubmFtZTsKKyAgICAgICAgICAgIGlm IChmaXJzdFN1c3BlY3RSZXZpc2lvbiA9PT0gbGFzdFN1c3BlY3RSZXZpc2lvbikKKyAgICAgICAg ICAgICAgICBlbmRPZkZpcnN0U2VudGVuY2UgKz0gJyBpbiByJyArIGZpcnN0U3VzcGVjdFJldmlz aW9uICsgJyA8JyArIHRoaXMuX3RyYWMuY2hhbmdlc2V0VVJMKGZpcnN0U3VzcGVjdFJldmlzaW9u KSArICc+JzsKKyAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICBlbmRPZkZpcnN0U2Vu dGVuY2UgKz0gJyBiZXR3ZWVuIHInICsgZmlyc3RTdXNwZWN0UmV2aXNpb24gKyAnIGFuZCByJyAr IGxhc3RTdXNwZWN0UmV2aXNpb24gKyAnIChpbmNsdXNpdmUpJzsKKyAgICAgICAgfSBlbHNlCisg ICAgICAgICAgICBlbmRPZkZpcnN0U2VudGVuY2UgPSAoZmFpbGluZ1Rlc3RzLmxlbmd0aCA9PT0g MSA/ICdoYXMnIDogJ2hhdmUnKSArICcgYmVlbiBmYWlsaW5nIG9uICcgKyB0ZXN0ZXIubmFtZSAr ICcgc2luY2UgYXQgbGVhc3QgcicgKyBmaXJzdFN1c3BlY3RSZXZpc2lvbiArICcgPCcgKyB0aGlz Ll90cmFjLmNoYW5nZXNldFVSTChmaXJzdFN1c3BlY3RSZXZpc2lvbikgKyAnPic7CisKICAgICAg ICAgdmFyIGRlc2NyaXB0aW9uOwotICAgICAgICBpZiAoZmFpbGluZ1Rlc3RzLmxlbmd0aCA9PT0g MSkgewotICAgICAgICAgICAgZGVzY3JpcHRpb24gPSBmYWlsaW5nVGVzdHNbMF0gKyAnIGhhcyBi ZWVuIGZhaWxpbmcgb24gJyArIHRlc3Rlci5uYW1lCi0gICAgICAgICAgICAgICAgKyAnIHNpbmNl IHInICsgcGFyc2VkRmFpbGluZ0J1aWxkTmFtZS5yZXZpc2lvbiArICcuXG5cbic7Ci0gICAgICAg IH0gZWxzZSBpZiAoZmFpbGluZ1Rlc3RzLmxlbmd0aCA9PT0gMikgewotICAgICAgICAgICAgZGVz Y3JpcHRpb24gPSBmYWlsaW5nVGVzdHMuam9pbignIGFuZCAnKSArICcgaGF2ZSBiZWVuIGZhaWxp bmcgb24gJyArIHRlc3Rlci5uYW1lCi0gICAgICAgICAgICAgICAgKyAnIHNpbmNlIHInICsgcGFy c2VkRmFpbGluZ0J1aWxkTmFtZS5yZXZpc2lvbiArICcuXG5cbic7Ci0gICAgICAgIH0gZWxzZSB7 Ci0gICAgICAgICAgICBkZXNjcmlwdGlvbiA9ICdUaGUgZm9sbG93aW5nIHRlc3RzIGhhdmUgYmVl biBmYWlsaW5nIG9uICcgKyB0ZXN0ZXIubmFtZQotICAgICAgICAgICAgICAgICsgJyBzaW5jZSBy JyArIHBhcnNlZEZhaWxpbmdCdWlsZE5hbWUucmV2aXNpb24gKyAnOlxuXG4nCisgICAgICAgIGlm IChmYWlsaW5nVGVzdHMubGVuZ3RoID09PSAxKQorICAgICAgICAgICAgZGVzY3JpcHRpb24gPSBm YWlsaW5nVGVzdHNbMF0gKyAnICcgKyBlbmRPZkZpcnN0U2VudGVuY2UgKyAnLlxuXG4nOworICAg ICAgICBlbHNlIGlmIChmYWlsaW5nVGVzdHMubGVuZ3RoID09PSAyKQorICAgICAgICAgICAgZGVz Y3JpcHRpb24gPSBmYWlsaW5nVGVzdHMuam9pbignIGFuZCAnKSArICcgJyArIGVuZE9mRmlyc3RT ZW50ZW5jZSArICcuXG5cbic7CisgICAgICAgIGVsc2UgeworICAgICAgICAgICAgZGVzY3JpcHRp b24gPSAnVGhlIGZvbGxvd2luZyB0ZXN0cyAnICsgZW5kT2ZGaXJzdFNlbnRlbmNlICsgJzpcblxu JwogICAgICAgICAgICAgICAgICsgZmFpbGluZ1Rlc3RzLm1hcChmdW5jdGlvbih0ZXN0KSB7IHJl dHVybiAnICAgICcgKyB0ZXN0IH0pLmpvaW4oJ1xuJykKICAgICAgICAgICAgICAgICArICdcblxu JzsKICAgICAgICAgfQorICAgICAgICBpZiAoZmlyc3RTdXNwZWN0UmV2aXNpb24gIT09IGxhc3RT dXNwZWN0UmV2aXNpb24pCisgICAgICAgICAgICBkZXNjcmlwdGlvbiArPSB0aGlzLl90cmFjLmxv Z1VSTCgndHJ1bmsnLCBmaXJzdFN1c3BlY3RSZXZpc2lvbiwgbGFzdFN1c3BlY3RSZXZpc2lvbikg KyAnXG5cbic7CiAgICAgICAgIGlmIChwYXNzaW5nQnVpbGROYW1lKQogICAgICAgICAgICAgZGVz Y3JpcHRpb24gKz0gZW5jb2RlVVJJKHRlc3Rlci5yZXN1bHRzUGFnZVVSTChwYXNzaW5nQnVpbGRO YW1lKSkgKyAnIHBhc3NlZFxuJzsKICAgICAgICAgdmFyIGZhaWxpbmdSZXN1bHRzSFRNTCA9IHRl c3Rlci5yZXN1bHRzUGFnZVVSTChmYWlsaW5nQnVpbGROYW1lKTsKZGlmZiAtLWdpdCBhL1Rvb2xz L0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3YWQyOWYwYzE1NjdmZDExOGQ4OTNk MTAzMGQ4YjhjZDZjNTMxMjQyLi5lZjAxOTc0OGI5MzMwYWJkZWFkYTJmMmI5NGQyNDQ3ZDFhMjUz YjdhIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBA IC0xLDUgKzEsMjMgQEAKIDIwMTEtMDYtMjQgIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29t PgogCisgICAgICAgIEluY2x1ZGUgbGlua3MgdG8gVHJhYyBpbiBidWdzIGZpbGVkIGZyb20gVGVz dEZhaWx1cmVzCisKKyAgICAgICAgRml4ZXMgPGh0dHA6Ly93ZWJraXQub3JnL2IvNjMzNDg+IEJ1 Z3MgZmlsZWQgZnJvbSBUZXN0RmFpbHVyZXMgcGFnZSBzaG91bGQgaW5jbHVkZSBsaW5rcyB0bwor ICAgICAgICBUcmFjIGZvciBzdXNwZWN0IHJldmlzaW9ucworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Vi a2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL1RyYWMuanM6CisgICAgICAg IChUcmFjLnByb3RvdHlwZS5jaGFuZ2VzZXRVUkwpOiBOZXcgZnVuY3Rpb24sIHJldHVybnMgdGhl IFVSTCBmb3IgYSBwYXJ0aWN1bGFyIHJldmlzaW9uIGluCisgICAgICAgIFRyYWMuCisKKyAgICAg ICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRt bC9UZXN0RmFpbHVyZXMvVmlld0NvbnRyb2xsZXIuanM6CisgICAgICAgIChWaWV3Q29udHJvbGxl ci5wcm90b3R5cGUuX2RvbUZvck5ld0FuZEV4aXN0aW5nQnVncyk6IElmIHRoZXJlJ3Mgb25seSBv bmUgc3VzcGVjdCByZXZpc2lvbiwKKyAgICAgICAgaW5jbHVkZSBhIGxpbmsgdG8gVHJhYyBmb3Ig aXQgaW4gdGhlIGZpcnN0IHNlbnRlbmNlIG9mIHRoZSBkZXNjcmlwdGlvbi4gT3RoZXJ3aXNlIGlu Y2x1ZGUgYQorICAgICAgICBsaW5rIHRvIHRoZSBzdXNwZWN0IHJhbmdlIGFmdGVyIHRoZSBsaXN0 IG9mIGZhaWxpbmcgdGVzdHMuCisKKzIwMTEtMDYtMjQgIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBw bGUuY29tPgorCiAgICAgICAgIEZpeCB0eXBvcyBpbnRyb2R1Y2VkIGluIHI4OTY5NgogCiAgICAg ICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0 bWwvVGVzdEZhaWx1cmVzL0J1aWxkZXIuanM6Cg==