63341 2011-06-24 12:27:32 -0700 Pass Strings by const reference to functions 2011-06-27 09:43:03 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tony tony abarth darin webkit.review.bot oldest_to_newest 427045 0 tony 2011-06-24 12:27:32 -0700 Pass Strings by const reference to functions 427048 1 98524 tony 2011-06-24 12:29:31 -0700 Created attachment 98524 Patch 427051 2 tony 2011-06-24 12:30:58 -0700 This is the last patch for fixing passing String by value in WebCore. The only trickiness is in FrameLoader.cpp. 427184 3 98524 webkit.review.bot 2011-06-24 15:05:30 -0700 Comment on attachment 98524 Patch Clearing flags on attachment: 98524 Committed r89707: <http://trac.webkit.org/changeset/89707> 427185 4 webkit.review.bot 2011-06-24 15:05:34 -0700 All reviewed patches have been landed. Closing bug. 427250 5 darin 2011-06-24 17:12:06 -0700 This broke the Windows build since String::charactersWithNullTermination is a non-const function. 427252 6 darin 2011-06-24 17:13:58 -0700 I tried to fix that in <http://trac.webkit.org/changeset/89717>. 428010 7 tony 2011-06-27 09:43:03 -0700 (In reply to comment #6) > I tried to fix that in <http://trac.webkit.org/changeset/89717>. Sorry. Thanks for fixing! 98524 2011-06-24 12:29:31 -0700 2011-06-24 15:05:29 -0700 Patch bug-63341-20110624122911.patch text/plain 14815 tony U3VidmVyc2lvbiBSZXZpc2lvbjogODk2OTEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA1ZGMzNTljYzZmMzE5NWUx MzExOTViNGUxMDg2Yzk4ZjY1MjVmOTE4Li5kMTliZjU2ZTJhNWNjM2I1ZTZjYzVmN2M0MWVkNGZl YWY3ZDQyYWY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsNDAgQEAKKzIwMTEtMDYtMjQgIFRvbnkg Q2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBQYXNzIFN0cmluZ3MgYnkgY29uc3QgcmVmZXJlbmNlIHRvIGZ1 bmN0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NjMzNDEKKworICAgICAgICBOb3RlIHRoYXQgc2luY2UgU3RyaW5ncyBob2xkIGEgUmVmUHRyIHRv IFN0cmluZ0ltcGwsIHBhc3NpbmcgU3RyaW5ncworICAgICAgICBieSB2YWx1ZSBpc24ndCBob3Jy aWJsZSwgYnV0IGl0IGRvZXMgY2F1c2UgcmVmIGNvdW50IGNodXJuIGFuZCB1c2luZworICAgICAg ICBjb25zdCByZWZlcmVuY2VzIGlzIG1vcmUgY29uc2lzdGVudCB3aXRoIHRoZSByZXN0IG9mIHRo ZSBjb2RlIGJhc2UuCisKKyAgICAgICAgKiBsb2FkZXIvRnJhbWVMb2FkZXIuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6RnJhbWVMb2FkZXI6OmFkZEhUVFBPcmlnaW5JZk5lZWRlZCk6IFJld29yayB0 aGUgY29kZSB0byBub3QKKyAgICAgICAgICAgIGNoYW5nZSB0aGUgdmFsdWUgb2YgdGhlIHBhc3Nl ZCBpbiBTdHJpbmcuCisgICAgICAgICogbG9hZGVyL0ZyYW1lTG9hZGVyLmg6CisgICAgICAgICog cGxhdGZvcm0vd2luL0NsaXBib2FyZFV0aWxpdGllc1dpbi5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpzZXRGaWxlRGVzY3JpcHRvckRhdGEpOgorICAgICAgICAqIHBsYXRmb3JtL3dpbi9DbGlwYm9h cmRVdGlsaXRpZXNXaW4uaDoKKyAgICAgICAgKiBzdG9yYWdlL0RhdGFiYXNlVHJhY2tlci5oOgor ICAgICAgICAqIHN0b3JhZ2UvSURCTGV2ZWxEQkJhY2tpbmdTdG9yZS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpJREJMZXZlbERCQmFja2luZ1N0b3JlOjpJREJMZXZlbERCQmFja2luZ1N0b3JlKToK KyAgICAgICAgKiBzdG9yYWdlL0lEQkxldmVsREJCYWNraW5nU3RvcmUuaDoKKyAgICAgICAgKiBz dG9yYWdlL0lEQlNRTGl0ZUJhY2tpbmdTdG9yZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJREJT UUxpdGVCYWNraW5nU3RvcmU6OklEQlNRTGl0ZUJhY2tpbmdTdG9yZSk6CisgICAgICAgICogc3Rv cmFnZS9JREJTUUxpdGVCYWNraW5nU3RvcmUuaDoKKyAgICAgICAgKiBzdG9yYWdlL2Nocm9taXVt L0RhdGFiYXNlVHJhY2tlckNocm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRhdGFiYXNl VHJhY2tlcjo6Z2V0T3BlbkRhdGFiYXNlcyk6CisgICAgICAgICogc3ZnL1NWR1BhaW50LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlNWR1BhaW50OjpTVkdQYWludCk6CisgICAgICAgICogc3ZnL1NW R1BhaW50Lmg6CisgICAgICAgICogc3ZnL2FuaW1hdGlvbi9TTUlMVGltZUNvbnRhaW5lci5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpTTUlMVGltZUNvbnRhaW5lcjo6dXBkYXRlQW5pbWF0aW9ucyk6 CisgICAgICAgICogc3ZnL2FuaW1hdGlvbi9TTUlMVGltZUNvbnRhaW5lci5oOgorICAgICAgICAq IHdlYnNvY2tldHMvVGhyZWFkYWJsZVdlYlNvY2tldENoYW5uZWxDbGllbnRXcmFwcGVyLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlRocmVhZGFibGVXZWJTb2NrZXRDaGFubmVsQ2xpZW50V3JhcHBl cjo6ZGlkUmVjZWl2ZU1lc3NhZ2VDYWxsYmFjayk6CisgICAgICAgICogd2Vic29ja2V0cy9UaHJl YWRhYmxlV2ViU29ja2V0Q2hhbm5lbENsaWVudFdyYXBwZXIuaDoKKwogMjAxMS0wNi0yNCAgTmlr b2xhcyBaaW1tZXJtYW5uICA8bnppbW1lcm1hbm5AcmltLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBEaXJrIFNjaHVsemUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJh bWVMb2FkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAppbmRl eCA4OGRjMDgxYmIyNWVlMmMzOWM1NmIyMTdiNGQ0NjFhNGVjYmQwYzA4Li45NTBjNDRmMTMyMGZj MjU1NmFlOWVhZmVhZWVjOTVhMjViZWQ4Yjg4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9s b2FkZXIvRnJhbWVMb2FkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxv YWRlci5jcHAKQEAgLTI1MjYsNyArMjUyNiw3IEBAIHZvaWQgRnJhbWVMb2FkZXI6OmFkZEV4dHJh RmllbGRzVG9SZXF1ZXN0KFJlc291cmNlUmVxdWVzdCYgcmVxdWVzdCwgRnJhbWVMb2FkVHlwCiAg ICAgcmVxdWVzdC5zZXRSZXNwb25zZUNvbnRlbnREaXNwb3NpdGlvbkVuY29kaW5nRmFsbGJhY2tB cnJheSgiVVRGLTgiLCBhY3RpdmVEb2N1bWVudExvYWRlcigpLT53cml0ZXIoKS0+ZGVwcmVjYXRl ZEZyYW1lRW5jb2RpbmcoKSwgc2V0dGluZ3MgPyBzZXR0aW5ncy0+ZGVmYXVsdFRleHRFbmNvZGlu Z05hbWUoKSA6IFN0cmluZygpKTsKIH0KIAotdm9pZCBGcmFtZUxvYWRlcjo6YWRkSFRUUE9yaWdp bklmTmVlZGVkKFJlc291cmNlUmVxdWVzdCYgcmVxdWVzdCwgU3RyaW5nIG9yaWdpbikKK3ZvaWQg RnJhbWVMb2FkZXI6OmFkZEhUVFBPcmlnaW5JZk5lZWRlZChSZXNvdXJjZVJlcXVlc3QmIHJlcXVl c3QsIGNvbnN0IFN0cmluZyYgb3JpZ2luKQogewogICAgIGlmICghcmVxdWVzdC5odHRwT3JpZ2lu KCkuaXNFbXB0eSgpKQogICAgICAgICByZXR1cm47ICAvLyBSZXF1ZXN0IGFscmVhZHkgaGFzIGFu IE9yaWdpbiBoZWFkZXIuCkBAIC0yNTQ2LDcgKzI1NDYsOCBAQCB2b2lkIEZyYW1lTG9hZGVyOjph ZGRIVFRQT3JpZ2luSWZOZWVkZWQoUmVzb3VyY2VSZXF1ZXN0JiByZXF1ZXN0LCBTdHJpbmcgb3Jp Z2luKQogICAgIGlmIChvcmlnaW4uaXNFbXB0eSgpKSB7CiAgICAgICAgIC8vIElmIHdlIGRvbid0 IGtub3cgd2hhdCBvcmlnaW4gaGVhZGVyIHRvIGF0dGFjaCwgd2UgYXR0YWNoIHRoZSB2YWx1ZQog ICAgICAgICAvLyBmb3IgYW4gZW1wdHkgb3JpZ2luLgotICAgICAgICBvcmlnaW4gPSBTZWN1cml0 eU9yaWdpbjo6Y3JlYXRlRW1wdHkoKS0+dG9TdHJpbmcoKTsKKyAgICAgICAgcmVxdWVzdC5zZXRI VFRQT3JpZ2luKFNlY3VyaXR5T3JpZ2luOjpjcmVhdGVFbXB0eSgpLT50b1N0cmluZygpKTsKKyAg ICAgICAgcmV0dXJuOwogICAgIH0KIAogICAgIHJlcXVlc3Quc2V0SFRUUE9yaWdpbihvcmlnaW4p OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmggYi9Tb3Vy Y2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuaAppbmRleCAyY2FhMmUyNDFjMDViZDU0ZWRm MzFiNWMxNDY4YjU1NmZiYzExZDFhLi5lYWRjNmQwM2JhMWFmZTUwZTkyNTdjZGNhN2ZmOTdlOGNk YTM3NTg2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuaApAQCAtMjAyLDcgKzIwMiw3 IEBAIHB1YmxpYzoKICAgICB2b2lkIGFkZEV4dHJhRmllbGRzVG9TdWJyZXNvdXJjZVJlcXVlc3Qo UmVzb3VyY2VSZXF1ZXN0Jik7CiAgICAgdm9pZCBhZGRFeHRyYUZpZWxkc1RvTWFpblJlc291cmNl UmVxdWVzdChSZXNvdXJjZVJlcXVlc3QmKTsKICAgICAKLSAgICBzdGF0aWMgdm9pZCBhZGRIVFRQ T3JpZ2luSWZOZWVkZWQoUmVzb3VyY2VSZXF1ZXN0JiwgU3RyaW5nIG9yaWdpbik7CisgICAgc3Rh dGljIHZvaWQgYWRkSFRUUE9yaWdpbklmTmVlZGVkKFJlc291cmNlUmVxdWVzdCYsIGNvbnN0IFN0 cmluZyYgb3JpZ2luKTsKIAogICAgIEZyYW1lTG9hZGVyQ2xpZW50KiBjbGllbnQoKSBjb25zdCB7 IHJldHVybiBtX2NsaWVudDsgfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS93aW4vQ2xpcGJvYXJkVXRpbGl0aWVzV2luLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L3dpbi9DbGlwYm9hcmRVdGlsaXRpZXNXaW4uY3BwCmluZGV4IGNmM2FiOTNjYTRkYjk2YjUwMjdj MzM2M2Q5ZTE1MDQyMmY5ODNkZTUuLmIxMzU4MGE1ZmMxN2Q2ZmQ5Mjg5MzVmYjVhZmI5MGZjZmEx MWE0MGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9DbGlwYm9hcmRV dGlsaXRpZXNXaW4uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9DbGlwYm9h cmRVdGlsaXRpZXNXaW4uY3BwCkBAIC00MDgsNyArNDA4LDcgQEAgdm9pZCBnZXRGaWxlQ29udGVu dERhdGEoSURhdGFPYmplY3QqIGRhdGFPYmplY3QsIGludCBzaXplLCB2b2lkKiBkYXRhQmxvYikK ICAgICA6OlJlbGVhc2VTdGdNZWRpdW0oJnN0b3JlKTsKIH0KIAotdm9pZCBzZXRGaWxlRGVzY3Jp cHRvckRhdGEoSURhdGFPYmplY3QqIGRhdGFPYmplY3QsIGludCBzaXplLCBTdHJpbmcgcGF0aG5h bWUpCit2b2lkIHNldEZpbGVEZXNjcmlwdG9yRGF0YShJRGF0YU9iamVjdCogZGF0YU9iamVjdCwg aW50IHNpemUsIGNvbnN0IFN0cmluZyYgcGF0aG5hbWUpCiB7CiAgICAgU1RHTUVESVVNIG1lZGl1 bSA9IHsgMCB9OwogICAgIG1lZGl1bS50eW1lZCA9IFRZTUVEX0hHTE9CQUw7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vQ2xpcGJvYXJkVXRpbGl0aWVzV2luLmggYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vQ2xpcGJvYXJkVXRpbGl0aWVzV2luLmgKaW5kZXgg M2QzNTRlMzRlMDM4YWU3NDhiNTI4MzczMjBkNWEyMDRjZmZiYWVlYy4uNzUwMWQ1NmYxN2ZkNzIw MjkxNGZlYWNlNWE0NWI4MDJiYzYzOTQ3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vd2luL0NsaXBib2FyZFV0aWxpdGllc1dpbi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL3dpbi9DbGlwYm9hcmRVdGlsaXRpZXNXaW4uaApAQCAtODAsNyArODAsNyBAQCB2b2lk IGdldENsaXBib2FyZERhdGEoSURhdGFPYmplY3QqLCBGT1JNQVRFVEMqIGZldGMsIFZlY3RvcjxT dHJpbmc+JiBkYXRhU3RyaW5ncwogdm9pZCBzZXRDbGlwYm9hcmREYXRhKElEYXRhT2JqZWN0Kiwg VUlOVCBmb3JtYXQsIGNvbnN0IFZlY3RvcjxTdHJpbmc+JiBkYXRhU3RyaW5ncyk7CiB2b2lkIGdl dEZpbGVEZXNjcmlwdG9yRGF0YShJRGF0YU9iamVjdCosIGludCYgc2l6ZSwgU3RyaW5nJiBwYXRo bmFtZSk7CiB2b2lkIGdldEZpbGVDb250ZW50RGF0YShJRGF0YU9iamVjdCosIGludCBzaXplLCB2 b2lkKiBkYXRhQmxvYik7Ci12b2lkIHNldEZpbGVEZXNjcmlwdG9yRGF0YShJRGF0YU9iamVjdCos IGludCBzaXplLCBTdHJpbmcgcGF0aG5hbWUpOwordm9pZCBzZXRGaWxlRGVzY3JpcHRvckRhdGEo SURhdGFPYmplY3QqLCBpbnQgc2l6ZSwgY29uc3QgU3RyaW5nJiBwYXRobmFtZSk7CiB2b2lkIHNl dEZpbGVDb250ZW50RGF0YShJRGF0YU9iamVjdCosIGludCBzaXplLCB2b2lkKiBkYXRhQmxvYik7 CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N0 b3JhZ2UvRGF0YWJhc2VUcmFja2VyLmggYi9Tb3VyY2UvV2ViQ29yZS9zdG9yYWdlL0RhdGFiYXNl VHJhY2tlci5oCmluZGV4IDY4OGEwNmYwMjVmMTJkNzUyYTBjODhiZjhkNTI3NDJhZTUxMDY5OGUu LjIxY2NjYmU5NDQwNzMyYmYyYzk2ZGRmZmYwMTc2ZmJiZDdjNTBkMzEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3N0b3JhZ2UvRGF0YWJhc2VUcmFja2VyLmgKKysrIGIvU291cmNlL1dlYkNv cmUvc3RvcmFnZS9EYXRhYmFzZVRyYWNrZXIuaApAQCAtMTczLDcgKzE3Myw3IEBAIHByaXZhdGU6 CiAgICAgc3RhdGljIHZvaWQgbm90aWZ5RGF0YWJhc2VzQ2hhbmdlZCh2b2lkKik7CiAjZWxzZQog cHVibGljOgotICAgIHZvaWQgZ2V0T3BlbkRhdGFiYXNlcyhTdHJpbmcgb3JpZ2luSWRlbnRpZmll ciwgY29uc3QgU3RyaW5nJiBuYW1lLCBIYXNoU2V0PFJlZlB0cjxBYnN0cmFjdERhdGFiYXNlPiA+ KiBkYXRhYmFzZXMpOworICAgIHZvaWQgZ2V0T3BlbkRhdGFiYXNlcyhjb25zdCBTdHJpbmcmIG9y aWdpbklkZW50aWZpZXIsIGNvbnN0IFN0cmluZyYgbmFtZSwgSGFzaFNldDxSZWZQdHI8QWJzdHJh Y3REYXRhYmFzZT4gPiogZGF0YWJhc2VzKTsKIAogcHJpdmF0ZToKICAgICB0eXBlZGVmIEhhc2hT ZXQ8QWJzdHJhY3REYXRhYmFzZSo+IERhdGFiYXNlU2V0OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvc3RvcmFnZS9JREJMZXZlbERCQmFja2luZ1N0b3JlLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3N0b3JhZ2UvSURCTGV2ZWxEQkJhY2tpbmdTdG9yZS5jcHAKaW5kZXggZmRiMjUxMTExMzc0YTI5 MzEzY2JmNWY2ZWI2N2VlYzUyMGE5ZjNiYy4uMjZiOTk2NWMzYzYzM2Y0OWQxZTM1OTM1YWY4Yjcy MjhmOTYwNjQ5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3RvcmFnZS9JREJMZXZlbERC QmFja2luZ1N0b3JlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdG9yYWdlL0lEQkxldmVsREJC YWNraW5nU3RvcmUuY3BwCkBAIC0xMTUsNyArMTE1LDcgQEAgc3RhdGljIGJvb2wgc2V0VXBNZXRh ZGF0YShMZXZlbERCRGF0YWJhc2UqIGRiKQogICAgIHJldHVybiB0cnVlOwogfQogCi1JREJMZXZl bERCQmFja2luZ1N0b3JlOjpJREJMZXZlbERCQmFja2luZ1N0b3JlKFN0cmluZyBpZGVudGlmaWVy LCBJREJGYWN0b3J5QmFja2VuZEltcGwqIGZhY3RvcnksIFBhc3NPd25QdHI8TGV2ZWxEQkRhdGFi YXNlPiBkYikKK0lEQkxldmVsREJCYWNraW5nU3RvcmU6OklEQkxldmVsREJCYWNraW5nU3RvcmUo Y29uc3QgU3RyaW5nJiBpZGVudGlmaWVyLCBJREJGYWN0b3J5QmFja2VuZEltcGwqIGZhY3Rvcnks IFBhc3NPd25QdHI8TGV2ZWxEQkRhdGFiYXNlPiBkYikKICAgICA6IG1faWRlbnRpZmllcihpZGVu dGlmaWVyKQogICAgICwgbV9mYWN0b3J5KGZhY3RvcnkpCiAgICAgLCBtX2RiKGRiKQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvc3RvcmFnZS9JREJMZXZlbERCQmFja2luZ1N0b3JlLmggYi9T b3VyY2UvV2ViQ29yZS9zdG9yYWdlL0lEQkxldmVsREJCYWNraW5nU3RvcmUuaAppbmRleCBkZjBh ZWRkMDEyNzcyMGUyZDJjOTA5NzA0ZWY1NWU4ZjI5NjMzYTgyLi4zMThjNDI2OWJlMjdhMjc4YmY5 YjM3M2UyNDRhNGIzYjFmNzQ3MjM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9zdG9yYWdl L0lEQkxldmVsREJCYWNraW5nU3RvcmUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdG9yYWdlL0lE QkxldmVsREJCYWNraW5nU3RvcmUuaApAQCAtNzksNyArNzksNyBAQCBwdWJsaWM6CiAgICAgc3Rh dGljIGJvb2wgYmFja2luZ1N0b3JlRXhpc3RzKFNlY3VyaXR5T3JpZ2luKiwgY29uc3QgU3RyaW5n JiBwYXRoQmFzZSk7CiAKIHByaXZhdGU6Ci0gICAgSURCTGV2ZWxEQkJhY2tpbmdTdG9yZShTdHJp bmcgaWRlbnRpZmllciwgSURCRmFjdG9yeUJhY2tlbmRJbXBsKiwgUGFzc093blB0cjxMZXZlbERC RGF0YWJhc2U+KTsKKyAgICBJREJMZXZlbERCQmFja2luZ1N0b3JlKGNvbnN0IFN0cmluZyYgaWRl bnRpZmllciwgSURCRmFjdG9yeUJhY2tlbmRJbXBsKiwgUGFzc093blB0cjxMZXZlbERCRGF0YWJh c2U+KTsKIAogICAgIFN0cmluZyBtX2lkZW50aWZpZXI7CiAgICAgUmVmUHRyPElEQkZhY3RvcnlC YWNrZW5kSW1wbD4gbV9mYWN0b3J5OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvc3RvcmFn ZS9JREJTUUxpdGVCYWNraW5nU3RvcmUuY3BwIGIvU291cmNlL1dlYkNvcmUvc3RvcmFnZS9JREJT UUxpdGVCYWNraW5nU3RvcmUuY3BwCmluZGV4IDJjNDhmMGVhYWNiODU2MGE0NjM0OTViYTg0ZjFh MWZlZWY1NDAzYTUuLmEzYzdiZTljNGU4NDE0NDk4MWEwOTk4OGVjZjY3NTIxOGJmN2QyMTIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvSURCU1FMaXRlQmFja2luZ1N0b3JlLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdG9yYWdlL0lEQlNRTGl0ZUJhY2tpbmdTdG9yZS5jcHAK QEAgLTM5LDcgKzM5LDcgQEAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCi1JREJTUUxpdGVCYWNr aW5nU3RvcmU6OklEQlNRTGl0ZUJhY2tpbmdTdG9yZShTdHJpbmcgaWRlbnRpZmllciwgSURCRmFj dG9yeUJhY2tlbmRJbXBsKiBmYWN0b3J5KQorSURCU1FMaXRlQmFja2luZ1N0b3JlOjpJREJTUUxp dGVCYWNraW5nU3RvcmUoY29uc3QgU3RyaW5nJiBpZGVudGlmaWVyLCBJREJGYWN0b3J5QmFja2Vu ZEltcGwqIGZhY3RvcnkpCiAgICAgOiBtX2lkZW50aWZpZXIoaWRlbnRpZmllcikKICAgICAsIG1f ZmFjdG9yeShmYWN0b3J5KQogewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvc3RvcmFnZS9J REJTUUxpdGVCYWNraW5nU3RvcmUuaCBiL1NvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvSURCU1FMaXRl QmFja2luZ1N0b3JlLmgKaW5kZXggMjI4ZTI2N2QzYzBjNWIzNjhmNGY3YWUyZjc2OWI4M2QyODM4 NzkwYi4uNTNjOTI3OTFmZDJmNmQzNDMwYmVjY2YzODg2NTlmMmZhMTFiODAzZiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvc3RvcmFnZS9JREJTUUxpdGVCYWNraW5nU3RvcmUuaAorKysgYi9T b3VyY2UvV2ViQ29yZS9zdG9yYWdlL0lEQlNRTGl0ZUJhY2tpbmdTdG9yZS5oCkBAIC03NCw3ICs3 NCw3IEBAIHB1YmxpYzoKICAgICBzdGF0aWMgYm9vbCBiYWNraW5nU3RvcmVFeGlzdHMoU2VjdXJp dHlPcmlnaW4qLCBjb25zdCBTdHJpbmcmIHBhdGhCYXNlKTsKIAogcHJpdmF0ZToKLSAgICBJREJT UUxpdGVCYWNraW5nU3RvcmUoU3RyaW5nIGlkZW50aWZpZXIsIElEQkZhY3RvcnlCYWNrZW5kSW1w bCopOworICAgIElEQlNRTGl0ZUJhY2tpbmdTdG9yZShjb25zdCBTdHJpbmcmIGlkZW50aWZpZXIs IElEQkZhY3RvcnlCYWNrZW5kSW1wbCopOwogCiAgICAgU1FMaXRlRGF0YWJhc2UgbV9kYjsKICAg ICBTdHJpbmcgbV9pZGVudGlmaWVyOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvc3RvcmFn ZS9jaHJvbWl1bS9EYXRhYmFzZVRyYWNrZXJDaHJvbWl1bS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9z dG9yYWdlL2Nocm9taXVtL0RhdGFiYXNlVHJhY2tlckNocm9taXVtLmNwcAppbmRleCA4ZGJjNzky M2FmMzhiZmI4NmJiYjgyODRmZjVmMTZiYWNhMTI5MTk1Li5mZDI3NGZmNzhlMzk5YTA3ZmRjODBm YzE3ZDU4MGYyZTg0OTcwZDQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9zdG9yYWdlL2No cm9taXVtL0RhdGFiYXNlVHJhY2tlckNocm9taXVtLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9z dG9yYWdlL2Nocm9taXVtL0RhdGFiYXNlVHJhY2tlckNocm9taXVtLmNwcApAQCAtMTUyLDcgKzE1 Miw3IEBAIHZvaWQgRGF0YWJhc2VUcmFja2VyOjpnZXRPcGVuRGF0YWJhc2VzKFNlY3VyaXR5T3Jp Z2luKiBvcmlnaW4sIGNvbnN0IFN0cmluZyYgbmFtCiAgICAgZ2V0T3BlbkRhdGFiYXNlcyhvcmln aW4tPmRhdGFiYXNlSWRlbnRpZmllcigpLCBuYW1lLCBkYXRhYmFzZXMpOwogfQogCi12b2lkIERh dGFiYXNlVHJhY2tlcjo6Z2V0T3BlbkRhdGFiYXNlcyhTdHJpbmcgb3JpZ2luSWRlbnRpZmllciwg Y29uc3QgU3RyaW5nJiBuYW1lLCBIYXNoU2V0PFJlZlB0cjxBYnN0cmFjdERhdGFiYXNlPiA+KiBk YXRhYmFzZXMpCit2b2lkIERhdGFiYXNlVHJhY2tlcjo6Z2V0T3BlbkRhdGFiYXNlcyhjb25zdCBT dHJpbmcmIG9yaWdpbklkZW50aWZpZXIsIGNvbnN0IFN0cmluZyYgbmFtZSwgSGFzaFNldDxSZWZQ dHI8QWJzdHJhY3REYXRhYmFzZT4gPiogZGF0YWJhc2VzKQogewogICAgIE11dGV4TG9ja2VyIG9w ZW5EYXRhYmFzZU1hcExvY2sobV9vcGVuRGF0YWJhc2VNYXBHdWFyZCk7CiAgICAgaWYgKCFtX29w ZW5EYXRhYmFzZU1hcCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdQYWludC5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHUGFpbnQuY3BwCmluZGV4IDlhNzUzZThhYzc5YjEw YTAwMzFhNzM1ZDcxMGY3YjcyNzQzYWUwZjcuLjZiYzMzNzA4ZGU1OTc2YTI3YjMxNDNkOTQ5NWNi NDAwOWVjMjBhNWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdQYWludC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvc3ZnL1NWR1BhaW50LmNwcApAQCAtNTMsNyArNTMsNyBAQCBz dGF0aWMgaW5saW5lIFNWR0NvbG9yOjpTVkdDb2xvclR5cGUgY29sb3JUeXBlRm9yUGFpbnRUeXBl KGNvbnN0IFNWR1BhaW50OjpTVkdQYQogICAgIHJldHVybiBTVkdDb2xvcjo6U1ZHX0NPTE9SVFlQ RV9VTktOT1dOOwogfQogCi1TVkdQYWludDo6U1ZHUGFpbnQoY29uc3QgU1ZHUGFpbnRUeXBlJiBw YWludFR5cGUsIFN0cmluZyB1cmkpCitTVkdQYWludDo6U1ZHUGFpbnQoY29uc3QgU1ZHUGFpbnRU eXBlJiBwYWludFR5cGUsIGNvbnN0IFN0cmluZyYgdXJpKQogICAgIDogU1ZHQ29sb3IoY29sb3JU eXBlRm9yUGFpbnRUeXBlKHBhaW50VHlwZSkpCiAgICAgLCBtX3BhaW50VHlwZShwYWludFR5cGUp CiAgICAgLCBtX3VyaSh1cmkpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHUGFp bnQuaCBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdQYWludC5oCmluZGV4IDFiYzk3YzNlM2FmYjEw YzJhZWFiNTgxZWViNTJkMjVhNDgxODQyY2MuLmU1OTFjN2E4NzY5MGQ4YmMwMDY2NTlhMjE4MzE0 ODAyNDdlMzY1NTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdQYWludC5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdQYWludC5oCkBAIC0xMDQsNyArMTA0LDcgQEAgcHJp dmF0ZToKICAgICB9CiAKIHByaXZhdGU6Ci0gICAgU1ZHUGFpbnQoY29uc3QgU1ZHUGFpbnRUeXBl JiwgU3RyaW5nIHVyaSA9IFN0cmluZygpKTsKKyAgICBTVkdQYWludChjb25zdCBTVkdQYWludFR5 cGUmLCBjb25zdCBTdHJpbmcmIHVyaSA9IFN0cmluZygpKTsKIAogICAgIHZpcnR1YWwgYm9vbCBp c1NWR1BhaW50KCkgY29uc3QgeyByZXR1cm4gdHJ1ZTsgfQogICAgIHZpcnR1YWwgU3RyaW5nIGNz c1RleHQoKSBjb25zdDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9hbmltYXRpb24v U01JTFRpbWVDb250YWluZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvc3ZnL2FuaW1hdGlvbi9TTUlM VGltZUNvbnRhaW5lci5jcHAKaW5kZXggNjIwYmEzMjVlMDM4YTkwMWZlMTczZGI1YWE3NDc0Yzdm ZTg2ODEzNC4uZTliYjM4YWViMTA0ZTI0MDY0ZmMxYWQ4ODI4ODNlYTZmN2UxNDkwOSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvc3ZnL2FuaW1hdGlvbi9TTUlMVGltZUNvbnRhaW5lci5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvc3ZnL2FuaW1hdGlvbi9TTUlMVGltZUNvbnRhaW5lci5jcHAK QEAgLTIxOSw3ICsyMTksNyBAQCB2b2lkIFNNSUxUaW1lQ29udGFpbmVyOjpzYW1wbGVBbmltYXRp b25BdFRpbWUoY29uc3QgU3RyaW5nJiBlbGVtZW50SWQsIGRvdWJsZSBuZQogICAgIHVwZGF0ZUFu aW1hdGlvbnMoZWxhcHNlZCgpLCBuZXdUaW1lLCBlbGVtZW50SWQpOwogfQogCi12b2lkIFNNSUxU aW1lQ29udGFpbmVyOjp1cGRhdGVBbmltYXRpb25zKFNNSUxUaW1lIGVsYXBzZWQsIGRvdWJsZSBu ZXh0TWFudWFsU2FtcGxlVGltZSwgU3RyaW5nIG5leHRTYW1wbGluZ1RhcmdldCkKK3ZvaWQgU01J TFRpbWVDb250YWluZXI6OnVwZGF0ZUFuaW1hdGlvbnMoU01JTFRpbWUgZWxhcHNlZCwgZG91Ymxl IG5leHRNYW51YWxTYW1wbGVUaW1lLCBjb25zdCBTdHJpbmcmIG5leHRTYW1wbGluZ1RhcmdldCkK IHsKICAgICBTTUlMVGltZSBlYXJsaWVyc0ZpcmVUaW1lID0gU01JTFRpbWU6OnVucmVzb2x2ZWQo KTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvc3ZnL2FuaW1hdGlvbi9TTUlMVGltZUNv bnRhaW5lci5oIGIvU291cmNlL1dlYkNvcmUvc3ZnL2FuaW1hdGlvbi9TTUlMVGltZUNvbnRhaW5l ci5oCmluZGV4IDM0MjM3ZjExYmEyMmM3YjZhZWM1ZjNlYmJlZjE1YTdhN2Y2MGY2ZGEuLjcwMDg1 MDhmMmU5ZmRmMjA3ZDJkMTcwNTM3MjVjZWNhMWMyNTRkZDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3N2Zy9hbmltYXRpb24vU01JTFRpbWVDb250YWluZXIuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9zdmcvYW5pbWF0aW9uL1NNSUxUaW1lQ29udGFpbmVyLmgKQEAgLTcwLDcgKzcwLDcgQEAg cHJpdmF0ZToKICAgICAKICAgICB2b2lkIHRpbWVyRmlyZWQoVGltZXI8U01JTFRpbWVDb250YWlu ZXI+Kik7CiAgICAgdm9pZCBzdGFydFRpbWVyKFNNSUxUaW1lIGZpcmVUaW1lLCBTTUlMVGltZSBt aW5pbXVtRGVsYXkgPSAwKTsKLSAgICB2b2lkIHVwZGF0ZUFuaW1hdGlvbnMoU01JTFRpbWUgZWxh cHNlZCwgZG91YmxlIG5leHRNYW51YWxTYW1wbGVUaW1lID0gMCwgU3RyaW5nIG5leHRTYW1wbGlu Z1RhcmdldCA9IFN0cmluZygpKTsKKyAgICB2b2lkIHVwZGF0ZUFuaW1hdGlvbnMoU01JTFRpbWUg ZWxhcHNlZCwgZG91YmxlIG5leHRNYW51YWxTYW1wbGVUaW1lID0gMCwgY29uc3QgU3RyaW5nJiBu ZXh0U2FtcGxpbmdUYXJnZXQgPSBTdHJpbmcoKSk7CiAgICAgCiAgICAgdm9pZCB1cGRhdGVEb2N1 bWVudE9yZGVySW5kZXhlcygpOwogICAgIHZvaWQgc29ydEJ5UHJpb3JpdHkoVmVjdG9yPFNWR1NN SUxFbGVtZW50Kj4mIHNtaWxFbGVtZW50cywgU01JTFRpbWUgZWxhcHNlZCk7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS93ZWJzb2NrZXRzL1RocmVhZGFibGVXZWJTb2NrZXRDaGFubmVsQ2xp ZW50V3JhcHBlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS93ZWJzb2NrZXRzL1RocmVhZGFibGVXZWJT b2NrZXRDaGFubmVsQ2xpZW50V3JhcHBlci5jcHAKaW5kZXggMmQ2ODI3OTNiM2IyZDFkNmMwYTUz NmZhNTFhOTQxY2JjYTljNGYxZi4uNzQwMjQ4MjNjY2VhYmYwMjZiNzI1NGExMjIzNTU1ZjdmNTM3 MGUwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvd2Vic29ja2V0cy9UaHJlYWRhYmxlV2Vi U29ja2V0Q2hhbm5lbENsaWVudFdyYXBwZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3dlYnNv Y2tldHMvVGhyZWFkYWJsZVdlYlNvY2tldENoYW5uZWxDbGllbnRXcmFwcGVyLmNwcApAQCAtMTUx LDcgKzE1MSw3IEBAIHZvaWQgVGhyZWFkYWJsZVdlYlNvY2tldENoYW5uZWxDbGllbnRXcmFwcGVy OjpkaWRDb25uZWN0Q2FsbGJhY2soU2NyaXB0RXhlY3V0aW9uCiAgICAgICAgIHdyYXBwZXItPm1f Y2xpZW50LT5kaWRDb25uZWN0KCk7CiB9CiAKLXZvaWQgVGhyZWFkYWJsZVdlYlNvY2tldENoYW5u ZWxDbGllbnRXcmFwcGVyOjpkaWRSZWNlaXZlTWVzc2FnZUNhbGxiYWNrKFNjcmlwdEV4ZWN1dGlv bkNvbnRleHQqIGNvbnRleHQsIFRocmVhZGFibGVXZWJTb2NrZXRDaGFubmVsQ2xpZW50V3JhcHBl ciogd3JhcHBlciwgU3RyaW5nIG1lc3NhZ2UpCit2b2lkIFRocmVhZGFibGVXZWJTb2NrZXRDaGFu bmVsQ2xpZW50V3JhcHBlcjo6ZGlkUmVjZWl2ZU1lc3NhZ2VDYWxsYmFjayhTY3JpcHRFeGVjdXRp b25Db250ZXh0KiBjb250ZXh0LCBUaHJlYWRhYmxlV2ViU29ja2V0Q2hhbm5lbENsaWVudFdyYXBw ZXIqIHdyYXBwZXIsIGNvbnN0IFN0cmluZyYgbWVzc2FnZSkKIHsKICAgICBBU1NFUlRfVU5VU0VE KGNvbnRleHQsICFjb250ZXh0KTsKICAgICBpZiAod3JhcHBlci0+bV9jbGllbnQpCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS93ZWJzb2NrZXRzL1RocmVhZGFibGVXZWJTb2NrZXRDaGFubmVs Q2xpZW50V3JhcHBlci5oIGIvU291cmNlL1dlYkNvcmUvd2Vic29ja2V0cy9UaHJlYWRhYmxlV2Vi U29ja2V0Q2hhbm5lbENsaWVudFdyYXBwZXIuaAppbmRleCBiMmI0YmIyM2U3MzYwMjNkNzQ2N2U0 NWI0NjI1ZmQ1YzlkMmRjZTcxLi5lZDhiY2U0NzVhZTE5MjAwYjc5NWYyNDdmMTEyZDRmNDVmMWIw ZTk0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS93ZWJzb2NrZXRzL1RocmVhZGFibGVXZWJT b2NrZXRDaGFubmVsQ2xpZW50V3JhcHBlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3dlYnNvY2tl dHMvVGhyZWFkYWJsZVdlYlNvY2tldENoYW5uZWxDbGllbnRXcmFwcGVyLmgKQEAgLTc0LDcgKzc0 LDcgQEAgcHJvdGVjdGVkOgogCiAgICAgdm9pZCBwcm9jZXNzUGVuZGluZ1Rhc2tzKCk7CiAgICAg c3RhdGljIHZvaWQgZGlkQ29ubmVjdENhbGxiYWNrKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqLCBU aHJlYWRhYmxlV2ViU29ja2V0Q2hhbm5lbENsaWVudFdyYXBwZXIqKTsKLSAgICBzdGF0aWMgdm9p ZCBkaWRSZWNlaXZlTWVzc2FnZUNhbGxiYWNrKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqLCBUaHJl YWRhYmxlV2ViU29ja2V0Q2hhbm5lbENsaWVudFdyYXBwZXIqLCBTdHJpbmcgbWVzc2FnZSk7Cisg ICAgc3RhdGljIHZvaWQgZGlkUmVjZWl2ZU1lc3NhZ2VDYWxsYmFjayhTY3JpcHRFeGVjdXRpb25D b250ZXh0KiwgVGhyZWFkYWJsZVdlYlNvY2tldENoYW5uZWxDbGllbnRXcmFwcGVyKiwgY29uc3Qg U3RyaW5nJiBtZXNzYWdlKTsKICAgICBzdGF0aWMgdm9pZCBkaWRTdGFydENsb3NpbmdIYW5kc2hh a2VDYWxsYmFjayhTY3JpcHRFeGVjdXRpb25Db250ZXh0KiwgVGhyZWFkYWJsZVdlYlNvY2tldENo YW5uZWxDbGllbnRXcmFwcGVyKik7CiAgICAgc3RhdGljIHZvaWQgZGlkQ2xvc2VDYWxsYmFjayhT Y3JpcHRFeGVjdXRpb25Db250ZXh0KiwgVGhyZWFkYWJsZVdlYlNvY2tldENoYW5uZWxDbGllbnRX cmFwcGVyKiwgdW5zaWduZWQgbG9uZyB1bmhhbmRsZWRCdWZmZXJlZEFtb3VudCwgV2ViU29ja2V0 Q2hhbm5lbENsaWVudDo6Q2xvc2luZ0hhbmRzaGFrZUNvbXBsZXRpb25TdGF0dXMpOwogCg==