63323 2011-06-24 07:50:51 -0700 Make <video> app cache test exit immediately on failure 2011-06-24 09:01:31 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 eric.carlson eric.carlson ap oldest_to_newest 426882 0 eric.carlson 2011-06-24 07:50:51 -0700 One of the conditions tested by http/tests/appcache/video.html is setting the video element's src to a JavaScript file included in the manifest to test the handling of a non-media resource from the manifest. This is the last condition tested so the test ends when an 'error' event is be posted, but if the media engine loads the JavaScript file "successfully" the test enters an infinite loop continues until the DRT watchdog timer kills it. 426885 1 98493 eric.carlson 2011-06-24 08:10:12 -0700 Created attachment 98493 Proposed patch. 426900 2 98493 ap 2011-06-24 08:50:28 -0700 Comment on attachment 98493 Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=98493&action=review > LayoutTests/http/tests/appcache/video.html:46 > + failTest("<br>Loaded file JavaScript file as media!"); Extra "file" here. 426910 3 eric.carlson 2011-06-24 09:01:31 -0700 http://trac.webkit.org/changeset/89676 98493 2011-06-24 08:10:12 -0700 2011-06-24 08:50:28 -0700 Proposed patch. patch_test_1.txt text/plain 2641 eric.carlson SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDg5NjcyKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDYtMjQgIEVyaWMgQ2FybHNvbiAgPGVy aWMuY2FybHNvbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisgICAgICAgIAorICAgICAgICBFeGl0IGltbWVkaWF0ZWx5IGlmIHRoZSBsYXN0IGNvbmRp dGlvbiB0ZXN0ZWQgZmFpbHMuCisKKyAgICAgICAgTWFrZSA8dmlkZW8+IGFwcCBjYWNoZSB0ZXN0 IGV4aXQgaW1tZWRpYXRlbHkgb24gZmFpbHVyZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjMzMjMKKwogMjAxMS0wNi0yNCAgQ3NhYmEgT3N6dHJvZ29u w6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtRdF1bV0syXSBmYXN0L2ZyYW1lcy9p ZnJhbWUtcGx1Z2luLWxvYWQtcmVtb3ZlLWRvY3VtZW50LWNyYXNoLmh0bWwgY3Jhc2hlcwpJbmRl eDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9hcHBjYWNoZS92aWRlby5odG1sCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL2h0dHAvdGVzdHMvYXBwY2FjaGUvdmlkZW8uaHRtbAkocmV2aXNpb24g ODk0MzIpCisrKyBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2FwcGNhY2hlL3ZpZGVvLmh0bWwJKHdv cmtpbmcgY29weSkKQEAgLTIxLDggKzIxLDcgQEAKICAgICAgICAgICAgICAgICBzd2l0Y2godGVz dCkKICAgICAgICAgICAgICAgICB7CiAgICAgICAgICAgICAgICAgICAgIGNhc2UgMToKLSAgICAg ICAgICAgICAgICAgICAgICAgIGxvZ1Jlc3VsdChmYWxzZSwgIkZhaWxlZCBsb2FkaW5nIGZpbGUg aW5jbHVkZWQgaW4gbWFuaWZlc3QhIik7Ci0gICAgICAgICAgICAgICAgICAgICAgICBlbmRUZXN0 KCk7CisgICAgICAgICAgICAgICAgICAgICAgICBmYWlsVGVzdChmYWxzZSwgIkZhaWxlZCBsb2Fk aW5nIGZpbGUgaW5jbHVkZWQgaW4gbWFuaWZlc3QhIik7CiAgICAgICAgICAgICAgICAgICAgICAg ICBicmVhazsKICAgICAgICAgICAgICAgICAgICAgY2FzZSAyOgogICAgICAgICAgICAgICAgICAg ICAgICAgdGVzdDMoKQpAQCAtMzMsNiArMzIsMjIgQEAKICAgICAgICAgICAgICAgICB9CiAgICAg ICAgICAgICB9CiAKKyAgICAgICAgICAgIGZ1bmN0aW9uIGR1cmF0aW9uY2hhbmdlRXZlbnQoKQor ICAgICAgICAgICAgeworICAgICAgICAgICAgICAgIHN3aXRjaCh0ZXN0KQorICAgICAgICAgICAg ICAgIHsKKyAgICAgICAgICAgICAgICAgICAgY2FzZSAxOgorICAgICAgICAgICAgICAgICAgICAg ICAgdGVzdDIoKTsKKyAgICAgICAgICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAg ICAgICAgICBjYXNlIDI6CisgICAgICAgICAgICAgICAgICAgICAgICBmYWlsVGVzdCgiPGJyPkxv YWRlZCBmaWxlIE5PVCBpbmNsdWRlZCBpbiBtYW5pZmVzdCEiKTsKKyAgICAgICAgICAgICAgICAg ICAgICAgIGJyZWFrOworICAgICAgICAgICAgICAgICAgICBjYXNlIDM6CisgICAgICAgICAgICAg ICAgICAgICAgICBmYWlsVGVzdCgiPGJyPkxvYWRlZCBmaWxlIEphdmFTY3JpcHQgZmlsZSBhcyBt ZWRpYSEiKTsKKyAgICAgICAgICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAgICAg IH0KKyAgICAgICAgICAgIH0KKwogICAgICAgICAgICAgZnVuY3Rpb24gdGVzdDMoKQogICAgICAg ICAgICAgewogICAgICAgICAgICAgICAgIGNvbnNvbGVXcml0ZSgiKioqIFNldHRpbmcgJ3NyYycg dG8gbm9uLW1lZGlhIGZpbGUgdGhhdCBpcyBpbiBtYW5pZmVzdC4gVGhpcyBmaWxlIHNob3VsZCBm YWlsIHRvIGxvYWQuPGJyPiIpOwpAQCAtNTEsMTggKzY2LDYgQEAKICAgICAgICAgICAgICAgICB2 aWRlby5zcmMgPSAiL21lZGlhLXJlc291cmNlcy9jb250ZW50LyIgKyBmaW5kTWVkaWFGaWxlKCJh dWRpbyIsICJzaWxlbmNlIik7CiAgICAgICAgICAgICB9CiAKLSAgICAgICAgICAgIGZ1bmN0aW9u IGR1cmF0aW9uY2hhbmdlRXZlbnQoKQotICAgICAgICAgICAgewotICAgICAgICAgICAgICAgIGlm ICh0ZXN0ID09IDIpIHsKLSAgICAgICAgICAgICAgICAgICAgbG9nUmVzdWx0KGZhbHNlLCAiPGJy PkxvYWRlZCBmaWxlIE5PVCBpbmNsdWRlZCBpbiBtYW5pZmVzdCEiKTsKLSAgICAgICAgICAgICAg ICAgICAgY29uc29sZVdyaXRlKCIiKTsKLSAgICAgICAgICAgICAgICAgICAgZW5kVGVzdCgpOwot ICAgICAgICAgICAgICAgICAgICByZXR1cm47Ci0gICAgICAgICAgICAgICAgfQotCi0gICAgICAg ICAgICAgICAgdGVzdDIoKTsKLSAgICAgICAgICAgIH0KLQogICAgICAgICAgICAgZnVuY3Rpb24g dGVzdDEoKQogICAgICAgICAgICAgewogICAgICAgICAgICAgICAgIGNvbnNvbGVXcml0ZSgiKioq IFNldHRpbmcgJ3NyYycgdG8gZmlsZSBzcGVjaWZpZWQgaW4gbWFuaWZlc3QuIFRoaXMgZmlsZSBz aG91bGQgbG9hZC48YnI+Iik7Cg==