63321 2011-06-24 07:13:08 -0700 [WK2] fast/frames/iframe-plugin-load-remove-document-crash.html crashes 2011-11-28 01:17:41 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED LayoutTestFailure P1 Major --- 1 ossy kbalazs andersca hausmann kbalazs ossy zoltan oldest_to_newest 426873 0 ossy 2011-06-24 07:13:08 -0700 stderr: Xlib: extension "RANDR" missing on display ":7.0". 426875 1 ossy 2011-06-24 07:16:09 -0700 Skipped by http://trac.webkit.org/changeset/89672 427866 2 kbalazs 2011-06-27 05:31:24 -0700 Remove [Qt] since it seems to be a common bug that somehow only appears on Qt. 427867 3 98706 kbalazs 2011-06-27 05:34:47 -0700 Created attachment 98706 Patch 427868 4 kbalazs 2011-06-27 05:35:28 -0700 I am still trying to find out why it is only appearing on Qt. 427873 5 kbalazs 2011-06-27 05:40:23 -0700 The null check is consistent with WebKit1: void PluginView::didFail(const ResourceError& error) { if (m_status != PluginStatusLoadedSuccessfully) return; ASSERT(m_loadManually); if (m_manualStream) <- !!! m_manualStream->didFail(0, error); } 456710 6 kbalazs 2011-08-25 01:38:01 -0700 ping 509616 7 98706 hausmann 2011-11-28 00:19:18 -0800 Comment on attachment 98706 Patch r=me. I guess the test only fails in debug builds? (which is why we don't see it on the bots and this patch doesn't affect the skiplist?) 509617 8 hausmann 2011-11-28 00:21:20 -0800 (In reply to comment #7) > (From update of attachment 98706 [details]) > r=me. I guess the test only fails in debug builds? (which is why we don't see it on the bots and this patch doesn't affect the skiplist?) Ohh, it looks like Ossy skipped it in http://trac.webkit.org/changeset/89672 . Please land this patch together with unskip. 509635 9 kbalazs 2011-11-28 01:12:07 -0800 Committed r101232: <http://trac.webkit.org/changeset/101232> 98706 2011-06-27 05:34:47 -0700 2011-11-28 01:17:41 -0800 Patch bug-63321-20110627123445.patch text/plain 1487 kbalazs U3VidmVyc2lvbiBSZXZpc2lvbjogODk3NDgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA4YjI1NjZjMTQ4MGNhN2Zi ZWI3YzUzODNiZDI1Nzk0YzZlNmFmNjZhLi44ZDY0OTVkN2VjODg1NjIyMzc3Y2JlZGVkZmZhYmVk ZTZjZjM0ZmU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDYtMjcgIEJhbGF6 cyBLZWxlbWVuICA8a2JhbGF6c0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtXSzJdIGZhc3QvZnJhbWVzL2lmcmFtZS1wbHVnaW4t bG9hZC1yZW1vdmUtZG9jdW1lbnQtY3Jhc2guaHRtbCBjcmFzaGVzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MzMyMQorCisgICAgICAgICogV2ViUHJv Y2Vzcy9QbHVnaW5zL05ldHNjYXBlL05ldHNjYXBlUGx1Z2luLmNwcDoKKyAgICAgICAgKFdlYktp dDo6TmV0c2NhcGVQbHVnaW46Om1hbnVhbFN0cmVhbURpZEZhaWwpOiBEb24ndCBhc3NlcnQgdGhh dCBtX21hbnVhbFN0cmVhbQorICAgICAgICBpcyBub3QgbnVsbCBzaW5jZSBpdCBpcyBub3QgZ3Vh cmFudGVlZCBidXQgaW5zdGVhZCBoYW5kbGUgdGhlIGNhc2Ugd2hlbiBpdCBpcyBudWxsCisgICAg ICAgIHdpdGggZWFybHkgcmV0dXJuLgorCiAyMDExLTA2LTIzICBCYWxhenMgS2VsZW1lbiAgPGti YWxhenNAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9O ZXRzY2FwZVBsdWdpbi5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0 c2NhcGUvTmV0c2NhcGVQbHVnaW4uY3BwCmluZGV4IGYwMDkzMjM5NGZkYzlmOWZhYjEzMTA4NzYx YzcyMzY0NTRhZTdmMjIuLmExMDQ0MTBiNDdmM2IwODFlOWE2ODU2NmRjM2I2M2Y4MDNkMWI4OWUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9O ZXRzY2FwZVBsdWdpbi5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5z L05ldHNjYXBlL05ldHNjYXBlUGx1Z2luLmNwcApAQCAtNjg0LDggKzY4NCw5IEBAIHZvaWQgTmV0 c2NhcGVQbHVnaW46Om1hbnVhbFN0cmVhbURpZEZhaWwoYm9vbCB3YXNDYW5jZWxsZWQpCiB7CiAg ICAgQVNTRVJUKG1faXNTdGFydGVkKTsKICAgICBBU1NFUlQobV9sb2FkTWFudWFsbHkpOwotICAg IEFTU0VSVChtX21hbnVhbFN0cmVhbSk7CiAKKyAgICBpZiAoIW1fbWFudWFsU3RyZWFtKQorICAg ICAgICByZXR1cm47CiAgICAgbV9tYW51YWxTdHJlYW0tPmRpZEZhaWwod2FzQ2FuY2VsbGVkKTsK IH0KIAo=