63318 2011-06-24 01:36:34 -0700 [GTK] Add more debug options to compilation 2011-06-27 01:55:05 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned pnormand oldest_to_newest 426789 0 cgarcia 2011-06-24 01:36:34 -0700 Currently --enable-debug option (used by debug builds) include the following: - Add -g flag to compile with debug symbols - Disable compiler optimizations - Disable fast malloc - Compile with deprecated flags - Other debug features: assertions enabled, some debug code, etc. Compiler optimizations and fast malloc can be enabled/disabled when debug is not enabled, but all other options depends directly on --enable-debug. The other day I wanted to debug and assertion, but I didn't want to build with debug symbols, because it's very slow, so I manually disabled debug symbols and I realized it's really useful to build with debug features enabled but without debug symbols. Martin suggested that building with debug symbols, but without debug features like assertions, would be useful too. So I think we could add options to enabled/disable debug symbols and all other debug features. 426790 1 98473 cgarcia 2011-06-24 01:42:36 -0700 Created attachment 98473 Patch The patch adds to options: - --enable-debug-symbols: whether to add -g or not - --enable-debug-features: whether to define NDEBUG macro and compile with deprecated flags or not Both options are unconditionally enabled for debug builds. 426863 2 98473 mrobinson 2011-06-24 06:46:05 -0700 Comment on attachment 98473 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98473&action=review > configure.ac:1238 > + Enable debug features : $enable_debug_features Should probably keep the (slow) tag here since it adds assertions and disables TCMalloc. 426905 3 cgarcia 2011-06-24 08:54:27 -0700 Committed r89675: <http://trac.webkit.org/changeset/89675> 427786 4 pnormand 2011-06-27 01:55:05 -0700 *** Bug 58773 has been marked as a duplicate of this bug. *** 98473 2011-06-24 01:42:36 -0700 2011-06-24 06:46:05 -0700 Patch configure-debug-options.diff text/plain 3600 cgarcia ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBjZjlmZGFiLi4yMWQ1ZjY4 IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAK KzIwMTEtMDYtMjQgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIEFk ZCBtb3JlIGRlYnVnIG9wdGlvbnMgdG8gY29tcGlsYXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYzMzE4CisKKyAgICAgICAgQWRkIC0tZW5hYmxl LWRlYnVnLXN5bWJvbHMgdG8gZW5hYmxlL2Rpc2FibGUgY29tcGlsYXRpb24gd2l0aAorICAgICAg ICBkZWJ1ZyBzeW1ib2xzIGFuZCAtLWVuYWJsZS1kZWJ1Zy1mZWF0dXJlcyB0byBlbmFibGUvZGlz YWJsZSBkZWJ1ZworICAgICAgICBmZWF0dXJlcy4gQm90aCBvcHRpb25zIGFyZSB1bmNvbmRpdGlv bmFsbHkgZW5hYmxlZCBmb3IgZGVidWcKKyAgICAgICAgYnVpbGRzLgorCisgICAgICAgICogY29u ZmlndXJlLmFjOgorCiAyMDExLTA2LTIzICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+ CiAKICAgICAgICAgUXQgYnVpbGQtZml4OiByZW1vdmUgd2FybmluZyB0aGF0IG5vIG90aGVyIHBs YXRmb3JtIGFwcGVhcnMgdG8gdXNlLgpkaWZmIC0tZ2l0IGEvY29uZmlndXJlLmFjIGIvY29uZmln dXJlLmFjCmluZGV4IGUwZmUxYzcuLjcwM2Y0OTUgMTAwNjQ0Ci0tLSBhL2NvbmZpZ3VyZS5hYwor KysgYi9jb25maWd1cmUuYWMKQEAgLTgxMiw2ICs4MTIsMjIgQEAgQUNfQVJHX0VOQUJMRShmYXN0 X21hbGxvYywKICAgICAgICAgICAgICAgW10sW2lmIHRlc3QgIiRlbmFibGVfZGVidWciID0gInll cyI7IHRoZW4gZW5hYmxlX2Zhc3RfbWFsbG9jPSJubyI7IGVsc2UgZW5hYmxlX2Zhc3RfbWFsbG9j PSJ5ZXMiOyBmaV0pCiBBQ19NU0dfUkVTVUxUKFskZW5hYmxlX2Zhc3RfbWFsbG9jXSkKIAorIyBj aGVjayB3aGV0aGVyIHRvIGVuYWJsZSBkZWJ1ZyBzeW1ib2xzCitBQ19NU0dfQ0hFQ0tJTkcoW3do ZXRoZXIgdG8gZW5hYmxlIGRlYnVnIHN5bWJvbHNdKQorQUNfQVJHX0VOQUJMRShkZWJ1Z19zeW1i b2xzLAorICAgICAgICAgICAgICBBQ19IRUxQX1NUUklORyhbLS1lbmFibGUtZGVidWctc3ltYm9s c10sCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFtlbmFibGUgZGVidWcgc3ltYm9scyBk ZWZhdWx0PW5vLCBkZWZhdWx0PXllcyBmb3IgZGVidWcgYnVpbGRzXSksCisgICAgICAgICAgICAg IFtdLFtpZiB0ZXN0ICIkZW5hYmxlX2RlYnVnIiA9ICJ5ZXMiOyB0aGVuIGVuYWJsZV9kZWJ1Z19z eW1ib2xzPSJ5ZXMiOyBlbHNlIGVuYWJsZV9kZWJ1Z19zeW1ib2xzPSJubyI7IGZpXSkKK0FDX01T R19SRVNVTFQoWyRlbmFibGVfZGVidWdfc3ltYm9sc10pCisKKyMgY2hlY2sgd2hldGhlciB0byBl bmFibGUgZGVidWcgZmVhdHVyZXMKK0FDX01TR19DSEVDS0lORyhbd2hldGhlciB0byBlbmFibGUg ZGVidWcgZmVhdHVyZXNdKQorQUNfQVJHX0VOQUJMRShkZWJ1Z19mZWF0dXJlcywKKyAgICAgICAg ICAgICAgQUNfSEVMUF9TVFJJTkcoWy0tZW5hYmxlLWRlYnVnLWZlYXR1cmVzXSwKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgW2VuYWJsZSBkZWJ1ZyBmZWF0dXJlcyBkZWZhdWx0PW5vLCBk ZWZhdWx0PXllcyBmb3IgZGVidWcgYnVpbGRzXSksCisgICAgICAgICAgICAgIFtdLFtpZiB0ZXN0 ICIkZW5hYmxlX2RlYnVnIiA9ICJ5ZXMiOyB0aGVuIGVuYWJsZV9kZWJ1Z19mZWF0dXJlcz0ieWVz IjsgZWxzZSBlbmFibGVfZGVidWdfZmVhdHVyZXM9Im5vIjsgZmldKQorQUNfTVNHX1JFU1VMVChb JGVuYWJsZV9kZWJ1Z19mZWF0dXJlc10pCisKIEFDX01TR19DSEVDS0lORyhbd2hldGhlciB0byBl bmFibGUgSklUIGNvbXBpbGF0aW9uXSkKIEFDX0FSR19FTkFCTEUoW2ppdF0sCiAgICAgICAgICAg ICAgIEFDX0hFTFBfU1RSSU5HKFstLWVuYWJsZS1qaXRdLApAQCAtOTUwLDExICs5NjYsMTMgQEAg aWYgdGVzdCAiJGhvc3RfY3B1IiA9ICJzaDQiOyB0aGVuCiAgICBDRkxBR1M9IiRDRkxBR1MgLW1p ZWVlIC13IgogZmkKIAotIyBBZGQgJy1nJyBmbGFnIHRvIGdjYyBpZiBpdCdzIGRlYnVnIGJ1aWxk Ci1pZiB0ZXN0ICIkZW5hYmxlX2RlYnVnIiA9ICJ5ZXMiOyB0aGVuCisjIEFkZCAnLWcnIGZsYWcg dG8gZ2NjIHRvIGJ1aWxkIHdpdGggZGVidWcgc3ltYm9scworaWYgdGVzdCAiJGVuYWJsZV9kZWJ1 Z19zeW1ib2xzIiA9ICJ5ZXMiOyB0aGVuCiAgICBDWFhGTEFHUz0iJENYWEZMQUdTIC1nIgogICAg Q0ZMQUdTPSIkQ0ZMQUdTIC1nIgotZWxzZQorZmkKKworaWYgdGVzdCAiJGVuYWJsZV9kZWJ1Z19m ZWF0dXJlcyIgPSAibm8iOyB0aGVuCiAgICBBQ19ERUZJTkUoW05ERUJVR10sIFsxXSwgW0RlZmlu ZSB0byBkaXNhYmxlIGRlYnVnZ2luZyBmZWF0dXJlc10pCiBmaQogCkBAIC0xMTEzLDcgKzExMzEs NyBAQCBBTV9DT05ESVRJT05BTChbVVNFX1BBTkdPXSwgW3Rlc3QgIiR3aXRoX2ZvbnRfYmFja2Vu ZCIgPSAicGFuZ28iXSkKIEFNX0NPTkRJVElPTkFMKFtVU0VfR1NUUkVBTUVSXSwgW3Rlc3QgIiRo YXZlX2dzdHJlYW1lciIgPSAieWVzIl0pCiAKICMgV2ViS2l0IGZlYXR1cmUgY29uZGl0aW9uYWxz Ci1BTV9DT05ESVRJT05BTChbRU5BQkxFX0RFQlVHXSxbdGVzdCAiJGVuYWJsZV9kZWJ1ZyIgPSAi eWVzIl0pCitBTV9DT05ESVRJT05BTChbRU5BQkxFX0RFQlVHXSxbdGVzdCAiJGVuYWJsZV9kZWJ1 Z19mZWF0dXJlcyIgPSAieWVzIl0pCiBBTV9DT05ESVRJT05BTChbRU5BQkxFXzNEX1RSQU5TRk9S TVNdLFt0ZXN0ICIkZW5hYmxlXzNkX3RyYW5zZm9ybXMiID0gInllcyJdKQogQU1fQ09ORElUSU9O QUwoW0VOQUJMRV9XRUJHTF0sW3Rlc3QgIiRlbmFibGVfd2ViZ2wiID0gInllcyJdKQogQU1fQ09O RElUSU9OQUwoW0VOQUJMRV9CTE9CXSxbdGVzdCAiJGVuYWJsZV9ibG9iIiA9ICJ5ZXMiXSkKQEAg LTEyMTYsNiArMTIzNCw4IEBAIFdlYktpdCB3YXMgY29uZmlndXJlZCB3aXRoIHRoZSBmb2xsb3dp bmcgb3B0aW9uczoKIAogQnVpbGQgY29uZmlndXJhdGlvbjoKICBFbmFibGUgZGVidWdnaW5nIChz bG93KSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6ICRlbmFibGVfZGVidWcKKyBD b21waWxlIHdpdGggZGVidWcgc3ltYm9scyAoc2xvdykgICAgICAgICAgICAgICAgICAgICAgICA6 ICRlbmFibGVfZGVidWdfc3ltYm9scworIEVuYWJsZSBkZWJ1ZyBmZWF0dXJlcyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIDogJGVuYWJsZV9kZWJ1Z19mZWF0dXJlcwogIEVuYWJs ZSBHQ0MgYnVpbGQgb3B0aW1pemF0aW9uICAgICAgICAgICAgICAgICAgICAgICAgICAgIDogJGVu YWJsZV9vcHRpbWl6YXRpb25zCiAgQ29kZSBjb3ZlcmFnZSBzdXBwb3J0ICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgOiAkZW5hYmxlX2NvdmVyYWdlCiAgVW5pY29kZSBiYWNrZW5k ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOiAkd2l0aF91bmljb2Rl X2JhY2tlbmQK