63287 2011-06-23 14:02:28 -0700 [GTK] [WebKit2] WebKitTestRunner does not properly load TestNetscapePlugin 2011-06-23 14:41:48 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P3 Normal --- 1 mrobinson mrobinson oldest_to_newest 426435 0 mrobinson 2011-06-23 14:02:28 -0700 TestNetscapePlugin is not loaded for WKTR runs. 426470 1 98405 mrobinson 2011-06-23 14:30:43 -0700 Created attachment 98405 Patch 426474 2 98405 xan.lopez 2011-06-23 14:34:54 -0700 Comment on attachment 98405 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98405&action=review > Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp:79 > + return g_filename_to_utf8(value, -1, 0, &bytesWritten, 0); Should just pass 0 for bitesWritten? 426482 3 98405 mrobinson 2011-06-23 14:40:13 -0700 Comment on attachment 98405 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98405&action=review Thanks for the review! >> Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp:79 >> + return g_filename_to_utf8(value, -1, 0, &bytesWritten, 0); > > Should just pass 0 for bitesWritten? The documentation doesn't say you can, so I think it's safer to leave it. :/ 426483 4 mrobinson 2011-06-23 14:41:48 -0700 Committed r89616: <http://trac.webkit.org/changeset/89616> 98405 2011-06-23 14:30:43 -0700 2011-06-23 14:40:13 -0700 Patch bug-63287-20110623143037.patch text/plain 3759 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogODk2MTIKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmYjA1ZmU2NDg2OWJkZTQzZmZmYzZkNmU3MTEwOWNhYjgy N2IzNTgzLi40ZmY3YzdkMTNhODA0OTdhZTQxNWM5NmRlYmQ1MzZiZGI2Y2U3N2U1IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTEtMDYtMjMgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIFtX ZWJLaXQyXSBXZWJLaXRUZXN0UnVubmVyIGRvZXMgbm90IHByb3Blcmx5IGxvYWQgVGVzdE5ldHNj YXBlUGx1Z2luCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD02MzI4NworCisgICAgICAgIFNlbmQgdGhlIHBhdGggdG8gdGhlIFRlc3ROZXRzY2FwZVBsdWdp biB0byB0aGUgV0tUUiB2aWEgYW4gZW52aXJvbm1lbnQgdmFyaWFibGUKKyAgICAgICAgc28gdGhh dCB0aGUgcGx1Z2luIGxvYWRzIHByb3Blcmx5LgorCisgICAgICAgICogU2NyaXB0cy9vbGQtcnVu LXdlYmtpdC10ZXN0czogUGFzcyB0aGUgYXBwcm9wcmlhdGUgZW52aXJvbm1lbnQgdmFyaWFibGUg dG8gV0tUUi4KKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL2d0ay9UZXN0Q29udHJvbGxlckd0 ay5jcHA6CisgICAgICAgIChXVFI6OmdldEVudmlyb25tZW50VmFyaWFibGVBc1VURjhTdHJpbmcp OiBBZGRlZCB0aGlzIGhlbHBlciB3aGljaCBhYnN0cmFjdHMgYXdheSBzb21lCisgICAgICAgIG9m IHRoZSB3b3JrIGZvciBnZXR0aW5nIGFuIGVudmlyb25tZW50IHZhcmlhYmxlIGFuZCBjb252ZXJ0 aW5nIGl0IHRvIFVURi04LgorICAgICAgICAoV1RSOjpUZXN0Q29udHJvbGxlcjo6aW5pdGlhbGl6 ZUluamVjdGVkQnVuZGxlUGF0aCk6IFVzZSB0aGUgaGVscGVyLgorICAgICAgICAoV1RSOjpUZXN0 Q29udHJvbGxlcjo6aW5pdGlhbGl6ZVRlc3RQbHVnaW5EaXJlY3RvcnkpOiBHZXQgdGhlIHBhdGgg ZnJvbSBhbiBlbnZpcm9ubWVudCB2YXJpYWJsZSBub3cuCisKIDIwMTEtMDYtMjMgIEFkYW0gUm9i ZW4gIDxhcm9iZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJlY29yZCB3aGV0aGVyIG9sZC1ydW4t d2Via2l0LXRlc3RzIGFib3J0ZWQgZWFybHkgaW4gcmVzdWx0cy5odG1sCmRpZmYgLS1naXQgYS9U b29scy9TY3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzIGIvVG9vbHMvU2NyaXB0cy9vbGQtcnVu LXdlYmtpdC10ZXN0cwppbmRleCA4NTU3ZjA4YjQ4OTRhYzk2ZWZkMWIxZTRhNmRiZTNiNWYzMDM2 MjYzLi5iYTRkMTc3ODE3NjUxZTdhOTE5ZmZjM2E2YWY1NzRiYTdiYjM2ZTU5IDEwMDc1NQotLS0g YS9Ub29scy9TY3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzCisrKyBiL1Rvb2xzL1NjcmlwdHMv b2xkLXJ1bi13ZWJraXQtdGVzdHMKQEAgLTE1MDIsNiArMTUwMiw4IEBAIHN1YiBvcGVuRHVtcFRv b2woKQogICAgICAgICBpZiAoJHVzZVdlYktpdFRlc3RSdW5uZXIpIHsKICAgICAgICAgICAgIG15 ICRpbmplY3RlZEJ1bmRsZVBhdGggPSBwcm9kdWN0RGlyKCkgLiAiL0xpYnJhcmllcy8ubGlicy9s aWJUZXN0UnVubmVySW5qZWN0ZWRCdW5kbGUiOwogICAgICAgICAgICAgJENMRUFOX0VOVntURVNU X1JVTk5FUl9JTkpFQ1RFRF9CVU5ETEVfRklMRU5BTUV9ID0gJGluamVjdGVkQnVuZGxlUGF0aDsK KyAgICAgICAgICAgIG15ICR0ZXN0UGx1Z2luUGF0aCA9IHByb2R1Y3REaXIoKSAuICIvVGVzdE5l dHNjYXBlUGx1Z2luLy5saWJzIjsKKyAgICAgICAgICAgICRDTEVBTl9FTlZ7VEVTVF9SVU5ORVJf VEVTVF9QTFVHSU5fUEFUSH0gPSAkdGVzdFBsdWdpblBhdGg7CiAgICAgICAgIH0KICAgICB9CiAK ZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvZ3RrL1Rlc3RDb250cm9sbGVyR3Rr LmNwcCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvZ3RrL1Rlc3RDb250cm9sbGVyR3RrLmNwcApp bmRleCBhMzNhNjRmOTBjNjQ5YmY3MDdjNzgyMWZiNmQ4ZmUxNTVkODY3ZjkwLi5lNWY2YTQ1OGEw OGJhMTc4NDFlYWIzZGQxMWRmMTQ0ZDQ5OTc2ZjAwIDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRU ZXN0UnVubmVyL2d0ay9UZXN0Q29udHJvbGxlckd0ay5jcHAKKysrIGIvVG9vbHMvV2ViS2l0VGVz dFJ1bm5lci9ndGsvVGVzdENvbnRyb2xsZXJHdGsuY3BwCkBAIC02OCwyNCArNjgsMjcgQEAgdm9p ZCBUZXN0Q29udHJvbGxlcjo6cGxhdGZvcm1SdW5VbnRpbChib29sJiwgZG91YmxlIHRpbWVvdXQp CiAgICAgZ3RrX21haW4oKTsKIH0KIAotdm9pZCBUZXN0Q29udHJvbGxlcjo6aW5pdGlhbGl6ZUlu amVjdGVkQnVuZGxlUGF0aCgpCitzdGF0aWMgY2hhciogZ2V0RW52aXJvbm1lbnRWYXJpYWJsZUFz VVRGOFN0cmluZyhjb25zdCBjaGFyKiB2YXJpYWJsZU5hbWUpCiB7Ci0gICAgY29uc3QgY2hhciog YnVuZGxlUGF0aCA9IGdfZ2V0ZW52KCJURVNUX1JVTk5FUl9JTkpFQ1RFRF9CVU5ETEVfRklMRU5B TUUiKTsKLSAgICBpZiAoIWJ1bmRsZVBhdGgpIHsKLSAgICAgICAgZnByaW50ZihzdGRlcnIsICJU RVNUX1JVTk5FUl9JTkpFQ1RFRF9CVU5ETEVfRklMRU5BTUUgZW52aXJvbm1lbnQgdmFyaWFibGUg bm90IGZvdW5kXG4iKTsKKyAgICBjb25zdCBjaGFyKiB2YWx1ZSA9IGdfZ2V0ZW52KHZhcmlhYmxl TmFtZSk7CisgICAgaWYgKCF2YWx1ZSkgeworICAgICAgICBmcHJpbnRmKHN0ZGVyciwgIiVzIGVu dmlyb25tZW50IHZhcmlhYmxlIG5vdCBmb3VuZFxuIiwgdmFyaWFibGVOYW1lKTsKICAgICAgICAg ZXhpdCgwKTsKICAgICB9Ci0KICAgICBnc2l6ZSBieXRlc1dyaXR0ZW47Ci0gICAgR093blB0cjxj aGFyPiB1dGY4QnVuZGxlUGF0aChnX2ZpbGVuYW1lX3RvX3V0ZjgoYnVuZGxlUGF0aCwgLTEsIDAs ICZieXRlc1dyaXR0ZW4sIDApKTsKKyAgICByZXR1cm4gZ19maWxlbmFtZV90b191dGY4KHZhbHVl LCAtMSwgMCwgJmJ5dGVzV3JpdHRlbiwgMCk7Cit9CisKK3ZvaWQgVGVzdENvbnRyb2xsZXI6Omlu aXRpYWxpemVJbmplY3RlZEJ1bmRsZVBhdGgoKQoreworICAgIEdPd25QdHI8Y2hhcj4gdXRmOEJ1 bmRsZVBhdGgoZ2V0RW52aXJvbm1lbnRWYXJpYWJsZUFzVVRGOFN0cmluZygiVEVTVF9SVU5ORVJf SU5KRUNURURfQlVORExFX0ZJTEVOQU1FIikpOwogICAgIG1faW5qZWN0ZWRCdW5kbGVQYXRoLmFk b3B0KFdLU3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5nKHV0ZjhCdW5kbGVQYXRoLmdldCgpKSk7 CiB9CiAKIHZvaWQgVGVzdENvbnRyb2xsZXI6OmluaXRpYWxpemVUZXN0UGx1Z2luRGlyZWN0b3J5 KCkKIHsKLSAgICAvLyBUaGlzIGlzIGNhbGxlZCBhZnRlciBpbml0aWFsaXplSW5qZWN0ZWRCdW5k bGVQYXRoLgotICAgIEFTU0VSVChtX2luamVjdGVkQnVuZGxlUGF0aCk7Ci0gICAgbV90ZXN0UGx1 Z2luRGlyZWN0b3J5ID0gbV9pbmplY3RlZEJ1bmRsZVBhdGg7CisgICAgR093blB0cjxjaGFyPiB0 ZXN0UGx1Z2luUGF0aChnZXRFbnZpcm9ubWVudFZhcmlhYmxlQXNVVEY4U3RyaW5nKCJURVNUX1JV Tk5FUl9URVNUX1BMVUdJTl9QQVRIIikpOworICAgIG1fdGVzdFBsdWdpbkRpcmVjdG9yeS5hZG9w dChXS1N0cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0cmluZyh0ZXN0UGx1Z2luUGF0aC5nZXQoKSkpOwog fQogCiB2b2lkIFRlc3RDb250cm9sbGVyOjpwbGF0Zm9ybUluaXRpYWxpemVDb250ZXh0KCkK