63285 2011-06-23 13:56:18 -0700 Add a test with a single <source> element 2011-06-23 14:37:16 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 eric.carlson eric.carlson oldest_to_newest 426428 0 eric.carlson 2011-06-23 13:56:18 -0700 We should test that a <video> element with a single <source> element loads correctly. 426438 1 98395 eric.carlson 2011-06-23 14:04:09 -0700 Created attachment 98395 Proposed patch. 426450 2 98395 menard 2011-06-23 14:13:11 -0700 Comment on attachment 98395 Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=98395&action=review > LayoutTests/media/video-single-source.html:27 > + // The second source is bogus and won't load, but it should never be processed. But the name of the tests is "single source". Perhaps you should name it "Single valid source". > LayoutTests/media/video-single-source.html:36 > + waitForEvent('error', errorEvent); You say that "The second source is bogus and won't load, but it should never be processed." -> processed you mean rendered or whatever, because here you expect an error on the last source as the spec says. I'm nitpicking. 426460 3 eric.carlson 2011-06-23 14:23:23 -0700 (In reply to comment #2) > (From update of attachment 98395 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=98395&action=review > > > LayoutTests/media/video-single-source.html:27 > > + // The second source is bogus and won't load, but it should never be processed. > > But the name of the tests is "single source". Perhaps you should name it "Single valid source". > OK. > > LayoutTests/media/video-single-source.html:36 > > + waitForEvent('error', errorEvent); > > You say that "The second source is bogus and won't load, but it should never be processed." -> processed you mean rendered or whatever, because here you expect an error on the last source as the spec says. I'm nitpicking. Not quite. If HTMLMediaElement processes the <source> at all, it will pass the url to the media engine based on the MIME type. The file doesn't exist so the load will fail and an error event will be posted, and errorEvent will fail the test with a message about what went wrong. 426471 4 98406 eric.carlson 2011-06-23 14:30:46 -0700 Created attachment 98406 Updated patch 426478 5 eric.carlson 2011-06-23 14:37:16 -0700 http://trac.webkit.org/changeset/89615 98395 2011-06-23 14:04:09 -0700 2011-06-23 14:30:46 -0700 Proposed patch. patch.txt text/plain 2957 eric.carlson SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDg5NjEwKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDYtMjMgIEVyaWMgQ2FybHNvbiAgPGVy aWMuY2FybHNvbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQWRkIGEgdGVzdCB3aXRoIGEgc2luZ2xlIDxzb3VyY2U+IGVsZW1lbnQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYzMjg1CisK KyAgICAgICAgKiBtZWRpYS92aWRlby1zaW5nbGUtc291cmNlLWV4cGVjdGVkLnR4dDogQWRkZWQu CisgICAgICAgICogbWVkaWEvdmlkZW8tc2luZ2xlLXNvdXJjZS5odG1sOiBBZGRlZC4KKwogMjAx MS0wNi0yMyAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAg ICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjg5NTkxIGFuZCByODk1OTMuCkluZGV4OiBM YXlvdXRUZXN0cy9tZWRpYS92aWRlby1zaW5nbGUtc291cmNlLWV4cGVjdGVkLnR4dAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9tZWRpYS92aWRlby1zaW5nbGUtc291cmNlLWV4cGVjdGVkLnR4 dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL21lZGlhL3ZpZGVvLXNpbmdsZS1zb3VyY2Ut ZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDYgQEAKK1Rlc3QgdGhhdCBhIHNp bmdsZSA8c291cmNlPiBlbGVtZW50IGxvYWRzIGNvcnJlY3RseQorCisKK0VWRU5UKGxvYWRlZG1l dGFkYXRhKQorRU5EIE9GIFRFU1QKKwpJbmRleDogTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tc2lu Z2xlLXNvdXJjZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL21lZGlhL3ZpZGVvLXNp bmdsZS1zb3VyY2UuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL21lZGlhL3ZpZGVv LXNpbmdsZS1zb3VyY2UuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw1MiBAQAorPCFkb2N0 eXBlIGh0bWw+Cis8aHRtbD4KKyAgICA8aGVhZD4KKyAgICAgICAgPHNjcmlwdCBzcmM9bWVkaWEt ZmlsZS5qcz48L3NjcmlwdD4KKyAgICAgICAgPHNjcmlwdCBzcmM9dmlkZW8tdGVzdC5qcz48L3Nj cmlwdD4KKyAgICAgICAgCisgICAgICAgIDxzY3JpcHQ+CisgICAgCisgICAgICAgICAgICBmdW5j dGlvbiBlcnJvckV2ZW50KCkKKyAgICAgICAgICAgIHsKKyAgICAgICAgICAgICAgICBsb2dSZXN1 bHQoZmFsc2UsICIqKiogXCIiICsgcmVsYXRpdmVVUkwodmlkZW8uY3VycmVudFNyYykgKyAiXCIg c2hvdWxkIG5vdCBoYXZlIGJlZW4gcHJvY2Vzc2VkISIgKTsKKyAgICAgICAgICAgICAgICBjb25z b2xlV3JpdGUoIiIpOworICAgICAgICAgICAgICAgIGVuZFRlc3QoKTsKKyAgICAgICAgICAgIH0K KyAgICAKKyAgICAgICAgICAgIGZ1bmN0aW9uIHNldHVwKCkKKyAgICAgICAgICAgIHsKKyAgICAg ICAgICAgICAgICB2aWRlbyA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoInZpZGVvIik7CisgICAg ICAgICAgICAgICAgdmlkZW8uc2V0QXR0cmlidXRlKCJjb250cm9scyIsICJjb250cm9scyIpOwor CisgICAgICAgICAgICAgICAgLy8gVGhlIGZpcnN0IHNvdXJjZSBzaG91bGQgbG9hZC4KKyAgICAg ICAgICAgICAgICB2YXIgc291cmNlID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgic291cmNlIik7 CisgICAgICAgICAgICAgICAgc291cmNlLnNldEF0dHJpYnV0ZSgic3JjIiwgZmluZE1lZGlhRmls ZSgidmlkZW8iLCAiY29udGVudC90ZXN0IikpOworICAgICAgICAgICAgICAgIHNvdXJjZS5zZXRB dHRyaWJ1dGUoInR5cGUiLCBtaW1lVHlwZUZvckZpbGUoc291cmNlLmdldEF0dHJpYnV0ZSgic3Jj IikpKTsKKyAgICAgICAgICAgICAgICB2aWRlby5hcHBlbmRDaGlsZChzb3VyY2UpOworCisgICAg ICAgICAgICAgICAgLy8gVGhlIHNlY29uZCBzb3VyY2UgaXMgYm9ndXMgYW5kIHdvbid0IGxvYWQs IGJ1dCBpdCBzaG91bGQgbmV2ZXIgYmUgcHJvY2Vzc2VkLgorICAgICAgICAgICAgICAgIHNvdXJj ZSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoInNvdXJjZSIpOworICAgICAgICAgICAgICAgIHNv dXJjZS5zZXRBdHRyaWJ1dGUoInNyYyIsIGZpbmRNZWRpYUZpbGUoInZpZGVvIiwgImNvbnRlbnQv ZG9lcy1ub3QtZXhpc3QiKSk7CisgICAgICAgICAgICAgICAgc291cmNlLnNldEF0dHJpYnV0ZSgi dHlwZSIsIG1pbWVUeXBlRm9yRmlsZShzb3VyY2UuZ2V0QXR0cmlidXRlKCJzcmMiKSkpOworICAg ICAgICAgICAgICAgIHZpZGVvLmFwcGVuZENoaWxkKHNvdXJjZSk7CisKKworICAgICAgICAgICAg ICAgIGRvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQodmlkZW8pOworCisgICAgICAgICAgICAgICAg d2FpdEZvckV2ZW50KCdlcnJvcicsIGVycm9yRXZlbnQpOworICAgICAgICAgICAgICAgIHdhaXRG b3JFdmVudCgnbG9hZGVkbWV0YWRhdGEnLCBlbmRUZXN0KTsKKyAgICAgICAgICAgICAgICBjb25z b2xlV3JpdGUoIiIpOworICAgICAgICAgICAgfQorCisgICAgICAgIDwvc2NyaXB0PgorICAgIDwv aGVhZD4KKzxib2R5IG9ubG9hZD0ic2V0dXAoKSI+CisKKyAgICA8cD5UZXN0IHRoYXQgYSBzaW5n bGUgJmx0O3NvdXJjZSZndDsgZWxlbWVudCBsb2FkcyBjb3JyZWN0bHk8L3A+CisKKyAgICA8c2Ny aXB0PgorICAgICAgICAKKyAgICA8L3NjcmlwdD4KKworPC9ib2R5PgorPC9odG1sPgo= 98406 2011-06-23 14:30:46 -0700 2011-06-23 14:32:03 -0700 Updated patch patch_2.txt text/plain 2976 eric.carlson SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDg5NjEwKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDYtMjMgIEVyaWMgQ2FybHNvbiAgPGVy aWMuY2FybHNvbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQWRkIGEgdGVzdCB3aXRoIGEgc2luZ2xlIDxzb3VyY2U+IGVsZW1lbnQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYzMjg1CisK KyAgICAgICAgKiBtZWRpYS92aWRlby1zaW5nbGUtdmFsaWQtc291cmNlLWV4cGVjdGVkLnR4dDog QWRkZWQuCisgICAgICAgICogbWVkaWEvdmlkZW8tc2luZ2xlLXZhbGlkLXNvdXJjZS5odG1sOiBB ZGRlZC4KKwogMjAxMS0wNi0yMyAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFp bC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjg5NTkxIGFuZCByODk1 OTMuCkluZGV4OiBMYXlvdXRUZXN0cy9tZWRpYS92aWRlby1zaW5nbGUtdmFsaWQtc291cmNlLWV4 cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9tZWRpYS92aWRlby1zaW5nbGUt dmFsaWQtc291cmNlLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL21l ZGlhL3ZpZGVvLXNpbmdsZS12YWxpZC1zb3VyY2UtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpA QCAtMCwwICsxLDYgQEAKK1Rlc3QgdGhhdCBhIHNpbmdsZSB2YWxpZCA8c291cmNlPiBlbGVtZW50 IGxvYWRzIGNvcnJlY3RseQorCisKK0VWRU5UKGxvYWRlZG1ldGFkYXRhKQorRU5EIE9GIFRFU1QK KwpJbmRleDogTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tc2luZ2xlLXZhbGlkLXNvdXJjZS5odG1s Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL21lZGlhL3ZpZGVvLXNpbmdsZS12YWxpZC1zb3Vy Y2UuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL21lZGlhL3ZpZGVvLXNpbmdsZS12 YWxpZC1zb3VyY2UuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw0OCBAQAorPCFkb2N0eXBl IGh0bWw+Cis8aHRtbD4KKyAgICA8aGVhZD4KKyAgICAgICAgPHNjcmlwdCBzcmM9bWVkaWEtZmls ZS5qcz48L3NjcmlwdD4KKyAgICAgICAgPHNjcmlwdCBzcmM9dmlkZW8tdGVzdC5qcz48L3Njcmlw dD4KKyAgICAgICAgCisgICAgICAgIDxzY3JpcHQ+CisgICAgCisgICAgICAgICAgICBmdW5jdGlv biBlcnJvckV2ZW50KCkKKyAgICAgICAgICAgIHsKKyAgICAgICAgICAgICAgICBsb2dSZXN1bHQo ZmFsc2UsICIqKiogXCIiICsgcmVsYXRpdmVVUkwodmlkZW8uY3VycmVudFNyYykgKyAiXCIgc2hv dWxkIG5vdCBoYXZlIGJlZW4gcHJvY2Vzc2VkISIgKTsKKyAgICAgICAgICAgICAgICBjb25zb2xl V3JpdGUoIiIpOworICAgICAgICAgICAgICAgIGVuZFRlc3QoKTsKKyAgICAgICAgICAgIH0KKyAg ICAKKyAgICAgICAgICAgIGZ1bmN0aW9uIHNldHVwKCkKKyAgICAgICAgICAgIHsKKyAgICAgICAg ICAgICAgICB2aWRlbyA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoInZpZGVvIik7CisgICAgICAg ICAgICAgICAgdmlkZW8uc2V0QXR0cmlidXRlKCJjb250cm9scyIsICJjb250cm9scyIpOworCisg ICAgICAgICAgICAgICAgLy8gVGhlIGZpcnN0IHNvdXJjZSBzaG91bGQgbG9hZC4KKyAgICAgICAg ICAgICAgICB2YXIgc291cmNlID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgic291cmNlIik7Cisg ICAgICAgICAgICAgICAgc291cmNlLnNldEF0dHJpYnV0ZSgic3JjIiwgZmluZE1lZGlhRmlsZSgi dmlkZW8iLCAiY29udGVudC90ZXN0IikpOworICAgICAgICAgICAgICAgIHNvdXJjZS5zZXRBdHRy aWJ1dGUoInR5cGUiLCBtaW1lVHlwZUZvckZpbGUoc291cmNlLmdldEF0dHJpYnV0ZSgic3JjIikp KTsKKyAgICAgICAgICAgICAgICB2aWRlby5hcHBlbmRDaGlsZChzb3VyY2UpOworCisgICAgICAg ICAgICAgICAgLy8gVGhlIHNlY29uZCBzb3VyY2UgaXMgYm9ndXMgYW5kIHdvbid0IGxvYWQsIGJ1 dCBpdCBzaG91bGQgbmV2ZXIgYmUgcHJvY2Vzc2VkLgorICAgICAgICAgICAgICAgIHNvdXJjZSA9 IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoInNvdXJjZSIpOworICAgICAgICAgICAgICAgIHNvdXJj ZS5zZXRBdHRyaWJ1dGUoInNyYyIsIGZpbmRNZWRpYUZpbGUoInZpZGVvIiwgImNvbnRlbnQvZG9l cy1ub3QtZXhpc3QiKSk7CisgICAgICAgICAgICAgICAgc291cmNlLnNldEF0dHJpYnV0ZSgidHlw ZSIsIG1pbWVUeXBlRm9yRmlsZShzb3VyY2UuZ2V0QXR0cmlidXRlKCJzcmMiKSkpOworICAgICAg ICAgICAgICAgIHZpZGVvLmFwcGVuZENoaWxkKHNvdXJjZSk7CisKKworICAgICAgICAgICAgICAg IGRvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQodmlkZW8pOworCisgICAgICAgICAgICAgICAgd2Fp dEZvckV2ZW50KCdlcnJvcicsIGVycm9yRXZlbnQpOworICAgICAgICAgICAgICAgIHdhaXRGb3JF dmVudCgnbG9hZGVkbWV0YWRhdGEnLCBlbmRUZXN0KTsKKyAgICAgICAgICAgICAgICBjb25zb2xl V3JpdGUoIiIpOworICAgICAgICAgICAgfQorCisgICAgICAgIDwvc2NyaXB0PgorICAgIDwvaGVh ZD4KKzxib2R5IG9ubG9hZD0ic2V0dXAoKSI+CisKKyAgICA8cD5UZXN0IHRoYXQgYSBzaW5nbGUg dmFsaWQgJmx0O3NvdXJjZSZndDsgZWxlbWVudCBsb2FkcyBjb3JyZWN0bHk8L3A+CisKKzwvYm9k eT4KKzwvaHRtbD4K