63281 2011-06-23 13:22:31 -0700 TestFailures page fetches build JSON for every build, which is slow and limits history to the last build master restart 2011-06-23 14:47:35 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED http://build.webkit.org/TestFailures/ P2 Normal --- 63280 1 aroben webkit-unassigned rniwa oldest_to_newest 426408 0 aroben 2011-06-23 13:22:31 -0700 TestFailures page fetches build JSON for every build, in addition to the results.html page. It does this so it can determine whether run-webkit-tests exited early due to too many failures/crashes/timeouts. But this is slow, and limits history to whenever the build master was last restarted. It would be much better if we could just pull this information out of results.html. Then we'd only have to do one request per build, and history would be practically unlimited. 426417 1 aroben 2011-06-23 13:28:45 -0700 After bug 63280 is fixed, we can change TestFailures to only look at the build JSON if we're dealing with a build older than whatever revision bug 63280 was fixed in. 426467 2 98404 aroben 2011-06-23 14:29:30 -0700 Created attachment 98404 Avoid fetching JSON data when possible on TestFailures page to determine if old-run-webkit-tests exited early 426477 3 98404 ddkilzer 2011-06-23 14:36:51 -0700 Comment on attachment 98404 Avoid fetching JSON data when possible on TestFailures page to determine if old-run-webkit-tests exited early View in context: https://bugs.webkit.org/attachment.cgi?id=98404&action=review r=me > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js:75 > + resultsHTMLForBuildIncludesTooManyFailuresInfo: function(buildName) { See next comment. > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:247 > + var resultsHTMLIncludesTooManyFailuresInfo = this.buildbot.resultsHTMLForBuildIncludesTooManyFailuresInfo(buildName); I don't like "Includes" in this variable name because that implies (just reading the variable name) that this particular build has info about too many failures. How about using "Supports" instead of "Includes"? var resultsHTMLSupportsTooManyFailuresInfo = this.buildbot.resultsHTMLForBuildSupportsTooManyFailuresInfo(buildName); 426479 4 98404 aroben 2011-06-23 14:38:22 -0700 Comment on attachment 98404 Avoid fetching JSON data when possible on TestFailures page to determine if old-run-webkit-tests exited early View in context: https://bugs.webkit.org/attachment.cgi?id=98404&action=review >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:247 >> + var resultsHTMLIncludesTooManyFailuresInfo = this.buildbot.resultsHTMLForBuildIncludesTooManyFailuresInfo(buildName); > > I don't like "Includes" in this variable name because that implies (just reading the variable name) that this particular build has info about too many failures. How about using "Supports" instead of "Includes"? > > var resultsHTMLSupportsTooManyFailuresInfo = this.buildbot.resultsHTMLForBuildSupportsTooManyFailuresInfo(buildName); Good suggestion. I'll go with that! 426496 5 aroben 2011-06-23 14:47:35 -0700 Committed r89619: <http://trac.webkit.org/changeset/89619> 98404 2011-06-23 14:29:30 -0700 2011-06-23 14:38:22 -0700 Avoid fetching JSON data when possible on TestFailures page to determine if old-run-webkit-tests exited early bug-63281-20110623172947.patch text/plain 5925 aroben U3VidmVyc2lvbiBSZXZpc2lvbjogODk2MTAKZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9C dWlsZGJvdC5qcyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u ZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9CdWlsZGJvdC5qcwppbmRleCBlOTQxNzI2MGU4 YWQ1NzBlZDMzYWZhN2JhZDhmMTFlYWQ0MWE5NTFlLi5kNTI1MDIzYmVjYmZmMjRkN2NlZjI3Mzg2 ZDZmNzBiZTRjODI2MzcyIDEwMDY0NAotLS0gYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWls ZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvQnVpbGRib3QuanMK KysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVi bGljX2h0bWwvVGVzdEZhaWx1cmVzL0J1aWxkYm90LmpzCkBAIC03Miw2ICs3MiwxMSBAQCBCdWls ZGJvdC5wcm90b3R5cGUgPSB7CiAgICAgICAgIHJldHVybiB0aGlzLmJhc2VVUkwgKyAncmVzdWx0 cy8nICsgYnVpbGRlck5hbWUgKyAnLycgKyBidWlsZE5hbWUgKyAnLyc7CiAgICAgfSwKIAorICAg IHJlc3VsdHNIVE1MRm9yQnVpbGRJbmNsdWRlc1Rvb01hbnlGYWlsdXJlc0luZm86IGZ1bmN0aW9u KGJ1aWxkTmFtZSkgeworICAgICAgICAvLyBodHRwOi8vd2Via2l0Lm9yZy9iLzYyMzgwIHdhcyBm aXhlZCBpbiByODk2MTAuCisgICAgICAgIHJldHVybiB0aGlzLnBhcnNlQnVpbGROYW1lKGJ1aWxk TmFtZSkucmV2aXNpb24gPj0gODk2MTA7CisgICAgfSwKKwogICAgIF9idWlsZGVyc0Zvck5hbWVz OiBmdW5jdGlvbihuYW1lcykgewogICAgICAgICB2YXIgc2VsZiA9IHRoaXM7CiAgICAgICAgIHJl dHVybiBuYW1lcy5tYXAoZnVuY3Rpb24obmFtZSkgeyByZXR1cm4gc2VsZi5idWlsZGVyTmFtZWQo bmFtZSkgfSk7CmRpZmYgLS1naXQgYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJr aXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvQnVpbGRlci5qcyBiL1Rvb2xz L0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rl c3RGYWlsdXJlcy9CdWlsZGVyLmpzCmluZGV4IGYwZTAxZWUxYTdmMjk0ZTVlYjBmZjBiZmFmNGNm YWE0Mjk1MTYwOGUuLmU3YTYwZmFhMGEyNzgxZjZjNWVhODA2NDU0N2QzZWQxNzU2N2ZmNDYgMTAw NjQ0Ci0tLSBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmln L3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9CdWlsZGVyLmpzCisrKyBiL1Rvb2xzL0J1aWxkU2xh dmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJl cy9CdWlsZGVyLmpzCkBAIC0yNDQsMjggKzI0NCwxOCBAQCBCdWlsZGVyLnByb3RvdHlwZSA9IHsK ICAgICAgICAgdmFyIHRlc3RzID0ge307CiAKICAgICAgICAgdmFyIGJ1aWxkTnVtYmVyID0gdGhp cy5idWlsZGJvdC5wYXJzZUJ1aWxkTmFtZShidWlsZE5hbWUpLmJ1aWxkTnVtYmVyOworICAgICAg ICB2YXIgcmVzdWx0c0hUTUxJbmNsdWRlc1Rvb01hbnlGYWlsdXJlc0luZm8gPSB0aGlzLmJ1aWxk Ym90LnJlc3VsdHNIVE1MRm9yQnVpbGRJbmNsdWRlc1Rvb01hbnlGYWlsdXJlc0luZm8oYnVpbGRO YW1lKTsKIAogICAgICAgICB2YXIgc2VsZiA9IHRoaXM7Ci0gICAgICAgIHNlbGYuZ2V0TnVtYmVy T2ZGYWlsaW5nVGVzdHMoYnVpbGROdW1iZXIsIGZ1bmN0aW9uKGZhaWxpbmdUZXN0Q291bnQsIHRv b01hbnlGYWlsdXJlcykgewotICAgICAgICAgICAgaWYgKGZhaWxpbmdUZXN0Q291bnQgPCAwKSB7 Ci0gICAgICAgICAgICAgICAgLy8gVGhlIG51bWJlciBvZiBmYWlsaW5nIHRlc3RzIGNvdWxkbid0 IGJlIGRldGVybWluZWQuCi0gICAgICAgICAgICAgICAgUGVyc2lzdGVudENhY2hlLnNldChjYWNo ZUtleSwgdGVzdHMpOwotICAgICAgICAgICAgICAgIGVycm9yQ2FsbGJhY2sodGVzdHMsIHRvb01h bnlGYWlsdXJlcyk7Ci0gICAgICAgICAgICAgICAgcmV0dXJuOwotICAgICAgICAgICAgfQogCi0g ICAgICAgICAgICBpZiAoIWZhaWxpbmdUZXN0Q291bnQpIHsKLSAgICAgICAgICAgICAgICAvLyBB bGwgdGVzdHMgcGFzc2VkLgotICAgICAgICAgICAgICAgIFBlcnNpc3RlbnRDYWNoZS5zZXQoY2Fj aGVLZXksIHRlc3RzKTsKLSAgICAgICAgICAgICAgICBjYWxsYmFjayh0ZXN0cywgdG9vTWFueUZh aWx1cmVzKTsKLSAgICAgICAgICAgICAgICByZXR1cm47Ci0gICAgICAgICAgICB9Ci0KLSAgICAg ICAgICAgIC8vIEZpbmQgb3V0IHdoaWNoIHRlc3RzIGZhaWxlZC4KKyAgICAgICAgZnVuY3Rpb24g ZmV0Y2hBbmRQYXJzZVJlc3VsdHNIVE1MQW5kQ2FsbENhbGxiYWNrKGNhbGxiYWNrLCB0b29NYW55 RmFpbHVyZXMpIHsKICAgICAgICAgICAgIGdldFJlc291cmNlKHNlbGYucmVzdWx0c1BhZ2VVUkwo YnVpbGROYW1lKSwgZnVuY3Rpb24oeGhyKSB7CiAgICAgICAgICAgICAgICAgdmFyIHJvb3QgPSBk b2N1bWVudC5jcmVhdGVFbGVtZW50KCdodG1sJyk7CiAgICAgICAgICAgICAgICAgcm9vdC5pbm5l ckhUTUwgPSB4aHIucmVzcG9uc2VUZXh0OwogCisgICAgICAgICAgICAgICAgaWYgKHJlc3VsdHNI VE1MSW5jbHVkZXNUb29NYW55RmFpbHVyZXNJbmZvKQorICAgICAgICAgICAgICAgICAgICB0b29N YW55RmFpbHVyZXMgPSByb290LmdldEVsZW1lbnRzQnlDbGFzc05hbWUoJ3N0b3BwZWQtcnVubmlu Zy1lYXJseS1tZXNzYWdlJykubGVuZ3RoID4gMDsKKwogICAgICAgICAgICAgICAgIGZ1bmN0aW9u IHRlc3RzRm9yUmVzdWx0VGFibGUocmVnZXgpIHsKICAgICAgICAgICAgICAgICAgICAgdmFyIHBh cmFncmFwaCA9IEFycmF5LnByb3RvdHlwZS5maW5kRmlyc3QuY2FsbChyb290LnF1ZXJ5U2VsZWN0 b3JBbGwoJ3AnKSwgZnVuY3Rpb24ocGFyYWdyYXBoKSB7CiAgICAgICAgICAgICAgICAgICAgICAg ICByZXR1cm4gcmVnZXgudGVzdChwYXJhZ3JhcGguaW5uZXJUZXh0KTsKQEAgLTMwMCw2ICsyOTAs MzAgQEAgQnVpbGRlci5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICAgICAgUGVyc2lzdGVudENh Y2hlLnNldChjYWNoZUtleSwgdGVzdHMpOwogICAgICAgICAgICAgICAgIGVycm9yQ2FsbGJhY2so dGVzdHMsIHRvb01hbnlGYWlsdXJlcyk7CiAgICAgICAgICAgICB9KTsKKyAgICAgICAgfQorCisg ICAgICAgIGlmIChyZXN1bHRzSFRNTEluY2x1ZGVzVG9vTWFueUZhaWx1cmVzSW5mbykgeworICAg ICAgICAgICAgZmV0Y2hBbmRQYXJzZVJlc3VsdHNIVE1MQW5kQ2FsbENhbGxiYWNrKGNhbGxiYWNr LCBmYWxzZSk7CisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KKworICAgICAgICBzZWxm LmdldE51bWJlck9mRmFpbGluZ1Rlc3RzKGJ1aWxkTnVtYmVyLCBmdW5jdGlvbihmYWlsaW5nVGVz dENvdW50LCB0b29NYW55RmFpbHVyZXMpIHsKKyAgICAgICAgICAgIGlmIChmYWlsaW5nVGVzdENv dW50IDwgMCkgeworICAgICAgICAgICAgICAgIC8vIFRoZSBudW1iZXIgb2YgZmFpbGluZyB0ZXN0 cyBjb3VsZG4ndCBiZSBkZXRlcm1pbmVkLgorICAgICAgICAgICAgICAgIFBlcnNpc3RlbnRDYWNo ZS5zZXQoY2FjaGVLZXksIHRlc3RzKTsKKyAgICAgICAgICAgICAgICBlcnJvckNhbGxiYWNrKHRl c3RzLCB0b29NYW55RmFpbHVyZXMpOworICAgICAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAg ICAgIH0KKworICAgICAgICAgICAgaWYgKCFmYWlsaW5nVGVzdENvdW50KSB7CisgICAgICAgICAg ICAgICAgLy8gQWxsIHRlc3RzIHBhc3NlZC4KKyAgICAgICAgICAgICAgICBQZXJzaXN0ZW50Q2Fj aGUuc2V0KGNhY2hlS2V5LCB0ZXN0cyk7CisgICAgICAgICAgICAgICAgY2FsbGJhY2sodGVzdHMs IHRvb01hbnlGYWlsdXJlcyk7CisgICAgICAgICAgICAgICAgcmV0dXJuOworICAgICAgICAgICAg fQorCisgICAgICAgICAgICAvLyBGaW5kIG91dCB3aGljaCB0ZXN0cyBmYWlsZWQuCisgICAgICAg ICAgICBmZXRjaEFuZFBhcnNlUmVzdWx0c0hUTUxBbmRDYWxsQ2FsbGJhY2soY2FsbGJhY2ssIHRv b01hbnlGYWlsdXJlcyk7CiAgICAgICAgIH0pOwogICAgIH0sCiAKZGlmZiAtLWdpdCBhL1Rvb2xz L0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmYjA1ZmU2NDg2OWJkZTQzZmZmYzZk NmU3MTEwOWNhYjgyN2IzNTgzLi5kNmRmNzEwYTZjNzI3OTliYTU2MWRkYTJjOGQ4MTkxN2ZjOWY3 NzFmIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBA IC0xLDUgKzEsMzAgQEAKIDIwMTEtMDYtMjMgIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29t PgogCisgICAgICAgIEF2b2lkIGZldGNoaW5nIEpTT04gZGF0YSB3aGVuIHBvc3NpYmxlIG9uIFRl c3RGYWlsdXJlcyBwYWdlIHRvIGRldGVybWluZSBpZgorICAgICAgICBvbGQtcnVuLXdlYmtpdC10 ZXN0cyBleGl0ZWQgZWFybHkKKworICAgICAgICBBcyBvZiByODk2MTAsIHJlc3VsdHMuaHRtbCBp bmNsdWRlcyBpbmZvcm1hdGlvbiBhYm91dCB3aGV0aGVyIG9sZC1ydW4td2Via2l0LXRlc3RzIGV4 aXRlZAorICAgICAgICBlYXJseSwgc28gd2UgZG9uJ3QgbmVlZCB0byBsb29rIGF0IEpTT04gZGF0 YSB0byBnZXQgdGhpcyBpbmZvcm1hdGlvbiBmb3IgYnVpbGRzIG5ld2VyIHRoYW4KKyAgICAgICAg dGhhdC4KKworICAgICAgICBGaXhlcyA8aHR0cDovL3dlYmtpdC5vcmcvYi82MzI4MT4gVGVzdEZh aWx1cmVzIHBhZ2UgZmV0Y2hlcyBidWlsZCBKU09OIGZvciBldmVyeSBidWlsZCwKKyAgICAgICAg d2hpY2ggaXMgc2xvdyBhbmQgbGltaXRzIGhpc3RvcnkgdG8gdGhlIGxhc3QgYnVpbGQgbWFzdGVy IHJlc3RhcnQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1s L1Rlc3RGYWlsdXJlcy9CdWlsZGJvdC5qczoKKyAgICAgICAgKEJ1aWxkYm90LnByb3RvdHlwZS5y ZXN1bHRzSFRNTEZvckJ1aWxkSW5jbHVkZXNUb29NYW55RmFpbHVyZXNJbmZvKTogTmV3IGZ1bmN0 aW9uLCByZXR1cm5zCisgICAgICAgIHRydWUgaWYgdGhlIGJ1aWxkIGNvcnJlc3BvbmRzIHRvIHI4 OTYxMCBvciBuZXdlci4KKworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtp dC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9CdWlsZGVyLmpzOgorICAgICAg ICAoQnVpbGRlci5wcm90b3R5cGUuX2dldEZhaWxpbmdUZXN0cyk6IE1vdmVkIGNvZGUgZGVhbGlu ZyB3aXRoIHJlc3VsdHMuaHRtbCBpbnRvIGEgbmV3CisgICAgICAgIGZ1bmN0aW9uLiBJZiB3ZSdy ZSBkZWFsaW5nIHdpdGggYSBidWlsZCB0aGF0IGhhcyBlYXJseS1leGl0IGluZm9ybWF0aW9uIGlu IHJlc3VsdHMuaHRtbCwKKyAgICAgICAgZG9uJ3QgYm90aGVyIGZldGNoaW5nIEpTT04gZGF0YSBh bmQgZ28gc3RyYWlnaHQgdG8gcGFyc2luZyByZXN1bHRzLmh0bWwuIE90aGVyd2lzZSBmaXJzdCB1 c2UKKyAgICAgICAgdGhlIEpTT04gZGF0YSB0byBkZXRlcm1pbmUgaWYgb2xkLXJ1bi13ZWJraXQt dGVzdHMgZXhpdGVkIGVhcmx5LCBhbmQgdGhlbiBwYXJzZSByZXN1bHRzLmh0bWwKKyAgICAgICAg KGFzIGJlZm9yZSkuCisKKzIwMTEtMDYtMjMgIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29t PgorCiAgICAgICAgIFJlY29yZCB3aGV0aGVyIG9sZC1ydW4td2Via2l0LXRlc3RzIGFib3J0ZWQg ZWFybHkgaW4gcmVzdWx0cy5odG1sCiAKICAgICAgICAgRml4ZXMgPGh0dHA6Ly93ZWJraXQub3Jn L2IvNjMyODA+IHJlc3VsdHMuaHRtbCBnaXZlcyBubyBpbmRpY2F0aW9uIG9mIHdoZXRoZXIK