63275 2011-06-23 13:08:07 -0700 Incorrect MIME type used for some media layout tests 2011-06-23 13:28:07 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 eric.carlson eric.carlson oldest_to_newest 426390 0 eric.carlson 2011-06-23 13:08:07 -0700 Several of the media layout tests use "video/mpeg" for MPEG-4 files. 426399 1 98386 eric.carlson 2011-06-23 13:14:06 -0700 Created attachment 98386 Proposed patch. 426402 2 98386 darin 2011-06-23 13:17:18 -0700 Comment on attachment 98386 Proposed patch. Is there any value in testing what happens when the incorrect MIME type is used? Are we losing test coverage of that specific mistake? 426413 3 eric.carlson 2011-06-23 13:26:04 -0700 http://trac.webkit.org/changeset/89608 426416 4 eric.carlson 2011-06-23 13:28:07 -0700 (In reply to comment #2) > (From update of attachment 98386 [details]) > Is there any value in testing what happens when the incorrect MIME type is used? Are we losing test coverage of that specific mistake? I don't think we are losing useful test coverage. 98386 2011-06-23 13:14:06 -0700 2011-06-23 13:17:18 -0700 Proposed patch. patch.txt text/plain 3996 eric.carlson SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDg5NjA2KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDYtMjMgIEVyaWMgQ2FybHNvbiAgPGVy aWMuY2FybHNvbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgSW5jb3JyZWN0IE1JTUUgdHlwZSB1c2VkIGZvciBzb21lIG1lZGlhIGxh eW91dCB0ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NjMyNzUKKworICAgICAgICAqIG1lZGlhL3ZpZGVvLWNhbi1wbGF5LXR5cGUtZXhwZWN0ZWQu dHh0OiB2aWRlby9tcGVnIC0+IHZpZGVvL21wNAorICAgICAgICAqIG1lZGlhL3ZpZGVvLWNhbi1w bGF5LXR5cGUuaHRtbDogRGl0dG8uCisgICAgICAgICogbWVkaWEvdmlkZW8tc291cmNlLWVycm9y Lmh0bWw6IERpdHRvLgorICAgICAgICAqIG1lZGlhL3ZpZGVvLXNvdXJjZS10eXBlLmh0bWw6IERp dHRvLgorCiAyMDExLTA2LTIzICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAg ICAgICAgQWRkZWQgZXhwZWN0ZWQgcmVzdWx0cyBmb3IgU25vdyBMZW9wYXJkIGFuZCBlYXJsaWVy LgpJbmRleDogTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tY2FuLXBsYXktdHlwZS1leHBlY3RlZC50 eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tY2FuLXBsYXktdHlwZS1l eHBlY3RlZC50eHQJKHJldmlzaW9uIDg5MzUxKQorKysgTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8t Y2FuLXBsYXktdHlwZS1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTMsNyArMyw3IEBA IFRlc3QgSFRNTE1lZGlhRWxlbWVudCBjYW5QbGF5VHlwZSgpIG1ldGgKIEVYUEVDVEVEICh2aWRl by5jYW5QbGF5VHlwZSgpID09ICcnKSBPSwogRVhQRUNURUQgKHZpZGVvLmNhblBsYXlUeXBlKCd2 aWRlby8nKSA9PSAnJykgT0sKIEVYUEVDVEVEICh2aWRlby5jYW5QbGF5VHlwZSgndmlkZW8vYmxh aGJsYWgnKSA9PSAnJykgT0sKLUVYUEVDVEVEICh2aWRlby5jYW5QbGF5VHlwZSgndmlkZW8vbXBl ZzsgQ29kZWNzPSJhdmMxLjRENDAwQyInKSA9PSAncHJvYmFibHknKSBPSworRVhQRUNURUQgKHZp ZGVvLmNhblBsYXlUeXBlKCd2aWRlby9tcDQ7IENvZGVjcz0iYXZjMS40RDQwMEMiJykgPT0gJ3By b2JhYmx5JykgT0sKIEVYUEVDVEVEICh2aWRlby5jYW5QbGF5VHlwZSgnIFZpZGVvL01QNCA7IENP REVDUz0ibXA0di4yMC44LCBtcDRhLjQwLjIiJykgPT0gJ3Byb2JhYmx5JykgT0sKIEVYUEVDVEVE ICh2aWRlby5jYW5QbGF5VHlwZSgnYXVkaW8vbXBlZycpID09ICdtYXliZScpIE9LCiBFWFBFQ1RF RCAodmlkZW8uY2FuUGxheVR5cGUoJ2F1ZGlvL1dhdicpID09ICdtYXliZScpIE9LCkluZGV4OiBM YXlvdXRUZXN0cy9tZWRpYS92aWRlby1jYW4tcGxheS10eXBlLmh0bWwKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tY2FuLXBsYXktdHlwZS5odG1sCShyZXZpc2lvbiA4OTM1 MSkKKysrIExheW91dFRlc3RzL21lZGlhL3ZpZGVvLWNhbi1wbGF5LXR5cGUuaHRtbAkod29ya2lu ZyBjb3B5KQpAQCAtMTgsNyArMTgsNyBAQAogICAgICAgICAgICAgdGVzdEV4cGVjdGVkKCJ2aWRl by5jYW5QbGF5VHlwZSgpIiwgIiIpOwogICAgICAgICAgICAgdGVzdEV4cGVjdGVkKCJ2aWRlby5j YW5QbGF5VHlwZSgndmlkZW8vJykiLCAiIik7CiAgICAgICAgICAgICB0ZXN0RXhwZWN0ZWQoInZp ZGVvLmNhblBsYXlUeXBlKCd2aWRlby9ibGFoYmxhaCcpIiwgIiIpOwotICAgICAgICAgICAgdGVz dEV4cGVjdGVkKCJ2aWRlby5jYW5QbGF5VHlwZSgndmlkZW8vbXBlZzsgQ29kZWNzPVwiYXZjMS40 RDQwMENcIicpIiwgInByb2JhYmx5Iik7CisgICAgICAgICAgICB0ZXN0RXhwZWN0ZWQoInZpZGVv LmNhblBsYXlUeXBlKCd2aWRlby9tcDQ7IENvZGVjcz1cImF2YzEuNEQ0MDBDXCInKSIsICJwcm9i YWJseSIpOwogICAgICAgICAgICAgdGVzdEV4cGVjdGVkKCJ2aWRlby5jYW5QbGF5VHlwZSgnICAg ICAgICBWaWRlby9NUDQgOyBDT0RFQ1M9XCJtcDR2LjIwLjgsIG1wNGEuNDAuMlwiJykiLCAicHJv YmFibHkiKTsKICAgICAgICAgICAgIHRlc3RFeHBlY3RlZCgidmlkZW8uY2FuUGxheVR5cGUoJ2F1 ZGlvL21wZWcnKSIsICJtYXliZSIpOwogICAgICAgICAgICAgdGVzdEV4cGVjdGVkKCJ2aWRlby5j YW5QbGF5VHlwZSgnYXVkaW8vV2F2JykiLCAibWF5YmUiKTsKSW5kZXg6IExheW91dFRlc3RzL21l ZGlhL3ZpZGVvLXNvdXJjZS1lcnJvci5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL21l ZGlhL3ZpZGVvLXNvdXJjZS1lcnJvci5odG1sCShyZXZpc2lvbiA4OTM1MSkKKysrIExheW91dFRl c3RzL21lZGlhL3ZpZGVvLXNvdXJjZS1lcnJvci5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC02Myw3 ICs2Myw3IEBACiAgICAgICAgICAgICA8c291cmNlIGlkPXVuc3VwcG9ydGVkLW1lZGlhLXF1ZXJ5 IHNyYz1jb250ZW50L3Rlc3QubXA0IG1lZGlhPXByaW50PgogICAgICAgICAgICAgPHNvdXJjZSBp ZD1taXNzaW5nLWZpbGUgc3JjPWNvbnRlbnQvZXJyb3IyLm1wZWcgdHlwZT12aWRlby9tcGVnPgog ICAgICAgICAgICAgPHNvdXJjZSBpZD1mb3JtYXQtZXJyb3Igc3JjPSJjb250ZW50L3Vuc3VwcG9y dGVkX3RyYWNrLm1vdiI+Ci0gICAgICAgICAgICA8c291cmNlIGlkPXN1cHBvcnRlZC1mb3JtYXQt bXA0IHNyYz1jb250ZW50L3Rlc3QubXA0IHR5cGU9InZpZGVvL21wZWc7IGNvZGVjcz0mcXVvdDth dmMxLjRENDAwQyZxdW90OyI+CisgICAgICAgICAgICA8c291cmNlIGlkPXN1cHBvcnRlZC1mb3Jt YXQtbXA0IHNyYz1jb250ZW50L3Rlc3QubXA0IHR5cGU9InZpZGVvL21wNDsgY29kZWNzPSZxdW90 O2F2YzEuNEQ0MDBDJnF1b3Q7Ij4KICAgICAgICAgICAgIDxzb3VyY2UgaWQ9c3VwcG9ydGVkLWZv cm1hdC1vZ3Ygc3JjPWNvbnRlbnQvdGVzdC5vZ3YgdHlwZT0idmlkZW8vb2dnIj4KICAgICAgICAg PC92aWRlbz4KICAgICAgICAgCkluZGV4OiBMYXlvdXRUZXN0cy9tZWRpYS92aWRlby1zb3VyY2Ut dHlwZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL21lZGlhL3ZpZGVvLXNvdXJjZS10 eXBlLmh0bWwJKHJldmlzaW9uIDg5MzUxKQorKysgTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tc291 cmNlLXR5cGUuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMTgsNyArMTgsNyBAQAogICAgICAgICA8 c291cmNlIHNyYz1jb250ZW50L2Vycm9yLm1wZWcgdHlwZT12aWRlby9ibGFoYmxhaD4KICAgICAg ICAgPHNvdXJjZSBzcmM9dGVzdC5tcDQgdHlwZT12aWRlby94LWNoaWNrZW4tZmFjZT4KICAgICAg ICAgPHNvdXJjZSBzcmM9dGVzdC5vZ3YgdHlwZT1hdWRpby94LWhpZ2dsZXR5LXBpZ2dsZXR5Pgot ICAgICAgICA8c291cmNlIHNyYz1jb250ZW50L3Rlc3QubXA0IHR5cGU9dmlkZW8vbXBlZz4KKyAg ICAgICAgPHNvdXJjZSBzcmM9Y29udGVudC90ZXN0Lm1wNCB0eXBlPXZpZGVvL21wND4KICAgICAg ICAgPHNvdXJjZSBzcmM9Y29udGVudC90ZXN0Lm9ndiB0eXBlPXZpZGVvL29nZz4KICAgICAgICAg PHNvdXJjZSBzcmM9Y29udGVudC9lcnJvcjIubXBlZyB0eXBlPXZpZGVvL21wZWc+CiAgICAgPC92 aWRlbz4K