63271 2011-06-23 12:20:58 -0700 Pass Strings as const references in NetworkResourcesData.h 2011-06-23 14:40:07 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tony tony jberlin pfeldman webkit.review.bot oldest_to_newest 426353 0 tony 2011-06-23 12:20:58 -0700 Pass Strings as const references in NetworkResourcesData.h 426354 1 98379 tony 2011-06-23 12:21:26 -0700 Created attachment 98379 Patch 426381 2 98379 webkit.review.bot 2011-06-23 12:53:55 -0700 Comment on attachment 98379 Patch Clearing flags on attachment: 98379 Committed r89604: <http://trac.webkit.org/changeset/89604> 426382 3 webkit.review.bot 2011-06-23 12:54:00 -0700 All reviewed patches have been landed. Closing bug. 426455 4 jberlin 2011-06-23 14:16:08 -0700 Looks like this is causing crashes on SL WK2: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r89604%20(12857)/results.html 426473 5 jberlin 2011-06-23 14:34:27 -0700 Andreas suggested that I roll this out unless Tony shows up soon to address it. 426481 6 jberlin 2011-06-23 14:40:07 -0700 The crash appears to have gone away, so I won't roll this patch out. I will keep an eye on that bot. 98379 2011-06-23 12:21:26 -0700 2011-06-23 12:53:55 -0700 Patch bug-63271-20110623122106.patch text/plain 2239 tony U3VidmVyc2lvbiBSZXZpc2lvbjogODk0OTIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzYmI5NzliOTZkMjk0MjU0 ZjcwYTBhNDJiNThjZDI3Zjc1NWM5YWMxLi40YTUxMjFmNjJkM2VhNjgwY2M3NDA0YWRiNGI1MGMy YTk2MTlkMmYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDYtMjMgIFRvbnkg Q2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBQYXNzIFN0cmluZ3MgYXMgY29uc3QgcmVmZXJlbmNlcyBpbiBO ZXR3b3JrUmVzb3VyY2VzRGF0YS5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD02MzI3MQorCisgICAgICAgICogaW5zcGVjdG9yL05ldHdvcmtSZXNvdXJj ZXNEYXRhLmg6CisgICAgICAgIChXZWJDb3JlOjpOZXR3b3JrUmVzb3VyY2VzRGF0YTo6UmVzb3Vy Y2VEYXRhOjpzZXRGcmFtZUlkKToKKyAgICAgICAgKFdlYkNvcmU6Ok5ldHdvcmtSZXNvdXJjZXNE YXRhOjpSZXNvdXJjZURhdGE6OnNldFVybCk6CisgICAgICAgIChXZWJDb3JlOjpOZXR3b3JrUmVz b3VyY2VzRGF0YTo6UmVzb3VyY2VEYXRhOjpzZXRUZXh0RW5jb2RpbmdOYW1lKToKKwogMjAxMS0w Ni0yMiAgQW5uaWUgU3VsbGl2YW4gIDxzdWxsaXZhbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgUnlvc3VrZSBOaXdhLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL05ldHdvcmtSZXNvdXJjZXNEYXRhLmggYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv TmV0d29ya1Jlc291cmNlc0RhdGEuaAppbmRleCA5YTk3ZjhlN2Q4NGNmYTMyNzM1ZjVjYTNkYjdj M2QwZmQxZjZlZTczLi43OGNkYmViZmFhNzNmNjgxOGU4MDJmYTAzOWJhZjllYzc1Yzc5YTk1IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvTmV0d29ya1Jlc291cmNlc0RhdGEu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvTmV0d29ya1Jlc291cmNlc0RhdGEuaApA QCAtNTYsMTAgKzU2LDEwIEBAIHB1YmxpYzoKICAgICAgICAgU3RyaW5nIGxvYWRlcklkKCkgY29u c3QgeyByZXR1cm4gbV9sb2FkZXJJZDsgfQogCiAgICAgICAgIFN0cmluZyBmcmFtZUlkKCkgY29u c3QgeyByZXR1cm4gbV9mcmFtZUlkOyB9Ci0gICAgICAgIHZvaWQgc2V0RnJhbWVJZChTdHJpbmcg ZnJhbWVJZCkgeyBtX2ZyYW1lSWQgPSBmcmFtZUlkOyB9CisgICAgICAgIHZvaWQgc2V0RnJhbWVJ ZChjb25zdCBTdHJpbmcmIGZyYW1lSWQpIHsgbV9mcmFtZUlkID0gZnJhbWVJZDsgfQogCiAgICAg ICAgIFN0cmluZyB1cmwoKSBjb25zdCB7IHJldHVybiBtX3VybDsgfQotICAgICAgICB2b2lkIHNl dFVybChTdHJpbmcgdXJsKSB7IG1fdXJsID0gdXJsOyB9CisgICAgICAgIHZvaWQgc2V0VXJsKGNv bnN0IFN0cmluZyYgdXJsKSB7IG1fdXJsID0gdXJsOyB9CiAKICAgICAgICAgYm9vbCBoYXNDb250 ZW50KCkgY29uc3QgeyByZXR1cm4gbV9oYXNDb250ZW50OyB9CiAgICAgICAgIFN0cmluZyBjb250 ZW50KCk7CkBAIC03Niw3ICs3Niw3IEBAIHB1YmxpYzoKICAgICAgICAgdm9pZCBzZXRCdWZmZXIo UGFzc1JlZlB0cjxTaGFyZWRCdWZmZXI+IGJ1ZmZlcikgeyBtX2J1ZmZlciA9IGJ1ZmZlcjsgfQog CiAgICAgICAgIFN0cmluZyB0ZXh0RW5jb2RpbmdOYW1lKCkgY29uc3QgeyByZXR1cm4gbV90ZXh0 RW5jb2RpbmdOYW1lOyB9Ci0gICAgICAgIHZvaWQgc2V0VGV4dEVuY29kaW5nTmFtZShTdHJpbmcg dGV4dEVuY29kaW5nTmFtZSkgeyBtX3RleHRFbmNvZGluZ05hbWUgPSB0ZXh0RW5jb2RpbmdOYW1l OyB9CisgICAgICAgIHZvaWQgc2V0VGV4dEVuY29kaW5nTmFtZShjb25zdCBTdHJpbmcmIHRleHRF bmNvZGluZ05hbWUpIHsgbV90ZXh0RW5jb2RpbmdOYW1lID0gdGV4dEVuY29kaW5nTmFtZTsgfQog CiAgICAgICAgIENhY2hlZFJlc291cmNlKiBjYWNoZWRSZXNvdXJjZSgpIGNvbnN0IHsgcmV0dXJu IG1fY2FjaGVkUmVzb3VyY2UuZ2V0KCk7IH0KICAgICAgICAgdm9pZCBzZXRDYWNoZWRSZXNvdXJj ZShDYWNoZWRSZXNvdXJjZSogY2FjaGVkUmVzb3VyY2UpIHsgbV9jYWNoZWRSZXNvdXJjZSA9IGNh Y2hlZFJlc291cmNlOyB9Cg==