63260 2011-06-23 09:40:05 -0700 [chromium] Fix WebScrollBarImpl on Mac after recent smooth scrolling changes 2011-06-23 10:36:25 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jam jam jamesr mihaip sail scottbyer thakis tony oldest_to_newest 426231 0 jam 2011-06-23 09:40:05 -0700 [chromium] Fix WebScrollBarImpl on Mac after recent smooth scrolling changes 426236 1 98360 jam 2011-06-23 09:50:28 -0700 Created attachment 98360 Patch 426245 2 jam 2011-06-23 10:01:27 -0700 Sailesh/Scott: can one of you look at this to see if it's reasonable? Tony can then approve. Background: the chrome pdf plugin reuses WebKit scrollbars through the WebScrollbar API. Sometime in the last few weeks, it stopped working on Mac. It looks to me like it's related to the smooth scrolling code, since methods on ScrollableArea that weren't used before started being called. This is tested in Chrome, but unfortunately there was another problem with the mac bots that run these tests so that they were red before this regressed. I'm following up on getting those green again. 426266 3 sail 2011-06-23 10:25:13 -0700 Looks good to me. It might be good to replace references to smooth scrolling with "ScrollAnimator". Currently we use the scroll animator with smooth scrolling disabled. 426276 4 jam 2011-06-23 10:35:35 -0700 done. thanks for the quick lookover. i will merge this to m13 branch as well. 426280 5 jam 2011-06-23 10:36:18 -0700 Committed r89584: <http://trac.webkit.org/changeset/89584> (webkit-patch land crashed) 98360 2011-06-23 09:50:28 -0700 2011-06-23 10:28:57 -0700 Patch bug-63260-20110623094909.patch text/plain 2642 jam SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA4OTU3OSkKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMDYtMjMgIEpvaG4gQWJkLUVsLU1hbGVrICA8amFtQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1d IEZpeCBXZWJTY3JvbGxCYXJJbXBsIG9uIE1hYyBhZnRlciByZWNlbnQgc21vb3RoIHNjcm9sbGlu ZyBjaGFuZ2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD02MzI2MAorCisgICAgICAgICogc3JjL1dlYlNjcm9sbGJhckltcGwuY3BwOgorICAgICAgICAo V2ViS2l0OjpXZWJTY3JvbGxiYXJJbXBsOjp2aXNpYmxlSGVpZ2h0KToKKyAgICAgICAgKFdlYktp dDo6V2ViU2Nyb2xsYmFySW1wbDo6dmlzaWJsZVdpZHRoKToKKyAgICAgICAgKFdlYktpdDo6V2Vi U2Nyb2xsYmFySW1wbDo6Y29udGVudHNTaXplKToKKyAgICAgICAgKFdlYktpdDo6V2ViU2Nyb2xs YmFySW1wbDo6b3ZlcmhhbmdBbW91bnQpOgorICAgICAgICAqIHNyYy9XZWJTY3JvbGxiYXJJbXBs Lmg6CisKIDIwMTEtMDYtMjMgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgUm9sbGVkIERFUFMuCkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJT Y3JvbGxiYXJJbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJTY3JvbGxiYXJJbXBsLmNwcAkocmV2aXNpb24gODk1NDMpCisrKyBTb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3NyYy9XZWJTY3JvbGxiYXJJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzE0 LDQgKzMxNCwyOCBAQCBTY3JvbGxiYXIqIFdlYlNjcm9sbGJhckltcGw6OnZlcnRpY2FsU2NyCiAg ICAgcmV0dXJuIG1fc2Nyb2xsYmFyLT5vcmllbnRhdGlvbigpID09IFZlcnRpY2FsU2Nyb2xsYmFy ID8gbV9zY3JvbGxiYXIuZ2V0KCkgOiAwOwogfQogCitpbnQgV2ViU2Nyb2xsYmFySW1wbDo6dmlz aWJsZUhlaWdodCgpIGNvbnN0Cit7CisgICAgcmV0dXJuIG1fc2Nyb2xsYmFyLT5oZWlnaHQoKTsK K30KKworaW50IFdlYlNjcm9sbGJhckltcGw6OnZpc2libGVXaWR0aCgpIGNvbnN0Cit7CisgICAg cmV0dXJuIG1fc2Nyb2xsYmFyLT53aWR0aCgpOworfQorCitJbnRTaXplIFdlYlNjcm9sbGJhcklt cGw6OmNvbnRlbnRzU2l6ZSgpIGNvbnN0Cit7CisgICAgLy8gVGhpcyBpc24ndCB0ZWNobmljYWxs eSBjb3JyZWN0LCBzaW5jZSB3ZSBkb24ndCBoYXZlIHRoZSBjb250ZW50U2l6ZS4gSG93ZXZlciBp dCdzIGdvb2QgZW5vdWdoCisgICAgLy8gdG8gbWFrZSB0aGUgc21vb3RoIHNjcm9sbGluZyBzY3Jv bGxiYXIgY29kZSBoYXBweS4KKyAgICBpbnQgdGhpY2tuZXNzID0gZGVmYXVsdFRoaWNrbmVzcygp OworICAgIGludCBsZW5ndGggPSBtX3Njcm9sbGJhci0+dG90YWxTaXplKCk7CisgICAgcmV0dXJu IG1fc2Nyb2xsYmFyLT5vcmllbnRhdGlvbigpID09IFZlcnRpY2FsU2Nyb2xsYmFyID8gSW50U2l6 ZSh0aGlja25lc3MsIGxlbmd0aCkgOiBJbnRTaXplKGxlbmd0aCwgdGhpY2tuZXNzKTsKK30KKwor SW50U2l6ZSBXZWJTY3JvbGxiYXJJbXBsOjpvdmVyaGFuZ0Ftb3VudCgpIGNvbnN0Cit7CisgICAg cmV0dXJuIEludFNpemUoKTsKK30KKwogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CkluZGV4OiBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTY3JvbGxiYXJJbXBsLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2Nyb2xsYmFySW1wbC5oCShyZXZpc2lvbiA4 OTU0MykKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNjcm9sbGJhckltcGwuaAko d29ya2luZyBjb3B5KQpAQCAtNjksNiArNjksMTAgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9p ZCBnZXRUaWNrbWFya3MoVmVjdG9yPFdlYkNvcmU6OkludFJlY3Q+JikgY29uc3Q7CiAgICAgdmly dHVhbCBXZWJDb3JlOjpTY3JvbGxiYXIqIGhvcml6b250YWxTY3JvbGxiYXIoKSBjb25zdDsKICAg ICB2aXJ0dWFsIFdlYkNvcmU6OlNjcm9sbGJhciogdmVydGljYWxTY3JvbGxiYXIoKSBjb25zdDsK KyAgICB2aXJ0dWFsIGludCB2aXNpYmxlSGVpZ2h0KCkgY29uc3Q7CisgICAgdmlydHVhbCBpbnQg dmlzaWJsZVdpZHRoKCkgY29uc3Q7CisgICAgdmlydHVhbCBXZWJDb3JlOjpJbnRTaXplIGNvbnRl bnRzU2l6ZSgpIGNvbnN0OworICAgIHZpcnR1YWwgV2ViQ29yZTo6SW50U2l6ZSBvdmVyaGFuZ0Ft b3VudCgpIGNvbnN0OwogCiBwcml2YXRlOgogICAgIGJvb2wgb25Nb3VzZURvd24oY29uc3QgV2Vi SW5wdXRFdmVudCYgZXZlbnQpOwo=