63250 2011-06-23 05:40:29 -0700 Web Inspector: [Chromium] Fix showing dominator leaf nodes after r89457 2011-06-23 05:52:11 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mnaganov mnaganov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 426101 0 mnaganov 2011-06-23 05:40:29 -0700 I forgot to update WebInspector.HeapSnapshotFilteredOrderedIterator.isEmpty. This results in showing leaf nodes as if they have children. 426103 1 98338 mnaganov 2011-06-23 05:42:26 -0700 Created attachment 98338 patch 426109 2 mnaganov 2011-06-23 05:52:11 -0700 Manually committed http://trac.webkit.org/changeset/89562 2011-06-23 Mikhail Naganov <mnaganov@chromium.org> Reviewed by Yury Semikhatsky. Web Inspector: [Chromium] Fix showing dominator leaf nodes after r89457 https://bugs.webkit.org/show_bug.cgi?id=63250 * inspector/front-end/DetailedHeapshotView.js: * inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.get isEmpty): 98338 2011-06-23 05:42:26 -0700 2011-06-23 05:47:27 -0700 patch patch-63250 text/plain 2849 mnaganov ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5NzU4ZjJkLi43YTZlNDcxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMDYtMjMgIE1pa2hhaWwgTmFnYW5vdiAgPG1uYWdhbm92QGNocm9taXVtLm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5z cGVjdG9yOiBbQ2hyb21pdW1dIEZpeCBzaG93aW5nIGRvbWluYXRvciBsZWFmIG5vZGVzIGFmdGVy IHI4OTQ1NworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NjMyNTAKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvRGV0YWlsZWRIZWFwc2hvdFZp ZXcuanM6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9IZWFwU25hcHNob3QuanM6Cisg ICAgICAgIChXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90RmlsdGVyZWRPcmRlcmVkSXRlcmF0b3Iu cHJvdG90eXBlLmdldCBpc0VtcHR5KToKKwogMjAxMS0wNi0yMiAgRGlyayBTY2h1bHplICA8a3Jp dEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFJvYiBCdWlzLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9EZXRhaWxlZEhlYXBzaG90Vmll dy5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRGV0YWlsZWRIZWFwc2hv dFZpZXcuanMKaW5kZXggNDgxYTg4OS4uNDI2NTM3ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9EZXRhaWxlZEhlYXBzaG90Vmlldy5qcworKysgYi9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RldGFpbGVkSGVhcHNob3RWaWV3LmpzCkBA IC05MTIsNyArOTEyLDcgQEAgV2ViSW5zcGVjdG9yLkRldGFpbGVkSGVhcHNob3RWaWV3LnByb3Rv dHlwZSA9IHsKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgdmFyIHJvdyA9IGV2ZW50LnRh cmdldC5lbmNsb3NpbmdOb2RlT3JTZWxmV2l0aE5vZGVOYW1lKCJ0ciIpOwogICAgICAgICB2YXIg bm9kZUl0ZW0gPSByb3cuX2RhdGFHcmlkTm9kZTsKLSAgICAgICAgaWYgKCFub2RlSXRlbSkKKyAg ICAgICAgaWYgKCFub2RlSXRlbSB8fCAhbm9kZUl0ZW0ucm91dGUpCiAgICAgICAgICAgICByZXR1 cm47CiAgICAgICAgIGZ1bmN0aW9uIGV4cGFuZFJvdXRlKCkKICAgICAgICAgewpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9IZWFwU25hcHNob3QuanMgYi9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0hlYXBTbmFwc2hvdC5qcwppbmRleCBl MTY1YTY5Li41MjIxYzcxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL0hlYXBTbmFwc2hvdC5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL0hlYXBTbmFwc2hvdC5qcwpAQCAtMTA3NSwxMyArMTA3NSwyNSBAQCBXZWJJbnNwZWN0 b3IuSGVhcFNuYXBzaG90RmlsdGVyZWRPcmRlcmVkSXRlcmF0b3IucHJvdG90eXBlID0gewogICAg IHsKICAgICAgICAgaWYgKHRoaXMuX2l0ZXJhdGlvbk9yZGVyKQogICAgICAgICAgICAgcmV0dXJu ICF0aGlzLl9pdGVyYXRpb25PcmRlci5sZW5ndGg7CisgICAgICAgIGlmICh0aGlzLl91bmZpbHRl cmVkSXRlcmF0aW9uT3JkZXIgJiYgIXRoaXMuX2ZpbHRlcikKKyAgICAgICAgICAgIHJldHVybiAh dGhpcy5fdW5maWx0ZXJlZEl0ZXJhdGlvbk9yZGVyLmxlbmd0aDsKICAgICAgICAgdmFyIGl0ZXJh dG9yID0gdGhpcy5faXRlcmF0b3I7Ci0gICAgICAgIGlmICghdGhpcy5fZmlsdGVyKSB7CisgICAg ICAgIGlmICghdGhpcy5fdW5maWx0ZXJlZEl0ZXJhdGlvbk9yZGVyICYmICF0aGlzLl9maWx0ZXIp IHsKICAgICAgICAgICAgIGl0ZXJhdG9yLmZpcnN0KCk7CiAgICAgICAgICAgICByZXR1cm4gIWl0 ZXJhdG9yLmhhc05leHQoKTsKKyAgICAgICAgfSBlbHNlIGlmICghdGhpcy5fdW5maWx0ZXJlZEl0 ZXJhdGlvbk9yZGVyKSB7CisgICAgICAgICAgICBmb3IgKGl0ZXJhdG9yLmZpcnN0KCk7IGl0ZXJh dG9yLmhhc05leHQoKTsgaXRlcmF0b3IubmV4dCgpKQorICAgICAgICAgICAgICAgIGlmICh0aGlz Ll9maWx0ZXIoaXRlcmF0b3IuaXRlbSkpCisgICAgICAgICAgICAgICAgICAgIHJldHVybiBmYWxz ZTsKKyAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIHZhciBvcmRlciA9IHRoaXMuX3VuZmls dGVyZWRJdGVyYXRpb25PcmRlci5jb25zdHJ1Y3RvciA9PT0gQXJyYXkgPworICAgICAgICAgICAg ICAgIHRoaXMuX3VuZmlsdGVyZWRJdGVyYXRpb25PcmRlciA6IHRoaXMuX3VuZmlsdGVyZWRJdGVy YXRpb25PcmRlci5zbGljZSgwKTsKKyAgICAgICAgICAgIGZvciAodmFyIGkgPSAwLCBsID0gb3Jk ZXIubGVuZ3RoOyBpIDwgbDsgKytpKSB7CisgICAgICAgICAgICAgICAgaXRlcmF0b3IuaW5kZXgg PSBvcmRlcltpXTsKKyAgICAgICAgICAgICAgICBpZiAodGhpcy5fZmlsdGVyKGl0ZXJhdG9yLml0 ZW0pKQorICAgICAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgICAgICAgICB9CiAg ICAgICAgIH0KLSAgICAgICAgZm9yIChpdGVyYXRvci5maXJzdCgpOyBpdGVyYXRvci5oYXNOZXh0 KCk7IGl0ZXJhdG9yLm5leHQoKSkKLSAgICAgICAgICAgIGlmICh0aGlzLl9maWx0ZXIoaXRlcmF0 b3IuaXRlbSkpIHJldHVybiBmYWxzZTsKICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgfSwKIAo=