63244 2011-06-23 04:28:37 -0700 [Qt] Fix tst_QWebPage::showModalDialog() API test 2012-11-12 07:31:31 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 38654 1 ossy jturcotte hausmann jturcotte ossy sergio.ahumada oldest_to_newest 426075 0 ossy 2011-06-23 04:28:37 -0700 http://build.webkit.org/builders/Qt%20Linux%20Release/builds/34519 FAIL! : tst_QWebPage::showModalDialog() Compared values are not the same Actual (res): Expected (QString("This is a test")): This is a test Loc: [/ramdisk/qt-linux-release/build/Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp(2796)] 426104 1 ossy 2011-06-23 05:50:20 -0700 Marked as expected fail until fix: http://trac.webkit.org/changeset/89560 553498 2 sergio.ahumada 2012-02-09 14:20:33 -0800 This test is passing in Qt Project CI 2/10/12 7:06:24 AM EST: XPASS : tst_QWebPage::showModalDialog() COMPARE() 2/10/12 7:06:24 AM EST: Loc: [../../../src/3rdparty/webkit/Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp(2830)] 670231 3 152507 sergio.ahumada 2012-07-16 04:15:11 -0700 Created attachment 152507 Remove QEXPECT_FAIL for tests marked as XPASS. This patch also applies to https://bugs.webkit.org/show_bug.cgi?id=63245 676457 4 152507 hausmann 2012-07-24 00:23:43 -0700 Comment on attachment 152507 Remove QEXPECT_FAIL for tests marked as XPASS. Hmm, in principle this sounds okay to me. But the patch doesn't apply, it uses src/3rdparty/webkit as prefix. Did you make this patch against Qt 4.8? It sounds like it needs to be rebased against WebKit trunk. The patch is also missing a ChangeLog entry. 763051 5 173315 jturcotte 2012-11-09 08:54:53 -0800 Created attachment 173315 Patch 763639 6 173315 hausmann 2012-11-10 06:01:39 -0800 Comment on attachment 173315 Patch Makes you wonder how this ever passed :) 764402 7 jturcotte 2012-11-12 07:31:31 -0800 Committed r134234: <http://trac.webkit.org/changeset/134234> 152507 2012-07-16 04:15:11 -0700 2012-11-09 08:54:45 -0800 Remove QEXPECT_FAIL for tests marked as XPASS. 0001-Qt-Fix-tst_QWebPage-showModalDialog-API-test.patch text/plain 2275 sergio.ahumada RnJvbSBhZjUzM2Y4MmY5NWU0NjM0NmZlOWU4NWYxY2M3NjcwZmVhMGRhMGM1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTZXJnaW8gQWh1bWFkYSA8c2VyZ2lvLmFodW1hZGFAbm9raWEu Y29tPgpEYXRlOiBNb24sIDE2IEp1bCAyMDEyIDEzOjA4OjI1ICswMjAwClN1YmplY3Q6ID0/VVRG LTg/cT9bUXRdPTIwRml4PTIwdHN0PTVGUVdlYlBhZ2U6OnNob3dNb2RhbERpYWxvZygpPTIwQVBJ PTIwdGU/PQogPT9VVEYtOD9xP3N0PTBBaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvdz01RmJ1 Zy5jZ2k9M0ZpZD0zRDYzMjQ0Pz0KCltRdF0gRml4IHRzdF9RV2ViUGFnZTo6dGVzdFN0b3BTY2hl ZHVsZWRQYWdlUmVmcmVzaCgpIEFQSSB0ZXN0Cmh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD02MzI0NQoKKiB0ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBhZ2UuY3BwOiBSZW1v dmUgUUVYUEVDVF9GQUlMIGZvciB0ZXN0cyBtYXJrZWQgYXMgWFBBU1MuCih0c3RfUVdlYlBhZ2U6 OnNob3dNb2RhbERpYWxvZyk6Cih0c3RfUVdlYlBhZ2U6OnRlc3RTdG9wU2NoZWR1bGVkUGFnZVJl ZnJlc2gpOgoKQ2hhbmdlLUlkOiBJYjRjYzliY2ExNmMzZDI1YTUxODJiYWQ1YjQ4YTFlMzQwNWQ0 OTFiMQotLS0KIC4uLi9XZWJLaXQvcXQvdGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJwYWdlLmNwcCAg ICAgIHwgICAgMyAtLS0KIDEgZmlsZXMgY2hhbmdlZCwgMCBpbnNlcnRpb25zKCspLCAzIGRlbGV0 aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy8zcmRwYXJ0eS93ZWJraXQvU291cmNlL1dlYktpdC9x dC90ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBhZ2UuY3BwIGIvc3JjLzNyZHBhcnR5L3dlYmtpdC9T b3VyY2UvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHAKaW5kZXggNjEw MjEwMi4uNzFkZDI3OCAxMDA2NDQKLS0tIGEvc3JjLzNyZHBhcnR5L3dlYmtpdC9Tb3VyY2UvV2Vi S2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHAKKysrIGIvc3JjLzNyZHBhcnR5 L3dlYmtpdC9Tb3VyY2UvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHAK QEAgLTI4MjYsNyArMjgyNiw2IEBAIHZvaWQgdHN0X1FXZWJQYWdlOjpzaG93TW9kYWxEaWFsb2co KQogICAgIFRlc3RNb2RhbFBhZ2UgcGFnZTsKICAgICBwYWdlLm1haW5GcmFtZSgpLT5zZXRIdG1s KFFTdHJpbmcoIjxodG1sPjwvaHRtbD4iKSk7CiAgICAgUVN0cmluZyByZXMgPSBwYWdlLm1haW5G cmFtZSgpLT5ldmFsdWF0ZUphdmFTY3JpcHQoIndpbmRvdy5zaG93TW9kYWxEaWFsb2coJ2phdmFz Y3JpcHQ6d2luZG93LnJldHVyblZhbHVlPWRpYWxvZ0FyZ3VtZW50czsgd2luZG93LmNsb3NlKCk7 JywgJ1RoaXMgaXMgYSB0ZXN0Jyk7IikudG9TdHJpbmcoKTsKLSAgICBRRVhQRUNUX0ZBSUwoIiIs ICJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjMyNDQiLCBDb250aW51 ZSk7CiAgICAgUUNPTVBBUkUocmVzLCBRU3RyaW5nKCJUaGlzIGlzIGEgdGVzdCIpKTsKIH0KIApA QCAtMjgzOSwxMCArMjgzOCw4IEBAIHZvaWQgdHN0X1FXZWJQYWdlOjp0ZXN0U3RvcFNjaGVkdWxl ZFBhZ2VSZWZyZXNoKCkKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIjxtZXRhIGh0 dHAtZXF1aXY9XCJyZWZyZXNoXCJjb250ZW50PVwiMDtVUkw9cXJjOi8vL3Jlc291cmNlcy9pbmRl eC5odG1sXCI+IgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiPC9oZWFkPjxib2R5 PjxoMT5QYWdlIHJlZGlyZWN0cyBpbW1lZGlhdGVseS4uLjwvaDE+IgogICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAiPC9ib2R5PjwvaHRtbD4iKTsKLSAgICBRRVhQRUNUX0ZBSUwoIiIs ICJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjMyNDUiLCBDb250aW51 ZSk7CiAgICAgUVZFUklGWSg6OndhaXRGb3JTaWduYWwoJnBhZ2UxLCBTSUdOQUwobG9hZEZpbmlz aGVkKGJvb2wpKSkpOwogICAgIFFUZXN0OjpxV2FpdCg1MDApOwotICAgIFFFWFBFQ1RfRkFJTCgi IiwgImh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MzI0NSIsIENvbnRp bnVlKTsKICAgICBRQ09NUEFSRShwYWdlMS5tYWluRnJhbWUoKS0+dXJsKCksIFFVcmwoUUxhdGlu MVN0cmluZygicXJjOi8vL3Jlc291cmNlcy9pbmRleC5odG1sIikpKTsKICAgICAKICAgICAvLyBX aXRoIFFXZWJQYWdlOjpTdG9wU2NoZWR1bGVkUGFnZVJlZnJlc2gKLS0gCjEuNy43LjYKCg== 173315 2012-11-09 08:54:53 -0800 2012-11-10 06:01:39 -0800 Patch bug-63244-20121109175300.patch text/plain 1567 jturcotte U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzMjg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0 L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDczYWNhZGIzMmNi NDg2YjRhYjYzNTM5MzUzZjg3OTBmZjk4OGFmYmUuLjVjNDJlN2U5ZTJkMGQ5MGZhOWI0NTQ2MTJk MjdhZGYyNDZlOTZjNWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAKIDIwMTItMTEt MDkgIEpvY2VseW4gVHVyY290dGUgIDxqb2NlbHluLnR1cmNvdHRlQGRpZ2lhLmNvbT4KIAorICAg ICAgICBbUXRdIEZpeCB0c3RfUVdlYlBhZ2U6OnNob3dNb2RhbERpYWxvZygpIEFQSSB0ZXN0Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MzI0NAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogdGVzdHMvcXdl YnBhZ2UvdHN0X3F3ZWJwYWdlLmNwcDoKKworMjAxMi0xMS0wOSAgSm9jZWx5biBUdXJjb3R0ZSAg PGpvY2VseW4udHVyY290dGVAZGlnaWEuY29tPgorCiAgICAgICAgIFtRdF0gRml4IHRzdF9RV2Vi UGFnZTo6dGVzdExvY2FsU3RvcmFnZVZpc2liaWxpdHkKIAogICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcXdlYnBh Z2UvdHN0X3F3ZWJwYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcXdlYnBhZ2UvdHN0 X3F3ZWJwYWdlLmNwcAppbmRleCBiZGRlNjNmNDNhNzMyZDVhZTFhYTMyZWQ2MGU0NDA3OGYyNzhj ZTM5Li41MzM1ZWFiZDAzNTVmMmNkNTA1YmRkNTMxYTk2Yzg4NjM2MDg4ZTQ3IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHAKKysrIGIv U291cmNlL1dlYktpdC9xdC90ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBhZ2UuY3BwCkBAIC0yOTE1 LDkgKzI5MTUsOSBAQCBwdWJsaWM6CiB2b2lkIHRzdF9RV2ViUGFnZTo6c2hvd01vZGFsRGlhbG9n KCkKIHsKICAgICBUZXN0TW9kYWxQYWdlIHBhZ2U7CisgICAgcGFnZS5zZXR0aW5ncygpLT5zZXRB dHRyaWJ1dGUoUVdlYlNldHRpbmdzOjpKYXZhc2NyaXB0Q2FuT3BlbldpbmRvd3MsIHRydWUpOwog ICAgIHBhZ2UubWFpbkZyYW1lKCktPnNldEh0bWwoUVN0cmluZygiPGh0bWw+PC9odG1sPiIpKTsK ICAgICBRU3RyaW5nIHJlcyA9IHBhZ2UubWFpbkZyYW1lKCktPmV2YWx1YXRlSmF2YVNjcmlwdCgi d2luZG93LnNob3dNb2RhbERpYWxvZygnamF2YXNjcmlwdDp3aW5kb3cucmV0dXJuVmFsdWU9ZGlh bG9nQXJndW1lbnRzOyB3aW5kb3cuY2xvc2UoKTsnLCAnVGhpcyBpcyBhIHRlc3QnKTsiKS50b1N0 cmluZygpOwotICAgIFFFWFBFQ1RfRkFJTCgiIiwgImh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD02MzI0NCIsIENvbnRpbnVlKTsKICAgICBRQ09NUEFSRShyZXMsIFFTdHJp bmcoIlRoaXMgaXMgYSB0ZXN0IikpOwogfQogCg==