63239 2011-06-23 02:38:48 -0700 [X11][WK2] plugins/mouse-evets-fixedpos.html is failing because of broken event propagation 2011-07-01 09:17:59 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kbalazs kbalazs oldest_to_newest 426047 0 kbalazs 2011-06-23 02:38:48 -0700 In the event handler methods of NetscapePlugin we return with the return value of NPP_HandleEvent. It has been copied from the Mac implementation. This is wrong since on X11 the plugin return with 0 if it handled the event so we need to revert it. The result of this bug is that we immediately remove the focus from the plugin element just after it has been given to it. 426057 1 98329 kbalazs 2011-06-23 03:07:33 -0700 Created attachment 98329 Patch 426071 2 kbalazs 2011-06-23 03:51:19 -0700 Current result (without the patch): CONSOLE MESSAGE: line 0: PLUGIN: getFocusEvent CONSOLE MESSAGE: line 0: PLUGIN: mouseDown at (50, 50) CONSOLE MESSAGE: line 0: PLUGIN: loseFocusEvent CONSOLE MESSAGE: line 0: PLUGIN: mouseUp at (50, 50) CONSOLE MESSAGE: line 0: PLUGIN: getFocusEvent CONSOLE MESSAGE: line 0: PLUGIN: mouseDown at (60, 60) CONSOLE MESSAGE: line 0: PLUGIN: loseFocusEvent CONSOLE MESSAGE: line 0: PLUGIN: mouseUp at (70, 60) Tests for widget positions being correctly updated after scrolling. rdar://problem/7559069 Expected result: CONSOLE MESSAGE: line 0: PLUGIN: getFocusEvent CONSOLE MESSAGE: line 0: PLUGIN: mouseDown at (50, 50) CONSOLE MESSAGE: line 0: PLUGIN: mouseUp at (50, 50) CONSOLE MESSAGE: line 0: PLUGIN: mouseDown at (60, 60) CONSOLE MESSAGE: line 0: PLUGIN: mouseUp at (70, 60) Tests for widget positions being correctly updated after scrolling. rdar://problem/7559069 431173 3 98329 kling 2011-07-01 08:41:42 -0700 Comment on attachment 98329 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98329&action=review I find it suspicious that the return value convention is in violation of https://developer.mozilla.org/en/NPP_HandleEvent but it's indeed what we already do in WebKit1. > Source/WebKit2/ChangeLog:9 > + Revert the return value of NPP_HandleEvent because the plugin function Revert -> Invert 431204 4 kbalazs 2011-07-01 09:17:59 -0700 Committed r90231: <http://trac.webkit.org/changeset/90231> 98329 2011-06-23 03:07:33 -0700 2011-07-01 08:41:42 -0700 Patch bug-63239-20110623100731.patch text/plain 4431 kbalazs U3VidmVyc2lvbiBSZXZpc2lvbjogODkwMjMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA2NmY2YTQ5ZGY0M2I3MGNkM2Y5Yzg4 MDQxMzIwMmM5MGYxYjFiZjIyLi5hNjg3MDVjMTgyN2E5Y2MwMjZkMjlmMDU1ZWQ4YzM0ODQ4MGJm N2M2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDYtMjMgIEJhbGF6cyBLZWxlbWVuICA8 a2JhbGF6c0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFtYMTFdW1dLMl0gcGx1Z2lucy9tb3VzZS1ldmV0cy1maXhlZHBvcy5odG1s IGlzIGZhaWxpbmcgYmVjYXVzZSBvZiBicm9rZW4gZXZlbnQgcHJvcGFnYXRpb24KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYzMjM5CisKKyAgICAgICAg KiBwbGF0Zm9ybS9xdC13azIvU2tpcHBlZDoKKwogMjAxMS0wNi0xNiAgVml0YWx5IFJlcGVzaGtv ICA8dml0YWx5ckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZC4KZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0LXdrMi9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxh dGZvcm0vcXQtd2syL1NraXBwZWQKaW5kZXggYWZlY2QyZmM4YTcwNWJjZGU1Y2Q4YWZmMjFkODVj YTU2NzZkOTUwZS4uMTc0MTg5N2JjZDYyZmRiNzRkNTIyN2ZkYmIxZTdlOGNkNzgxNGM0ZiAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQtd2syL1NraXBwZWQKKysrIGIvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vcXQtd2syL1NraXBwZWQKQEAgLTE5MjcsNyArMTkyNyw2IEBAIHNwdXRu aWsvQ29uZm9ybWFuY2UvMTBfRXhlY3V0aW9uX0NvbnRleHRzLzEwLjJfRW50ZXJpbmdfQW5fRXhl Y3V0aW9uX0NvbnRleHQvMTAuCiBwbHVnaW5zL2RvY3VtZW50LW9wZW4uaHRtbAogcGx1Z2lucy9l bWJlZC1wcmVmZXJzLXBsdWdpbnMtZm9yLWltYWdlcy5odG1sCiBwbHVnaW5zL2dldHVybG5vdGlm eS1kdXJpbmctZG9jdW1lbnQtdGVhcmRvd24uaHRtbAotcGx1Z2lucy9tb3VzZS1ldmVudHMtZml4 ZWRwb3MuaHRtbAogcGx1Z2lucy9uZXRzY2FwZS1kb20tYWNjZXNzLmh0bWwKIHBsdWdpbnMvbnBw LXNldC13aW5kb3ctY2FsbGVkLWR1cmluZy1kZXN0cnVjdGlvbi5odG1sCiBwbHVnaW5zL29wZW4t YW5kLWNsb3NlLXdpbmRvdy13aXRoLXBsdWdpbi5odG1sCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNjg5MmNkYjE1 N2U4YmY5M2M1Y2Y3NWQ4MjQ4OGNjN2Q5Y2Q2MDZmZS4uYTFjNzg5NmJhNjAyNTI5ZjRlMjgyN2Jj MmM2MzIwYWRiZjU0MmE1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDExLTA2LTIz ICBCYWxhenMgS2VsZW1lbiAgPGtiYWxhenNAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbWDExXVtXSzJdIHBsdWdpbnMvbW91c2Ut ZXZldHMtZml4ZWRwb3MuaHRtbCBpcyBmYWlsaW5nIGJlY2F1c2Ugb2YgYnJva2VuIGV2ZW50IHBy b3BhZ2F0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD02MzIzOQorCisgICAgICAgICogV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL3gxMS9OZXRz Y2FwZVBsdWdpblgxMS5jcHA6CisgICAgICAgIFJldmVydCB0aGUgcmV0dXJuIHZhbHVlIG9mIE5Q UF9IYW5kbGVFdmVudCBiZWNhdXNlIHRoZSBwbHVnaW4gZnVuY3Rpb24KKyAgICAgICAgcmV0dXJu cyB3aXRoIDAgaWYgaXQgaGFuZGxlZCB0aGUgZXZlbnQuCisgICAgICAgIChXZWJLaXQ6Ok5ldHNj YXBlUGx1Z2luOjpwbGF0Zm9ybUhhbmRsZU1vdXNlRXZlbnQpOgorICAgICAgICAoV2ViS2l0OjpO ZXRzY2FwZVBsdWdpbjo6cGxhdGZvcm1IYW5kbGVXaGVlbEV2ZW50KToKKyAgICAgICAgKFdlYktp dDo6TmV0c2NhcGVQbHVnaW46OnBsYXRmb3JtSGFuZGxlTW91c2VFbnRlckV2ZW50KToKKyAgICAg ICAgKFdlYktpdDo6TmV0c2NhcGVQbHVnaW46OnBsYXRmb3JtSGFuZGxlTW91c2VMZWF2ZUV2ZW50 KToKKyAgICAgICAgKFdlYktpdDo6TmV0c2NhcGVQbHVnaW46OnBsYXRmb3JtSGFuZGxlS2V5Ym9h cmRFdmVudCk6CisKIDIwMTEtMDYtMjIgIEJhbGF6cyBLZWxlbWVuICA8a2JhbGF6c0B3ZWJraXQu b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL3gxMS9OZXRzY2FwZVBs dWdpblgxMS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUv eDExL05ldHNjYXBlUGx1Z2luWDExLmNwcAppbmRleCBlYmYwNjNiN2RhMzhlNThmMmJmYmFhYzUz YjJlY2JjMTg5N2ExNmE0Li42NjFjNGY2MjY1MDU4OWUyOTc3M2RkZTU1MDJjOGM1MzljZjcyYjlh IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUv eDExL05ldHNjYXBlUGx1Z2luWDExLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L1BsdWdpbnMvTmV0c2NhcGUveDExL05ldHNjYXBlUGx1Z2luWDExLmNwcApAQCAtNDE1LDcgKzQx NSw3IEBAIGJvb2wgTmV0c2NhcGVQbHVnaW46OnBsYXRmb3JtSGFuZGxlTW91c2VFdmVudChjb25z dCBXZWJNb3VzZUV2ZW50JiBldmVudCkKICAgICAgICAgYnJlYWs7CiAgICAgfQogCi0gICAgcmV0 dXJuIE5QUF9IYW5kbGVFdmVudCgmeEV2ZW50KTsKKyAgICByZXR1cm4gIU5QUF9IYW5kbGVFdmVu dCgmeEV2ZW50KTsKIH0KIAogLy8gV2UgdW5kZWZpbmUgdGhlc2UgY29uc3RhbnRzIGluIG5wcnVu dGltZV9pbnRlcm5hbC5oIHRvIGF2b2lkIGNvbGxpc2lvbgpAQCAtNDM0LDcgKzQzNCw3IEBAIGJv b2wgTmV0c2NhcGVQbHVnaW46OnBsYXRmb3JtSGFuZGxlV2hlZWxFdmVudChjb25zdCBXZWJXaGVl bEV2ZW50JiBldmVudCkKICAgICBpbml0aWFsaXplWEV2ZW50KHhFdmVudCk7CiAgICAgc2V0WEJ1 dHRvbkV2ZW50RmllbGRzQnlXZWJXaGVlbEV2ZW50KHhFdmVudCwgZXZlbnQsIG1fZnJhbWVSZWN0 LmxvY2F0aW9uKCkpOwogCi0gICAgcmV0dXJuIE5QUF9IYW5kbGVFdmVudCgmeEV2ZW50KTsKKyAg ICByZXR1cm4gIU5QUF9IYW5kbGVFdmVudCgmeEV2ZW50KTsKIH0KIAogdm9pZCBOZXRzY2FwZVBs dWdpbjo6cGxhdGZvcm1TZXRGb2N1cyhib29sKQpAQCAtNDYxLDcgKzQ2MSw3IEBAIGJvb2wgTmV0 c2NhcGVQbHVnaW46OnBsYXRmb3JtSGFuZGxlTW91c2VFbnRlckV2ZW50KGNvbnN0IFdlYk1vdXNl RXZlbnQmIGV2ZW50KQogICAgIGluaXRpYWxpemVYRXZlbnQoeEV2ZW50KTsKICAgICBzZXRYQ3Jv c3NpbmdFdmVudEZpZWxkcyh4RXZlbnQsIGV2ZW50LCBtX2ZyYW1lUmVjdC5sb2NhdGlvbigpLCBF bnRlck5vdGlmeSk7CiAKLSAgICByZXR1cm4gTlBQX0hhbmRsZUV2ZW50KCZ4RXZlbnQpOworICAg IHJldHVybiAhTlBQX0hhbmRsZUV2ZW50KCZ4RXZlbnQpOwogfQogCiBib29sIE5ldHNjYXBlUGx1 Z2luOjpwbGF0Zm9ybUhhbmRsZU1vdXNlTGVhdmVFdmVudChjb25zdCBXZWJNb3VzZUV2ZW50JiBl dmVudCkKQEAgLTQ3Myw3ICs0NzMsNyBAQCBib29sIE5ldHNjYXBlUGx1Z2luOjpwbGF0Zm9ybUhh bmRsZU1vdXNlTGVhdmVFdmVudChjb25zdCBXZWJNb3VzZUV2ZW50JiBldmVudCkKICAgICBpbml0 aWFsaXplWEV2ZW50KHhFdmVudCk7CiAgICAgc2V0WENyb3NzaW5nRXZlbnRGaWVsZHMoeEV2ZW50 LCBldmVudCwgbV9mcmFtZVJlY3QubG9jYXRpb24oKSwgTGVhdmVOb3RpZnkpOwogCi0gICAgcmV0 dXJuIE5QUF9IYW5kbGVFdmVudCgmeEV2ZW50KTsKKyAgICByZXR1cm4gIU5QUF9IYW5kbGVFdmVu dCgmeEV2ZW50KTsKIH0KIAogc3RhdGljIGlubGluZSB2b2lkIHNldFhLZXlFdmVudEZpZWxkcyhY RXZlbnQmIHhFdmVudCwgY29uc3QgV2ViS2V5Ym9hcmRFdmVudCYgd2ViRXZlbnQpCkBAIC01MDUs NyArNTA1LDcgQEAgYm9vbCBOZXRzY2FwZVBsdWdpbjo6cGxhdGZvcm1IYW5kbGVLZXlib2FyZEV2 ZW50KGNvbnN0IFdlYktleWJvYXJkRXZlbnQmIGV2ZW50KQogICAgIGluaXRpYWxpemVYRXZlbnQo eEV2ZW50KTsKICAgICBzZXRYS2V5RXZlbnRGaWVsZHMoeEV2ZW50LCBldmVudCk7CiAKLSAgICBy ZXR1cm4gTlBQX0hhbmRsZUV2ZW50KCZ4RXZlbnQpOworICAgIHJldHVybiAhTlBQX0hhbmRsZUV2 ZW50KCZ4RXZlbnQpOwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQK