63234 2011-06-23 01:49:17 -0700 line ending strip suggestion in KeywordLookupGenerator.py 2019-06-06 04:01:43 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Enhancement --- 0 hgneng jhaygood ap aroben commit-queue jhaygood msaboff oliver pkasting siddhubadhe oldest_to_newest 426021 0 hgneng 2011-06-23 01:49:17 -0700 Hi, I am trying to build Webkit in Cygwin. The source is checkout with TortoiseSVN. When I run build-webkit, KeywordLookupGenerator.py throws error of "expected description ending with @end". I think it's a line ending issue. I suggest making a small improvement in this script: In about line 68: if not terminator == "@end" Change it to: if not terminator.rstrip() == "@end" It works for me currently although I am trying to fix another compiling issues... Thanks a lot! Cameron Wong 426339 1 ap 2011-06-23 12:03:32 -0700 Does making this change alone fix the build for you? <http://www.webkit.org/building/checkout.html> says that one should use cygwin version of svn, and I thought that a lot would break if TortoiseSVN (or another client that changes line endings) were used. 426348 2 aroben 2011-06-23 12:12:36 -0700 I think it is highly likely that there are lots of line-ending-related issue to be found if you use a non-Cygwin version of Subversion. But it would be nice to make it work! Peter Kasting did some work in this area a while back; he may know more. 426350 3 pkasting 2011-06-23 12:15:57 -0700 In general I think it's a good things to make scripts able to handle both CR and CRLF. I fixed enough issues long ago that I think there shouldn't be all that many remaining, but I would imagine they also creep in over time. I'm not going to post a patch for this particular case because I don't know python, though. 426726 4 hgneng 2011-06-23 22:07:23 -0700 > Does making this change alone fix the build for you? No. Besides adding rstrip() in KeywordLookupGenerator.py, I also added following setting in Cygwin.bat before launching bash. This can fix the issue of failing to run shell scripts before of bad line ending. set SHELLOPTS=igncr Then, I got error of non-ASCII character in: Source\WebCore\platform\DefaultLocalizationStrategy.cpp I changed the non-ASCII string into English. There is another file (forget the filename) that is non-ASCII character, but I could't find with my eye. So I re-saved that file in ASCII-only format. Now `build-webkit --debug` is successfully finish running although I am trying to figuring out how to `debug-safari`. 427007 5 pkasting 2011-06-24 11:27:48 -0700 (In reply to comment #4) > Then, I got error of non-ASCII character in: > Source\WebCore\platform\DefaultLocalizationStrategy.cpp > > I changed the non-ASCII string into English. There is another file (forget the filename) that is non-ASCII character, but I could't find with my eye. So I re-saved that file in ASCII-only format. Can you file a separate bug for these cases? We should fix these regardless; embedded Unicode (or other encodings) can cause various problems for particular build environments. 427304 6 hgneng 2011-06-24 21:03:15 -0700 > Then, I got error of non-ASCII character in: > Source\WebCore\platform\DefaultLocalizationStrategy.cpp >Can you file a separate bug for these cases? I've open a ticket for it https://bugs.webkit.org/show_bug.cgi?id=63375 870500 7 196798 jhaygood 2013-04-07 12:24:57 -0700 Created attachment 196798 Patch 870834 8 196798 jhaygood 2013-04-08 10:15:58 -0700 Comment on attachment 196798 Patch Requesting commit 870872 9 196798 commit-queue 2013-04-08 10:49:29 -0700 Comment on attachment 196798 Patch Clearing flags on attachment: 196798 Committed r147934: <http://trac.webkit.org/changeset/147934> 870873 10 commit-queue 2013-04-08 10:49:32 -0700 All reviewed patches have been landed. Closing bug. 1542345 11 siddhubadhe 2019-06-06 04:01:43 -0700 I was facing the same bug in Ubuntu, even after the patch for cygwin. In my case the CR-LF line endings were added to all the files in the repo. So I faced this problem in shebang for the build script file too. Temporarily resolved the issue by commenting the check for cygwin. Will converting the CR-LF to LF work on windows? In that case, there won't be any need for the platform check, i.e. regardless of the platform, the CR-LF, if present, will be converted to LF. 196798 2013-04-07 12:24:57 -0700 2013-04-08 10:49:28 -0700 Patch bug-63234-20130407152435.patch text/plain 1451 jhaygood SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQ3ODcyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDEzLTA0LTA3ICBKdXN0aW4gSGF5Z29vZCAgPGpoYXlnb29kQHJlYWt0aXguY29tPgorCisg ICAgICAgIEFsbG93IEtleXdvcmRMb29rdXBHZW5lcmF0b3IucHkgdG8gd29yayBvbiBXaW5kb3dz IHdpdGggV2luZG93cyBzdHlsZSBsaW5lIGVuZGluZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYzMjM0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBLZXl3b3JkTG9va3VwR2VuZXJhdG9yLnB5OgorICAg ICAgICAocGFyc2VLZXl3b3Jkcyk6CisKIDIwMTMtMDQtMDcgIE9saXZlciBIdW50ICA8b2xpdmVy QGFwcGxlLmNvbT4KIAogICAgICAgICBJbnNwZWN0b3Igc2hvdWxkIGRpc3BsYXkgaW5mb3JtYXRp b24gYWJvdXQgbm9uLW9iamVjdCBleGNlcHRpb25zCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENv cmUvS2V5d29yZExvb2t1cEdlbmVyYXRvci5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNj cmlwdENvcmUvS2V5d29yZExvb2t1cEdlbmVyYXRvci5weQkocmV2aXNpb24gMTQ3ODcyKQorKysg U291cmNlL0phdmFTY3JpcHRDb3JlL0tleXdvcmRMb29rdXBHZW5lcmF0b3IucHkJKHdvcmtpbmcg Y29weSkKQEAgLTY4LDExICs2OCwxNiBAQCBkZWYgYWxsV2hpdGVzcGFjZShzdHIpOgogCiAKIGRl ZiBwYXJzZUtleXdvcmRzKGtleXdvcmRzVGV4dCk6CisKKyAgICBpZiBzeXMucGxhdGZvcm0gPT0g ImN5Z3dpbiI6CisgICAgICAgIGtleXdvcmRzVGV4dCA9IGtleXdvcmRzVGV4dC5yZXBsYWNlKCJc clxuIiwgIlxuIikKKwogICAgIGxpbmVzID0ga2V5d29yZHNUZXh0LnNwbGl0KCJcbiIpCiAgICAg bGluZXMgPSBbbGluZS5zcGxpdCgiIyIpWzBdIGZvciBsaW5lIGluIGxpbmVzXQogICAgIGxpbmVz ID0gW2xpbmUgZm9yIGxpbmUgaW4gbGluZXMgaWYgKG5vdCBhbGxXaGl0ZXNwYWNlKGxpbmUpKV0K ICAgICBuYW1lID0gbGluZXNbMF0uc3BsaXQoKQogICAgIHRlcm1pbmF0b3IgPSBsaW5lc1stMV0K KwogICAgIGlmIG5vdCBuYW1lWzBdID09ICJAYmVnaW4iOgogICAgICAgICByYWlzZSBFeGNlcHRp b24oImV4cGVjdGVkIGRlc2NyaXB0aW9uIGJlZ2lubmluZyB3aXRoIEBiZWdpbiIpCiAgICAgaWYg bm90IHRlcm1pbmF0b3IgPT0gIkBlbmQiOgo=