63230 2011-06-22 23:58:12 -0700 SVGAnimation - keyTime value 1 never get animated 2011-07-04 08:25:17 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://dev.w3.org/SVG/profiles/1.1F2/test/svg/animate-elem-31-t.svg P2 Normal --- 41761 1 krit webkit-unassigned joybro201 rwlbuis webkit.review.bot zimmermann oldest_to_newest 425982 0 98317 krit 2011-06-22 23:58:12 -0700 Created attachment 98317 SVG values animation with keytimes According to http://www.w3.org/TR/SMIL3/smil-animation.html#adef-keyTimes , the keyTime 1 should be the last time value of an animation. Right now it is the value right after that value. Short example: <rect width="100" height="100" fill="green"> <animate attributeName="width" values="100 ; 200 ; 300" calcMode="discrete" keyTimes="0;0.5;1" dur="6" fill="freeze"/> </rect> According to http://www.w3.org/TR/SMIL3/smil-animation.html#animationNS-InterpolationIllus the values should change at 2s, 4s and right before 6s. At the moment we take the last value at exactly 6s. According to the spec, it should not affect the animation, because 6s would be excluded. We should check for keyTime 1 and should calculate the last time value right before reaching the end. While FF, Opera and Batik end the animation with the value 300 for width, we end with 200. This affects at least one W3C test: http://dev.w3.org/SVG/profiles/1.1F2/test/svg/animate-elem-31-t.svg 427547 1 98633 joybro201 2011-06-26 10:49:44 -0700 Created attachment 98633 Patch 427551 2 joybro201 2011-06-26 11:03:24 -0700 SVGAnimationElement::calculateKeyTimesIndex has to return the index n if the m_keyTimes[n] is the same with the given percent. 427568 3 98633 krit 2011-06-26 13:08:00 -0700 Comment on attachment 98633 Patch Good catch! r=me 427574 4 98633 webkit.review.bot 2011-06-26 14:26:42 -0700 Comment on attachment 98633 Patch Clearing flags on attachment: 98633 Committed r89774: <http://trac.webkit.org/changeset/89774> 427575 5 webkit.review.bot 2011-06-26 14:26:46 -0700 All reviewed patches have been landed. Closing bug. 431708 6 krit 2011-07-03 09:35:56 -0700 This seems to cause an ASSERTion on http://dev.w3.org/SVG/profiles/1.1F2/test/svg/animate-elem-82-t.svg Can you have a look please, Young Han? 431709 7 krit 2011-07-03 09:43:08 -0700 ASSERTION FAILED: i < size() /Users/dirk/Downloads/webkit-trunk/WebKitBuild/Debug/JavaScriptCore.framework/PrivateHeaders/Vector.h(542) : const T& WTF::Vector<T, inlineCapacity>::at(size_t) const [with T = float, long unsigned int inlineCapacity = 0ul] 1 WTF::Vector<float, 0ul>::at(unsigned long) const 2 WTF::Vector<float, 0ul>::operator[](unsigned long) const 3 WebCore::SVGAnimationElement::currentValuesForValuesAnimation(float, float&, WTF::String&, WTF::String&) const 4 WebCore::SVGAnimationElement::updateAnimation(float, unsigned int, WebCore::SVGSMILElement*) 5 WebCore::SVGSMILElement::progress(WebCore::SMILTime, WebCore::SVGSMILElement*) 6 WebCore::SMILTimeContainer::updateAnimations(WebCore::SMILTime, double, WTF::String const&) 7 WebCore::SMILTimeContainer::timerFired(WebCore::Timer<WebCore::SMILTimeContainer>*) 8 WebCore::Timer<WebCore::SMILTimeContainer>::fired() 431765 8 joybro201 2011-07-03 18:22:10 -0700 (In reply to comment #6) > This seems to cause an ASSERTion on http://dev.w3.org/SVG/profiles/1.1F2/test/svg/animate-elem-82-t.svg > > Can you have a look please, Young Han? Yes, the assertion failure seems to be caused by my patch. I will upload a follow-up patch soon. 431941 9 joybro201 2011-07-04 08:25:17 -0700 Bug 63911 was opened for this regression. 98317 2011-06-22 23:58:12 -0700 2011-06-22 23:58:12 -0700 SVG values animation with keytimes svg-values-keytimes.svg image/svg+xml 224 krit PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciPgo8cmVjdCB3aWR0aD0iMTAw IiBoZWlnaHQ9IjEwMCIgZmlsbD0iZ3JlZW4iPgogICAgPGFuaW1hdGUgYXR0cmlidXRlTmFtZT0i d2lkdGgiIHZhbHVlcz0iMTAwIDsgMjAwIDsgMzAwIiBjYWxjTW9kZT0iZGlzY3JldGUiIGtleVRp bWVzPSIwOzAuNTsxIiBkdXI9IjYiIGZpbGw9ImZyZWV6ZSIvPgo8L3JlY3Q+Cjwvc3ZnPgo= 98633 2011-06-26 10:49:44 -0700 2011-06-26 14:26:42 -0700 Patch bug-63230-20110627024941.patch text/plain 6097 joybro201 U3VidmVyc2lvbiBSZXZpc2lvbjogODk3MjEKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA1ZTk5N2U5Yjg3YmZkOGExN2U2YzFh MDYwMzkxNzdiYjIxYTA4ZWM5Li4wYjcwY2Q3MGQ3M2IwNDY4MDFkNDRhZDhjNDVlZmUyY2E4MzNm NTI0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTEtMDYtMjYgIFlvdW5nIEhhbiBMZWUgIDxq b3licm9AY29tcGFueTEwMC5uZXQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgU1ZHQW5pbWF0aW9uIC0ga2V5VGltZSB2YWx1ZSAxIG5ldmVyIGdldCBh bmltYXRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NjMyMzAKKworICAgICAgICBBY2NvcmRpbmcgdG8gdGhlIFNNSUwgMy4wIHNwZWNpZmljYXRpb24s IHRoZSBpbmRleCBvZiB0aGUga2V5VGltZXMgc2hvdWxkIGJlIAorICAgICAgICBkZXRlcm1pbmVk IHVuZGVyIHRoZSBlbmQtcG9pbnQtZXhjbHVzaXZlIHJ1bGUgKGUuZy4gR2l2ZW4ga2V5VGltZXMo MDswLjU7MSkgCisgICAgICAgIGFuZCB0PTAuNSwgdGhlIGN1cnJlbnQgaW5kZXggb2YgdGhlIGtl eVRpbWVzIGhhdmUgdG8gYmUgMSBub3QgMCkuCisgICAgICAgIGh0dHA6Ly93d3cudzMub3JnL1RS L1NNSUwzL3NtaWwtYW5pbWF0aW9uLmh0bWwjYW5pbWF0aW9uTlMtSW50ZXJwb2xhdGlvbkV4YW1w bGVzQWR2YW5jZWQKKworICAgICAgICAqIHN2Zy9hbmltYXRpb25zL2FuaW1hdGUtbnVtYmVyLWNh bGNNb2RlLWRpc2NyZXRlLWtleVRpbWVzLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICog c3ZnL2FuaW1hdGlvbnMvYW5pbWF0ZS1udW1iZXItY2FsY01vZGUtZGlzY3JldGUta2V5VGltZXMu aHRtbDogQWRkZWQuCisgICAgICAgICogc3ZnL2FuaW1hdGlvbnMvc2NyaXB0LXRlc3RzL2FuaW1h dGUtbnVtYmVyLWNhbGNNb2RlLWRpc2NyZXRlLWtleVRpbWVzLmpzOiBBZGRlZC4KKyAgICAgICAg KHNhbXBsZTEpOgorICAgICAgICAoc2FtcGxlMik6CisgICAgICAgIChzYW1wbGUzKToKKyAgICAg ICAgKGV4ZWN1dGVUZXN0KToKKwogMjAxMS0wNi0yNCAgVG9ueSBDaGFuZyAgPHRvbnlAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9qYW4gVmFmYWkuCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9zdmcvYW5pbWF0aW9ucy9hbmltYXRlLW51bWJlci1jYWxjTW9kZS1kaXNjcmV0 ZS1rZXlUaW1lcy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9zdmcvYW5pbWF0aW9ucy9hbmlt YXRlLW51bWJlci1jYWxjTW9kZS1kaXNjcmV0ZS1rZXlUaW1lcy1leHBlY3RlZC50eHQKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMC4uZmNjMGMxYzQ4ZjZkNTFkZGZlNGYzMzQ4YWEyMjBjNjAxODhiNzdlMgotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL3N2Zy9hbmltYXRpb25zL2FuaW1hdGUtbnVtYmVyLWNhbGNN b2RlLWRpc2NyZXRlLWtleVRpbWVzLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDcgQEAKK1BBU1Mg cmVjdC54LmJhc2VWYWwudmFsdWUgaXMgMTAwCitQQVNTIHJlY3QueC5iYXNlVmFsLnZhbHVlIGlz IDIwMAorUEFTUyByZWN0LnguYmFzZVZhbC52YWx1ZSBpcyAzMDAKK1BBU1Mgc3VjY2Vzc2Z1bGx5 UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9zdmcvYW5pbWF0aW9ucy9hbmltYXRlLW51bWJlci1jYWxjTW9kZS1kaXNjcmV0ZS1rZXlUaW1l cy5odG1sIGIvTGF5b3V0VGVzdHMvc3ZnL2FuaW1hdGlvbnMvYW5pbWF0ZS1udW1iZXItY2FsY01v ZGUtZGlzY3JldGUta2V5VGltZXMuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi45NjRkZGI1NDhmMjE0ZTdkNThi MzQ2ZjMzNWY0YzE3ZTE5ZDE2NDY4Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvc3Zn L2FuaW1hdGlvbnMvYW5pbWF0ZS1udW1iZXItY2FsY01vZGUtZGlzY3JldGUta2V5VGltZXMuaHRt bApAQCAtMCwwICsxLDExIEBACis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdCBzcmM9Ii4uLy4uL2Zh c3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIu Li9keW5hbWljLXVwZGF0ZXMvcmVzb3VyY2VzL1NWR1Rlc3RDYXNlLmpzIj48L3NjcmlwdD4KKzxz Y3JpcHQgc3JjPSJyZXNvdXJjZXMvU1ZHQW5pbWF0aW9uVGVzdENhc2UuanMiPjwvc2NyaXB0Pgor PC9oZWFkPgorPGJvZHk+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQgc3JjPSJz Y3JpcHQtdGVzdHMvYW5pbWF0ZS1udW1iZXItY2FsY01vZGUtZGlzY3JldGUta2V5VGltZXMuanMi Pjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvc3Zn L2FuaW1hdGlvbnMvc2NyaXB0LXRlc3RzL2FuaW1hdGUtbnVtYmVyLWNhbGNNb2RlLWRpc2NyZXRl LWtleVRpbWVzLmpzIGIvTGF5b3V0VGVzdHMvc3ZnL2FuaW1hdGlvbnMvc2NyaXB0LXRlc3RzL2Fu aW1hdGUtbnVtYmVyLWNhbGNNb2RlLWRpc2NyZXRlLWtleVRpbWVzLmpzCm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmM3 Y2JjZjhhMGUwYTFiMzMyMjJmNzdmZDU4YTc2ZGUwN2UzMzI0OGQKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy9zdmcvYW5pbWF0aW9ucy9zY3JpcHQtdGVzdHMvYW5pbWF0ZS1udW1iZXIt Y2FsY01vZGUtZGlzY3JldGUta2V5VGltZXMuanMKQEAgLTAsMCArMSw1MCBAQAorY3JlYXRlU1ZH VGVzdENhc2UoKTsKKworLy8gU2V0dXAgdGVzdCBkb2N1bWVudAordmFyIHJlY3QgPSBjcmVhdGVT VkdFbGVtZW50KCJyZWN0Iik7CityZWN0LnNldEF0dHJpYnV0ZSgiaWQiLCAicmVjdCIpOworcmVj dC5zZXRBdHRyaWJ1dGUoIngiLCAiMTAwIik7CityZWN0LnNldEF0dHJpYnV0ZSgid2lkdGgiLCAi MTAwIik7CityZWN0LnNldEF0dHJpYnV0ZSgiaGVpZ2h0IiwgIjEwMCIpOworcmVjdC5zZXRBdHRy aWJ1dGUoImZpbGwiLCAiZ3JlZW4iKTsKK3JlY3Quc2V0QXR0cmlidXRlKCJvbmNsaWNrIiwgImV4 ZWN1dGVUZXN0KCkiKTsKKwordmFyIGFuaW1hdGUgPSBjcmVhdGVTVkdFbGVtZW50KCJhbmltYXRl Iik7CithbmltYXRlLnNldEF0dHJpYnV0ZSgiaWQiLCAiYW5pbWF0aW9uIik7CithbmltYXRlLnNl dEF0dHJpYnV0ZSgiYXR0cmlidXRlTmFtZSIsICJ4Iik7CithbmltYXRlLnNldEF0dHJpYnV0ZSgi dmFsdWVzIiwgIjEwMDsyMDA7MzAwIik7CithbmltYXRlLnNldEF0dHJpYnV0ZSgiYmVnaW4iLCAi Y2xpY2siKTsKK2FuaW1hdGUuc2V0QXR0cmlidXRlKCJkdXIiLCAiM3MiKTsKK2FuaW1hdGUuc2V0 QXR0cmlidXRlKCJrZXlUaW1lcyIsICIwOzAuNTsxIik7CithbmltYXRlLnNldEF0dHJpYnV0ZSgi Y2FsY01vZGUiLCAiZGlzY3JldGUiKTsKK2FuaW1hdGUuc2V0QXR0cmlidXRlKCJmaWxsIiwgImZy ZWV6ZSIpOworcmVjdC5hcHBlbmRDaGlsZChhbmltYXRlKTsKK3Jvb3RTVkdFbGVtZW50LmFwcGVu ZENoaWxkKHJlY3QpOworCisvLyBTZXR1cCBhbmltYXRpb24gdGVzdAorZnVuY3Rpb24gc2FtcGxl MSgpIHsKKyAgICBzaG91bGRCZSgicmVjdC54LmJhc2VWYWwudmFsdWUiLCAiMTAwIik7Cit9CisK K2Z1bmN0aW9uIHNhbXBsZTIoKSB7CisgICAgc2hvdWxkQmUoInJlY3QueC5iYXNlVmFsLnZhbHVl IiwgIjIwMCIpOworfQorCitmdW5jdGlvbiBzYW1wbGUzKCkgeworICAgIHNob3VsZEJlKCJyZWN0 LnguYmFzZVZhbC52YWx1ZSIsICIzMDAiKTsKK30KKworZnVuY3Rpb24gZXhlY3V0ZVRlc3QoKSB7 CisgICAgY29uc3QgZXhwZWN0ZWRWYWx1ZXMgPSBbCisgICAgICAgIC8vIFthbmltYXRpb25JZCwg dGltZSwgZWxlbWVudElkLCBzYW1wbGVDYWxsYmFja10KKyAgICAgICAgWyJhbmltYXRpb24iLCAx LjAsICAgICJyZWN0Iiwgc2FtcGxlMV0sCisgICAgICAgIFsiYW5pbWF0aW9uIiwgMS41LCAgICAi cmVjdCIsIHNhbXBsZTJdLAorICAgICAgICBbImFuaW1hdGlvbiIsIDMuMCwgICAgInJlY3QiLCBz YW1wbGUzXQorICAgIF07CisKKyAgICBydW5BbmltYXRpb25UZXN0KGV4cGVjdGVkVmFsdWVzKTsK K30KKworLy8gQmVnaW4gdGVzdCBhc3luYword2luZG93LnNldFRpbWVvdXQoInRyaWdnZXJVcGRh dGUoMTUwLCAzMCkiLCAwKTsKK3ZhciBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n CmluZGV4IDhlZjJhYmJiNzcyY2VmZjUzNzdiOTg2MTc0NTU0MGIyMGFjY2IxZjUuLjBmZWQ4OGU0 OTE4ZDIzYjcyMTMzNWZkMGY0NDA0ODYxOTJmMzJhOTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwy MCBAQAorMjAxMS0wNi0yNiAgWW91bmcgSGFuIExlZSAgPGpveWJyb0Bjb21wYW55MTAwLm5ldD4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTVkdBbmlt YXRpb24gLSBrZXlUaW1lIHZhbHVlIDEgbmV2ZXIgZ2V0IGFuaW1hdGVkCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MzIzMAorCisgICAgICAgIEFjY29y ZGluZyB0byB0aGUgU01JTCAzLjAgc3BlY2lmaWNhdGlvbiwgdGhlIGluZGV4IG9mIHRoZSBrZXlU aW1lcyBzaG91bGQgYmUgCisgICAgICAgIGRldGVybWluZWQgdW5kZXIgdGhlIGVuZC1wb2ludC1l eGNsdXNpdmUgcnVsZSAoZS5nLiBHaXZlbiBrZXlUaW1lcygwOzAuNTsxKSAKKyAgICAgICAgYW5k IHQ9MC41LCB0aGUgY3VycmVudCBpbmRleCBvZiB0aGUga2V5VGltZXMgaGF2ZSB0byBiZSAxIG5v dCAwKS4KKyAgICAgICAgaHR0cDovL3d3dy53My5vcmcvVFIvU01JTDMvc21pbC1hbmltYXRpb24u aHRtbCNhbmltYXRpb25OUy1JbnRlcnBvbGF0aW9uRXhhbXBsZXNBZHZhbmNlZAorCisgICAgICAg IFRlc3Q6IHN2Zy9hbmltYXRpb25zL2FuaW1hdGUtbnVtYmVyLWNhbGNNb2RlLWRpc2NyZXRlLWtl eVRpbWVzLmh0bWwKKworICAgICAgICAqIHN2Zy9TVkdBbmltYXRpb25FbGVtZW50LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlNWR0FuaW1hdGlvbkVsZW1lbnQ6OmNhbGN1bGF0ZUtleVRpbWVzSW5k ZXgpOgorCiAyMDExLTA2LTI0ICBHYXZpbiBQZXRlcnMgIDxnYXZpbnBAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvc3ZnL1NWR0FuaW1hdGlvbkVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvc3ZnL1NW R0FuaW1hdGlvbkVsZW1lbnQuY3BwCmluZGV4IDVjMTcwOTFjNDg3MmZjMTIxNTkwNGE5MGRkODk2 MGY3OTU2NzI0MDYuLjU0NjdiNTFlNTI1MGRmMDRmNTc2NDFmOTU2OTVjZWM3MzFlNzJlOGYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdBbmltYXRpb25FbGVtZW50LmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHQW5pbWF0aW9uRWxlbWVudC5jcHAKQEAgLTQyMiw3ICs0 MjIsNyBAQCB1bnNpZ25lZCBTVkdBbmltYXRpb25FbGVtZW50OjpjYWxjdWxhdGVLZXlUaW1lc0lu ZGV4KGZsb2F0IHBlcmNlbnQpIGNvbnN0CiAgICAgdW5zaWduZWQgaW5kZXg7CiAgICAgdW5zaWdu ZWQga2V5VGltZXNDb3VudCA9IG1fa2V5VGltZXMuc2l6ZSgpOwogICAgIGZvciAoaW5kZXggPSAx OyBpbmRleCA8IGtleVRpbWVzQ291bnQ7ICsraW5kZXgpIHsKLSAgICAgICAgaWYgKG1fa2V5VGlt ZXNbaW5kZXhdID49IHBlcmNlbnQpCisgICAgICAgIGlmIChtX2tleVRpbWVzW2luZGV4XSA+IHBl cmNlbnQpCiAgICAgICAgICAgICBicmVhazsKICAgICB9CiAgICAgcmV0dXJuIC0taW5kZXg7Cg==