63224 2011-06-22 19:51:02 -0700 Convert FileIconLoaderClient to "smart client" pattern, just like FileChooserClient. 2011-06-22 20:56:10 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 62069 1 dglazkov dglazkov tkent webkit.review.bot oldest_to_newest 425905 0 dglazkov 2011-06-22 19:51:02 -0700 Convert FileIconLoaderClient to "smart client" pattern, just like FileChooserClient. 425907 1 98299 dglazkov 2011-06-22 19:53:07 -0700 Created attachment 98299 Patch 425921 2 98299 tkent 2011-06-22 20:15:04 -0700 Comment on attachment 98299 Patch ok. But I guess this patch will cause a conflict with your previous patch :-) 425934 3 98299 webkit.review.bot 2011-06-22 20:56:06 -0700 Comment on attachment 98299 Patch Clearing flags on attachment: 98299 Committed r89526: <http://trac.webkit.org/changeset/89526> 425935 4 webkit.review.bot 2011-06-22 20:56:10 -0700 All reviewed patches have been landed. Closing bug. 98299 2011-06-22 19:53:07 -0700 2011-06-22 20:56:06 -0700 Patch bug-63224-20110622195305.patch text/plain 4958 dglazkov U3VidmVyc2lvbiBSZXZpc2lvbjogODk1MjIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzODJlMmJiYTczNmE2YjA0 OGNhNzA0ZWU1YWJmN2M0ZmU1NmExYzEzLi45MGE4OWNkZjAwNDNhMzhiNDRmNWNkZTQ2NjcxZDg4 YTRjMTEzMGVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTEtMDYtMjIgIERpbWl0 cmkgR2xhemtvdiAgPGRnbGF6a292QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb252ZXJ0IEZpbGVJY29uTG9hZGVyQ2xpZW50 IHRvICJzbWFydCBjbGllbnQiIHBhdHRlcm4sIGp1c3QgbGlrZSBGaWxlQ2hvb3NlckNsaWVudC4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYzMjI0CisK KyAgICAgICAgUmVmYWN0b3JpbmcsIGNvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9GaWxlSWNvbkxvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGaWxl SWNvbkxvYWRlckNsaWVudDo6fkZpbGVJY29uTG9hZGVyQ2xpZW50KTogQ2hhbmdlZCB0byBkaXNj YXJkIGxvYWRlci4KKyAgICAgICAgKFdlYkNvcmU6OkZpbGVJY29uTG9hZGVyQ2xpZW50OjpuZXdG aWxlSWNvbkxvYWRlcik6IEFkZGVkLgorICAgICAgICAoV2ViQ29yZTo6RmlsZUljb25Mb2FkZXJD bGllbnQ6OmRpc2NhcmRMb2FkZXIpOiBBZGRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9GaWxlSWNv bkxvYWRlci5oOiBVcGRhdGVkIGRlZnMuCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckZpbGVV cGxvYWRDb250cm9sLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckZpbGVVcGxvYWRDb250 cm9sOjpSZW5kZXJGaWxlVXBsb2FkQ29udHJvbCk6IFJlbW92ZWQgaW5pdGlhbGl6YXRpb24gb2Yg aWNvbiBsb2FkZXIuCisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJGaWxlVXBsb2FkQ29udHJvbDo6 flJlbmRlckZpbGVVcGxvYWRDb250cm9sKTogUmVtb3ZlIGRpc2NhcmRpbmcgb2YgbG9hZGVyLgor ICAgICAgICAoV2ViQ29yZTo6UmVuZGVyRmlsZVVwbG9hZENvbnRyb2w6OnJlcXVlc3RJY29uKTog Q2hhbmdlZCB0byB1c2UgbmV3RmlsZUljb25Mb2FkZXIuCisgICAgICAgICogcmVuZGVyaW5nL1Jl bmRlckZpbGVVcGxvYWRDb250cm9sLmg6IFVwZGF0ZWQgZGVmcy4KKwogMjAxMS0wNi0yMiAgU2Ft IFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFy dGguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9GaWxlSWNvbkxvYWRlci5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9GaWxlSWNvbkxvYWRlci5jcHAKaW5kZXggMzRk ZThhNWYzOWFiMGQ3NDM3MGJiMTBhY2FkZjlmNmNjZDdlM2Y1ZC4uMTZiNTc5MmRjOGUzYjU2NDU2 NmQyYzI1OTMzOTk5Yzk5MDJhN2IxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vRmlsZUljb25Mb2FkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0ZpbGVJ Y29uTG9hZGVyLmNwcApAQCAtMzYsNiArMzYsMjEgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiBG aWxlSWNvbkxvYWRlckNsaWVudDo6fkZpbGVJY29uTG9hZGVyQ2xpZW50KCkKIHsKKyAgICBkaXNj YXJkTG9hZGVyKCk7Cit9CisKK0ZpbGVJY29uTG9hZGVyKiBGaWxlSWNvbkxvYWRlckNsaWVudDo6 bmV3RmlsZUljb25Mb2FkZXIoKQoreworICAgIGRpc2NhcmRMb2FkZXIoKTsKKworICAgIG1fbG9h ZGVyID0gRmlsZUljb25Mb2FkZXI6OmNyZWF0ZSh0aGlzKTsKKyAgICByZXR1cm4gbV9sb2FkZXIu Z2V0KCk7Cit9CisKK3ZvaWQgRmlsZUljb25Mb2FkZXJDbGllbnQ6OmRpc2NhcmRMb2FkZXIoKQor eworICAgIGlmIChtX2xvYWRlcikKKyAgICAgICAgbV9sb2FkZXItPmRpc2Nvbm5lY3RDbGllbnQo KTsKIH0KIAogUGFzc1JlZlB0cjxGaWxlSWNvbkxvYWRlcj4gRmlsZUljb25Mb2FkZXI6OmNyZWF0 ZShGaWxlSWNvbkxvYWRlckNsaWVudCogY2xpZW50KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vRmlsZUljb25Mb2FkZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0Zp bGVJY29uTG9hZGVyLmgKaW5kZXggZGMzOTRkMWRlYTQ3NGMxNWQ0MjYyMGQwZDNiMmNjMTA0ZTI1 N2I2OC4uZGE4Y2EyYWQwMWQ3YWQ4ZDVlYzc0NjJjY2ZhMWZmNTFiNTNiZmU2MyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vRmlsZUljb25Mb2FkZXIuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9GaWxlSWNvbkxvYWRlci5oCkBAIC0zMSwxNyArMzEsMjYgQEAKICNp Zm5kZWYgRmlsZUljb25Mb2FkZXJfaAogI2RlZmluZSBGaWxlSWNvbkxvYWRlcl9oCiAKLSNpbmNs dWRlIDx3dGYvUGFzc1JlZlB0ci5oPgorI2luY2x1ZGUgPHd0Zi9SZWZQdHIuaD4KICNpbmNsdWRl IDx3dGYvUmVmQ291bnRlZC5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKK2NsYXNzIEZpbGVJ Y29uTG9hZGVyOwogY2xhc3MgSWNvbjsKIAogY2xhc3MgRmlsZUljb25Mb2FkZXJDbGllbnQgewog cHVibGljOgogICAgIHZpcnR1YWwgdm9pZCB1cGRhdGVSZW5kZXJpbmcoUGFzc1JlZlB0cjxJY29u PikgPSAwOwogICAgIHZpcnR1YWwgfkZpbGVJY29uTG9hZGVyQ2xpZW50KCk7CisKK3Byb3RlY3Rl ZDoKKyAgICBGaWxlSWNvbkxvYWRlciogbmV3RmlsZUljb25Mb2FkZXIoKTsKKworcHJpdmF0ZToK KyAgICB2b2lkIGRpc2NhcmRMb2FkZXIoKTsKKworICAgIFJlZlB0cjxGaWxlSWNvbkxvYWRlcj4g bV9sb2FkZXI7CiB9OwogCiBjbGFzcyBGaWxlSWNvbkxvYWRlciA6IHB1YmxpYyBSZWZDb3VudGVk PEZpbGVJY29uTG9hZGVyPiB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyRmlsZVVwbG9hZENvbnRyb2wuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckZpbGVVcGxvYWRDb250cm9sLmNwcAppbmRleCA1NjRiNWQyZGM1MDdmMTVlMjc2ZjgzMTc3 NzA2MmViOTYwMzUzNzk0Li45ODg5ZmM0NDUzNzA0NDdlNjA3ODgzMTg3YzM1YTFmYTc3ZjYwMzU0 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmlsZVVwbG9hZENv bnRyb2wuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGaWxlVXBsb2Fk Q29udHJvbC5jcHAKQEAgLTYzLDcgKzYzLDYgQEAgc3RhdGljIHZvaWQgZmlsZW5hbWVzRnJvbUZp bGVMaXN0KGNvbnN0IEZpbGVMaXN0KiBsaXN0LCBWZWN0b3I8U3RyaW5nPiYgZmlsZW5hbWUKIAog UmVuZGVyRmlsZVVwbG9hZENvbnRyb2w6OlJlbmRlckZpbGVVcGxvYWRDb250cm9sKEhUTUxJbnB1 dEVsZW1lbnQqIGlucHV0KQogICAgIDogUmVuZGVyQmxvY2soaW5wdXQpCi0gICAgLCBtX2ljb25M b2FkZXIoRmlsZUljb25Mb2FkZXI6OmNyZWF0ZSh0aGlzKSkKIHsKICAgICBWZWN0b3I8U3RyaW5n PiBmaWxlbmFtZXM7CiAgICAgZmlsZW5hbWVzRnJvbUZpbGVMaXN0KGlucHV0LT5maWxlcygpLCBm aWxlbmFtZXMpOwpAQCAtNzIsMTYgKzcxLDE1IEBAIFJlbmRlckZpbGVVcGxvYWRDb250cm9sOjpS ZW5kZXJGaWxlVXBsb2FkQ29udHJvbChIVE1MSW5wdXRFbGVtZW50KiBpbnB1dCkKIAogUmVuZGVy RmlsZVVwbG9hZENvbnRyb2w6On5SZW5kZXJGaWxlVXBsb2FkQ29udHJvbCgpCiB7Ci0gICAgbV9p Y29uTG9hZGVyLT5kaXNjb25uZWN0Q2xpZW50KCk7CiB9CiAKLXZvaWQgUmVuZGVyRmlsZVVwbG9h ZENvbnRyb2w6OnJlcXVlc3RJY29uKGNvbnN0IFZlY3RvcjxTdHJpbmc+JiBmaWxlbmFtZXMpIGNv bnN0Cit2b2lkIFJlbmRlckZpbGVVcGxvYWRDb250cm9sOjpyZXF1ZXN0SWNvbihjb25zdCBWZWN0 b3I8U3RyaW5nPiYgZmlsZW5hbWVzKQogewogICAgIGlmICghZmlsZW5hbWVzLnNpemUoKSkKICAg ICAgICAgcmV0dXJuOwogCiAgICAgaWYgKENocm9tZSogY2hyb21lID0gdGhpcy0+Y2hyb21lKCkp Ci0gICAgICAgIGNocm9tZS0+bG9hZEljb25Gb3JGaWxlcyhmaWxlbmFtZXMsIG1faWNvbkxvYWRl ci5nZXQoKSk7CisgICAgICAgIGNocm9tZS0+bG9hZEljb25Gb3JGaWxlcyhmaWxlbmFtZXMsIG5l d0ZpbGVJY29uTG9hZGVyKCkpOwogfQogCiB2b2lkIFJlbmRlckZpbGVVcGxvYWRDb250cm9sOjpm aWxlc0Nob3Nlbihjb25zdCBWZWN0b3I8U3RyaW5nPiYgZmlsZW5hbWVzKQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZpbGVVcGxvYWRDb250cm9sLmggYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmlsZVVwbG9hZENvbnRyb2wuaAppbmRleCA5MTY1 OTEwNGMzZjdjZmViZTRkN2JjMzNjYWY5MmI2NjY3ZmEwMjA4Li4yNWY5YWM3YjY1OWM3ZTQ0ZjBh MDFjNDg2ZGRjZjI2MDc0NGE5ODM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyRmlsZVVwbG9hZENvbnRyb2wuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyRmlsZVVwbG9hZENvbnRyb2wuaApAQCAtNzMsOSArNzMsOCBAQCBwcml2YXRlOgog ICAgIHZpcnR1YWwgVmlzaWJsZVBvc2l0aW9uIHBvc2l0aW9uRm9yUG9pbnQoY29uc3QgSW50UG9p bnQmKTsKIAogICAgIEhUTUxJbnB1dEVsZW1lbnQqIHVwbG9hZEJ1dHRvbigpIGNvbnN0OwotICAg IHZvaWQgcmVxdWVzdEljb24oY29uc3QgVmVjdG9yPFN0cmluZz4mKSBjb25zdDsKKyAgICB2b2lk IHJlcXVlc3RJY29uKGNvbnN0IFZlY3RvcjxTdHJpbmc+Jik7CiAKLSAgICBSZWZQdHI8RmlsZUlj b25Mb2FkZXI+IG1faWNvbkxvYWRlcjsKICAgICBSZWZQdHI8SWNvbj4gbV9pY29uOwogfTsKIAo=