63217 2011-06-22 18:51:09 -0700 Full-screen: Don't change the collectionBehavior of the WebView's NSWindow if not necessary 2011-07-12 14:39:10 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble dbates oldest_to_newest 425861 0 jer.noble 2011-06-22 18:51:09 -0700 Full-screen: Don't change the collectionBehavior of the WebView's NSWindow if not necessary 425865 1 98293 jer.noble 2011-06-22 18:55:15 -0700 Created attachment 98293 Patch 425867 2 jer.noble 2011-06-22 18:56:09 -0700 <rdar://problem/9660291> 431306 3 98293 dbates 2011-07-01 11:51:36 -0700 Comment on attachment 98293 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98293&action=review > Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:332 > +#if !defined(BUILDING_ON_LEOPARD) > + if (![webWindow isOnActiveSpace]) { > +#endif Have you considered encapsulating this functionality into a static function, say isWindowOnActiveSpace(NSWindow*) or windowIsOnActiveSpace(NSWindow*), that is hardcoded to return false when building on Leopard and sends the specified NSWindow an isOnActiveSpace: message when we aren't building on Leopard? 434346 4 mrowe 2011-07-08 15:52:37 -0700 WebKit2 isn’t built on Leopard so the #if’s aren't necessary. 434352 5 jer.noble 2011-07-08 15:56:52 -0700 @Daniel(In reply to comment #3) > (From update of attachment 98293 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=98293&action=review > > > Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:332 > > +#if !defined(BUILDING_ON_LEOPARD) > > + if (![webWindow isOnActiveSpace]) { > > +#endif > > Have you considered encapsulating this functionality into a static function, say isWindowOnActiveSpace(NSWindow*) or windowIsOnActiveSpace(NSWindow*), that is hardcoded to return false when building on Leopard and sends the specified NSWindow an isOnActiveSpace: message when we aren't building on Leopard? Apparently, since WebKit2 isn't built on Leopard, I can just remove those checks entirely. ;-) 434357 6 98293 dbates 2011-07-08 15:59:06 -0700 Comment on attachment 98293 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98293&action=review >>> Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:332 >>> +#endif >> >> Have you considered encapsulating this functionality into a static function, say isWindowOnActiveSpace(NSWindow*) or windowIsOnActiveSpace(NSWindow*), that is hardcoded to return false when building on Leopard and sends the specified NSWindow an isOnActiveSpace: message when we aren't building on Leopard? > > Apparently, since WebKit2 isn't built on Leopard, I can just remove those checks entirely. ;-) That sounds even better. 435229 7 100370 jer.noble 2011-07-11 15:22:24 -0700 Created attachment 100370 Patch 435737 8 100370 darin 2011-07-12 10:46:07 -0700 Comment on attachment 100370 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100370&action=review > Source/WebKit2/ChangeLog:9 > + collectionBehavior. The isOnActiveSpace API was added in 10.6, so skip this check on Leopard. This comment is now out of date. > Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:330 > + if (![webWindow isOnActiveSpace]) { This check needs a why comment. 435822 9 jer.noble 2011-07-12 11:43:22 -0700 (In reply to comment #8) > (From update of attachment 100370 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=100370&action=review > > > Source/WebKit2/ChangeLog:9 > > + collectionBehavior. The isOnActiveSpace API was added in 10.6, so skip this check on Leopard. > > This comment is now out of date. I thought I squashed that comment. Will remove. > > Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:330 > > + if (![webWindow isOnActiveSpace]) { > > This check needs a why comment. The current comment says: // The user may have moved the fullScreen window in Spaces, so temporarily change // the collectionBehavior of the webView's window: I'll change this to: // If the user has moved the fullScreen window into a new space, temporarily change // the collectionBehavior of the webView's window so that it is pulled into the active space: 435967 10 jer.noble 2011-07-12 14:39:10 -0700 Committed r90851: <http://trac.webkit.org/changeset/90851> 98293 2011-06-22 18:55:15 -0700 2011-07-11 15:22:21 -0700 Patch bug-63217-20110622185514.patch text/plain 2542 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogODk0OTkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCAzNGUzYjJkMGUyMmM3Yzdl Y2RkMTkwMGU5YjY4OWQ3M2E2YmUwMWJlLi5hNDRjNzY4MmM4Mjg4OGJjZTlmYTQ3NzhhZjI4NjZm NmE1YWQxNjRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDYtMjIgIEplciBO b2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgRnVsbC1zY3JlZW46IERvbid0IGNoYW5nZSB0aGUgY29sbGVj dGlvbkJlaGF2aW9yIG9mIHRoZSBXZWJWaWV3J3MgTlNXaW5kb3cgaWYgbm90IG5lY2Vzc2FyeQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjMyMTcKKwor ICAgICAgICBDaGVjayB0byBzZWUgaWYgdGhlIE5TV2luZG93IGhvc3RpbmcgdGhlIFdlYlZpZXcg aXMgbm90IG9uIHRoZSBhY3RpdmUgc3BhY2UgYmVmb3JlIGNoYW5naW5nIHRoZSB3aW5kb3cncyAK KyAgICAgICAgY29sbGVjdGlvbkJlaGF2aW9yLiAgVGhlIGlzT25BY3RpdmVTcGFjZSBBUEkgd2Fz IGFkZGVkIGluIDEwLjYsIHNvIHNraXAgdGhpcyBjaGVjayBvbiBMZW9wYXJkLgorCisgICAgICAg ICogVUlQcm9jZXNzL21hYy9XS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyLm1tOgorICAgICAg ICAoLVtXS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyIGJlZ2FuRXhpdEZ1bGxTY3JlZW5Bbmlt YXRpb25dKToKKwogMjAxMS0wNi0yMiAgQmFsYXpzIEtlbGVtZW4gIDxrYmFsYXpzQHdlYmtpdC5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kcmVhcyBLbGluZy4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5t bSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJv bGxlci5tbQppbmRleCBmMGNhZjE1NTljNzJiMmJhMjViY2UzOWY1OGFkYTkyYTFmMmYwNGEwLi41 ZmVmZjhhMzFhYmFkMTMyNDhlNjM5YTEwOWQ4NDNiMTZmZmVhYWE1IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIubW0K KysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XS0Z1bGxTY3JlZW5XaW5kb3dDb250 cm9sbGVyLm1tCkBAIC0zMjcsMTAgKzMyNywxOCBAQCB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsK ICNlbmRpZgogICAgICAgICAvLyBUaGUgdXNlciBtYXkgaGF2ZSBtb3ZlZCB0aGUgZnVsbFNjcmVl biB3aW5kb3cgaW4gU3BhY2VzLCBzbyB0ZW1wb3JhcmlseSBjaGFuZ2UgCiAgICAgICAgIC8vIHRo ZSBjb2xsZWN0aW9uQmVoYXZpb3Igb2YgdGhlIHdlYlZpZXcncyB3aW5kb3c6Ci0gICAgICAgIE5T V2luZG93Q29sbGVjdGlvbkJlaGF2aW9yIGJlaGF2aW9yID0gW3dlYldpbmRvdyBjb2xsZWN0aW9u QmVoYXZpb3JdOwotICAgICAgICBbd2ViV2luZG93IHNldENvbGxlY3Rpb25CZWhhdmlvcjpOU1dp bmRvd0NvbGxlY3Rpb25CZWhhdmlvckNhbkpvaW5BbGxTcGFjZXNdOwotICAgICAgICBbd2ViV2lu ZG93IG9yZGVyV2luZG93Ok5TV2luZG93QmVsb3cgcmVsYXRpdmVUbzpbW3NlbGYgd2luZG93XSB3 aW5kb3dOdW1iZXJdXTsKLSAgICAgICAgW3dlYldpbmRvdyBzZXRDb2xsZWN0aW9uQmVoYXZpb3I6 YmVoYXZpb3JdOworI2lmICFkZWZpbmVkKEJVSUxESU5HX09OX0xFT1BBUkQpCisgICAgICAgIGlm ICghW3dlYldpbmRvdyBpc09uQWN0aXZlU3BhY2VdKSB7CisjZW5kaWYKKyAgICAgICAgICAgIE5T V2luZG93Q29sbGVjdGlvbkJlaGF2aW9yIGJlaGF2aW9yID0gW3dlYldpbmRvdyBjb2xsZWN0aW9u QmVoYXZpb3JdOworICAgICAgICAgICAgW3dlYldpbmRvdyBzZXRDb2xsZWN0aW9uQmVoYXZpb3I6 TlNXaW5kb3dDb2xsZWN0aW9uQmVoYXZpb3JDYW5Kb2luQWxsU3BhY2VzXTsKKyAgICAgICAgICAg IFt3ZWJXaW5kb3cgb3JkZXJXaW5kb3c6TlNXaW5kb3dCZWxvdyByZWxhdGl2ZVRvOltbc2VsZiB3 aW5kb3ddIHdpbmRvd051bWJlcl1dOworICAgICAgICAgICAgW3dlYldpbmRvdyBzZXRDb2xsZWN0 aW9uQmVoYXZpb3I6YmVoYXZpb3JdOworI2lmICFkZWZpbmVkKEJVSUxESU5HX09OX0xFT1BBUkQp CisgICAgICAgIH0gZWxzZSAKKyAgICAgICAgICAgIFt3ZWJXaW5kb3cgb3JkZXJXaW5kb3c6TlNX aW5kb3dCZWxvdyByZWxhdGl2ZVRvOltbc2VsZiB3aW5kb3ddIHdpbmRvd051bWJlcl1dOworI2Vu ZGlmCisKICNpZiAhZGVmaW5lZChCVUlMRElOR19PTl9MRU9QQVJEKSAmJiAhZGVmaW5lZChCVUlM RElOR19PTl9TTk9XX0xFT1BBUkQpCiAgICAgICAgIFt3ZWJXaW5kb3cgc2V0QW5pbWF0aW9uQmVo YXZpb3I6YW5pbWF0aW9uQmVoYXZpb3JdOwogI2VuZGlmCg== 100370 2011-07-11 15:22:24 -0700 2011-07-12 10:46:07 -0700 Patch bug-63217-20110711152223.patch text/plain 2474 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogOTA3ODIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCBiYTJlZGM2MDNiYTNjNmVh Y2MxMmFhZDI2NzQ0N2FhOGQ0OGNkOTQ1Li40ZWJkZTkzZWQzYTM1MjBkODg3ZDc4NzRlMmUyYTM2 OWIyZGFlMDI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDYtMjIgIEplciBO b2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgRnVsbC1zY3JlZW46IERvbid0IGNoYW5nZSB0aGUgY29sbGVj dGlvbkJlaGF2aW9yIG9mIHRoZSBXZWJWaWV3J3MgTlNXaW5kb3cgaWYgbm90IG5lY2Vzc2FyeQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjMyMTcKKwor ICAgICAgICBDaGVjayB0byBzZWUgaWYgdGhlIE5TV2luZG93IGhvc3RpbmcgdGhlIFdlYlZpZXcg aXMgbm90IG9uIHRoZSBhY3RpdmUgc3BhY2UgYmVmb3JlIGNoYW5naW5nIHRoZSB3aW5kb3cncyAK KyAgICAgICAgY29sbGVjdGlvbkJlaGF2aW9yLiAgVGhlIGlzT25BY3RpdmVTcGFjZSBBUEkgd2Fz IGFkZGVkIGluIDEwLjYsIHNvIHNraXAgdGhpcyBjaGVjayBvbiBMZW9wYXJkLgorCisgICAgICAg ICogVUlQcm9jZXNzL21hYy9XS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyLm1tOgorICAgICAg ICAoLVtXS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyIGJlZ2FuRXhpdEZ1bGxTY3JlZW5Bbmlt YXRpb25dKToKKwogMjAxMS0wNy0xMSAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtp dC5vcmc+CiAKICAgICAgICAgW1F0XVtXSzJdIEdldCByaWQgb2YgZm9jdXNOZXh0UHJldkNoaWxk KCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVu V2luZG93Q29udHJvbGxlci5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tGdWxs U2NyZWVuV2luZG93Q29udHJvbGxlci5tbQppbmRleCBmMGNhZjE1NTljNzJiMmJhMjViY2UzOWY1 OGFkYTkyYTFmMmYwNGEwLi42NjFmNWQ0YzY5N2ExYWU1ZDU3NzE5NjMzNjRmNTI4MTY3NGUzZWMz IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldp bmRvd0NvbnRyb2xsZXIubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XS0Z1 bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyLm1tCkBAIC0zMjcsMTAgKzMyNywxNCBAQCB1c2luZyBu YW1lc3BhY2UgV2ViQ29yZTsKICNlbmRpZgogICAgICAgICAvLyBUaGUgdXNlciBtYXkgaGF2ZSBt b3ZlZCB0aGUgZnVsbFNjcmVlbiB3aW5kb3cgaW4gU3BhY2VzLCBzbyB0ZW1wb3JhcmlseSBjaGFu Z2UgCiAgICAgICAgIC8vIHRoZSBjb2xsZWN0aW9uQmVoYXZpb3Igb2YgdGhlIHdlYlZpZXcncyB3 aW5kb3c6Ci0gICAgICAgIE5TV2luZG93Q29sbGVjdGlvbkJlaGF2aW9yIGJlaGF2aW9yID0gW3dl YldpbmRvdyBjb2xsZWN0aW9uQmVoYXZpb3JdOwotICAgICAgICBbd2ViV2luZG93IHNldENvbGxl Y3Rpb25CZWhhdmlvcjpOU1dpbmRvd0NvbGxlY3Rpb25CZWhhdmlvckNhbkpvaW5BbGxTcGFjZXNd OwotICAgICAgICBbd2ViV2luZG93IG9yZGVyV2luZG93Ok5TV2luZG93QmVsb3cgcmVsYXRpdmVU bzpbW3NlbGYgd2luZG93XSB3aW5kb3dOdW1iZXJdXTsKLSAgICAgICAgW3dlYldpbmRvdyBzZXRD b2xsZWN0aW9uQmVoYXZpb3I6YmVoYXZpb3JdOworICAgICAgICBpZiAoIVt3ZWJXaW5kb3cgaXNP bkFjdGl2ZVNwYWNlXSkgeworICAgICAgICAgICAgTlNXaW5kb3dDb2xsZWN0aW9uQmVoYXZpb3Ig YmVoYXZpb3IgPSBbd2ViV2luZG93IGNvbGxlY3Rpb25CZWhhdmlvcl07CisgICAgICAgICAgICBb d2ViV2luZG93IHNldENvbGxlY3Rpb25CZWhhdmlvcjpOU1dpbmRvd0NvbGxlY3Rpb25CZWhhdmlv ckNhbkpvaW5BbGxTcGFjZXNdOworICAgICAgICAgICAgW3dlYldpbmRvdyBvcmRlcldpbmRvdzpO U1dpbmRvd0JlbG93IHJlbGF0aXZlVG86W1tzZWxmIHdpbmRvd10gd2luZG93TnVtYmVyXV07Cisg ICAgICAgICAgICBbd2ViV2luZG93IHNldENvbGxlY3Rpb25CZWhhdmlvcjpiZWhhdmlvcl07Cisg ICAgICAgIH0gZWxzZSAKKyAgICAgICAgICAgIFt3ZWJXaW5kb3cgb3JkZXJXaW5kb3c6TlNXaW5k b3dCZWxvdyByZWxhdGl2ZVRvOltbc2VsZiB3aW5kb3ddIHdpbmRvd051bWJlcl1dOworCiAjaWYg IWRlZmluZWQoQlVJTERJTkdfT05fTEVPUEFSRCkgJiYgIWRlZmluZWQoQlVJTERJTkdfT05fU05P V19MRU9QQVJEKQogICAgICAgICBbd2ViV2luZG93IHNldEFuaW1hdGlvbkJlaGF2aW9yOmFuaW1h dGlvbkJlaGF2aW9yXTsKICNlbmRpZgo=