63211 2011-06-22 18:17:33 -0700 Make sheriff-bot robust against exceptions from commands 2011-06-22 18:44:37 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eric eric abarth jamesr webkit.review.bot oldest_to_newest 425821 0 eric 2011-06-22 18:17:33 -0700 Make sheriff-bot robust against exceptions from commands 425822 1 98282 eric 2011-06-22 18:18:08 -0700 Created attachment 98282 Patch 425827 2 98282 abarth 2011-06-22 18:21:27 -0700 Comment on attachment 98282 Patch Looks great. Catching Exception is always scary, but this is probably the right thing to do. 425854 3 98282 webkit.review.bot 2011-06-22 18:44:33 -0700 Comment on attachment 98282 Patch Clearing flags on attachment: 98282 Committed r89518: <http://trac.webkit.org/changeset/89518> 425855 4 webkit.review.bot 2011-06-22 18:44:37 -0700 All reviewed patches have been landed. Closing bug. 98282 2011-06-22 18:18:08 -0700 2011-06-22 18:44:33 -0700 Patch bug-63211-20110622181807.patch text/plain 4750 eric U3VidmVyc2lvbiBSZXZpc2lvbjogODk0OTIKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAwNmUwMWNjZTc1ZGVkYzdkMDczMDdmZmZhODAxZmMxNDlm N2Y4ODM1Li4xNWYzMmMxNGUwYTIxOWMxNzY0ZTI2ZTljOTFiODY0NmQyODFhOTg1IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTEtMDYtMjIgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2Ugc2hlcmlmZi1ib3Qg cm9idXN0IGFnYWluc3QgZXhjZXB0aW9ucyBmcm9tIGNvbW1hbmRzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MzIxMQorCisgICAgICAgIHNoZXJpZmYt Ym90IHdhcyBhY3Rpbmcgc3RyYW5nZSB0aGlzIGFmdGVybm9vbi4KKyAgICAgICAgV2UgZG9uJ3Qg a25vdyBpZiB0aGlzIHdpbGwgZml4IHRoZSBjYXVzZSwgYnV0CisgICAgICAgIGF0IGxlYXN0IGl0 IGFkZHMgc29tZSB1bml0IHRlc3RzIGFuZCBjYXRjaGVzCisgICAgICAgIG9uZSBwb3NzaWJsZSBj YXVzZS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3Qvc2hlcmlmZmlyY2Jv dC5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L3NoZXJpZmZpcmNib3Rf dW5pdHRlc3QucHk6CisKIDIwMTEtMDYtMjIgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBPamFuIFZhZmFpLgpkaWZmIC0tZ2l0IGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9zaGVyaWZmaXJjYm90LnB5IGIvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS90b29sL2JvdC9zaGVyaWZmaXJjYm90LnB5CmluZGV4IDI5ZTg5YThjZGYzODZk N2U5ZDQyZTJjZGNlYmZkZWRkMzhlMDdmMjMuLjU1YzVlYWIwOGQyYTIyYTk0Mjg3Y2M5OTdkMTQ5 ZmU3NjE3NWIxMmMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3Qv c2hlcmlmZmlyY2JvdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L3No ZXJpZmZpcmNib3QucHkKQEAgLTYyLDIyICs2MiwyNyBAQCBjbGFzcyBTaGVyaWZmSVJDQm90KG9i amVjdCk6CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzZWxmLl9tZXNzYWdlX3F1 ZXVlLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc2VsZi5fdG9vbC53YWtldXBf ZXZlbnQpCiAKLSAgICBkZWYgcHJvY2Vzc19tZXNzYWdlKHNlbGYsIG1lc3NhZ2UpOgotICAgICAg ICAobmljaywgcmVxdWVzdCkgPSBtZXNzYWdlCisgICAgZGVmIF9wYXJzZV9jb21tYW5kX2FuZF9h cmdzKHNlbGYsIHJlcXVlc3QpOgogICAgICAgICB0b2tlbml6ZWRfcmVxdWVzdCA9IHJlcXVlc3Qu c3RyaXAoKS5zcGxpdCgiICIpCi0gICAgICAgIGlmIG5vdCB0b2tlbml6ZWRfcmVxdWVzdDoKLSAg ICAgICAgICAgIHJldHVybgogICAgICAgICBjb21tYW5kID0gaXJjX2NvbW1hbmQuY29tbWFuZHMu Z2V0KHRva2VuaXplZF9yZXF1ZXN0WzBdKQogICAgICAgICBhcmdzID0gdG9rZW5pemVkX3JlcXVl c3RbMTpdCiAgICAgICAgIGlmIG5vdCBjb21tYW5kOgogICAgICAgICAgICAgIyBHaXZlIHRoZSBw ZW9wbGVzIHNvbWVvbmUgdG8gdGFsayB3aXRoLgogICAgICAgICAgICAgY29tbWFuZCA9IGlyY19j b21tYW5kLkVsaXphCiAgICAgICAgICAgICBhcmdzID0gdG9rZW5pemVkX3JlcXVlc3QKLSAgICAg ICAgcmVzcG9uc2UgPSBjb21tYW5kKCkuZXhlY3V0ZShuaWNrLCBhcmdzLCBzZWxmLl90b29sLCBz ZWxmLl9zaGVyaWZmKQotICAgICAgICBpZiByZXNwb25zZToKLSAgICAgICAgICAgIHNlbGYuX3Rv b2wuaXJjKCkucG9zdChyZXNwb25zZSkKKyAgICAgICAgcmV0dXJuIChjb21tYW5kLCBhcmdzKQor CisgICAgZGVmIHByb2Nlc3NfbWVzc2FnZShzZWxmLCByZXF1ZXN0ZXJfbmljaywgcmVxdWVzdCk6 CisgICAgICAgIGNvbW1hbmQsIGFyZ3MgPSBzZWxmLl9wYXJzZV9jb21tYW5kX2FuZF9hcmdzKHJl cXVlc3QpCisgICAgICAgIHRyeToKKyAgICAgICAgICAgIHJlc3BvbnNlID0gY29tbWFuZCgpLmV4 ZWN1dGUocmVxdWVzdGVyX25pY2ssIGFyZ3MsIHNlbGYuX3Rvb2wsIHNlbGYuX3NoZXJpZmYpCisg ICAgICAgICAgICBpZiByZXNwb25zZToKKyAgICAgICAgICAgICAgICBzZWxmLl90b29sLmlyYygp LnBvc3QocmVzcG9uc2UpCisgICAgICAgIGV4Y2VwdCBFeGNlcHRpb24sIGU6CisgICAgICAgICAg ICBzZWxmLl90b29sLmlyYygpLnBvc3QoIkV4Y2VwdGlvbiBleGVjdXRpbmcgY29tbWFuZDogJXMi ICUgZSkKIAogICAgIGRlZiBwcm9jZXNzX3BlbmRpbmdfbWVzc2FnZXMoc2VsZik6CiAgICAgICAg IChtZXNzYWdlcywgaXNfcnVubmluZykgPSBzZWxmLl9tZXNzYWdlX3F1ZXVlLnRha2VfYWxsKCkK ICAgICAgICAgZm9yIG1lc3NhZ2UgaW4gbWVzc2FnZXM6Ci0gICAgICAgICAgICBzZWxmLnByb2Nl c3NfbWVzc2FnZShtZXNzYWdlKQorICAgICAgICAgICAgKG5pY2ssIHJlcXVlc3QpID0gbWVzc2Fn ZQorICAgICAgICAgICAgc2VsZi5wcm9jZXNzX21lc3NhZ2UobmljaywgcmVxdWVzdCkKZGlmZiAt LWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3Qvc2hlcmlmZmlyY2JvdF91bml0 dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3Qvc2hlcmlmZmlyY2JvdF91 bml0dGVzdC5weQppbmRleCAxY2ZiNTkxMzYyNWViOWU2ZGJlYTExZmZhNTQyMzQwZDBmYmU3Zjdm Li42Y2IwMGY1OGM0NmFhMmY4MjE1ZjdiZDMyZmE0ZTM0OTM2ZGNjNmVhIDEwMDY0NAotLS0gYS9U b29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L3NoZXJpZmZpcmNib3RfdW5pdHRlc3QucHkK KysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9zaGVyaWZmaXJjYm90X3VuaXR0 ZXN0LnB5CkBAIC0zMCw2ICszMCw3IEBAIGltcG9ydCB1bml0dGVzdAogaW1wb3J0IHJhbmRvbQog CiBmcm9tIHdlYmtpdHB5LmNvbW1vbi5zeXN0ZW0ub3V0cHV0Y2FwdHVyZSBpbXBvcnQgT3V0cHV0 Q2FwdHVyZQorZnJvbSB3ZWJraXRweS50b29sLmJvdCBpbXBvcnQgaXJjX2NvbW1hbmQKIGZyb20g d2Via2l0cHkudG9vbC5ib3Quc2hlcmlmZiBpbXBvcnQgU2hlcmlmZgogZnJvbSB3ZWJraXRweS50 b29sLmJvdC5zaGVyaWZmaXJjYm90IGltcG9ydCBTaGVyaWZmSVJDQm90CiBmcm9tIHdlYmtpdHB5 LnRvb2wuYm90LnNoZXJpZmZfdW5pdHRlc3QgaW1wb3J0IE1vY2tTaGVyaWZmQm90CkBAIC00NSw2 ICs0NiwyNyBAQCBkZWYgcnVuKG1lc3NhZ2UpOgogCiAKIGNsYXNzIFNoZXJpZmZJUkNCb3RUZXN0 KHVuaXR0ZXN0LlRlc3RDYXNlKToKKyAgICBkZWYgdGVzdF9wYXJzZV9jb21tYW5kX2FuZF9hcmdz KHNlbGYpOgorICAgICAgICB0b29sID0gTW9ja1Rvb2woKQorICAgICAgICBib3QgPSBTaGVyaWZm SVJDQm90KHRvb2wsIFNoZXJpZmYodG9vbCwgTW9ja1NoZXJpZmZCb3QoKSkpCisgICAgICAgIHNl bGYuYXNzZXJ0RXF1YWwoYm90Ll9wYXJzZV9jb21tYW5kX2FuZF9hcmdzKCIiKSwgKGlyY19jb21t YW5kLkVsaXphLCBbIiJdKSkKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChib3QuX3BhcnNlX2Nv bW1hbmRfYW5kX2FyZ3MoIiAgICIpLCAoaXJjX2NvbW1hbmQuRWxpemEsIFsiIl0pKQorICAgICAg ICBzZWxmLmFzc2VydEVxdWFsKGJvdC5fcGFyc2VfY29tbWFuZF9hbmRfYXJncygiIGhpICIpLCAo aXJjX2NvbW1hbmQuSGksIFtdKSkKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChib3QuX3BhcnNl X2NvbW1hbmRfYW5kX2FyZ3MoIiBoaSB0aGVyZSAiKSwgKGlyY19jb21tYW5kLkhpLCBbInRoZXJl Il0pKQorCisgICAgZGVmIHRlc3RfZXhjZXB0aW9uX2R1cmluZ19jb21tYW5kKHNlbGYpOgorICAg ICAgICB0b29sID0gTW9ja1Rvb2woKQorICAgICAgICB0b29sLmVuc3VyZV9pcmNfY29ubmVjdGVk KE5vbmUpCisgICAgICAgIGJvdCA9IFNoZXJpZmZJUkNCb3QodG9vbCwgU2hlcmlmZih0b29sLCBN b2NrU2hlcmlmZkJvdCgpKSkKKworICAgICAgICBjbGFzcyBDb21tYW5kV2l0aEV4Y2VwdGlvbihv YmplY3QpOgorICAgICAgICAgICAgZGVmIGV4ZWN1dGUoc2VsZiwgbmljaywgYXJncywgdG9vbCwg c2hlcmlmZik6CisgICAgICAgICAgICAgICAgcmFpc2UgRXhjZXB0aW9uKCJtb2NrX2V4Y2VwdGlv biIpCisKKyAgICAgICAgYm90Ll9wYXJzZV9jb21tYW5kX2FuZF9hcmdzID0gbGFtYmRhIHJlcXVl c3Q6IChDb21tYW5kV2l0aEV4Y2VwdGlvbiwgW10pCisgICAgICAgIGV4cGVjdGVkX3N0ZGVyciA9 ICdNT0NLOiBpcmMucG9zdDogRXhjZXB0aW9uIGV4ZWN1dGluZyBjb21tYW5kOiBtb2NrX2V4Y2Vw dGlvblxuJworICAgICAgICBPdXRwdXRDYXB0dXJlKCkuYXNzZXJ0X291dHB1dHMoc2VsZiwgYm90 LnByb2Nlc3NfbWVzc2FnZSwgYXJncz1bIm1vY2tfbmljayIsICJpZ25vcmVkIG1lc3NhZ2UiXSwg ZXhwZWN0ZWRfc3RkZXJyPWV4cGVjdGVkX3N0ZGVycikKKwogICAgIGRlZiB0ZXN0X2hpKHNlbGYp OgogICAgICAgICByYW5kb20uc2VlZCgyMzMyNCkKICAgICAgICAgZXhwZWN0ZWRfc3RkZXJyID0g J01PQ0s6IGlyYy5wb3N0OiAiT25seSB5b3UgY2FuIHByZXZlbnQgZm9yZXN0IGZpcmVzLiIgLS0g U21va2V5IHRoZSBCZWFyXG4nCg==