63204 2011-06-22 16:52:26 -0700 check-webkit-style should detect returning (Own|Ref)Ptr instead of the Pass*Ptr version. 2011-06-22 18:05:29 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 levin levin oldest_to_newest 425738 0 levin 2011-06-22 16:52:26 -0700 Follow up from https://bugs.webkit.org/show_bug.cgi?id=63198#c7 425797 1 98274 levin 2011-06-22 17:58:14 -0700 Created attachment 98274 Patch 425803 2 98274 levin 2011-06-22 18:05:25 -0700 Comment on attachment 98274 Patch Clearing flags on attachment: 98274 Committed r89508: <http://trac.webkit.org/changeset/89508> 425804 3 levin 2011-06-22 18:05:29 -0700 All reviewed patches have been landed. Closing bug. 98274 2011-06-22 17:58:14 -0700 2011-06-22 18:05:25 -0700 Patch bug-63204-20110622175808.patch text/plain 6914 levin U3VidmVyc2lvbiBSZXZpc2lvbjogODk0OTcKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2ZDA2ZGJiZjMzMzY3YjFiZDQ0MjRlYjU3ZjgwM2U2NDU1 Njk5ZGUxLi5iOGNhOTg0MTExNDQyZjZjYTI1MWYxM2JlNGY1OGYzNTBiM2JkNzVhIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkg QEAKIDIwMTEtMDYtMjIgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgogCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGNoZWNrLXdlYmtpdC1z dHlsZSBzaG91bGQgZGV0ZWN0IHJldHVybmluZyAoT3dufFJlZilQdHIgaW5zdGVhZCBvZiB0aGUg UGFzcypQdHIgdmVyc2lvbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTYzMjA0CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNr ZXJzL2NwcC5weTogQWRkZWQgYSBjaGVjayBmb3IgdGhlIHJldHVybiB2YWx1ZSBhbmQgY29tYmlu ZWQKKyAgICAgICAgICB3aXRoIHNpbWlsYXIgY29kZSBmb3IgdGhlIHBhcmFtZXRlciBjaGVja2lu Zy4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVz dC5weTogUmVtb3ZlZCBwYXNzX3B0ciBjaGVja3MgZnJvbQorICAgICAgICAgIHRob3NlIGRvbmUg Zm9yIHNpbmdsZSBsaW5lcyBzaW5jZSB0aGV5IGRvbid0IG1ha2Ugc2Vuc2UgaW4gdGhhdCBjYXNl ICh2YXJpYWJsZSBkZWNscyBsb29rIGxpa2UgZnVuY3Rpb24gZGVjbHMpLgorICAgICAgICAgIFJl bW92ZWQgc29tZSByZWR1bmRhbnQgY29tbWVudHMgKG9uZSBvZiB3aGljaCB3YXMgc2xpZ2h0bHkg d3JvbmcpLgorICAgICAgICAgIEFkZGVkIGNoZWNrcyBmb3IgdGhlIG5ldyBmdW5jdGlvbmFsaXR5 IGFuZCBtaW5vciBvdGhlciB0ZXN0IGNoYW5nZXMuCisKKzIwMTEtMDYtMjIgIERhdmlkIExldmlu ICA8bGV2aW5AY2hyb21pdW0ub3JnPgorCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGgu CiAKICAgICAgICAgY2hlY2std2Via2l0LXN0eWxlIHNob3VsZCBjaGVjayBmb3IgaW52YWxpZCB1 c2VzIG9mIFJlZlB0ci9Pd25QdHIgYXMgcGFyYW1ldGVycy4KZGlmZiAtLWdpdCBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKaW5kZXggMjM4ZjcwZGFkZDg1M2Q0NmU1Njk3NDJm NDUzNjI1ZTYxNmVjYzUzYy4uMDk0NjMyNzJiMDNmZjkzZDk3ODY1YTY2Mzc2NTY0ZWE3MzQxNWY4 MyAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAu cHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKQEAg LTE1NjYsNiArMTU2NiwyNCBAQCBkZWYgX2NoZWNrX3BhcmFtZXRlcl9uYW1lX2FnYWluc3RfdGV4 dChwYXJhbWV0ZXIsIHRleHQsIGVycm9yKToKICAgICByZXR1cm4gVHJ1ZQogCiAKK2RlZiBjaGVj a19mdW5jdGlvbl9kZWZpbml0aW9uX2FuZF9wYXNzX3B0cih0eXBlX3RleHQsIHJvdywgbG9jYXRp b25fZGVzY3JpcHRpb24sIGVycm9yKToKKyAgICAiIiJDaGVjayB0aGF0IGZ1bmN0aW9uIGRlZmlu aXRpb25zIGZvciB1c2UgUGFzcypQdHIgaW5zdGVhZCBvZiAqUHRyLgorCisgICAgQXJnczoKKyAg ICAgICB0eXBlX3RleHQ6IEEgc3RyaW5nIGNvbnRhaW5pbmcgdGhlIHR5cGUuIChGb3IgcmV0dXJu IHZhbHVlcywgaXQgbWF5IGNvbnRhaW4gbW9yZSB0aGFuIHRoZSB0eXBlLikKKyAgICAgICByb3c6 IFRoZSByb3cgbnVtYmVyIG9mIHRoZSB0eXBlLgorICAgICAgIGxvY2F0aW9uX2Rlc2NyaXB0aW9u OiBVc2VkIHRvIGluZGljYXRlIHdoZXJlIHRoZSB0eXBlIGlzLiBUaGlzIGlzIGVpdGhlciAncGFy YW1ldGVyJyBvciAncmV0dXJuJy4KKyAgICAgICBlcnJvcjogVGhlIGZ1bmN0aW9uIHRvIGNhbGwg d2l0aCBhbnkgZXJyb3JzIGZvdW5kLgorICAgICIiIgorICAgIG1hdGNoX3JlZl9vcl9vd25fcHRy ID0gJyg/PVxXfF4pKFJlZnxPd24pUHRyKD89XFcpJworICAgIGJhZF90eXBlX3VzYWdlID0gc2Vh cmNoKG1hdGNoX3JlZl9vcl9vd25fcHRyLCB0eXBlX3RleHQpCisgICAgaWYgbm90IGJhZF90eXBl X3VzYWdlOgorICAgICAgICByZXR1cm4KKyAgICB0eXBlX25hbWUgPSBiYWRfdHlwZV91c2FnZS5n cm91cCgwKQorICAgIGVycm9yKHJvdywgJ3JlYWRhYmlsaXR5L3Bhc3NfcHRyJywgNSwKKyAgICAg ICAgICAnVGhlICVzIHR5cGUgc2hvdWxkIHVzZSBQYXNzJXMgaW5zdGVhZCBvZiAlcy4nICUgKGxv Y2F0aW9uX2Rlc2NyaXB0aW9uLCB0eXBlX25hbWUsIHR5cGVfbmFtZSkpCisKKwogZGVmIGNoZWNr X2Z1bmN0aW9uX2RlZmluaXRpb24oZmlsZW5hbWUsIGZpbGVfZXh0ZW5zaW9uLCBjbGVhbl9saW5l cywgbGluZV9udW1iZXIsIGZ1bmN0aW9uX3N0YXRlLCBlcnJvcik6CiAgICAgIiIiQ2hlY2sgdGhh dCBmdW5jdGlvbiBkZWZpbml0aW9ucyBmb3Igc3R5bGUgaXNzdWVzLgogCkBAIC0xNTk3LDEzICsx NjE1LDExIEBAIGRlZiBjaGVja19mdW5jdGlvbl9kZWZpbml0aW9uKGZpbGVuYW1lLCBmaWxlX2V4 dGVuc2lvbiwgY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyCiAgICAgICAgICAgICBlcnJvcihmdW5j dGlvbl9zdGF0ZS5mdW5jdGlvbl9uYW1lX3N0YXJ0X3Bvc2l0aW9uLnJvdywgJ3JlYWRhYmlsaXR5 L3dlYmtpdF9hcGknLCA1LAogICAgICAgICAgICAgICAgICAgJ1dFQktJVF9BUEkgc2hvdWxkIG5v dCBiZSB1c2VkIHdpdGggYSBwdXJlIHZpcnR1YWwgZnVuY3Rpb24uJykKIAorICAgIGNoZWNrX2Z1 bmN0aW9uX2RlZmluaXRpb25fYW5kX3Bhc3NfcHRyKG1vZGlmaWVyc19hbmRfcmV0dXJuX3R5cGUs IGZ1bmN0aW9uX3N0YXRlLmZ1bmN0aW9uX25hbWVfc3RhcnRfcG9zaXRpb24ucm93LCAncmV0dXJu JywgZXJyb3IpCisKICAgICBwYXJhbWV0ZXJfbGlzdCA9IGZ1bmN0aW9uX3N0YXRlLnBhcmFtZXRl cl9saXN0KCkKICAgICBmb3IgcGFyYW1ldGVyIGluIHBhcmFtZXRlcl9saXN0OgotICAgICAgICBi YWRfcGFyYW1ldGVyX3R5cGUgPSBzZWFyY2goJyg/PVxXfF4pKFJlZnxPd24pUHRyKD89XFcpJywg cGFyYW1ldGVyLnR5cGUpCi0gICAgICAgIGlmIGJhZF9wYXJhbWV0ZXJfdHlwZToKLSAgICAgICAg ICAgIHR5cGVfbmFtZSA9IGJhZF9wYXJhbWV0ZXJfdHlwZS5ncm91cCgwKQotICAgICAgICAgICAg ZXJyb3IocGFyYW1ldGVyLnJvdywgJ3JlYWRhYmlsaXR5L3Bhc3NfcHRyJywgNSwKLSAgICAgICAg ICAgICAgICAgICdUaGUgcGFyYW1ldGVyIHR5cGUgc2hvdWxkIHVzZSBQYXNzJXMgaW5zdGVhZCBv ZiAlcy4nICUgKHR5cGVfbmFtZSwgdHlwZV9uYW1lKSkKKyAgICAgICAgY2hlY2tfZnVuY3Rpb25f ZGVmaW5pdGlvbl9hbmRfcGFzc19wdHIocGFyYW1ldGVyLnR5cGUsIHBhcmFtZXRlci5yb3csICdw YXJhbWV0ZXInLCBlcnJvcikKIAogICAgICAgICAjIERvIGNoZWNrcyBzcGVjaWZpYyB0byBmdW5j dGlvbiBkZWNsYXJhdGlvbnMgYW5kIHBhcmFtZXRlciBuYW1lcy4KICAgICAgICAgaWYgbm90IGZ1 bmN0aW9uX3N0YXRlLmlzX2RlY2xhcmF0aW9uIG9yIG5vdCBwYXJhbWV0ZXIubmFtZToKZGlmZiAt LWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0 LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3Qu cHkKaW5kZXggZWUyZjVlYWQ3ZmRhMGJmZTZjYTE2ZjIzNjlhYTI5NGY4MGM2YWI2ZS4uODAwZTJl MzNmMTQwYjJhZDUwMzNkYWNhYWYyMTVjZGVjZWI4MmFlZiAxMDA2NDQKLS0tIGEvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKKysrIGIvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKQEAgLTI1OSw2 ICsyNTksNyBAQCBjbGFzcyBDcHBTdHlsZVRlc3RCYXNlKHVuaXR0ZXN0LlRlc3RDYXNlKToKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgJy1sZWdhbC9jb3B5cmlnaHQnLAogICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAnLXJlYWRhYmlsaXR5L2ZuX3NpemUnLAogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAnLXJlYWRhYmlsaXR5L3BhcmFtZXRlcl9uYW1lJywKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgJy1yZWFkYWJpbGl0eS9wYXNzX3B0cicsCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICctd2hpdGVzcGFjZS9lbmRpbmdfbmV3bGluZScpCiAgICAgICAg IHJldHVybiBzZWxmLnBlcmZvcm1fbGludChjb2RlLCBmaWxlbmFtZSwgYmFzaWNfZXJyb3JfcnVs ZXMpCiAKQEAgLTMyMDUsNyArMzIwNiw2IEBAIGNsYXNzIFBhc3NQdHJUZXN0KENwcFN0eWxlVGVz dEJhc2UpOgogICAgICAgICAgICAgICAgICAgICAgICAgICBzZWxmLnBlcmZvcm1fcGFzc19wdHJf Y2hlY2soY29kZSkpCiAKICAgICBkZWYgdGVzdF9wYXNzX3JlZl9wdHJfaW5fZnVuY3Rpb24oc2Vs Zik6Ci0gICAgICAgICMgTG9jYWwgdmFyaWFibGVzIHNob3VsZCBuZXZlciBiZSBQYXNzUmVmUHRy LgogICAgICAgICBzZWxmLmFzc2VydF9wYXNzX3B0cl9jaGVjaygKICAgICAgICAgICAgICdpbnQg bXlGdW5jdGlvbigpXG4nCiAgICAgICAgICAgICAne1xuJwpAQCAtMzIxNSw3ICszMjE1LDYgQEAg Y2xhc3MgUGFzc1B0clRlc3QoQ3BwU3R5bGVUZXN0QmFzZSk6CiAgICAgICAgICAgICAnaHR0cDov L3dlYmtpdC5vcmcvY29kaW5nL1JlZlB0ci5odG1sKS4gIFtyZWFkYWJpbGl0eS9wYXNzX3B0cl0g WzVdJykKIAogICAgIGRlZiB0ZXN0X3Bhc3Nfb3duX3B0cl9pbl9mdW5jdGlvbihzZWxmKToKLSAg ICAgICAgIyBMb2NhbCB2YXJpYWJsZXMgc2hvdWxkIG5ldmVyIGJlIFBhc3NSZWZQdHIuCiAgICAg ICAgIHNlbGYuYXNzZXJ0X3Bhc3NfcHRyX2NoZWNrKAogICAgICAgICAgICAgJ2ludCBteUZ1bmN0 aW9uKClcbicKICAgICAgICAgICAgICd7XG4nCkBAIC0zMjI1LDcgKzMyMjQsNiBAQCBjbGFzcyBQ YXNzUHRyVGVzdChDcHBTdHlsZVRlc3RCYXNlKToKICAgICAgICAgICAgICdodHRwOi8vd2Via2l0 Lm9yZy9jb2RpbmcvUmVmUHRyLmh0bWwpLiAgW3JlYWRhYmlsaXR5L3Bhc3NfcHRyXSBbNV0nKQog CiAgICAgZGVmIHRlc3RfcGFzc19vdGhlcl90eXBlX3B0cl9pbl9mdW5jdGlvbihzZWxmKToKLSAg ICAgICAgIyBMb2NhbCB2YXJpYWJsZXMgc2hvdWxkIG5ldmVyIGJlIFBhc3NSZWZQdHIuCiAgICAg ICAgIHNlbGYuYXNzZXJ0X3Bhc3NfcHRyX2NoZWNrKAogICAgICAgICAgICAgJ2ludCBteUZ1bmN0 aW9uKClcbicKICAgICAgICAgICAgICd7XG4nCkBAIC0zMjQ5LDE1ICszMjQ3LDI2IEBAIGNsYXNz IFBhc3NQdHJUZXN0KENwcFN0eWxlVGVzdEJhc2UpOgogICAgICAgICBzZWxmLmFzc2VydF9wYXNz X3B0cl9jaGVjaygKICAgICAgICAgICAgICdQYXNzUmVmUHRyPFR5cGUxPiBteUZ1bmN0aW9uKCk7 XG4nLAogICAgICAgICAgICAgJycpCisgICAgICAgIHNlbGYuYXNzZXJ0X3Bhc3NfcHRyX2NoZWNr KAorICAgICAgICAgICAgJ093blJlZlB0cjxUeXBlMT4gbXlGdW5jdGlvbigpO1xuJywKKyAgICAg ICAgICAgICcnKQorICAgICAgICBzZWxmLmFzc2VydF9wYXNzX3B0cl9jaGVjaygKKyAgICAgICAg ICAgICdSZWZQdHI8VHlwZTE+IG15RnVuY3Rpb24oaW50KVxuJworICAgICAgICAgICAgJ3tcbicK KyAgICAgICAgICAgICd9JywKKyAgICAgICAgICAgICdUaGUgcmV0dXJuIHR5cGUgc2hvdWxkIHVz ZSBQYXNzUmVmUHRyIGluc3RlYWQgb2YgUmVmUHRyLiAgW3JlYWRhYmlsaXR5L3Bhc3NfcHRyXSBb NV0nKQorICAgICAgICBzZWxmLmFzc2VydF9wYXNzX3B0cl9jaGVjaygKKyAgICAgICAgICAgICdP d25QdHI8VHlwZTE+IG15RnVuY3Rpb24oaW50KVxuJworICAgICAgICAgICAgJ3tcbicKKyAgICAg ICAgICAgICd9JywKKyAgICAgICAgICAgICdUaGUgcmV0dXJuIHR5cGUgc2hvdWxkIHVzZSBQYXNz T3duUHRyIGluc3RlYWQgb2YgT3duUHRyLiAgW3JlYWRhYmlsaXR5L3Bhc3NfcHRyXSBbNV0nKQog Ci0gICAgZGVmIHRlc3RfcGFzc19yZWZfcHRyX3BhcmFtZXRlcl92YWx1ZShzZWxmKToKKyAgICBk ZWYgdGVzdF9yZWZfcHRyX3BhcmFtZXRlcl92YWx1ZShzZWxmKToKICAgICAgICAgc2VsZi5hc3Nl cnRfcGFzc19wdHJfY2hlY2soCiAgICAgICAgICAgICAnaW50IG15RnVuY3Rpb24oUGFzc1JlZlB0 cjxUeXBlMT4pXG4nCiAgICAgICAgICAgICAne1xuJwogICAgICAgICAgICAgJ30nLAogICAgICAg ICAgICAgJycpCi0KLSAgICBkZWYgdGVzdF9yZWZfcHRyX3BhcmFtZXRlcl92YWx1ZShzZWxmKToK ICAgICAgICAgc2VsZi5hc3NlcnRfcGFzc19wdHJfY2hlY2soCiAgICAgICAgICAgICAnaW50IG15 RnVuY3Rpb24oUmVmUHRyPFR5cGUxPilcbicKICAgICAgICAgICAgICd7XG4nCkBAIC0zMjY2LDYg KzMyNzUsMTEgQEAgY2xhc3MgUGFzc1B0clRlc3QoQ3BwU3R5bGVUZXN0QmFzZSk6CiAKICAgICBk ZWYgdGVzdF9vd25fcHRyX3BhcmFtZXRlcl92YWx1ZShzZWxmKToKICAgICAgICAgc2VsZi5hc3Nl cnRfcGFzc19wdHJfY2hlY2soCisgICAgICAgICAgICAnaW50IG15RnVuY3Rpb24oUGFzc093blB0 cjxUeXBlMT4pXG4nCisgICAgICAgICAgICAne1xuJworICAgICAgICAgICAgJ30nLAorICAgICAg ICAgICAgJycpCisgICAgICAgIHNlbGYuYXNzZXJ0X3Bhc3NfcHRyX2NoZWNrKAogICAgICAgICAg ICAgJ2ludCBteUZ1bmN0aW9uKE93blB0cjxUeXBlMT4pXG4nCiAgICAgICAgICAgICAne1xuJwog ICAgICAgICAgICAgJ30nLAo=