63192 2011-06-22 15:17:54 -0700 :checked pseudo selector not matching selected option 2011-10-11 20:44:58 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED FIXED http://jsfiddle.net/5dqPv/31/ P2 Normal --- 19264 1 karl.bohlmark webkit-unassigned ap koivisto mkrp87 shanestephens simon.fraser tkent webkit.review.bot oldest_to_newest 425656 0 karl.bohlmark 2011-06-22 15:17:54 -0700 The :checked pseudo selector is not matched by select options that have the "selected" attribute. The spec clearly states that :checked should match form elements that have the "checked" or "selected" attributes. Test case: http://jsfiddle.net/5dqPv/11/ Tested in webkit nightly. 425940 1 shanestephens 2011-06-22 21:21:00 -0700 Your test case doesn't demonstrate the behavior claimed in this bug - the letter-spacing property doesn't apply to option elements even in the absence of a :checked selector. Please provide a test case that demonstrates the behavior. 425993 2 karl.bohlmark 2011-06-23 00:38:44 -0700 Ok, I changed the test case to demonstrating it using querySelectorAll http://jsfiddle.net/5dqPv/31/ 426002 3 ap 2011-06-23 00:56:28 -0700 Please attach your test case to the bug. There is no reason to keep tests on jsfiddle. 426020 4 98323 karl.bohlmark 2011-06-23 01:48:29 -0700 Created attachment 98323 test case 426606 5 shanestephens 2011-06-23 16:30:33 -0700 Nice test case :) I couldn't find a property that applied to both selected and unselected option elements (e.g. background-color and color apply to the unselected elements but are overridden by the selection highlight). 481569 6 110499 mkrp87 2011-10-11 04:21:21 -0700 Created attachment 110499 Patch Option element selected state need to be checked in PseudoChecked, currently HTMLInput elements are checked on their checked state. I guess option elements do require check here if we want them to be considered as checked when it's state is selected. 482161 7 110499 tkent 2011-10-11 19:14:44 -0700 Comment on attachment 110499 Patch ok 482177 8 110499 mkrp87 2011-10-11 20:29:44 -0700 Comment on attachment 110499 Patch Thanks for review. Setting the commit-queue flag. 482180 9 110499 webkit.review.bot 2011-10-11 20:44:53 -0700 Comment on attachment 110499 Patch Clearing flags on attachment: 110499 Committed r97224: <http://trac.webkit.org/changeset/97224> 482181 10 webkit.review.bot 2011-10-11 20:44:58 -0700 All reviewed patches have been landed. Closing bug. 98323 2011-06-23 01:48:29 -0700 2011-06-23 01:48:29 -0700 test case test.html text/html 260 karl.bohlmark PHNlbGVjdCBtdWx0aXBsZT4NCgk8b3B0aW9uPnRlc3QxPC9vcHRpb24+DQoJPG9wdGlvbiBzZWxl Y3RlZD50ZXN0Mjwvb3B0aW9uPg0KPC9zZWxlY3Q+DQo8ZGl2Pg0KCVNlbGVjdGVkIGl0ZW1zOiA8 c3BhbiBpZD0icmVzdWx0Ij48L3NwYW4+DQo8L2Rpdj4NCjxzY3JpcHQ+DQoJZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoJ3Jlc3VsdCcpLmlubmVySFRNTCA9IGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3JB bGwoJzpjaGVja2VkJykubGVuZ3RoDQo8L3NjcmlwdD4= 110499 2011-10-11 04:21:21 -0700 2011-10-11 20:44:53 -0700 Patch patch.txt text/plain 5201 mkrp87 SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk3MTM4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMTAtMTEgIFNhbWVlciBQ YXRpbCAgPG1rcnA4N0Btb3Rvcm9sYS5jb20+CisKKyAgICAgICAgOmNoZWNrZWQgcHNldWRvIHNl bGVjdG9yIG5vdCBtYXRjaGluZyBzZWxlY3RlZCBvcHRpb24gCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MzE5MgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3Q6IGZhc3QvY3NzL2NoZWNrZWQtcHNldWRv LXNlbGVjdG9yLmh0bWwKKworICAgICAgICBPcHRpb24gZWxlbWVudCBzZWxlY3RlZCBzdGF0ZSBu ZWVkIHRvIGJlIGNoZWNrZWQgaW4gY2hlY2tPbmVTZWxlY3RvciwgCisgICAgICAgIHNvIHRoYXQg aXQgY2FuIGJlIGNvbnNpZGVyZWQgYXMgY2hlY2tlZCBvbiBxdWVyeVNlbGVjdG9yQWxsKCc6Y2hl Y2tlZCcpLgorCisgICAgICAgICogY3NzL1NlbGVjdG9yQ2hlY2tlci5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpTZWxlY3RvckNoZWNrZXI6OmNoZWNrT25lU2VsZWN0b3IpOgorCiAyMDExLTEwLTEw ICBBbmRyZWFzIEtsaW5nICA8a2xpbmdAd2Via2l0Lm9yZz4KIAogICAgICAgICBTaHJpbmsgV2Vi Q29yZTo6Tm9kZSBvbiA2NC1iaXQuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9jc3MvU2VsZWN0b3JD aGVja2VyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9jc3MvU2VsZWN0b3JDaGVj a2VyLmNwcAkocmV2aXNpb24gOTcwNDkpCisrKyBTb3VyY2UvV2ViQ29yZS9jc3MvU2VsZWN0b3JD aGVja2VyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDAsNiArNDAsNyBAQAogI2luY2x1ZGUgIkhU TUxQcm9ncmVzc0VsZW1lbnQuaCIKICNpbmNsdWRlICJJbnNwZWN0b3JJbnN0cnVtZW50YXRpb24u aCIKICNpbmNsdWRlICJOb2RlUmVuZGVyU3R5bGUuaCIKKyNpbmNsdWRlICJPcHRpb25FbGVtZW50 LmgiCiAjaW5jbHVkZSAiUGFnZS5oIgogI2luY2x1ZGUgIlBhZ2VHcm91cC5oIgogI2luY2x1ZGUg IlJlbmRlck9iamVjdC5oIgpAQCAtMTExNiw2ICsxMTE3LDEwIEBAIGJvb2wgU2VsZWN0b3JDaGVj a2VyOjpjaGVja09uZVNlbGVjdG9yKEMKICAgICAgICAgICAgICAgICBIVE1MSW5wdXRFbGVtZW50 KiBpbnB1dEVsZW1lbnQgPSBlLT50b0lucHV0RWxlbWVudCgpOwogICAgICAgICAgICAgICAgIGlm IChpbnB1dEVsZW1lbnQgJiYgaW5wdXRFbGVtZW50LT5zaG91bGRBcHBlYXJDaGVja2VkKCkgJiYg IWlucHV0RWxlbWVudC0+aXNJbmRldGVybWluYXRlKCkpCiAgICAgICAgICAgICAgICAgICAgIHJl dHVybiB0cnVlOworCisgICAgICAgICAgICAgICAgT3B0aW9uRWxlbWVudCogb3B0aW9uRWxlbWVu dCA9IHRvT3B0aW9uRWxlbWVudChlKTsKKyAgICAgICAgICAgICAgICBpZiAob3B0aW9uRWxlbWVu dCAmJiBvcHRpb25FbGVtZW50LT5zZWxlY3RlZCgpKQorICAgICAgICAgICAgICAgICAgICByZXR1 cm4gdHJ1ZTsKICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgIH0KICAgICAgICAg Y2FzZSBDU1NTZWxlY3Rvcjo6UHNldWRvSW5kZXRlcm1pbmF0ZToKSW5kZXg6IExheW91dFRlc3Rz L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9u IDk3MTM4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTMgQEAKKzIwMTEtMTAtMTEgIFNhbWVlciBQYXRpbCAgPG1rcnA4N0Btb3Rvcm9sYS5jb20+ CisKKyAgICAgICAgOmNoZWNrZWQgcHNldWRvIHNlbGVjdG9yIG5vdCBtYXRjaGluZyBzZWxlY3Rl ZCBvcHRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTYzMTkyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBmYXN0L2Nzcy9jaGVja2VkLXBzZXVkby1zZWxlY3Rvci1leHBlY3RlZC50eHQ6IEFkZGVkLgor ICAgICAgICAqIGZhc3QvY3NzL2NoZWNrZWQtcHNldWRvLXNlbGVjdG9yLmh0bWw6IEFkZGVkLgor CiAyMDExLTEwLTExICBQYXZlbCBQb2Rpdmlsb3YgIDxwb2Rpdmlsb3ZAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFVucmV2aWV3ZWQsIHJlYmFzZWxpbmUgdGVzdCBleHBlY3RhdGlvbnMgYWZ0ZXIg cjEwNDg2NCAoY2hyb21pdW0pLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9jc3MvY2hlY2tlZC1w c2V1ZG8tc2VsZWN0b3ItZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zh c3QvY3NzL2NoZWNrZWQtcHNldWRvLXNlbGVjdG9yLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkK KysrIExheW91dFRlc3RzL2Zhc3QvY3NzL2NoZWNrZWQtcHNldWRvLXNlbGVjdG9yLWV4cGVjdGVk LnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMCBAQAorVGhpcyBpcyBhIDpjaGVja2VkIHBz ZXVkbyBzZWxlY3RvciB0ZXN0LgorCisgCisgUmFkaW8xIAorIFJhZGlvMiAKKyBDaGVja2JveDEg CisgQ2hlY2tib3gyCisKK1BBU1MgLSBleHBlY3RlZDogNSBhbmQgZG9jdW1lbnQucXVlcnlTZWxl Y3RvckFsbCBnb3Q6IDUKKwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9jc3MvY2hlY2tlZC1wc2V1 ZG8tc2VsZWN0b3IuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2Nzcy9jaGVj a2VkLXBzZXVkby1zZWxlY3Rvci5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFz dC9jc3MvY2hlY2tlZC1wc2V1ZG8tc2VsZWN0b3IuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCAr MSw2NSBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorPHRpdGxlPjpjaGVja2Vk IHBzZXVkbyBzZWxlY3RvciBub3QgbWF0Y2hpbmcgc2VsZWN0ZWQgb3B0aW9uPC90aXRsZT4KKzwv aGVhZD4KKzxib2R5PgorCis8cD5UaGlzIGlzIGEgOmNoZWNrZWQgcHNldWRvIHNlbGVjdG9yIHRl c3QuPC9wPgorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+CisKKzxmb3JtIGFjdGlvbj0nJz4KKzxz ZWxlY3QgaWQ9J3NlbCcgbmFtZT0nc2VsZWN0JyBtdWx0aXBsZT4KKyAgICA8b3B0aW9uIGlkPSJv cHRpb24xIiBzZWxlY3RlZD5vcHRpb24xPC9vcHRpb24+CisgICAgPG9wdGlvbiBpZD0ib3B0aW9u MiI+b3B0aW9uMjwvb3B0aW9uPgorICAgIDxvcHRpb24gaWQ9Im9wdGlvbjMiIHNlbGVjdGVkPm9w dGlvbjM8L29wdGlvbj4KKyAgICA8b3B0aW9uIGlkPSJvcHRpb240Ij5vcHRpb240PC9vcHRpb24+ Cis8L3NlbGVjdD4KKzxicj4KKzxpbnB1dCBpZD0icmFkaW8xIiB0eXBlPSJyYWRpbyIgbmFtZT0i cmFkaW90ZXN0IiB2YWx1ZT0icmFkaW8xIiAvPiBSYWRpbzEKKzxicj4KKzxpbnB1dCBpZD0icmFk aW8yIiB0eXBlPSJyYWRpbyIgbmFtZT0icmFkaW90ZXN0IiB2YWx1ZT0icmFkaW8yIiBjaGVja2Vk Lz4gUmFkaW8yCis8YnI+Cis8aW5wdXQgaWQ9ImNoZWNrYm94MSIgdHlwZT0iY2hlY2tib3giIG5h bWU9ImNoZWNrdGVzdCIgdmFsdWU9ImNoZWNrYm94MSIgY2hlY2tlZC8+IENoZWNrYm94MQorPGJy PgorPGlucHV0IGlkPSJjaGVja2JveDIiIHR5cGU9ImNoZWNrYm94IiBuYW1lPSJjaGVja3Rlc3Qi IHZhbHVlPSJjaGVja2JveDIiIGNoZWNrZWQvPiBDaGVja2JveDIKKzwvZm9ybT4KKzxicj4KKzxz Y3JpcHQgbGFuZ3VhZ2U9IkphdmFTY3JpcHQiIHR5cGU9InRleHQvamF2YXNjcmlwdCI+Cit2YXIg dG90YWxDaGVja2VkID0gMDsKK3ZhciBleHBlY3RlZENvdW50ID0gMDsKK3ZhciBpZEFycmF5PW5l dyBBcnJheSgib3B0aW9uMSIsIm9wdGlvbjIiLCJvcHRpb24zIiwib3B0aW9uNCIsInJhZGlvMSIs InJhZGlvMiIsImNoZWNrYm94MSIsImNoZWNrYm94MiIpOworCitpZiAod2luZG93LmxheW91dFRl c3RDb250cm9sbGVyKSB7CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOwor fQorCitmdW5jdGlvbiBpc0NoZWNrZWRPclNlbGVjdGVkKGlkKSB7CisgICAgdmFyIG9iaiA9IGRv Y3VtZW50LmdldEVsZW1lbnRCeUlkKGlkKTsKKyAgICBpZiAob2JqLmNoZWNrZWQgfHwgb2JqLnNl bGVjdGVkKQorICAgICAgICByZXR1cm4gdHJ1ZTsKK30KKworZnVuY3Rpb24gcnVuVGVzdCgpIHsK KyAgICBmb3IgKHZhciBpID0gMDsgaSA8IGlkQXJyYXkubGVuZ3RoOyBpKyspIHsKKyAgICAgICAg aWYgKGlzQ2hlY2tlZE9yU2VsZWN0ZWQoaWRBcnJheVtpXSkpCisgICAgICAgICAgICBleHBlY3Rl ZENvdW50Kys7CisgICAgfQorICAgIHRvdGFsQ2hlY2tlZCA9IGRvY3VtZW50LnF1ZXJ5U2VsZWN0 b3JBbGwoJzpjaGVja2VkJykubGVuZ3RoOworICAgIGxvZ1Jlc3VsdCh0b3RhbENoZWNrZWQsZXhw ZWN0ZWRDb3VudCk7Cit9CisKK2Z1bmN0aW9uIGxvZ1Jlc3VsdCh0b3RhbENoZWNrZWQsIGV4cGVj dGVkQ291bnQpIHsKKyAgICAgaWYgKHRvdGFsQ2hlY2tlZCAhPSBleHBlY3RlZENvdW50KQorICAg ICAgICBkb2N1bWVudC53cml0ZSgnRkFJTCAtIGV4cGVjdGVkOiAnICsgZXhwZWN0ZWRDb3VudCAr ICcgYW5kIGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3JBbGwgZ290OiAnICsgdG90YWxDaGVja2VkKTsK KyAgICBlbHNlCisgICAgICAgIGRvY3VtZW50LndyaXRlKCdQQVNTIC0gZXhwZWN0ZWQ6ICcgKyBl eHBlY3RlZENvdW50ICsgJyBhbmQgZG9jdW1lbnQucXVlcnlTZWxlY3RvckFsbCBnb3Q6ICcgKyB0 b3RhbENoZWNrZWQpOworICAgIGRvY3VtZW50LndyaXRlKCc8YnI+Jyk7CisgICAgfQorCitpZiAo d2luZG93LmV2ZW50U2VuZGVyKSB7CisgICAgcnVuVGVzdCgpOworIH0KKzwvc2NyaXB0PgorPC9i b2R5PgorPC9odG1sPgo=