63178 2011-06-22 13:49:47 -0700 REGRESSION (r89449): http/tests/inspector/extensions-resources-redirect.html failing on SnowLeopard Intel Release (Tests), Windows 7 Release (Tests), Qt 2011-06-28 08:28:39 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED http://build.webkit.org/results/SnowLeopard Intel Release (Tests)/r89449 (30638)/results.html InRadar, LayoutTestFailure, Regression P2 Normal --- 1 jberlin vsevik aroben caseq jberlin ossy pfeldman vsevik oldest_to_newest 425550 0 jberlin 2011-06-22 13:49:47 -0700 http/tests/inspector/extensions-resources-redirect.html has been failing on SnowLeopard Intel Release (Tests) since r89449. http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r89448%20(30637)/results.html passed http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r89449%20(30638)/results.html failed This is happening on Windows as well: http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r89462%20(14031)/http/tests/inspector/extensions-resources-redirect-pretty-diff.html 425561 1 jberlin 2011-06-22 13:59:08 -0700 Added expected failing results http://trac.webkit.org/changeset/89477 425562 2 jberlin 2011-06-22 13:59:28 -0700 <rdar://problem/9658001> 426177 3 ossy 2011-06-23 08:01:05 -0700 I skipped it on Qt: http://trac.webkit.org/changeset/89570 But I don't think if it is a good idea to check in expected fails and/or skipping a failing test because of a regression. Regressions shouldn't be in trunk. 426183 4 vsevik 2011-06-23 08:10:05 -0700 this is a problem in test, not in the code, I have a patch ready and will upload it tomorrow. 426881 5 98492 vsevik 2011-06-24 07:50:19 -0700 Created attachment 98492 Patch 426903 6 aroben 2011-06-24 08:53:03 -0700 I wonder if this fill fix bug 63325 and/or bug 57491? 426913 7 vsevik 2011-06-24 09:04:31 -0700 (In reply to comment #6) > I wonder if this fill fix bug 63325 and/or bug 57491? I don't think so. I was not aware of these bugs, and could have a deeper look on them, but they are most probably related to the test implementation details, that were present in it initially, while this patch only fixes the problem caused by recent changes in a way inspector receives resources content. 426929 8 98492 jberlin 2011-06-24 09:43:34 -0700 Comment on attachment 98492 Patch Unofficial r=me (I am not a reviewer yet) 428145 9 98492 pfeldman 2011-06-27 11:38:36 -0700 Comment on attachment 98492 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98492&action=review > LayoutTests/platform/mac/http/tests/inspector/extensions-resources-redirect-expected.txt:-1 > -Tests WebInspector extension API Are you expecting this blank output on a Mac? 428146 10 98492 pfeldman 2011-06-27 11:40:12 -0700 Comment on attachment 98492 Patch Ah! you removed the custom expectation! 428902 11 caseq 2011-06-28 08:28:39 -0700 Manually committed r89931: http://trac.webkit.org/changeset/89931 98492 2011-06-24 07:50:19 -0700 2011-06-27 11:40:12 -0700 Patch bug-63178-20110624185017.patch text/plain 5613 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogODk2NzEKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBmZWJjZWNlNzhhYjBkMDViMzQyNDQ1 OWFiYmJmNTM1MDVhMTU1NjZiLi43ZTc5Y2QyN2Y4YjkzNTFmMzBmNjFiNDM1MTQwMTc3OGZlMGVj NThlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDYtMjQgIFZzZXZvbG9kIFZsYXNvdiAg PHZzZXZpa0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgUkVHUkVTU0lPTiAocjg5NDQ5KTogaHR0cC90ZXN0cy9pbnNwZWN0b3Iv ZXh0ZW5zaW9ucy1yZXNvdXJjZXMtcmVkaXJlY3QuaHRtbCBmYWlsaW5nIG9uIFNub3dMZW9wYXJk IEludGVsIFJlbGVhc2UgKFRlc3RzKSwgV2luZG93cyA3IFJlbGVhc2UgKFRlc3RzKSwgUXQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYzMTc4CisKKyAg ICAgICAgKiBodHRwL3Rlc3RzL2luc3BlY3Rvci9leHRlbnNpb25zLXJlc291cmNlcy1yZWRpcmVj dC1leHBlY3RlZC50eHQ6CisgICAgICAgICogcGxhdGZvcm0vbWFjL2h0dHAvdGVzdHMvaW5zcGVj dG9yL2V4dGVuc2lvbnMtcmVzb3VyY2VzLXJlZGlyZWN0LWV4cGVjdGVkLnR4dDogUmVtb3ZlZC4K KyAgICAgICAgKiBwbGF0Zm9ybS9xdC9Ta2lwcGVkOgorCiAyMDExLTA2LTI0ICBCYWxhenMgS2Vs ZW1lbiAgPGtiYWxhenNAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9pbnNwZWN0b3IvZXh0ZW5zaW9ucy1yZXNvdXJj ZXMtcmVkaXJlY3QtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9pbnNwZWN0 b3IvZXh0ZW5zaW9ucy1yZXNvdXJjZXMtcmVkaXJlY3QtZXhwZWN0ZWQudHh0CmluZGV4IGVkNDE1 NzFmMTk1MWE4MmFhMDQzYzY3MGM4MzY0ZTI2NzhjZGQ5NTguLmUxZDNhMTE1NDZkZjZjOWU5OWE1 YWZjZjRjZDExOWE5YzdkNjY3NmUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMv aW5zcGVjdG9yL2V4dGVuc2lvbnMtcmVzb3VyY2VzLXJlZGlyZWN0LWV4cGVjdGVkLnR4dAorKysg Yi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2luc3BlY3Rvci9leHRlbnNpb25zLXJlc291cmNlcy1y ZWRpcmVjdC1leHBlY3RlZC50eHQKQEAgLTQsNyArNCw3IEBAIFBhZ2UgcmVsb2FkZWQuCiBTdGFy dGVkIGV4dGVuc2lvbi4KIFJ1bm5pbmcgdGVzdHMuLi4KIFJVTk5JTkcgVEVTVDogZXh0ZW5zaW9u X3Rlc3RHZXRSZWRpcmVjdFJlc291cmNlQ29udGVudAotY29udGVudDogbnVsbCwgZW5jb2Rpbmc6 IGJhc2U2NAorY29udGVudDogbnVsbCwgZW5jb2Rpbmc6IAogUlVOTklORyBURVNUOiBleHRlbnNp b25fdGVzdFJlZGlyZWN0UmVzb3VyY2VGaW5pc2hlZAogRmluaXNoZWQgcmVzb3VyY2U6IGh0dHA6 Ly8xMjcuMC4wLjE6ODAwMC9sb2FkaW5nL3Jlc291cmNlcy9yZWRpcmVjdC1tZXRob2RzLXJlc3Vs dC5waHA/c3RhdHVzPTMwMgogRmluaXNoZWQgcmVzb3VyY2U6IGh0dHA6Ly8xMjcuMC4wLjE6ODAw MC9sb2FkaW5nL3Jlc291cmNlcy9yZWRpcmVjdC1tZXRob2RzLXJlc3VsdC5waHA/cmVkaXJlY3Rl ZD10cnVlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvaHR0cC90ZXN0cy9p bnNwZWN0b3IvZXh0ZW5zaW9ucy1yZXNvdXJjZXMtcmVkaXJlY3QtZXhwZWN0ZWQudHh0IGIvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2h0dHAvdGVzdHMvaW5zcGVjdG9yL2V4dGVuc2lvbnMtcmVz b3VyY2VzLXJlZGlyZWN0LWV4cGVjdGVkLnR4dApkZWxldGVkIGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggZTFkM2ExMTU0NmRmNmM5ZTk5YTVhZmNmNGNkMTE5YTljN2Q2Njc2ZS4uMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9t YWMvaHR0cC90ZXN0cy9pbnNwZWN0b3IvZXh0ZW5zaW9ucy1yZXNvdXJjZXMtcmVkaXJlY3QtZXhw ZWN0ZWQudHh0CisrKyAvZGV2L251bGwKQEAgLTEsMjIgKzAsMCBAQAotVGVzdHMgV2ViSW5zcGVj dG9yIGV4dGVuc2lvbiBBUEkKLQotUGFnZSByZWxvYWRlZC4KLVN0YXJ0ZWQgZXh0ZW5zaW9uLgot UnVubmluZyB0ZXN0cy4uLgotUlVOTklORyBURVNUOiBleHRlbnNpb25fdGVzdEdldFJlZGlyZWN0 UmVzb3VyY2VDb250ZW50Ci1jb250ZW50OiBudWxsLCBlbmNvZGluZzogCi1SVU5OSU5HIFRFU1Q6 IGV4dGVuc2lvbl90ZXN0UmVkaXJlY3RSZXNvdXJjZUZpbmlzaGVkCi1GaW5pc2hlZCByZXNvdXJj ZTogaHR0cDovLzEyNy4wLjAuMTo4MDAwL2xvYWRpbmcvcmVzb3VyY2VzL3JlZGlyZWN0LW1ldGhv ZHMtcmVzdWx0LnBocD9zdGF0dXM9MzAyCi1GaW5pc2hlZCByZXNvdXJjZTogaHR0cDovLzEyNy4w LjAuMTo4MDAwL2xvYWRpbmcvcmVzb3VyY2VzL3JlZGlyZWN0LW1ldGhvZHMtcmVzdWx0LnBocD9y ZWRpcmVjdGVkPXRydWUKLVJVTk5JTkcgVEVTVDogZXh0ZW5zaW9uX3Rlc3RSZWRpcmVjdFJlc291 cmNlc0luSEFSCi1SZXNvdXJjZXMgaW4gSEFSOgotaHR0cDovLzEyNy4wLjAuMTo4MDAwL2luc3Bl Y3Rvci9leHRlbnNpb25zLXJlc291cmNlcy1yZWRpcmVjdC5odG1sCi1odHRwOi8vMTI3LjAuMC4x OjgwMDAvaW5zcGVjdG9yL2V4dGVuc2lvbnMtcmVzb3VyY2VzLXRlc3QuanMKLWh0dHA6Ly8xMjcu MC4wLjE6ODAwMC9pbnNwZWN0b3IvZXh0ZW5zaW9ucy10ZXN0LmpzCi1odHRwOi8vMTI3LjAuMC4x OjgwMDAvaW5zcGVjdG9yL2luc3BlY3Rvci10ZXN0LmpzCi1odHRwOi8vMTI3LjAuMC4xOjgwMDAv bG9hZGluZy9yZXNvdXJjZXMvcmVkaXJlY3QtbWV0aG9kcy1yZXN1bHQucGhwP3JlZGlyZWN0ZWQ9 dHJ1ZQotaHR0cDovLzEyNy4wLjAuMTo4MDAwL2xvYWRpbmcvcmVzb3VyY2VzL3JlZGlyZWN0LW1l dGhvZHMtcmVzdWx0LnBocD9yZWRpcmVjdGVkPXRydWUKLWh0dHA6Ly8xMjcuMC4wLjE6ODAwMC9s b2FkaW5nL3Jlc291cmNlcy9yZWRpcmVjdC1tZXRob2RzLXJlc3VsdC5waHA/c3RhdHVzPTMwMgot aHR0cDovLzEyNy4wLjAuMTo4MDAwL2xvYWRpbmcvcmVzb3VyY2VzL3JlZGlyZWN0LW1ldGhvZHMt cmVzdWx0LnBocD9zdGF0dXM9MzAyCi1BbGwgdGVzdHMgZG9uZS4KLQpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1Nr aXBwZWQKaW5kZXggMWFlYTdjYzAxMzNmZGIxOGE3MzZjYmFmNjZiMWY4MGNlZWMxMTUwMS4uZTI3 YWQ1Y2FjZTZjOGE1ZTViZTBjMmVhNTI4NTRhNjAzOWZmZjA1MiAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9T a2lwcGVkCkBAIC0yNTUzLDYgKzI1NTMsMyBAQCBmYXN0L25vdGlmaWNhdGlvbnMvbm90aWZpY2F0 aW9ucy1uby1pY29uLmh0bWwKIGZhc3Qvbm90aWZpY2F0aW9ucy9ub3RpZmljYXRpb25zLXdpdGgt cGVybWlzc2lvbi5odG1sCiBmYXN0L25vdGlmaWNhdGlvbnMvbm90aWZpY2F0aW9ucy13aXRob3V0 LXBlcm1pc3Npb24uaHRtbAogCi0jIFJFR1JFU1NJT04gKHI4OTQ0OSk6IGh0dHAvdGVzdHMvaW5z cGVjdG9yL2V4dGVuc2lvbnMtcmVzb3VyY2VzLXJlZGlyZWN0Lmh0bWwgZmFpbGluZyBvbiBTbm93 TGVvcGFyZCBJbnRlbCBSZWxlYXNlIChUZXN0cyksIFdpbmRvd3MgNyBSZWxlYXNlIChUZXN0cyks IFF0Ci0jIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MzE3OAotaHR0 cC90ZXN0cy9pbnNwZWN0b3IvZXh0ZW5zaW9ucy1yZXNvdXJjZXMtcmVkaXJlY3QuaHRtbApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCmluZGV4IDhmZmY4ODk0N2NjMTg0MjI5ZGNmODViZWRlZTIwNzVkNDk2YTA4YjUuLmQxNTM4 ODA5MzRiMTkzNThhNGFlYzk3ZmE3MDUyNmNkMmRlYjgzYTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxMyBAQAorMjAxMS0wNi0yNCAgVnNldm9sb2QgVmxhc292ICA8dnNldmlrQGNocm9taXVtLm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSRUdS RVNTSU9OIChyODk0NDkpOiBodHRwL3Rlc3RzL2luc3BlY3Rvci9leHRlbnNpb25zLXJlc291cmNl cy1yZWRpcmVjdC5odG1sIGZhaWxpbmcgb24gU25vd0xlb3BhcmQgSW50ZWwgUmVsZWFzZSAoVGVz dHMpLCBXaW5kb3dzIDcgUmVsZWFzZSAoVGVzdHMpLCBRdAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjMxNzgKKworICAgICAgICAqIGluc3BlY3Rvci9m cm9udC1lbmQvTmV0d29ya01hbmFnZXIuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuTmV0d29y a01hbmFnZXIucHJvdG90eXBlLnJlcXVlc3RDb250ZW50KToKKwogMjAxMS0wNi0yNCAgWXV0YSBL aXRhbXVyYSAgPHl1dGFrQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFt IEJhcnRoLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9O ZXR3b3JrTWFuYWdlci5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvTmV0 d29ya01hbmFnZXIuanMKaW5kZXggMzg5ZGMxYjEyNDgxMzFjYjM1YzdhNTYwNGY0YTJlMmMzYzNh MzE3ZC4uM2MwZmYzNDk2MDJkYWQ2NmMzZjZiZWFhZTg0YjkxZDM4MzZlN2E2YyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9OZXR3b3JrTWFuYWdlci5qcwor KysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL05ldHdvcmtNYW5hZ2VyLmpz CkBAIC00Niw3ICs0NiwxMCBAQCBXZWJJbnNwZWN0b3IuTmV0d29ya01hbmFnZXIucHJvdG90eXBl ID0gewogICAgIHsKICAgICAgICAgZnVuY3Rpb24gY2FsbGJhY2tXcmFwcGVyKGVycm9yLCBjb250 ZW50LCBjb250ZW50RW5jb2RlZCkKICAgICAgICAgewotICAgICAgICAgICAgY2FsbGJhY2soIWVy cm9yID8gY29udGVudCA6IG51bGwsIGNvbnRlbnRFbmNvZGVkKTsKKyAgICAgICAgICAgIGlmIChl cnJvcikKKyAgICAgICAgICAgICAgICBjYWxsYmFjayhudWxsLCBmYWxzZSk7CisgICAgICAgICAg ICBlbHNlCisgICAgICAgICAgICAgICAgY2FsbGJhY2soY29udGVudCwgY29udGVudCAmJiBjb250 ZW50RW5jb2RlZCk7CiAgICAgICAgIH0KICAgICAgICAgLy8gRklYTUU6IGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTM2MyBXZSBzaG91bGQgc2VwYXJhdGUgTmV0d29y a1Jlc291cmNlIChOZXR3b3JrUGFuZWwgcmVzb3VyY2UpIAogICAgICAgICAvLyBmcm9tIFJlc291 cmNlUmV2aXNpb24gKFJlc291cmNlc1BhbmVsL1NjcmlwdHNQYW5lbCByZXNvdXJjZSkgYW5kIHJl cXVlc3QgY29udGVudCBhY2NvcmRpbmdseS4K