63163 2011-06-22 11:51:51 -0700 Add preference for setting the html parser depth limit 2011-06-23 07:10:20 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 sam sam abarth ap mitz oldest_to_newest 425435 0 sam 2011-06-22 11:51:51 -0700 Add preference for setting the html parser depth limit 425437 1 98210 sam 2011-06-22 11:52:40 -0700 Created attachment 98210 Patch 425517 2 sam 2011-06-22 13:13:59 -0700 Committed r89469: <http://trac.webkit.org/changeset/89469> 425552 3 98210 mitz 2011-06-22 13:51:06 -0700 Comment on attachment 98210 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98210&action=review > Source/WebKit/mac/WebView/WebPreferencesPrivate.h:242 > +- (void)setMaximumHTMLParserDOMTreeDepth:(unsigned)depth; > +- (unsigned)maximumHTMLParserDOMTreeDepth; Should use NSUInteger instead of unsigned here. 425644 4 sam 2011-06-22 15:03:47 -0700 (In reply to comment #3) > (From update of attachment 98210 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=98210&action=review > > > Source/WebKit/mac/WebView/WebPreferencesPrivate.h:242 > > +- (void)setMaximumHTMLParserDOMTreeDepth:(unsigned)depth; > > +- (unsigned)maximumHTMLParserDOMTreeDepth; > > Should use NSUInteger instead of unsigned here. Ok, I actually think I want to back this out. There isn't a super compelling reason for it as it turns out. 425761 5 sam 2011-06-22 17:17:39 -0700 Rolled out the patch in 89501. 426004 6 ap 2011-06-23 01:01:40 -0700 So, changing resolution to WONTFIX. I can't see how the preference could be a good idea - either the depth limit doesn't affect real life Web sites, or the limit should be the same across all WebKit ports for compatibility. 426141 7 sam 2011-06-23 07:10:20 -0700 (In reply to comment #6) > So, changing resolution to WONTFIX. > > I can't see how the preference could be a good idea - either the depth limit doesn't affect real life Web sites, or the limit should be the same across all WebKit ports for compatibility. The initial intent of the preference was for applications that don't care as much about about web compatibilty (such as mail client). 98210 2011-06-22 11:52:40 -0700 2011-06-22 15:03:59 -0700 Patch bug-63163-20110622115239.patch text/plain 5142 sam SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDg5NDUzKQorKysgU291cmNlL1dlYktpdC9t YWMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDYtMjIg IFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgcHJlZmVyZW5jZSBmb3Igc2V0dGluZyB0aGUgaHRt bCBwYXJzZXIgZGVwdGggbGltaXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTYzMTYzCisKKyAgICAgICAgKiBXZWJWaWV3L1dlYlByZWZlcmVuY2VLZXlz UHJpdmF0ZS5oOgorICAgICAgICAqIFdlYlZpZXcvV2ViUHJlZmVyZW5jZXMubW06CisgICAgICAg ICgrW1dlYlByZWZlcmVuY2VzIGluaXRpYWxpemVdKToKKyAgICAgICAgKC1bV2ViUHJlZmVyZW5j ZXMgc2V0TWF4aW11bUhUTUxQYXJzZXJET01UcmVlRGVwdGg6XSk6CisgICAgICAgICgtW1dlYlBy ZWZlcmVuY2VzIG1heGltdW1IVE1MUGFyc2VyRE9NVHJlZURlcHRoXSk6CisgICAgICAgICogV2Vi Vmlldy9XZWJQcmVmZXJlbmNlc1ByaXZhdGUuaDoKKyAgICAgICAgKiBXZWJWaWV3L1dlYlZpZXcu bW06CisgICAgICAgICgtW1dlYlZpZXcgX3ByZWZlcmVuY2VzQ2hhbmdlZDpdKToKKyAgICAgICAg QWRkIHByaXZhdGUgcHJlZmVyZW5jZSBmb3Igc2V0dGluZyB0aGUgcGFyc2VyIGRlcHRoIGxpbWl0 LgorCiAyMDExLTA2LTIyICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogU291cmNlL1dlYktpdC9tYWMvV2Vi Vmlldy9XZWJQcmVmZXJlbmNlS2V5c1ByaXZhdGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0L21hYy9XZWJWaWV3L1dlYlByZWZlcmVuY2VLZXlzUHJpdmF0ZS5oCShyZXZpc2lvbiA4OTQ1 MikKKysrIFNvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViUHJlZmVyZW5jZUtleXNQcml2YXRl LmgJKHdvcmtpbmcgY29weSkKQEAgLTEyMCw2ICsxMjAsNyBAQAogI2RlZmluZSBXZWJLaXRUZXh0 RGlyZWN0aW9uU3VibWVudUluY2x1c2lvbkJlaGF2aW9yUHJlZmVyZW5jZUtleSBAIldlYktpdFRl eHREaXJlY3Rpb25TdWJtZW51SW5jbHVzaW9uQmVoYXZpb3JQcmVmZXJlbmNlS2V5IgogI2RlZmlu ZSBXZWJLaXRFZGl0aW5nQmVoYXZpb3JQcmVmZXJlbmNlS2V5IEAiV2ViS2l0RWRpdGluZ0JlaGF2 aW9yIgogI2RlZmluZSBXZWJLaXRVc2VQcmVIVE1MNVBhcnNlclF1aXJrc0tleSBAIldlYktpdFVz ZVByZUhUTUw1UGFyc2VyUXVpcmtzIgorI2RlZmluZSBXZWJLaXRNYXhpbXVtSFRNTFBhcnNlckRP TVRyZWVEZXB0aEtleSBAIldlYktpdE1heGltdW1IVE1MUGFyc2VyRE9NVHJlZURlcHRoIgogCiAv LyBDb3JlR3JhcGhpY3MgZGVmZXJyZWQgdXBkYXRlcyBhcmUgZGlzYWJsZWQgaWYgV2ViS2l0RW5h YmxlQ29hbGVzY2VkVXBkYXRlc1ByZWZlcmVuY2VLZXkgaXMgc2V0CiAvLyB0byBOTywgb3IgaGFz IG5vIHZhbHVlLiAgRm9yIGNvbXBhdGliaWxpdHkgd2l0aCBNYWMgT1MgWCAxMC40LjYsIGRlZmVy cmVkIHVwZGF0ZXMgYXJlIE9GRiBieQpJbmRleDogU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9X ZWJQcmVmZXJlbmNlcy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3 L1dlYlByZWZlcmVuY2VzLm1tCShyZXZpc2lvbiA4OTQ1MikKKysrIFNvdXJjZS9XZWJLaXQvbWFj L1dlYlZpZXcvV2ViUHJlZmVyZW5jZXMubW0JKHdvcmtpbmcgY29weSkKQEAgLTM5LDYgKzM5LDcg QEAKICNpbXBvcnQgIldlYk5TRGljdGlvbmFyeUV4dHJhcy5oIgogI2ltcG9ydCAiV2ViTlNVUkxF eHRyYXMuaCIKICNpbXBvcnQgPFdlYkNvcmUvQXBwbGljYXRpb25DYWNoZVN0b3JhZ2UuaD4KKyNp bXBvcnQgPFdlYkNvcmUvU2V0dGluZ3MuaD4KIAogTlNTdHJpbmcgKldlYlByZWZlcmVuY2VzQ2hh bmdlZE5vdGlmaWNhdGlvbiA9IEAiV2ViUHJlZmVyZW5jZXNDaGFuZ2VkTm90aWZpY2F0aW9uIjsK IE5TU3RyaW5nICpXZWJQcmVmZXJlbmNlc1JlbW92ZWROb3RpZmljYXRpb24gPSBAIldlYlByZWZl cmVuY2VzUmVtb3ZlZE5vdGlmaWNhdGlvbiI7CkBAIC0zNzUsNiArMzc2LDcgQEAgKyAodm9pZClp bml0aWFsaXplCiAgICAgICAgIFtOU051bWJlciBudW1iZXJXaXRoQm9vbDpOT10sICAgV2ViS2l0 TWVtb3J5SW5mb0VuYWJsZWRQcmVmZXJlbmNlS2V5LAogICAgICAgICBbTlNOdW1iZXIgbnVtYmVy V2l0aEJvb2w6WUVTXSwgIFdlYktpdEh5cGVybGlua0F1ZGl0aW5nRW5hYmxlZFByZWZlcmVuY2VL ZXksCiAgICAgICAgIFtOU051bWJlciBudW1iZXJXaXRoQm9vbDpOT10sICAgV2ViS2l0VXNlUHJl SFRNTDVQYXJzZXJRdWlya3NLZXksCisgICAgICAgIFtOU051bWJlciBudW1iZXJXaXRoVW5zaWdu ZWRJbnQ6V2ViQ29yZTo6U2V0dGluZ3M6OmRlZmF1bHRNYXhpbXVtSFRNTFBhcnNlckRPTVRyZWVE ZXB0aF0sIFdlYktpdE1heGltdW1IVE1MUGFyc2VyRE9NVHJlZURlcHRoS2V5LAogICAgICAgICBb TlNOdW1iZXIgbnVtYmVyV2l0aEJvb2w6WUVTXSwgIFdlYktpdEFWRm91bmRhdGlvbkVuYWJsZWRL ZXksCiAgICAgICAgIFtOU051bWJlciBudW1iZXJXaXRoTG9uZ0xvbmc6V2ViQ29yZTo6QXBwbGlj YXRpb25DYWNoZVN0b3JhZ2U6Om5vUXVvdGEoKV0sIFdlYktpdEFwcGxpY2F0aW9uQ2FjaGVUb3Rh bFF1b3RhLAogICAgICAgICBbTlNOdW1iZXIgbnVtYmVyV2l0aExvbmdMb25nOldlYkNvcmU6OkFw cGxpY2F0aW9uQ2FjaGVTdG9yYWdlOjpub1F1b3RhKCldLCBXZWJLaXRBcHBsaWNhdGlvbkNhY2hl RGVmYXVsdE9yaWdpblF1b3RhLApAQCAtMTQwOCw2ICsxNDEwLDE2IEBAIC0gKHZvaWQpc2V0VXNl UHJlSFRNTDVQYXJzZXJRdWlya3M6KEJPT0wKICAgICBbc2VsZiBfc2V0Qm9vbFZhbHVlOmZsYWcg Zm9yS2V5OldlYktpdFVzZVByZUhUTUw1UGFyc2VyUXVpcmtzS2V5XTsKIH0KIAorLSAodm9pZClz ZXRNYXhpbXVtSFRNTFBhcnNlckRPTVRyZWVEZXB0aDoodW5zaWduZWQpZGVwdGgKK3sKKyAgICBb c2VsZiBfc2V0SW50ZWdlclZhbHVlOmRlcHRoIGZvcktleTpXZWJLaXRNYXhpbXVtSFRNTFBhcnNl ckRPTVRyZWVEZXB0aEtleV07Cit9CisKKy0gKHVuc2lnbmVkKW1heGltdW1IVE1MUGFyc2VyRE9N VHJlZURlcHRoCit7CisgICAgcmV0dXJuIFtzZWxmIF9pbnRlZ2VyVmFsdWVGb3JLZXk6V2ViS2l0 TWF4aW11bUhUTUxQYXJzZXJET01UcmVlRGVwdGhLZXldOworfQorCiAtICh2b2lkKWRpZFJlbW92 ZUZyb21XZWJWaWV3CiB7CiAgICAgQVNTRVJUKF9wcml2YXRlLT5udW1XZWJWaWV3cyk7CkluZGV4 OiBTb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlByZWZlcmVuY2VzUHJpdmF0ZS5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViUHJlZmVyZW5jZXNQcml2YXRl LmgJKHJldmlzaW9uIDg5NDUyKQorKysgU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJQcmVm ZXJlbmNlc1ByaXZhdGUuaAkod29ya2luZyBjb3B5KQpAQCAtMjM4LDYgKzIzOCw5IEBAIEBpbnRl cmZhY2UgV2ViUHJlZmVyZW5jZXMgKFdlYlByaXZhdGUpCiAtICh2b2lkKXNldFVzZVByZUhUTUw1 UGFyc2VyUXVpcmtzOihCT09MKWZsYWc7CiAtIChCT09MKXVzZVByZUhUTUw1UGFyc2VyUXVpcmtz OwogCistICh2b2lkKXNldE1heGltdW1IVE1MUGFyc2VyRE9NVHJlZURlcHRoOih1bnNpZ25lZClk ZXB0aDsKKy0gKHVuc2lnbmVkKW1heGltdW1IVE1MUGFyc2VyRE9NVHJlZURlcHRoOworCiAtICh2 b2lkKXNldExvYWRzU2l0ZUljb25zSWdub3JpbmdJbWFnZUxvYWRpbmdQcmVmZXJlbmNlOiAoQk9P TClmbGFnOwogLSAoQk9PTClsb2Fkc1NpdGVJY29uc0lnbm9yaW5nSW1hZ2VMb2FkaW5nUHJlZmVy ZW5jZTsKIApJbmRleDogU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViVmlldy5tbQkocmV2aXNpb24g ODk0NTIpCisrKyBTb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlZpZXcubW0JKHdvcmtpbmcg Y29weSkKQEAgLTE1NzAsNiArMTU3MCw3IEBAIC0gKHZvaWQpX3ByZWZlcmVuY2VzQ2hhbmdlZDoo V2ViUHJlZmVyZW4KICAgICBzZXR0aW5ncy0+c2V0TWVtb3J5SW5mb0VuYWJsZWQoW3ByZWZlcmVu Y2VzIG1lbW9yeUluZm9FbmFibGVkXSk7CiAgICAgc2V0dGluZ3MtPnNldEh5cGVybGlua0F1ZGl0 aW5nRW5hYmxlZChbcHJlZmVyZW5jZXMgaHlwZXJsaW5rQXVkaXRpbmdFbmFibGVkXSk7CiAgICAg c2V0dGluZ3MtPnNldFVzZVByZUhUTUw1UGFyc2VyUXVpcmtzKFtzZWxmIF9uZWVkc1ByZUhUTUw1 UGFyc2VyUXVpcmtzXSk7CisgICAgc2V0dGluZ3MtPnNldE1heGltdW1IVE1MUGFyc2VyRE9NVHJl ZURlcHRoKFtwcmVmZXJlbmNlcyBtYXhpbXVtSFRNTFBhcnNlckRPTVRyZWVEZXB0aF0pOwogICAg IHNldHRpbmdzLT5zZXRDcm9zc09yaWdpbkNoZWNrSW5HZXRNYXRjaGVkQ1NTUnVsZXNEaXNhYmxl ZChbc2VsZiBfbmVlZHNVbnJlc3RyaWN0ZWRHZXRNYXRjaGVkQ1NTUnVsZXNdKTsKICAgICBzZXR0 aW5ncy0+c2V0SW50ZXJhY3RpdmVGb3JtVmFsaWRhdGlvbkVuYWJsZWQoW3NlbGYgaW50ZXJhY3Rp dmVGb3JtVmFsaWRhdGlvbkVuYWJsZWRdKTsKICAgICBzZXR0aW5ncy0+c2V0VmFsaWRhdGlvbk1l c3NhZ2VUaW1lck1hZ25pZmljYXRpb24oW3NlbGYgdmFsaWRhdGlvbk1lc3NhZ2VUaW1lck1hZ25p ZmljYXRpb25dKTsK