63157 2011-06-22 11:03:03 -0700 REGRESSION (r89407): Text in search field in Safari's find banner is too low on Windows 2011-06-29 06:37:13 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) PC Windows 7 RESOLVED FIXED InRadar, PlatformOnly, Regression P2 Normal --- 61415 1 aroben webkit-unassigned dglazkov hyatt mitz simon.fraser tkent oldest_to_newest 425373 0 98200 aroben 2011-06-22 11:03:03 -0700 Created attachment 98200 screenshot To reproduce: 1. Go to any page 2. Press Ctrl-F to show the find banner 3. Type some text in the find banner's search field The text is too low. See screenshot. 425375 1 aroben 2011-06-22 11:03:27 -0700 Looks like this started happening in r89407: http://trac.webkit.org/changeset/89407 Note that the search field contains a WebView with an <input> element. 425380 2 aroben 2011-06-22 11:04:09 -0700 <rdar://problem/9656624> 425499 3 aroben 2011-06-22 12:59:15 -0700 r89407 was rolled out in r89460. 425860 4 tkent 2011-06-22 18:49:50 -0700 (In reply to comment #0) > Created an attachment (id=98200) [details] > screenshot What OS version are you using? I couldn't reproduce this issue with Safari 5.0.4 + WebKit with r89407 on Snow Leopard. The search field appearance in the screenshot looks different. 425863 5 tkent 2011-06-22 18:53:28 -0700 Ah, it's on Windows. I see. 425981 6 tkent 2011-06-22 23:48:32 -0700 Does it have any additional CSS properties? 426303 7 98372 aroben 2011-06-23 10:55:57 -0700 Created attachment 98372 testcase Here's a testcase. In r89407, you can see that the baseline of the text in the search field is below the border, while in ToT it is above the border. 426851 8 tkent 2011-06-24 05:22:39 -0700 (In reply to comment #7) > Created an attachment (id=98372) [details] > testcase > > Here's a testcase. In r89407, you can see that the baseline of the text in the search field is below the border, while in ToT it is above the border. Thank you! It's very helpful. 429433 9 tkent 2011-06-28 22:37:19 -0700 The purpose of r89407 is to use the standard CSS rendering as possible, and I wanted to make RenderTextControlSingleLine honored paddings. However the testcase expects it ignores paddings. So, I decided to introduce a special handling for type=search so that only type=search ignores paddings if the content box of <input> is smaller than the text height. 98200 2011-06-22 11:03:03 -0700 2011-06-22 11:03:03 -0700 screenshot screenshot.png image/png 1619 aroben iVBORw0KGgoAAAANSUhEUgAAAKAAAAAYCAMAAABKiAYHAAAAAXNSR0IArs4c6QAAAARnQU1BAACx jwv8YQUAAAAgY0hSTQAAeiYAAICEAAD6AAAAgOgAAHUwAADqYAAAOpgAABdwnLpRPAAAAwBQTFRF ZGRkZWVlampqb29vd3d3enp6e3t7fHx8fn5+MmjEM2nFMmjNMmjZM2naWWnFWWnOMoLjWYPjWbr4 gWjEgmnFgmnaoptwo5xxo51yo592pJxypJ1zpJ50pJ91pp92pqB2pqB3hYWFhoaGh4eHiIiIiYmJ l5eXnJycnZ2dqaWDq6aDq6WGr6uJsauMsq6Qp6enqKiorKysrq6uuLekurimv7yntLS0tra2vLy2 vr63ubm5uru5urq6u7u7ury6u727vLy8vL68o4LEo4PFvsC3gtHto+33o+3/wL2pw6DEw7nN57rO wsCvx8SzwMC5wcG6wsK7wMG/w8O9xMa9yMWzysq/wsPAw8PDw8XDxMTCxMTExcXFxMbExsbGx8fH yMjIycnJyMrIycrJysrKy8vLyszKy83Lzc3JzMzKzc3Lzc3Nzc7Nzs7Oz8/PztDO1tLA09LO1NLN 2tfG2tfH3tvL0NDQ0dHR0dLQ0dLR0tLS09PT0tTS1NTU1dXV19fV1tbW19fX2NjY2dnZ2tra29vb 3Nzc3d3d3t7e39/f3uDe3+Dfw//tw///4ODg4eHh4uLi4+Pj4+Tj5uXh5OTk5eXl5ubm5+fn5+3j 6Ojo6enp6urq6+vr7Ozq7Ozs7e3t7u7u7+/v5//s5//t5////+3j///t8PDw8fHx9vb29/f3+Pj1 +vn2+Pj4+fn5+/r4+vr6+/v7///4/Pz8/f39/v7+////AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAbq25pAAAABl0RVh0U29mdHdhcmUAUGFpbnQuTkVU IHYzLjUuODc7gF0AAAKgSURBVFhHzZbpVxJRFMDfo0WhLCraKQK1fc/UaDRpX2yxzcJEDSs3aIXC SmNwEEpJA9QwixYVW4Rg3v/XuyPpcDqnbwzzmw9z7psz5/3m3nfnPfRe5qDQYMDv7+/3SU+/mNf+ DAKDoaERAcR1PbPb7+SAuy0tc7O2trbbxTzt4gLBMICu7V67Wn5s2HXV7QuGKEh78KFbfjyo1p73 BIIUdHosTuRHPFq983nvAAW9k5+dYPRBe6/nLQUlIfpYVqwoLhsTuar+RYIvibKWCos7CjOldFfc 0OYIgtGtGNgyOueQE8FwHQPUhcFDd7nblxbkS7HByBn1uDS3ghMzfozRDDnUXXrZS3/OkMFUIa6Y nJqswoWpWUP18BJxEiHMeolZI0M4hiMMw4LgxU7O6/WCYFKBIwmSiGBFIqeCFoba0YthLJmCcQOu pSO12BB3zgNchJwi5Jz6K/l9TLWckG9LIcx6BitoeQU/pgoEL7h6OI6DDCb246L6WH0R3psgLurn pGO0pgVvNCr18LIvGtUJjSQl/ptB40wGDzlZj8cjrEHfZqGL8cIJQpyCHwjSBBIyvrJvXKOiohKs QTeTsQbLHW6WZYXfzE9un16h37MA54OhUEoQTPdJAVWURDCa7mLGTDWIrtz2iu7BIMinpj4NDQxF PHkoP8rPoP68YnHfGaVSqT6rXHTyKA2V6SdZvIXNRsAc4kHwuAPOCGga8sWnkolkMubNmz+S9Vb4 3wTCTsIKO8n0muu2bgq6P/cCH/N6foG8HHi8/ZbjBQVtfPR91oePy8Xvx5NNJVanIFiyY53ovLpK JmfX9dsONHS4Oimo8WaNyXQ4B1SK56ysPGISU3Ojoc3hAlBHe3NTk9XaKD1WMbebMmhu63A4BZBN 5vwBj0rWi3+d3vcAAAAASUVORK5CYII= 98372 2011-06-23 10:55:57 -0700 2011-06-23 10:55:57 -0700 testcase find-banner-search-field.html text/html 289 aroben PCFET0NUWVBFIEhUTUw+CjxodG1sPgo8aGVhZD4KICAgIDxzdHlsZT4KCiAgICBpbnB1dCB7CiAg ICAgICAgLXdlYmtpdC1hcHBlYXJhbmNlOiBub25lOwogICAgICAgIGhlaWdodDogMjRweDsKICAg ICAgICBib3JkZXItd2lkdGg6IDdweCA3cHggN3B4IDI2cHg7CiAgICAgICAgYm9yZGVyLXN0eWxl OiBzb2xpZDsKICAgICAgICBmb250LXNpemU6IDExcHg7CiAgICB9CiAgICA8L3N0eWxlPgo8L2hl YWQ+Cjxib2R5PgogICAgPGlucHV0IHR5cGU9c2VhcmNoIHZhbHVlPWZvbz4KPC9ib2R5Pgo8L2h0 bWw+Cg==