63149 2011-06-22 09:40:30 -0700 [UNIX] Check for npp directly when getting X display in NetscapeBrowserFuncs 2011-06-22 23:44:52 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk, Qt P2 Normal --- 1 cgarcia webkit-unassigned oldest_to_newest 425308 0 cgarcia 2011-06-22 09:40:30 -0700 NetscapePlugin::fromNPP() shouldn't be called with a null npp, it contains an assert that make it crash when building with debug enabled. 425309 1 98186 cgarcia 2011-06-22 09:42:34 -0700 Created attachment 98186 Patch 425979 2 cgarcia 2011-06-22 23:44:52 -0700 Committed r89537: <http://trac.webkit.org/changeset/89537> 98186 2011-06-22 09:42:34 -0700 2011-06-22 10:20:22 -0700 Patch wk2-crash-npp.diff text/plain 1606 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAxOWE2ZjUxLi5jZjdlNzA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTgg QEAKIDIwMTEtMDYtMjIgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtVTklY XSBDaGVjayBmb3IgbnBwIGRpcmVjdGx5IHdoZW4gZ2V0dGluZyBYIGRpc3BsYXkgaW4gTmV0c2Nh cGVCcm93c2VyRnVuY3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTYzMTQ5CisKKyAgICAgICAgTmV0c2NhcGVQbHVnaW46OmZyb21OUFAoKSBzaG91bGRu J3QgYmUgY2FsbGVkIHdpdGggYSBudWxsIG5wcCwgaXQKKyAgICAgICAgY29udGFpbnMgYW4gYXNz ZXJ0IHRoYXQgbWFrZSBpdCBjcmFzaCB3aGVuIGJ1aWxkaW5nIHdpdGggZGVidWcgZW5hYmxlZC4K KworICAgICAgICAqIFdlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZUJyb3dzZXJG dW5jcy5jcHA6CisgICAgICAgIChXZWJLaXQ6Ok5QTl9HZXRWYWx1ZSk6CisKKzIwMTEtMDYtMjIg IENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCiAgICAgICAgIFJl dmlld2VkIGJ5IE1hcnRpbiBSb2JpbnNvbi4KIAogICAgICAgICBbR1RLXSBSZW1vdmUgQ29ubmVj dGlvbjo6c2V0U2hvdWxkQ2xvc2VDb25uZWN0aW9uT25Qcm9jZXNzVGVybWluYXRpb24oKQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL05ldHNj YXBlQnJvd3NlckZ1bmNzLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9O ZXRzY2FwZS9OZXRzY2FwZUJyb3dzZXJGdW5jcy5jcHAKaW5kZXggMWU4MWZlMy4uM2UwYjhlZSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL05l dHNjYXBlQnJvd3NlckZ1bmNzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1Bs dWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVCcm93c2VyRnVuY3MuY3BwCkBAIC01MDQsOCArNTA0LDcg QEAgc3RhdGljIE5QRXJyb3IgTlBOX0dldFZhbHVlKE5QUCBucHAsIE5QTlZhcmlhYmxlIHZhcmlh YmxlLCB2b2lkICp2YWx1ZSkKICAgICAgICAgICAgYnJlYWs7CiAjZWxpZiBQTFVHSU5fQVJDSElU RUNUVVJFKFgxMSkKICAgICAgICBjYXNlIE5QTlZ4RGlzcGxheTogewotICAgICAgICAgICBSZWZQ dHI8TmV0c2NhcGVQbHVnaW4+IHBsdWdpbiA9IE5ldHNjYXBlUGx1Z2luOjpmcm9tTlBQKG5wcCk7 Ci0gICAgICAgICAgIGlmICghcGx1Z2luKQorICAgICAgICAgICBpZiAoIW5wcCkKICAgICAgICAg ICAgICAgIHJldHVybiBOUEVSUl9HRU5FUklDX0VSUk9SOwogI2lmIFBMQVRGT1JNKFFUKQogICAg ICAgICAgICAqcmVpbnRlcnByZXRfY2FzdDxEaXNwbGF5Kio+KHZhbHVlKSA9IFFYMTFJbmZvOjpk aXNwbGF5KCk7Cg==