63146 2011-06-22 09:14:39 -0700 Web Inspector: Restore console messages when restoring inspector state 2011-06-22 12:27:02 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 sreeram webkit-unassigned apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 425281 0 sreeram 2011-06-22 09:14:39 -0700 When inspector state needs to be restored (e.g.: when the inspected tab is swapped), console messages are not restored. They should be. For reference, other panels (Elements, Resources, etc) are correctly restored. 425285 1 98182 sreeram 2011-06-22 09:17:37 -0700 Created attachment 98182 Patch 425290 2 98182 pfeldman 2011-06-22 09:22:32 -0700 Comment on attachment 98182 Patch We will lose the expiredCount information in this case, so we'll need to fix it further. But this is an incremental improvement, so r+. 425293 3 98182 webkit.review.bot 2011-06-22 09:25:06 -0700 Comment on attachment 98182 Patch Rejecting attachment 98182 from commit-queue. sreeram@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 425461 4 98182 webkit.review.bot 2011-06-22 12:26:58 -0700 Comment on attachment 98182 Patch Clearing flags on attachment: 98182 Committed r89456: <http://trac.webkit.org/changeset/89456> 425462 5 webkit.review.bot 2011-06-22 12:27:02 -0700 All reviewed patches have been landed. Closing bug. 98182 2011-06-22 09:17:37 -0700 2011-06-22 12:26:58 -0700 Patch bug-63146-20110622091736.patch text/plain 2838 sreeram U3VidmVyc2lvbiBSZXZpc2lvbjogODk0MzMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA3MzJjMWQwNGM2ZDRlNWVm ZTA5NGNiZDA3ZmMwYjBiZjFkMThhMjkxLi5jN2ZiNTliN2MyZjk0N2FhZTkwNGQyYmJiN2I3ODY1 N2JkNWRiODI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDYtMjIgIFNyZWVy YW0gUmFtYWNoYW5kcmFuICA8c3JlZXJhbUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVzdG9yZSBj b25zb2xlIG1lc3NhZ2VzIHdoZW4gcmVzdG9yaW5nIGluc3BlY3RvciBzdGF0ZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjMxNDYKKworICAgICAgICBO byBuZXcgdGVzdHMgKG5vIGNoYW5nZSBpbiBmdW5jdGlvbmFsaXR5LCBvbmx5IGluIGRpc3BsYXkp LgorCisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvckNvbnNvbGVBZ2VudC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpJbnNwZWN0b3JDb25zb2xlQWdlbnQ6OnJlc3RvcmUpOgorICAgICAgICAq IGluc3BlY3Rvci9JbnNwZWN0b3JDb25zb2xlQWdlbnQuaDoKKyAgICAgICAgKiBpbnNwZWN0b3Iv SW5zcGVjdG9yQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JDb250 cm9sbGVyOjpyZXN0b3JlSW5zcGVjdG9yU3RhdGVGcm9tQ29va2llKToKKwogMjAxMS0wNi0yMiAg RGlyayBTY2h1bHplICA8a3JpdEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5p a29sYXMgWmltbWVybWFubi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9J bnNwZWN0b3JDb25zb2xlQWdlbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3Bl Y3RvckNvbnNvbGVBZ2VudC5jcHAKaW5kZXggMzE4NjAwY2M2NDlkZGY3ZjU1ZWI0YzQ3NDFiNWY1 MDU2MGJlOGMyNy4uNTFjYTQ0Zjk4YTBmZDcyNTE1ZmM4MTAyNGMzMTNhNTE2YWEzMzQzNiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnNvbGVBZ2VudC5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnNvbGVBZ2VudC5j cHAKQEAgLTExNSw2ICsxMTUsMTUgQEAgdm9pZCBJbnNwZWN0b3JDb25zb2xlQWdlbnQ6OnJlc2V0 KCkKICAgICBtX2NvdW50cy5jbGVhcigpOwogfQogCit2b2lkIEluc3BlY3RvckNvbnNvbGVBZ2Vu dDo6cmVzdG9yZSgpCit7CisgICAgaWYgKG1faW5zcGVjdG9yU3RhdGUtPmdldEJvb2xlYW4oQ29u c29sZUFnZW50U3RhdGU6OmNvbnNvbGVNZXNzYWdlc0VuYWJsZWQpKSB7CisgICAgICAgIEVycm9y U3RyaW5nIGVycm9yOworICAgICAgICBpbnQgZXhwaXJlZENvdW50OworICAgICAgICBlbmFibGUo JmVycm9yLCAmZXhwaXJlZENvdW50KTsKKyAgICB9Cit9CisKIHZvaWQgSW5zcGVjdG9yQ29uc29s ZUFnZW50OjpzZXRGcm9udGVuZChJbnNwZWN0b3JGcm9udGVuZCogZnJvbnRlbmQpCiB7CiAgICAg bV9mcm9udGVuZCA9IGZyb250ZW5kLT5jb25zb2xlKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29uc29sZUFnZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvSW5zcGVjdG9yQ29uc29sZUFnZW50LmgKaW5kZXggNzg0YjE5ZDllMjU1YjE2M2Nh YjliMWVlNGI5MDU2Y2E1M2Y4NjEwMy4uY2Q5NjViMWFjYzQ5NmZiYjllMTI2YzliZWY0ZDNkOWM4 NTNhMzI0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNv bnNvbGVBZ2VudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb25z b2xlQWdlbnQuaApAQCAtNjMsNiArNjMsNyBAQCBwdWJsaWM6CiAgICAgdm9pZCBkaXNhYmxlKEVy cm9yU3RyaW5nKik7CiAgICAgdm9pZCBjbGVhckNvbnNvbGVNZXNzYWdlcyhFcnJvclN0cmluZyog ZXJyb3IpOwogICAgIHZvaWQgcmVzZXQoKTsKKyAgICB2b2lkIHJlc3RvcmUoKTsKICAgICB2b2lk IHNldEZyb250ZW5kKEluc3BlY3RvckZyb250ZW5kKik7CiAgICAgdm9pZCBjbGVhckZyb250ZW5k KCk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250 cm9sbGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVy LmNwcAppbmRleCAzYTM4YmNlZWRjNTQ0OGYyMWI0NDUwMzlmNWNiYTM1YTQyN2NlMDU4Li5mYjI2 NWQ1OTk3NzFiZjg0ZDI3N2JkMDQ1MTAzYmY0NDM4OWM5YjcyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xsZXIuY3BwCkBAIC0zMzIsNiArMzMyLDcg QEAgdm9pZCBJbnNwZWN0b3JDb250cm9sbGVyOjpyZXN0b3JlSW5zcGVjdG9yU3RhdGVGcm9tQ29v a2llKGNvbnN0IFN0cmluZyYgaW5zcGVjdG8KICAgICBtX2RvbUFnZW50LT5yZXN0b3JlKCk7CiAg ICAgbV9yZXNvdXJjZUFnZW50LT5yZXN0b3JlKCk7CiAgICAgbV90aW1lbGluZUFnZW50LT5yZXN0 b3JlKCk7CisgICAgbV9jb25zb2xlQWdlbnQtPnJlc3RvcmUoKTsKICNpZiBFTkFCTEUoREFUQUJB U0UpCiAgICAgbV9kYXRhYmFzZUFnZW50LT5yZXN0b3JlKCk7CiAjZW5kaWYK