63144 2011-06-22 08:41:06 -0700 Send keypress events to windowless plugins on the windows port. 2011-06-27 19:36:29 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 noel.gordon noel.gordon andersca aroben tony webkit.review.bot oldest_to_newest 425264 0 noel.gordon 2011-06-22 08:41:06 -0700 Map keypress to WM_CHAR in NPEvent.event. 425269 1 98177 noel.gordon 2011-06-22 08:55:08 -0700 Created attachment 98177 Patch 425270 2 noel.gordon 2011-06-22 08:56:17 -0700 Before and _after_ my change: % ./Tools/Scripts/run-webkit-tests --debug LayoutTests/plugins/*.html Testing 82 test cases. plugins/application-plugin-plugins-disabled.html -> failed plugins/destroy-during-npp-new.html -> crashed plugins/embed-attributes-style.html -> failed plugins/get-url-with-blank-target.html -> failed plugins/keyboard-events.html -> failed plugins/netscape-dom-access.html -> failed plugins/plugin-initiate-popup-window.html -> failed plugins/plugin-javascript-access.html -> failed plugins/windowless_plugin_paint_test.html -> failed stderr 73 test cases (89%) succeeded 8 test cases (9%) had incorrect layout 1 test case (1%) crashed 1 test case (1%) had stderr output 425271 3 noel.gordon 2011-06-22 08:58:02 -0700 plugins/keyboard-events.html will be fixed on bug 62375. 425464 4 98177 aroben 2011-06-22 12:33:49 -0700 Comment on attachment 98177 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98177&action=review > Source/WebCore/ChangeLog:9 > + No new tests. Covered by existing tests, plugins/mouse-events.html and > + plugins/keyboard-events.html. Both are semi-broken on the win port due Does plugins/mouse-events.html really cover this change? If this change affects keyboard-events.html, why don't you need to update the expected results? 425919 5 noel.gordon 2011-06-22 20:12:07 -0700 > Does plugins/mouse-events.html really cover this change? I did change handleMouseEvent(), and mouse-events.html depends on that code. > If this change affects keyboard-events.html, why don't you need to update the expected results? The result of keyboard-events.html did not change. 426116 6 aroben 2011-06-23 06:30:20 -0700 (In reply to comment #5) > > Does plugins/mouse-events.html really cover this change? > > I did change handleMouseEvent(), and mouse-events.html depends on that code. OK. It is confusing to have that change included in this bug, which is supposedly just about keypress events. It would be clearer to do it separately. > > If this change affects keyboard-events.html, why don't you need to update the expected results? > > The result of keyboard-events.html did not change. I see, because logging isn't implemented on Windows yet. You should mention that in the ChangeLog. Otherwise it is confusing to have a change that's covered by a test but doesn't affect that test's output. 426204 7 noel.gordon 2011-06-23 08:43:00 -0700 (In reply to comment #6) > > > > I did change handleMouseEvent(), and mouse-events.html depends on that code. > > OK. It is confusing to have that change included in this bug, which is supposedly just about keypress events. It would be clearer to do it separately. > Maybe. It's an "ASSERT(m_plugin && !m_isWindowed)" added to handleMouseEvent() and also to handleKeyboardEvent(), 1) for symmetry and 2) to make the code clearer to me. This code feels so three-weeks ago, and that ASSERT reminded me ... "oh right, windowless plugins". Helped me, and hope it helps others, understand the preconditions needed by these routines, since that was entirely unclear to me from reading the code, prior to making my change. > > > > The result of keyboard-events.html did not change. > > I see, because logging isn't implemented on Windows yet. You should mention that in the ChangeLog. Otherwise it is confusing to have a change that's covered by a test but doesn't affect that test's output. But logging is implemented on win; I fixed that in bug 61721. I too was also confused about not having to update the expectations. Tracked it down - bug 33973 - seems Jessie noticed my plugin logging fix and updated the expectations already :) 426222 8 aroben 2011-06-23 09:09:44 -0700 OK. I at least think you should explain things more clearly in the ChangeLog. 427928 9 noel.gordon 2011-06-27 07:47:04 -0700 (In reply to comment #8) > OK. I at least think you should explain things more clearly in the ChangeLog. OK, let's try that then. 427929 10 98724 noel.gordon 2011-06-27 07:47:27 -0700 Created attachment 98724 Patch 427934 11 98724 aroben 2011-06-27 07:56:07 -0700 Comment on attachment 98724 Patch Does WebKit2 need this fix as well? 427961 12 98724 webkit.review.bot 2011-06-27 08:37:30 -0700 Comment on attachment 98724 Patch Clearing flags on attachment: 98724 Committed r89823: <http://trac.webkit.org/changeset/89823> 427962 13 webkit.review.bot 2011-06-27 08:37:36 -0700 All reviewed patches have been landed. Closing bug. 428572 14 noel.gordon 2011-06-27 19:36:29 -0700 > Does WebKit2 need this fix as well? Eventually. NetscapePlugin::platformHandleKeyboardEvent() is currently notImplemented() on the windows port. 98177 2011-06-22 08:55:08 -0700 2011-06-27 07:47:27 -0700 Patch plugin-win-wm-char.git.diff text/plain 3123 noel.gordon ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzMDFjMDU1Li4xZWIwNTY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTEtMDYtMjIgIE5vZWwgR29yZG9uICA8bm9lbC5nb3Jkb25AZ21haWwuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNlbmQga2V5cHJl c3MgZXZlbnRzIHRvIHdpbmRvd2xlc3MgcGx1Z2lucyBvbiB0aGUgd2luZG93cyBwb3J0LgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjMxNDQKKworICAg ICAgICBObyBuZXcgdGVzdHMuICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLCBwbHVnaW5zL21v dXNlLWV2ZW50cy5odG1sIGFuZAorICAgICAgICBwbHVnaW5zL2tleWJvYXJkLWV2ZW50cy5odG1s LiAgQm90aCBhcmUgc2VtaS1icm9rZW4gb24gdGhlIHdpbiBwb3J0IGR1ZQorICAgICAgICB0byBs YWNrIG9mIGZvY3VzIGV2ZW50IGZvd2FyZGluZyB0byB3aW5kb3dlZCBwbHVnaW5zIG9uIHdlYmtp dCB3aW4uICBTZWUKKyAgICAgICAgYnVnIDYyMzc1IGZvciB0aGUgZm9jdXMgZm93YXJkaW5nIGZp eC4KKworICAgICAgICAqIHBsdWdpbnMvd2luL1BsdWdpblZpZXdXaW4uY3BwOgorICAgICAgICAo V2ViQ29yZTo6UGx1Z2luVmlldzo6aGFuZGxlS2V5Ym9hcmRFdmVudCk6ICBEb24ndCBzZW5kIHJh bmRvbSBrZXlib2FyZAorICAgICAgICBldmVudHMgdG8gdGhlIHBsdWdpbiAobnBFdmVudC5ldmVu dCB3YXMgYmVpbmcgdXNlZCB1bmluaXRpYWxpemVkKS4KKyAgICAgICAgKFdlYkNvcmU6OlBsdWdp blZpZXc6OmhhbmRsZU1vdXNlRXZlbnQpOiAgRklYTUUuCisKIDIwMTEtMDYtMTcgIFBhdmVsIFBv ZGl2aWxvdiAgPHBvZGl2aWxvdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg WXVyeSBTZW1pa2hhdHNreS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvd2lu L1BsdWdpblZpZXdXaW4uY3BwIGIvU291cmNlL1dlYkNvcmUvcGx1Z2lucy93aW4vUGx1Z2luVmll d1dpbi5jcHAKaW5kZXggODNjNDk2Ni4uZmU1YjFjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGx1Z2lucy93aW4vUGx1Z2luVmlld1dpbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGx1 Z2lucy93aW4vUGx1Z2luVmlld1dpbi5jcHAKQEAgLTYzOSwxNyArNjM5LDIzIEBAIHZvaWQgUGx1 Z2luVmlldzo6cGFpbnQoR3JhcGhpY3NDb250ZXh0KiBjb250ZXh0LCBjb25zdCBJbnRSZWN0JiBy ZWN0KQogCiB2b2lkIFBsdWdpblZpZXc6OmhhbmRsZUtleWJvYXJkRXZlbnQoS2V5Ym9hcmRFdmVu dCogZXZlbnQpCiB7CisgICAgQVNTRVJUKG1fcGx1Z2luICYmICFtX2lzV2luZG93ZWQpOworCiAg ICAgTlBFdmVudCBucEV2ZW50OwogCi0gICAgbnBFdmVudC53UGFyYW0gPSBldmVudC0+a2V5Q29k ZSgpOyAgICAKKyAgICBucEV2ZW50LndQYXJhbSA9IGV2ZW50LT5rZXlDb2RlKCk7CiAKICAgICBp ZiAoZXZlbnQtPnR5cGUoKSA9PSBldmVudE5hbWVzKCkua2V5ZG93bkV2ZW50KSB7CiAgICAgICAg IG5wRXZlbnQuZXZlbnQgPSBXTV9LRVlET1dOOwogICAgICAgICBucEV2ZW50LmxQYXJhbSA9IDA7 CisgICAgfSBlbHNlIGlmIChldmVudC0+dHlwZSgpID09IGV2ZW50TmFtZXMoKS5rZXlwcmVzc0V2 ZW50KSB7CisgICAgICAgIG5wRXZlbnQuZXZlbnQgPSBXTV9DSEFSOworICAgICAgICBucEV2ZW50 LmxQYXJhbSA9IDA7CiAgICAgfSBlbHNlIGlmIChldmVudC0+dHlwZSgpID09IGV2ZW50TmFtZXMo KS5rZXl1cEV2ZW50KSB7CiAgICAgICAgIG5wRXZlbnQuZXZlbnQgPSBXTV9LRVlVUDsKICAgICAg ICAgbnBFdmVudC5sUGFyYW0gPSAweDgwMDA7Ci0gICAgfQorICAgIH0gZWxzZQorICAgICAgICBy ZXR1cm47CiAKICAgICBKU0M6OkpTTG9jazo6RHJvcEFsbExvY2tzIGRyb3BBbGxMb2NrcyhKU0M6 OlNpbGVuY2VBc3NlcnRpb25zT25seSk7CiAgICAgaWYgKCFkaXNwYXRjaE5QRXZlbnQobnBFdmVu dCkpCkBAIC02NjIsNiArNjY4LDggQEAgZXh0ZXJuIGJvb2wgaWdub3JlTmV4dFNldEN1cnNvcjsK IAogdm9pZCBQbHVnaW5WaWV3OjpoYW5kbGVNb3VzZUV2ZW50KE1vdXNlRXZlbnQqIGV2ZW50KQog eworICAgIEFTU0VSVChtX3BsdWdpbiAmJiAhbV9pc1dpbmRvd2VkKTsKKwogICAgIE5QRXZlbnQg bnBFdmVudDsKIAogICAgIEludFBvaW50IHAgPSBzdGF0aWNfY2FzdDxGcmFtZVZpZXcqPihwYXJl bnQoKSktPmNvbnRlbnRzVG9XaW5kb3coSW50UG9pbnQoZXZlbnQtPnBhZ2VYKCksIGV2ZW50LT5w YWdlWSgpKSk7CkBAIC03MjAsNiArNzI4LDcgQEAgdm9pZCBQbHVnaW5WaWV3OjpoYW5kbGVNb3Vz ZUV2ZW50KE1vdXNlRXZlbnQqIGV2ZW50KQogICAgICAgICByZXR1cm47CiAKICAgICBKU0M6OkpT TG9jazo6RHJvcEFsbExvY2tzIGRyb3BBbGxMb2NrcyhKU0M6OlNpbGVuY2VBc3NlcnRpb25zT25s eSk7CisgICAgLy8gRklYTUU6IENvbnNpZGVyIGJhY2sgcG9ydGluZyB0aGUgaHR0cDovL3dlYmtp dC5vcmcvYi81ODEwOCBmaXggaGVyZS4KICAgICBpZiAoIWRpc3BhdGNoTlBFdmVudChucEV2ZW50 KSkKICAgICAgICAgZXZlbnQtPnNldERlZmF1bHRIYW5kbGVkKCk7CiAKQEAgLTcyOCw3ICs3Mzcs NyBAQCB2b2lkIFBsdWdpblZpZXc6OmhhbmRsZU1vdXNlRXZlbnQoTW91c2VFdmVudCogZXZlbnQp CiAgICAgLy8gYW5kIHNpbmNlIHdlIGRvbid0IHdhbnQgdGhhdCB3ZSBzZXQgaWdub3JlTmV4dFNl dEN1cnNvciB0byB0cnVlIGhlcmUgdG8gcHJldmVudCB0aGF0LgogICAgIGlnbm9yZU5leHRTZXRD dXJzb3IgPSB0cnVlOwogICAgIGlmIChQYWdlKiBwYWdlID0gbV9wYXJlbnRGcmFtZS0+cGFnZSgp KQotICAgICAgICBwYWdlLT5jaHJvbWUoKS0+Y2xpZW50KCktPnNldExhc3RTZXRDdXJzb3JUb0N1 cnJlbnRDdXJzb3IoKTsgICAgCisgICAgICAgIHBhZ2UtPmNocm9tZSgpLT5jbGllbnQoKS0+c2V0 TGFzdFNldEN1cnNvclRvQ3VycmVudEN1cnNvcigpOwogI2VuZGlmCiB9CiAK 98724 2011-06-27 07:47:27 -0700 2011-06-27 08:37:30 -0700 Patch plugin-win-wm-char.git.diff text/plain 3550 noel.gordon ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2MDBlZGUwLi5lMDNiM2VkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQg QEAKKzIwMTEtMDYtMjcgIE5vZWwgR29yZG9uICA8bm9lbC5nb3Jkb25AZ21haWwuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNlbmQga2V5cHJl c3MgZXZlbnRzIHRvIHdpbmRvd2xlc3MgcGx1Z2lucyBvbiB0aGUgd2luZG93cyBwb3J0LgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjMxNDQKKworICAg ICAgICBObyBuZXcgdGVzdHMuICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHdpbmRvd2xlc3MgcGx1Z2lu IHRlc3RzIHBsdWdpbnMvbW91c2UtZXZlbnRzLmh0bWwKKyAgICAgICAgYW5kIHBsdWdpbnMva2V5 Ym9hcmQtZXZlbnRzLmh0bWwuICBCb3RoIGFyZSBub3QgeWV0IHdvcmtpbmcgYXMgZGVzaXJlZCBi ZWNhdXNlIGZvY3VzCisgICAgICAgIGV2ZW50cyBhcmUgbm90IGJlaW5nIGZvd2FyZGVkIHRvIHdp bmRvd2VkIHBsdWdpbnMgb24gdGhlIHdpbiBwb3J0IChidWcgNjIzNzUpLiAgVGVzdAorICAgICAg ICBwbHVnaW4gbG9nZ2luZyBvbiB0aGUgd2luIHBvcnQgd2FzIGFkZGVkIGluIGJ1ZyA2MTcyMS4g IE5ldyBmYWlsaW5nIGV4cGVjdGF0aW9ucyBmb3IKKyAgICAgICAgcGx1Z2lucy9rZXlib2FyZC1l dmVudHMuaHRtbCB3ZXJlIHN1YnNlcXVlbnRseSBhZGRlZCBpbiBidWcgMzM5NzMgc28gdGhlcmUn cyBubyBuZWVkCisgICAgICAgIHRvIHVwZGF0ZSB0ZXN0IGV4cGVjdGF0aW9ucyBpbiB0aGlzIHBh dGNoLgorCisgICAgICAgICAqIHBsdWdpbnMvd2luL1BsdWdpblZpZXdXaW4uY3BwOgorICAgICAg ICAoV2ViQ29yZTo6UGx1Z2luVmlldzo6aGFuZGxlS2V5Ym9hcmRFdmVudCk6IEFkZCBhbiBBU1NF UlQobV9wbHVnaW4gJiYgIW1faXNXaW5kb3dlZCkKKyAgICAgICAgdG8gaW5kaWNhdGUgdGhhdCB0 aGUgcm91dGluZSBpcyBmb3Igd2luZG93bGVzcyBwbHVnaW5zLiAgUmVtb3ZlIHRyYWlsaW5nIHdo aXRlc3BhY2UuCisgICAgICAgIEFkZCBoYW5kbGluZyBmb3Iga2V5UHJlc3MgZXZlbnRzIChtYXAg dG8gV01fQ0hBUikuCisgICAgICAgIChXZWJDb3JlOjpQbHVnaW5WaWV3OjpoYW5kbGVNb3VzZUV2 ZW50KTogQWRkIHRoZSBBU1NFUlQgdG8gaW5kaWNhdGUgdGhhdCB0aGUgcm91dGluZQorICAgICAg ICBpcyBmb3Igd2luZG93bGVzcyBwbHVnaW5zLiAgQWRkIEZJWE1FIG5vdGUuICBSZW1vdmUgdHJh aWxpbmcgd2hpdGVzcGFjZS4KKwogMjAxMS0wNi0yNCAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBw bGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZGVycyBDYXJsc3Nvbi4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvd2luL1BsdWdpblZpZXdXaW4uY3BwIGIvU291cmNl L1dlYkNvcmUvcGx1Z2lucy93aW4vUGx1Z2luVmlld1dpbi5jcHAKaW5kZXggZWQ2MTY1MS4uNjI3 YjE4MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGx1Z2lucy93aW4vUGx1Z2luVmlld1dp bi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGx1Z2lucy93aW4vUGx1Z2luVmlld1dpbi5jcHAK QEAgLTYzOSwxNyArNjM5LDIzIEBAIHZvaWQgUGx1Z2luVmlldzo6cGFpbnQoR3JhcGhpY3NDb250 ZXh0KiBjb250ZXh0LCBjb25zdCBJbnRSZWN0JiByZWN0KQogCiB2b2lkIFBsdWdpblZpZXc6Omhh bmRsZUtleWJvYXJkRXZlbnQoS2V5Ym9hcmRFdmVudCogZXZlbnQpCiB7CisgICAgQVNTRVJUKG1f cGx1Z2luICYmICFtX2lzV2luZG93ZWQpOworCiAgICAgTlBFdmVudCBucEV2ZW50OwogCi0gICAg bnBFdmVudC53UGFyYW0gPSBldmVudC0+a2V5Q29kZSgpOyAgICAKKyAgICBucEV2ZW50LndQYXJh bSA9IGV2ZW50LT5rZXlDb2RlKCk7CiAKICAgICBpZiAoZXZlbnQtPnR5cGUoKSA9PSBldmVudE5h bWVzKCkua2V5ZG93bkV2ZW50KSB7CiAgICAgICAgIG5wRXZlbnQuZXZlbnQgPSBXTV9LRVlET1dO OwogICAgICAgICBucEV2ZW50LmxQYXJhbSA9IDA7CisgICAgfSBlbHNlIGlmIChldmVudC0+dHlw ZSgpID09IGV2ZW50TmFtZXMoKS5rZXlwcmVzc0V2ZW50KSB7CisgICAgICAgIG5wRXZlbnQuZXZl bnQgPSBXTV9DSEFSOworICAgICAgICBucEV2ZW50LmxQYXJhbSA9IDA7CiAgICAgfSBlbHNlIGlm IChldmVudC0+dHlwZSgpID09IGV2ZW50TmFtZXMoKS5rZXl1cEV2ZW50KSB7CiAgICAgICAgIG5w RXZlbnQuZXZlbnQgPSBXTV9LRVlVUDsKICAgICAgICAgbnBFdmVudC5sUGFyYW0gPSAweDgwMDA7 Ci0gICAgfQorICAgIH0gZWxzZQorICAgICAgICByZXR1cm47CiAKICAgICBKU0M6OkpTTG9jazo6 RHJvcEFsbExvY2tzIGRyb3BBbGxMb2NrcyhKU0M6OlNpbGVuY2VBc3NlcnRpb25zT25seSk7CiAg ICAgaWYgKGRpc3BhdGNoTlBFdmVudChucEV2ZW50KSkKQEAgLTY2Miw2ICs2NjgsOCBAQCBleHRl cm4gYm9vbCBpZ25vcmVOZXh0U2V0Q3Vyc29yOwogCiB2b2lkIFBsdWdpblZpZXc6OmhhbmRsZU1v dXNlRXZlbnQoTW91c2VFdmVudCogZXZlbnQpCiB7CisgICAgQVNTRVJUKG1fcGx1Z2luICYmICFt X2lzV2luZG93ZWQpOworCiAgICAgTlBFdmVudCBucEV2ZW50OwogCiAgICAgSW50UG9pbnQgcCA9 IHN0YXRpY19jYXN0PEZyYW1lVmlldyo+KHBhcmVudCgpKS0+Y29udGVudHNUb1dpbmRvdyhJbnRQ b2ludChldmVudC0+cGFnZVgoKSwgZXZlbnQtPnBhZ2VZKCkpKTsKQEAgLTcyMCw2ICs3MjgsNyBA QCB2b2lkIFBsdWdpblZpZXc6OmhhbmRsZU1vdXNlRXZlbnQoTW91c2VFdmVudCogZXZlbnQpCiAg ICAgICAgIHJldHVybjsKIAogICAgIEpTQzo6SlNMb2NrOjpEcm9wQWxsTG9ja3MgZHJvcEFsbExv Y2tzKEpTQzo6U2lsZW5jZUFzc2VydGlvbnNPbmx5KTsKKyAgICAvLyBGSVhNRTogQ29uc2lkZXIg YmFjayBwb3J0aW5nIHRoZSBodHRwOi8vd2Via2l0Lm9yZy9iLzU4MTA4IGZpeCBoZXJlLgogICAg IGlmIChkaXNwYXRjaE5QRXZlbnQobnBFdmVudCkpCiAgICAgICAgIGV2ZW50LT5zZXREZWZhdWx0 SGFuZGxlZCgpOwogCkBAIC03MjgsNyArNzM3LDcgQEAgdm9pZCBQbHVnaW5WaWV3OjpoYW5kbGVN b3VzZUV2ZW50KE1vdXNlRXZlbnQqIGV2ZW50KQogICAgIC8vIGFuZCBzaW5jZSB3ZSBkb24ndCB3 YW50IHRoYXQgd2Ugc2V0IGlnbm9yZU5leHRTZXRDdXJzb3IgdG8gdHJ1ZSBoZXJlIHRvIHByZXZl bnQgdGhhdC4KICAgICBpZ25vcmVOZXh0U2V0Q3Vyc29yID0gdHJ1ZTsKICAgICBpZiAoUGFnZSog cGFnZSA9IG1fcGFyZW50RnJhbWUtPnBhZ2UoKSkKLSAgICAgICAgcGFnZS0+Y2hyb21lKCktPmNs aWVudCgpLT5zZXRMYXN0U2V0Q3Vyc29yVG9DdXJyZW50Q3Vyc29yKCk7ICAgIAorICAgICAgICBw YWdlLT5jaHJvbWUoKS0+Y2xpZW50KCktPnNldExhc3RTZXRDdXJzb3JUb0N1cnJlbnRDdXJzb3Io KTsKICNlbmRpZgogfQogCg==