63126 2011-06-22 03:21:10 -0700 Web Inspector: use column numbers when linking to script location in timeline and console. 2011-06-28 09:49:37 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 podivilov podivilov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 425119 0 podivilov 2011-06-22 03:21:10 -0700 Web Inspector: use column numbers when linking to script location in timeline and console. Column number provide more accurate location in pretty-print mode. 425121 1 98149 podivilov 2011-06-22 03:22:56 -0700 Created attachment 98149 Patch. 428931 2 podivilov 2011-06-28 09:49:37 -0700 Committed r89938: <http://trac.webkit.org/changeset/89938> 98149 2011-06-22 03:22:56 -0700 2011-06-27 01:40:11 -0700 Patch. patch text/plain 3920 podivilov ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzMDFjMDU1Li5jODc5MmU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMDYtMjIgIFBhdmVsIFBvZGl2aWxvdiAgPHBvZGl2aWxvdkBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViIElu c3BlY3RvcjogdXNlIGNvbHVtbiBudW1iZXJzIHdoZW4gbGlua2luZyB0byBzY3JpcHQgbG9jYXRp b24gaW4gdGltZWxpbmUgYW5kIGNvbnNvbGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02MzEyNgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVu ZC9Db25zb2xlVmlldy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Db25zb2xlTWVzc2FnZS5w cm90b3R5cGUuX3BvcHVsYXRlU3RhY2tUcmFjZVRyZWVFbGVtZW50KToKKyAgICAgICAgKiBpbnNw ZWN0b3IvZnJvbnQtZW5kL1RpbWVsaW5lUGFuZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3Iu VGltZWxpbmVQYW5lbC5Gb3JtYXR0ZWRSZWNvcmQucHJvdG90eXBlLl9nZXRSZWNvcmREZXRhaWxz KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZVBhbmVsLlBvcHVwQ29udGVudEhlbHBl ci5wcm90b3R5cGUuX2FwcGVuZFN0YWNrVHJhY2UpOgorCiAyMDExLTA2LTE3ICBQYXZlbCBQb2Rp dmlsb3YgIDxwb2Rpdmlsb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFl1 cnkgU2VtaWtoYXRza3kuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL0NvbnNvbGVWaWV3LmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9Db25zb2xlVmlldy5qcwppbmRleCAyZWRiOWM0Li41MTAxYzNlIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGVWaWV3LmpzCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ29uc29sZVZpZXcuanMKQEAgLTk3OSw3ICs5 NzksNyBAQCBXZWJJbnNwZWN0b3IuQ29uc29sZU1lc3NhZ2UucHJvdG90eXBlID0gewogICAgICAg ICAgICAgbWVzc2FnZVRleHRFbGVtZW50LmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZVRleHRO b2RlKGZ1bmN0aW9uTmFtZSkpOwogICAgICAgICAgICAgY29udGVudC5hcHBlbmRDaGlsZChtZXNz YWdlVGV4dEVsZW1lbnQpOwogCi0gICAgICAgICAgICB2YXIgdXJsRWxlbWVudCA9IFdlYkluc3Bl Y3Rvci5saW5raWZ5UmVzb3VyY2VBc05vZGUoZnJhbWUudXJsLCAic2NyaXB0cyIsIGZyYW1lLmxp bmVOdW1iZXIsICJjb25zb2xlLW1lc3NhZ2UtdXJsIik7CisgICAgICAgICAgICB2YXIgdXJsRWxl bWVudCA9IFdlYkluc3BlY3Rvci5saW5raWZ5Q2FsbEZyYW1lQXNOb2RlKGZyYW1lLCAiY29uc29s ZS1tZXNzYWdlLXVybCIpOwogICAgICAgICAgICAgY29udGVudC5hcHBlbmRDaGlsZCh1cmxFbGVt ZW50KTsKIAogICAgICAgICAgICAgdmFyIHRyZWVFbGVtZW50ID0gbmV3IFRyZWVFbGVtZW50KGNv bnRlbnQpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9U aW1lbGluZVBhbmVsLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1l bGluZVBhbmVsLmpzCmluZGV4IDQ4ZTcxNjIuLmU0ZjAxNWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGltZWxpbmVQYW5lbC5qcworKysgYi9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RpbWVsaW5lUGFuZWwuanMKQEAgLTEwMjEsMTAg KzEwMjEsMTAgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lUGFuZWwuRm9ybWF0dGVkUmVjb3JkLnBy b3RvdHlwZSA9IHsKICAgICAgICAgICAgICAgICByZXR1cm4gdGhpcy5kYXRhLndpZHRoICsgIlx1 MjAwOVx1MDBkN1x1MjAwOSIgKyB0aGlzLmRhdGEuaGVpZ2h0OwogICAgICAgICAgICAgY2FzZSBX ZWJJbnNwZWN0b3IuVGltZWxpbmVBZ2VudC5SZWNvcmRUeXBlLlRpbWVySW5zdGFsbDoKICAgICAg ICAgICAgIGNhc2UgV2ViSW5zcGVjdG9yLlRpbWVsaW5lQWdlbnQuUmVjb3JkVHlwZS5UaW1lclJl bW92ZToKLSAgICAgICAgICAgICAgICByZXR1cm4gdGhpcy5zdGFja1RyYWNlID8gV2ViSW5zcGVj dG9yLmxpbmtpZnlSZXNvdXJjZUFzTm9kZSh0aGlzLnN0YWNrVHJhY2VbMF0udXJsLCAic2NyaXB0 cyIsIHRoaXMuc3RhY2tUcmFjZVswXS5saW5lTnVtYmVyLCAiIiwgIiIpIDogdGhpcy5kYXRhLnRp bWVySWQ7CisgICAgICAgICAgICAgICAgcmV0dXJuIHRoaXMuc3RhY2tUcmFjZSA/IFdlYkluc3Bl Y3Rvci5saW5raWZ5Q2FsbEZyYW1lQXNOb2RlKHRoaXMuc3RhY2tUcmFjZVswXSwgIiIpIDogdGhp cy5kYXRhLnRpbWVySWQ7CiAgICAgICAgICAgICBjYXNlIFdlYkluc3BlY3Rvci5UaW1lbGluZUFn ZW50LlJlY29yZFR5cGUuUGFyc2VIVE1MOgogICAgICAgICAgICAgY2FzZSBXZWJJbnNwZWN0b3Iu VGltZWxpbmVBZ2VudC5SZWNvcmRUeXBlLlJlY2FsY3VsYXRlU3R5bGVzOgotICAgICAgICAgICAg ICAgIHJldHVybiB0aGlzLnN0YWNrVHJhY2UgPyBXZWJJbnNwZWN0b3IubGlua2lmeVJlc291cmNl QXNOb2RlKHRoaXMuc3RhY2tUcmFjZVswXS51cmwsICJzY3JpcHRzIiwgdGhpcy5zdGFja1RyYWNl WzBdLmxpbmVOdW1iZXIsICIiLCAiIikgOiBudWxsOworICAgICAgICAgICAgICAgIHJldHVybiB0 aGlzLnN0YWNrVHJhY2UgPyBXZWJJbnNwZWN0b3IubGlua2lmeUNhbGxGcmFtZUFzTm9kZSh0aGlz LnN0YWNrVHJhY2VbMF0sICIiKSA6IG51bGw7CiAgICAgICAgICAgICBjYXNlIFdlYkluc3BlY3Rv ci5UaW1lbGluZUFnZW50LlJlY29yZFR5cGUuRXZhbHVhdGVTY3JpcHQ6CiAgICAgICAgICAgICAg ICAgcmV0dXJuIHRoaXMudXJsID8gV2ViSW5zcGVjdG9yLmxpbmtpZnlSZXNvdXJjZUFzTm9kZSh0 aGlzLnVybCwgInNjcmlwdHMiLCB0aGlzLmRhdGEubGluZU51bWJlciwgIiIsICIiKSA6IG51bGw7 CiAgICAgICAgICAgICBjYXNlIFdlYkluc3BlY3Rvci5UaW1lbGluZUFnZW50LlJlY29yZFR5cGUu WEhSUmVhZHlTdGF0ZUNoYW5nZToKQEAgLTExMjQsNyArMTEyNCw3IEBAIFdlYkluc3BlY3Rvci5U aW1lbGluZVBhbmVsLlBvcHVwQ29udGVudEhlbHBlci5wcm90b3R5cGUgPSB7CiAgICAgICAgICAg ICByb3cuYXBwZW5kQ2hpbGQodGhpcy5fY3JlYXRlQ2VsbChzdGFja0ZyYW1lLmZ1bmN0aW9uTmFt ZSA/IHN0YWNrRnJhbWUuZnVuY3Rpb25OYW1lIDogV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCIoYW5v bnltb3VzIGZ1bmN0aW9uKSIpLCAidGltZWxpbmUtZnVuY3Rpb24tbmFtZSIpKTsKICAgICAgICAg ICAgIHJvdy5hcHBlbmRDaGlsZCh0aGlzLl9jcmVhdGVDZWxsKCIgQCAiKSk7CiAgICAgICAgICAg ICB2YXIgbGlua0NlbGwgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJ0ZCIpOwotICAgICAgICAg ICAgbGlua0NlbGwuYXBwZW5kQ2hpbGQoV2ViSW5zcGVjdG9yLmxpbmtpZnlSZXNvdXJjZUFzTm9k ZShzdGFja0ZyYW1lLnVybCwgInNjcmlwdHMiLCBzdGFja0ZyYW1lLmxpbmVOdW1iZXIsICJ0aW1l bGluZS1kZXRhaWxzIikpOworICAgICAgICAgICAgbGlua0NlbGwuYXBwZW5kQ2hpbGQoV2ViSW5z cGVjdG9yLmxpbmtpZnlDYWxsRnJhbWVBc05vZGUoc3RhY2tGcmFtZSwgInRpbWVsaW5lLWRldGFp bHMiKSk7CiAgICAgICAgICAgICByb3cuYXBwZW5kQ2hpbGQobGlua0NlbGwpOwogICAgICAgICAg ICAgZnJhbWVzVGFibGUuYXBwZW5kQ2hpbGQocm93KTsKICAgICAgICAgfQo=