63114 2011-06-21 20:25:10 -0700 IndexedDB createIndex should NOT throw if name arg is null 2011-06-22 14:23:33 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 pilgrim webkit-unassigned abarth dgrogan fishd hans webkit.review.bot oldest_to_newest 424985 0 pilgrim 2011-06-21 20:25:10 -0700 Calling objectStore.createIndex(null, null) should behave identically to calling createIndex("null", "null"). I have double-checked this (highly unintuitive) behavior with the author of the WebIDL spec and he confirms it ( http://krijnhoetmer.nl/irc-logs/whatwg/20110622#l-187 ). There was also apparently a WebIDL spec bug recently asking to change this behavior, but it was WONTFIXED ( http://www.w3.org/Bugs/Public/show_bug.cgi?id=12798 ). End result: null values for DOMString arguments get stringified to the four-character string "null". This affects several functions in WebKit's IndexedDB implementation. I am filing separate bugs for each of them. (See also bug 63110, for instance.) Patch attached. 424987 1 98111 pilgrim 2011-06-21 20:26:56 -0700 Created attachment 98111 Patch 425586 2 98111 webkit.review.bot 2011-06-22 14:23:28 -0700 Comment on attachment 98111 Patch Clearing flags on attachment: 98111 Committed r89479: <http://trac.webkit.org/changeset/89479> 425587 3 webkit.review.bot 2011-06-22 14:23:33 -0700 All reviewed patches have been landed. Closing bug. 98111 2011-06-21 20:26:56 -0700 2011-06-22 14:23:28 -0700 Patch bug-63114-20110621232659.patch text/plain 3809 pilgrim SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg5NDAzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDYtMjEgIE1hcmsgUGls Z3JpbSAgPHBpbGdyaW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEluZGV4ZWREQiBjcmVhdGVJbmRleCBzaG91bGQgTk9UIHRo cm93IGlmIG5hbWUgYXJnIGlzIG51bGwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTYzMTE0CisKKyAgICAgICAgKiBzdG9yYWdlL0lEQk9iamVjdFN0b3Jl LmlkbDogcmVtb3ZlIENvbnZlcnROdWxsVG9OdWxsU3RyaW5nIGZsYWcKKyAgICAgICAgc28gbnVs bCB2YWx1ZXMgd2lsbCBiZSBzdHJpbmdpZmllZCBhcyAibnVsbCIsIGFzIHBlciBXZWJJREwgc3Bl Yy4KKwogMjAxMS0wNi0yMSAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgW01hY10gU29ydCBYY29kZSBwcm9qZWN0IGZpbGVzLgpJbmRleDogU291cmNlL1dlYkNv cmUvc3RvcmFnZS9JREJPYmplY3RTdG9yZS5pZGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvc3RvcmFnZS9JREJPYmplY3RTdG9yZS5pZGwJKHJldmlzaW9uIDg5Mzk3KQorKysgU291cmNl L1dlYkNvcmUvc3RvcmFnZS9JREJPYmplY3RTdG9yZS5pZGwJKHdvcmtpbmcgY29weSkKQEAgLTQ0 LDcgKzQ0LDcgQEAgbW9kdWxlIHN0b3JhZ2UgewogICAgICAgICAgICAgcmFpc2VzIChJREJEYXRh YmFzZUV4Y2VwdGlvbik7CiAgICAgICAgIFtDYWxsV2l0aD1TY3JpcHRFeGVjdXRpb25Db250ZXh0 XSBJREJSZXF1ZXN0IG9wZW5DdXJzb3IoaW4gW09wdGlvbmFsXSBJREJLZXlSYW5nZSByYW5nZSwg aW4gW09wdGlvbmFsXSB1bnNpZ25lZCBzaG9ydCBkaXJlY3Rpb24pCiAgICAgICAgICAgICByYWlz ZXMgKElEQkRhdGFiYXNlRXhjZXB0aW9uKTsKLSAgICAgICAgSURCSW5kZXggY3JlYXRlSW5kZXgo aW4gW0NvbnZlcnROdWxsVG9OdWxsU3RyaW5nXSBET01TdHJpbmcgbmFtZSwgaW4gW0NvbnZlcnRO dWxsVG9OdWxsU3RyaW5nXSBET01TdHJpbmcga2V5UGF0aCwgaW4gW09wdGlvbmFsXSBPcHRpb25z T2JqZWN0IG9wdGlvbnMpCisgICAgICAgIElEQkluZGV4IGNyZWF0ZUluZGV4KGluIERPTVN0cmlu ZyBuYW1lLCBpbiBET01TdHJpbmcga2V5UGF0aCwgaW4gW09wdGlvbmFsXSBPcHRpb25zT2JqZWN0 IG9wdGlvbnMpCiAgICAgICAgICAgICByYWlzZXMgKElEQkRhdGFiYXNlRXhjZXB0aW9uKTsKICAg ICAgICAgSURCSW5kZXggaW5kZXgoaW4gRE9NU3RyaW5nIG5hbWUpCiAgICAgICAgICAgICByYWlz ZXMgKElEQkRhdGFiYXNlRXhjZXB0aW9uKTsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDg5NDAzKQorKysg TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIw MTEtMDYtMjEgIE1hcmsgUGlsZ3JpbSAgPHBpbGdyaW1AY2hyb21pdW0ub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluZGV4ZWREQiBjcmVhdGVJ bmRleCBzaG91bGQgTk9UIHRocm93IGlmIG5hbWUgYXJnIGlzIG51bGwKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYzMTE0CisKKyAgICAgICAgKiBzdG9y YWdlL2luZGV4ZWRkYi9tb3ppbGxhL2NyZWF0ZS1pbmRleC1udWxsLW5hbWUtZXhwZWN0ZWQudHh0 OgorICAgICAgICAqIHN0b3JhZ2UvaW5kZXhlZGRiL21vemlsbGEvY3JlYXRlLWluZGV4LW51bGwt bmFtZS5odG1sOgorCiAyMDExLTA2LTIxICBNYXR0aGV3IERlbGFuZXkgIDxtZGVsYW5leUBhcHBs ZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gRnJhc2VyLgpJbmRleDogTGF5b3V0 VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvbW96aWxsYS9jcmVhdGUtaW5kZXgtbnVsbC1uYW1lLWV4 cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9t b3ppbGxhL2NyZWF0ZS1pbmRleC1udWxsLW5hbWUtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiA4OTM5 NykKKysrIExheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL21vemlsbGEvY3JlYXRlLWluZGV4 LW51bGwtbmFtZS1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTEyLDkgKzEyLDkgQEAg ZGIgPSBldmVudC50YXJnZXQucmVzdWx0CiByZXF1ZXN0ID0gZGIuc2V0VmVyc2lvbignMScpCiBE ZWxldGVkIGFsbCBvYmplY3Qgc3RvcmVzLgogb2JqZWN0U3RvcmUgPSBkYi5jcmVhdGVPYmplY3RT dG9yZSgnYScsIHsga2V5UGF0aDogJ2lkJywgYXV0b0luY3JlbWVudDogdHJ1ZSB9KTsKLUV4cGVj dGluZyBleGNlcHRpb24gZnJvbSBpbmRleCA9IG9iamVjdFN0b3JlLmNyZWF0ZUluZGV4KG51bGws IG51bGwpOwotUEFTUyBFeGNlcHRpb24gd2FzIHRocm93bi4KLVBBU1MgY29kZSBpcyBJREJEYXRh YmFzZUV4Y2VwdGlvbi5OT05fVFJBTlNJRU5UX0VSUgoraW5kZXggPSBvYmplY3RTdG9yZS5jcmVh dGVJbmRleChudWxsLCBudWxsKTsKK1BBU1MgaW5kZXgubmFtZSBpcyAnbnVsbCcKK1BBU1MgaW5k ZXgua2V5UGF0aCBpcyAnbnVsbCcKIFBBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKIAog VEVTVCBDT01QTEVURQpJbmRleDogTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvbW96aWxs YS9jcmVhdGUtaW5kZXgtbnVsbC1uYW1lLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv c3RvcmFnZS9pbmRleGVkZGIvbW96aWxsYS9jcmVhdGUtaW5kZXgtbnVsbC1uYW1lLmh0bWwJKHJl dmlzaW9uIDg5Mzk3KQorKysgTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvbW96aWxsYS9j cmVhdGUtaW5kZXgtbnVsbC1uYW1lLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTUwLDcgKzUwLDkg QEAgZnVuY3Rpb24gY2xlYW5EYXRhYmFzZSgpCiAKICAgICBvYmplY3RTdG9yZSA9IGV2YWxBbmRM b2coIm9iamVjdFN0b3JlID0gZGIuY3JlYXRlT2JqZWN0U3RvcmUoJ2EnLCB7IGtleVBhdGg6ICdp ZCcsIGF1dG9JbmNyZW1lbnQ6IHRydWUgfSk7Iik7CiAKLSAgICBpbmRleCA9IGV2YWxBbmRFeHBl Y3RFeGNlcHRpb24oImluZGV4ID0gb2JqZWN0U3RvcmUuY3JlYXRlSW5kZXgobnVsbCwgbnVsbCk7 IiwgIklEQkRhdGFiYXNlRXhjZXB0aW9uLk5PTl9UUkFOU0lFTlRfRVJSIik7CisgICAgaW5kZXgg PSBldmFsQW5kTG9nKCJpbmRleCA9IG9iamVjdFN0b3JlLmNyZWF0ZUluZGV4KG51bGwsIG51bGwp OyIpOworICAgIHNob3VsZEJlKCJpbmRleC5uYW1lIiwgIidudWxsJyIpOworICAgIHNob3VsZEJl KCJpbmRleC5rZXlQYXRoIiwgIidudWxsJyIpOwogCiAgICAgZG9uZSgpOwogfQo=