63110 2011-06-21 18:56:51 -0700 IndexedDB open (database) should NOT throw if name is null 2011-06-22 17:57:59 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 pilgrim webkit-unassigned abarth dgrogan fishd hans tony webkit.review.bot oldest_to_newest 424947 0 pilgrim 2011-06-21 18:56:51 -0700 Bug 60022 was wrong, and Mozilla's implementation was wrong. Calling indexedDB.open(null) should behave identically to calling indexedDB.open("null"). I have double-checked this (highly unintuitive) behavior with the author of the WebIDL spec and he confirms it ( http://krijnhoetmer.nl/irc-logs/whatwg/20110622#l-187 ). There was also apparently a WebIDL spec bug recently asking to change this behavior, but it was WONTFIXED ( http://www.w3.org/Bugs/Public/show_bug.cgi?id=12798 ). End result: null values for DOMString arguments get stringified to the four-character string "null". This affects several functions in WebKit's IndexedDB implementation. I will file separate bugs for each of them. Patch attached. 424951 1 98099 pilgrim 2011-06-21 19:01:29 -0700 Created attachment 98099 Patch 424956 2 98099 dgrogan 2011-06-21 19:17:42 -0700 Comment on attachment 98099 Patch LGTM but could you add abarth to the reviewers since he seems to really know this stuff. Unless Tony also feels confident about it. 425795 3 98099 webkit.review.bot 2011-06-22 17:57:54 -0700 Comment on attachment 98099 Patch Clearing flags on attachment: 98099 Committed r89506: <http://trac.webkit.org/changeset/89506> 425796 4 webkit.review.bot 2011-06-22 17:57:59 -0700 All reviewed patches have been landed. Closing bug. 98099 2011-06-21 19:01:29 -0700 2011-06-22 17:57:54 -0700 Patch bug-63110-20110621220132.patch text/plain 5550 pilgrim SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg5Mzk5KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDYtMjEgIE1hcmsgUGls Z3JpbSAgPHBpbGdyaW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEluZGV4ZWREQiBvcGVuIChkYXRhYmFzZSkgc2hvdWxkIE5P VCB0aHJvdyBpZiBuYW1lIGlzIG51bGwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTYzMTEwCisKKyAgICAgICAgKiBzdG9yYWdlL0lEQkZhY3RvcnkuaWRs OiByZW1vdmUgQ29udmVydE51bGxUb051bGxTdHJpbmcgZmxhZyBvbgorICAgICAgICBuYW1lIGFy Z3VtZW50LCBsZXQgSURMIGNvZGUgZ2VuZXJhdG9yIHN0cmluZ2lmeSBudWxsIHZhbHVlIHRvICJu dWxsIgorCiAyMDExLTA2LTIxICBNYXR0aGV3IERlbGFuZXkgIDxtZGVsYW5leUBhcHBsZS5jb20+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gRnJhc2VyLgpJbmRleDogU291cmNlL1dlYkNv cmUvc3RvcmFnZS9JREJGYWN0b3J5LmlkbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9z dG9yYWdlL0lEQkZhY3RvcnkuaWRsCShyZXZpc2lvbiA4OTM5NykKKysrIFNvdXJjZS9XZWJDb3Jl L3N0b3JhZ2UvSURCRmFjdG9yeS5pZGwJKHdvcmtpbmcgY29weSkKQEAgLTI4LDcgKzI4LDcgQEAg bW9kdWxlIHN0b3JhZ2UgewogICAgIGludGVyZmFjZSBbCiAgICAgICAgIENvbmRpdGlvbmFsPUlO REVYRURfREFUQUJBU0UKICAgICBdIElEQkZhY3RvcnkgewotICAgICAgICBbQ2FsbFdpdGg9U2Ny aXB0RXhlY3V0aW9uQ29udGV4dF0gSURCUmVxdWVzdCBvcGVuKGluIFtDb252ZXJ0TnVsbFRvTnVs bFN0cmluZ10gRE9NU3RyaW5nIG5hbWUpCisgICAgICAgIFtDYWxsV2l0aD1TY3JpcHRFeGVjdXRp b25Db250ZXh0XSBJREJSZXF1ZXN0IG9wZW4oaW4gRE9NU3RyaW5nIG5hbWUpCiAgICAgICAgICAg ICByYWlzZXMgKElEQkRhdGFiYXNlRXhjZXB0aW9uKTsKICAgICB9OwogCkluZGV4OiBMYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZp c2lvbiA4OTM5OSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAt MSwzICsxLDE3IEBACisyMDExLTA2LTIxICBNYXJrIFBpbGdyaW0gIDxwaWxncmltQGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJ bmRleGVkREIgb3BlbiAoZGF0YWJhc2UpIHNob3VsZCBOT1QgdGhyb3cgaWYgbmFtZSBpcyBudWxs CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MzExMAor CisgICAgICAgICogc3RvcmFnZS9pbmRleGVkZGIvZGF0YWJhc2UtbmFtZS11bmRlZmluZWQtZXhw ZWN0ZWQudHh0OgorICAgICAgICAqIHN0b3JhZ2UvaW5kZXhlZGRiL2RhdGFiYXNlLW5hbWUtdW5k ZWZpbmVkLmh0bWw6IHJlbW92ZWQgc29tZSBjb2RlIGhlcmUKKyAgICAgICAgYmVjYXVzZSBpdCdz IGR1cGxpY2F0ZWQgaW4gdGhlIG1vemlsbGEvb3Blbi1kYXRhYmFzZS1udWxsLW5hbWUgdGVzdAor ICAgICAgICAqIHN0b3JhZ2UvaW5kZXhlZGRiL21vemlsbGEvb3Blbi1kYXRhYmFzZS1udWxsLW5h bWUtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIHN0b3JhZ2UvaW5kZXhlZGRiL21vemlsbGEvb3Bl bi1kYXRhYmFzZS1udWxsLW5hbWUuaHRtbDogZml4ZWQgZXhwZWN0ZWQKKyAgICAgICAgYmVoYXZp b3IgKGRiLm5hbWUgZW5kcyB1cCBhcyBmb3VyLWNoYXJhY3RlciBzdHJpbmcgIm51bGwiKQorCiAy MDExLTA2LTIxICBNYXR0aGV3IERlbGFuZXkgIDxtZGVsYW5leUBhcHBsZS5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgU2ltb24gRnJhc2VyLgpJbmRleDogTGF5b3V0VGVzdHMvc3RvcmFnZS9p bmRleGVkZGIvZGF0YWJhc2UtbmFtZS11bmRlZmluZWQtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL2RhdGFiYXNlLW5hbWUtdW5kZWZpbmVk LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gODkzOTcpCisrKyBMYXlvdXRUZXN0cy9zdG9yYWdlL2lu ZGV4ZWRkYi9kYXRhYmFzZS1uYW1lLXVuZGVmaW5lZC1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29w eSkKQEAgLTEyLDcgKzEyLDYgQEAgUEFTUyBJREJDdXJzb3IgPT0gbnVsbCBpcyBmYWxzZQogSURC S2V5UmFuZ2UgPSB3aW5kb3cuSURCS2V5UmFuZ2UgfHwgd2luZG93LndlYmtpdElEQktleVJhbmdl OwogUEFTUyBJREJLZXlSYW5nZSA9PSBudWxsIGlzIGZhbHNlCiBQQVNTIGluZGV4ZWREQi5vcGVu KCk7IHRocmV3IGV4Y2VwdGlvbiBUeXBlRXJyb3I6IE5vdCBlbm91Z2ggYXJndW1lbnRzLgotUEFT UyBpbmRleGVkREIub3BlbihudWxsKTsgdGhyZXcgZXhjZXB0aW9uIEVycm9yOiBOT05fVFJBTlNJ RU5UX0VSUjogRE9NIElEQkRhdGFiYXNlIEV4Y2VwdGlvbiAyLgogUEFTUyBzdWNjZXNzZnVsbHlQ YXJzZWQgaXMgdHJ1ZQogCiBURVNUIENPTVBMRVRFCkluZGV4OiBMYXlvdXRUZXN0cy9zdG9yYWdl L2luZGV4ZWRkYi9kYXRhYmFzZS1uYW1lLXVuZGVmaW5lZC5odG1sCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL2RhdGFiYXNlLW5hbWUtdW5kZWZpbmVkLmh0bWwJ KHJldmlzaW9uIDg5Mzk3KQorKysgTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvZGF0YWJh c2UtbmFtZS11bmRlZmluZWQuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMjcsNyArMjcsNiBAQCBm dW5jdGlvbiB0ZXN0KCkKICAgICBzaG91bGRCZUZhbHNlKCJJREJLZXlSYW5nZSA9PSBudWxsIik7 CiAKICAgICBzaG91bGRUaHJvdygiaW5kZXhlZERCLm9wZW4oKTsiKTsKLSAgICBzaG91bGRUaHJv dygiaW5kZXhlZERCLm9wZW4obnVsbCk7Iik7CiAgICAgZG9uZSgpOwogfQogCkluZGV4OiBMYXlv dXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9tb3ppbGxhL29wZW4tZGF0YWJhc2UtbnVsbC1uYW1l LWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRk Yi9tb3ppbGxhL29wZW4tZGF0YWJhc2UtbnVsbC1uYW1lLWV4cGVjdGVkLnR4dAkocmV2aXNpb24g ODkzOTcpCisrKyBMYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9tb3ppbGxhL29wZW4tZGF0 YWJhc2UtbnVsbC1uYW1lLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMSw0ICsxLDQg QEAKLVRlc3QgSW5kZXhlZERCOiBzaG91bGQgdGhyb3cgd2hlbiBvcGVuaW5nIGEgZGF0YWJhc2Ug d2l0aCBhIG51bGwgbmFtZQorVGVzdCBJbmRleGVkREI6IHNob3VsZCBOT1QgdGhyb3cgd2hlbiBv cGVuaW5nIGEgZGF0YWJhc2Ugd2l0aCBhIG51bGwgbmFtZQogCiBPbiBzdWNjZXNzLCB5b3Ugd2ls bCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01Q TEVURSIuCiAKQEAgLTksOSArOSw5IEBAIElEQkRhdGFiYXNlRXhjZXB0aW9uID0gd2luZG93LklE QkRhdGFiYXMKIFBBU1MgSURCRGF0YWJhc2VFeGNlcHRpb24gPT0gbnVsbCBpcyBmYWxzZQogSURC VHJhbnNhY3Rpb24gPSB3aW5kb3cuSURCVHJhbnNhY3Rpb24gfHwgd2luZG93LndlYmtpdElEQlRy YW5zYWN0aW9uOwogUEFTUyBJREJUcmFuc2FjdGlvbiA9PSBudWxsIGlzIGZhbHNlCi1FeHBlY3Rp bmcgZXhjZXB0aW9uIGZyb20gaW5kZXhlZERCLm9wZW4obnVsbCwgZGVzY3JpcHRpb24pCi1QQVNT IEV4Y2VwdGlvbiB3YXMgdGhyb3duLgotUEFTUyBjb2RlIGlzIElEQkRhdGFiYXNlRXhjZXB0aW9u Lk5PTl9UUkFOU0lFTlRfRVJSCitpbmRleGVkREIub3BlbihudWxsKTsKK2RiID0gZXZlbnQudGFy Z2V0LnJlc3VsdAorUEFTUyBkYi5uYW1lIGlzICdudWxsJwogUEFTUyBzdWNjZXNzZnVsbHlQYXJz ZWQgaXMgdHJ1ZQogCiBURVNUIENPTVBMRVRFCkluZGV4OiBMYXlvdXRUZXN0cy9zdG9yYWdlL2lu ZGV4ZWRkYi9tb3ppbGxhL29wZW4tZGF0YWJhc2UtbnVsbC1uYW1lLmh0bWwKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvbW96aWxsYS9vcGVuLWRhdGFiYXNlLW51 bGwtbmFtZS5odG1sCShyZXZpc2lvbiA4OTM5NykKKysrIExheW91dFRlc3RzL3N0b3JhZ2UvaW5k ZXhlZGRiL21vemlsbGEvb3Blbi1kYXRhYmFzZS1udWxsLW5hbWUuaHRtbAkod29ya2luZyBjb3B5 KQpAQCAtMTcsNyArMTcsNyBAQAogPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+CiA8c2NyaXB0Pgog Ci1kZXNjcmlwdGlvbigiVGVzdCBJbmRleGVkREI6IHNob3VsZCB0aHJvdyB3aGVuIG9wZW5pbmcg YSBkYXRhYmFzZSB3aXRoIGEgbnVsbCBuYW1lIik7CitkZXNjcmlwdGlvbigiVGVzdCBJbmRleGVk REI6IHNob3VsZCBOT1QgdGhyb3cgd2hlbiBvcGVuaW5nIGEgZGF0YWJhc2Ugd2l0aCBhIG51bGwg bmFtZSIpOwogaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKICAgICBsYXlvdXRUZXN0 Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7CiAKQEAgLTMxLDcgKzMxLDE1IEBAIGZ1bmN0aW9u IHRlc3QoKQogICAgIHNob3VsZEJlRmFsc2UoIklEQlRyYW5zYWN0aW9uID09IG51bGwiKTsKIAog ICAgIGRlc2NyaXB0aW9uID0gIk15IFRlc3QgRGF0YWJhc2UiOwotICAgIGV2YWxBbmRFeHBlY3RF eGNlcHRpb24oImluZGV4ZWREQi5vcGVuKG51bGwsIGRlc2NyaXB0aW9uKSIsICJJREJEYXRhYmFz ZUV4Y2VwdGlvbi5OT05fVFJBTlNJRU5UX0VSUiIpOworICAgIHJlcXVlc3QgPSBldmFsQW5kTG9n KCJpbmRleGVkREIub3BlbihudWxsKTsiKTsKKyAgICByZXF1ZXN0Lm9uc3VjY2VzcyA9IG9wZW5T dWNjZXNzOworICAgIHJlcXVlc3Qub25lcnJvciA9IHVuZXhwZWN0ZWRFcnJvckNhbGxiYWNrOwor fQorCitmdW5jdGlvbiBvcGVuU3VjY2VzcygpCit7CisgICAgZGIgPSBldmFsQW5kTG9nKCJkYiA9 IGV2ZW50LnRhcmdldC5yZXN1bHQiKTsKKyAgICBzaG91bGRCZSgiZGIubmFtZSIsICInbnVsbCci KTsKICAgICBkb25lKCk7CiB9CiAK