63105 2011-06-21 16:27:56 -0700 Moved 'const' off the global-variable-as-local-variable crack pipe 2011-06-21 16:39:32 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ggaren ggaren oliver oldest_to_newest 424856 0 ggaren 2011-06-21 16:27:56 -0700 Moved 'const' off the global-variable-as-local-variable crack pipe 424862 1 98078 ggaren 2011-06-21 16:36:26 -0700 Created attachment 98078 Patch 424864 2 98078 oliver 2011-06-21 16:37:46 -0700 Comment on attachment 98078 Patch i hate const 424865 3 ggaren 2011-06-21 16:39:32 -0700 Committed r89392: <http://trac.webkit.org/changeset/89392> 98078 2011-06-21 16:36:26 -0700 2011-06-21 16:37:46 -0700 Patch bug-63105-20110621163625.patch text/plain 5516 ggaren SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODkzOTEpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjkgQEAK KzIwMTEtMDYtMjEgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNb3ZlZCAnY29uc3QnIG9m ZiB0aGUgZ2xvYmFsLXZhcmlhYmxlLWFzLWxvY2FsLXZhcmlhYmxlIGNyYWNrIHBpcGUKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYzMTA1CisgICAgICAg IAorICAgICAgICBUaGlzIGlzIG5lY2Vzc2FyeSBmb3IgbW92aW5nIHRoZSByZXN0IG9mIHRoZSBj b2RlIG9mZiBvZiBzYW1lLgorICAgICAgICAKKyAgICAgICAgTWFueSBwcm9ibGVtcyByZW1haW4g aW4gb3VyIGhhbmRsaW5nIG9mIGNvbnN0LiBJIGhhdmUgZml4ZWQgbm9uZSBvZiB0aGVtLgorCisg ICAgICAgICogYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmg6CisgICAgICAgIChKU0M6 OkJ5dGVjb2RlR2VuZXJhdG9yOjpzY29wZUNoYWluKTogTmV3IGFjY2Vzc29yLCBuZWVkZWQgdG8g ZW5hYmxlCisgICAgICAgIGNvbnN0IHRvIGRpcmVjdGx5IGltcGxlbWVudCBpdHMgdW5pcXVlIHNj b3BpbmcgcnVsZXMuCisKKyAgICAgICAgKiBieXRlY29tcGlsZXIvTm9kZXNDb2RlZ2VuLmNwcDoK KyAgICAgICAgKEpTQzo6UHJlZml4UmVzb2x2ZU5vZGU6OmVtaXRCeXRlY29kZSk6IERvIHNwZWNp ZnkgdGhhdCBvdXIgcmVzb2x2ZSBpcworICAgICAgICBmb3Igd3JpdGluZywgc28gd2UgZG9uJ3Qg b3ZlcndyaXRlIGNvbnN0IHZhcmlhYmxlcy4KKworICAgICAgICAoSlNDOjpDb25zdERlY2xOb2Rl OjplbWl0Q29kZVNpbmdsZSk6IERvbid0IGFzc3VtZSB0aGF0IGFsbCBkZWNsYXJlZCBjb25zdAor ICAgICAgICB2YXJpYWJsZXMgYXJlIGF2YWlsYWJsZSBhcyBsb2NhbCB2YXJpYWJsZXMsIHNpbmNl IHRoaXMgd29uJ3QgYmUgdGhlIGNhc2UKKyAgICAgICAgb25jZSBnbG9iYWwgdmFyaWFibGVzIGFy ZSBub3QgYXZhaWxhYmxlIGFzIGxvY2FsIHZhcmlhYmxlcy4gSW5zdGVhZCwgdXNlCisgICAgICAg IHB1dF9zY29wZWRfdmFyIGluIHRoZSBjYXNlIHdoZXJlIHRoZXJlIGlzIG5vIGxvY2FsIHZhcmlh YmxlLiBMaWtlIGEgbG9jYWwKKyAgICAgICAgdmFyaWFibGUsIHB1dF9zY29wZWRfdmFyIHN1Y2Nl ZWRzIGV2ZW4gdGhvdWdoIGNvbnN0IHByb3BlcnRpZXMgYXJlCisgICAgICAgIHJlYWQtb25seSwg c2luY2UgcHV0X3Njb3BlZF92YXIgc2tpcHMgcmVhZC1vbmx5IGNoZWNrcy4gKFlheT8pCisKIDIw MTEtMDYtMjEgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBBbGV4ZXkgUHJvc2t1cnlha292LgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl L2J5dGVjb21waWxlci9CeXRlY29kZUdlbmVyYXRvci5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuaAkocmV2aXNpb24g ODkyOTEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2Vu ZXJhdG9yLmgJKHdvcmtpbmcgY29weSkKQEAgLTM5OSw2ICszOTksOCBAQCBuYW1lc3BhY2UgSlND IHsKICAgICAgICAgYm9vbCBzaG91bGRFbWl0UHJvZmlsZUhvb2tzKCkgeyByZXR1cm4gbV9zaG91 bGRFbWl0UHJvZmlsZUhvb2tzOyB9CiAgICAgICAgIAogICAgICAgICBib29sIGlzU3RyaWN0TW9k ZSgpIGNvbnN0IHsgcmV0dXJuIG1fY29kZUJsb2NrLT5pc1N0cmljdE1vZGUoKTsgfQorICAgICAg ICAKKyAgICAgICAgU2NvcGVDaGFpbk5vZGUqIHNjb3BlQ2hhaW4oKSBjb25zdCB7IHJldHVybiBt X3Njb3BlQ2hhaW4uZ2V0KCk7IH0KIAogICAgIHByaXZhdGU6CiAgICAgICAgIHZvaWQgZW1pdE9w Y29kZShPcGNvZGVJRCk7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVy L05vZGVzQ29kZWdlbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2J5 dGVjb21waWxlci9Ob2Rlc0NvZGVnZW4uY3BwCShyZXZpc2lvbiA4OTI5MSkKKysrIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvTm9kZXNDb2RlZ2VuLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNzQ0LDcgKzc0NCw3IEBAIFJlZ2lzdGVySUQqIFByZWZpeFJlc29sdmVOb2RlOjplbWl0 Qnl0ZWMKICAgICBzaXplX3QgZGVwdGggPSAwOwogICAgIEpTT2JqZWN0KiBnbG9iYWxPYmplY3Qg PSAwOwogICAgIGJvb2wgcmVxdWlyZXNEeW5hbWljQ2hlY2tzID0gZmFsc2U7Ci0gICAgaWYgKGdl bmVyYXRvci5maW5kU2NvcGVkUHJvcGVydHkobV9pZGVudCwgaW5kZXgsIGRlcHRoLCBmYWxzZSwg cmVxdWlyZXNEeW5hbWljQ2hlY2tzLCBnbG9iYWxPYmplY3QpICYmIGluZGV4ICE9IG1pc3NpbmdT eW1ib2xNYXJrZXIoKSAmJiAhcmVxdWlyZXNEeW5hbWljQ2hlY2tzKSB7CisgICAgaWYgKGdlbmVy YXRvci5maW5kU2NvcGVkUHJvcGVydHkobV9pZGVudCwgaW5kZXgsIGRlcHRoLCB0cnVlLCByZXF1 aXJlc0R5bmFtaWNDaGVja3MsIGdsb2JhbE9iamVjdCkgJiYgaW5kZXggIT0gbWlzc2luZ1N5bWJv bE1hcmtlcigpICYmICFyZXF1aXJlc0R5bmFtaWNDaGVja3MpIHsKICAgICAgICAgUmVmUHRyPFJl Z2lzdGVySUQ+IHByb3BEc3QgPSBnZW5lcmF0b3IuZW1pdEdldFNjb3BlZFZhcihnZW5lcmF0b3Iu dGVtcERlc3RpbmF0aW9uKGRzdCksIGRlcHRoLCBpbmRleCwgZ2xvYmFsT2JqZWN0KTsKICAgICAg ICAgZW1pdFByZUluY09yRGVjKGdlbmVyYXRvciwgcHJvcERzdC5nZXQoKSwgbV9vcGVyYXRvcik7 CiAgICAgICAgIGdlbmVyYXRvci5lbWl0UHV0U2NvcGVkVmFyKGRlcHRoLCBpbmRleCwgcHJvcERz dC5nZXQoKSwgZ2xvYmFsT2JqZWN0KTsKQEAgLTEyOTMsNiArMTI5Myw3IEBAIFJlZ2lzdGVySUQq IENvbW1hTm9kZTo6ZW1pdEJ5dGVjb2RlKEJ5dGUKIAogUmVnaXN0ZXJJRCogQ29uc3REZWNsTm9k ZTo6ZW1pdENvZGVTaW5nbGUoQnl0ZWNvZGVHZW5lcmF0b3ImIGdlbmVyYXRvcikKIHsKKyAgICAv LyBGSVhNRTogVGhpcyBjb2RlIGRvZXMgbm90IG1hdGNoIHRoZSBiZWhhdmlvciBvZiBjb25zdCBp biBGaXJlZm94LgogICAgIGlmIChSZWdpc3RlcklEKiBsb2NhbCA9IGdlbmVyYXRvci5jb25zdFJl Z2lzdGVyRm9yKG1faWRlbnQpKSB7CiAgICAgICAgIGlmICghbV9pbml0KQogICAgICAgICAgICAg cmV0dXJuIGxvY2FsOwpAQCAtMTMwMCwxNyArMTMwMSwzMCBAQCBSZWdpc3RlcklEKiBDb25zdERl Y2xOb2RlOjplbWl0Q29kZVNpbmdsCiAgICAgICAgIHJldHVybiBnZW5lcmF0b3IuZW1pdE5vZGUo bG9jYWwsIG1faW5pdCk7CiAgICAgfQogCi0gICAgaWYgKGdlbmVyYXRvci5jb2RlVHlwZSgpICE9 IEV2YWxDb2RlKSB7Ci0gICAgICAgIGlmIChtX2luaXQpCi0gICAgICAgICAgICByZXR1cm4gZ2Vu ZXJhdG9yLmVtaXROb2RlKG1faW5pdCk7Ci0gICAgICAgIGVsc2UKLSAgICAgICAgICAgIHJldHVy biBnZW5lcmF0b3IuZW1pdFJlc29sdmUoZ2VuZXJhdG9yLm5ld1RlbXBvcmFyeSgpLCBtX2lkZW50 KTsKKyAgICBSZWZQdHI8UmVnaXN0ZXJJRD4gdmFsdWUgPSBtX2luaXQgPyBnZW5lcmF0b3IuZW1p dE5vZGUobV9pbml0KSA6IGdlbmVyYXRvci5lbWl0TG9hZCgwLCBqc1VuZGVmaW5lZCgpKTsKKwor ICAgIFNjb3BlQ2hhaW5JdGVyYXRvciBpdGVyID0gZ2VuZXJhdG9yLnNjb3BlQ2hhaW4oKS0+YmVn aW4oKTsKKyAgICBTY29wZUNoYWluSXRlcmF0b3IgZW5kID0gZ2VuZXJhdG9yLnNjb3BlQ2hhaW4o KS0+ZW5kKCk7CisgICAgc2l6ZV90IGRlcHRoID0gMDsKKyAgICBmb3IgKDsgaXRlciAhPSBlbmQ7 ICsraXRlciwgKytkZXB0aCkgeworICAgICAgICBKU09iamVjdCogY3VycmVudFNjb3BlID0gaXRl ci0+Z2V0KCk7CisgICAgICAgIGlmICghY3VycmVudFNjb3BlLT5pc1ZhcmlhYmxlT2JqZWN0KCkp CisgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgSlNWYXJpYWJsZU9iamVjdCogY3VycmVu dFZhcmlhYmxlT2JqZWN0ID0gc3RhdGljX2Nhc3Q8SlNWYXJpYWJsZU9iamVjdCo+KGN1cnJlbnRT Y29wZSk7CisgICAgICAgIFN5bWJvbFRhYmxlRW50cnkgZW50cnkgPSBjdXJyZW50VmFyaWFibGVP YmplY3QtPnN5bWJvbFRhYmxlKCkuZ2V0KG1faWRlbnQuaW1wbCgpKTsKKyAgICAgICAgaWYgKGVu dHJ5LmlzTnVsbCgpKQorICAgICAgICAgICAgY29udGludWU7CisKKyAgICAgICAgcmV0dXJuIGdl bmVyYXRvci5lbWl0UHV0U2NvcGVkVmFyKGRlcHRoLCBlbnRyeS5nZXRJbmRleCgpLCB2YWx1ZS5n ZXQoKSwgY3VycmVudFZhcmlhYmxlT2JqZWN0LT5pc0dsb2JhbE9iamVjdCgpID8gY3VycmVudFZh cmlhYmxlT2JqZWN0IDogMCk7CiAgICAgfQotICAgIC8vIEZJWE1FOiBXaGlsZSB0aGlzIGNvZGUg c2hvdWxkIG9ubHkgYmUgaGl0IGluIGV2YWwgY29kZSwgaXQgd2lsbCBwb3RlbnRpYWxseQotICAg IC8vIGFzc2lnbiB0byB0aGUgd3JvbmcgYmFzZSBpZiBtX2lkZW50IGV4aXN0cyBpbiBhbiBpbnRl cnZlbmluZyBkeW5hbWljIHNjb3BlLgorCisgICAgaWYgKGdlbmVyYXRvci5jb2RlVHlwZSgpICE9 IEV2YWxDb2RlKQorICAgICAgICByZXR1cm4gdmFsdWUuZ2V0KCk7CisKKyAgICAvLyBGSVhNRTog V2hpbGUgdGhpcyBjb2RlIHNob3VsZCBvbmx5IGJlIGhpdCBpbiBhbiBldmFsIGJsb2NrLCBpdCB3 aWxsIGFzc2lnbgorICAgIC8vIHRvIHRoZSB3cm9uZyBiYXNlIGlmIG1faWRlbnQgZXhpc3RzIGlu IGFuIGludGVydmVuaW5nIHdpdGggc2NvcGUuCiAgICAgUmVmUHRyPFJlZ2lzdGVySUQ+IGJhc2Ug PSBnZW5lcmF0b3IuZW1pdFJlc29sdmVCYXNlKGdlbmVyYXRvci5uZXdUZW1wb3JhcnkoKSwgbV9p ZGVudCk7Ci0gICAgUmVnaXN0ZXJJRCogdmFsdWUgPSBtX2luaXQgPyBnZW5lcmF0b3IuZW1pdE5v ZGUobV9pbml0KSA6IGdlbmVyYXRvci5lbWl0TG9hZCgwLCBqc1VuZGVmaW5lZCgpKTsKLSAgICBy ZXR1cm4gZ2VuZXJhdG9yLmVtaXRQdXRCeUlkKGJhc2UuZ2V0KCksIG1faWRlbnQsIHZhbHVlKTsK KyAgICByZXR1cm4gZ2VuZXJhdG9yLmVtaXRQdXRCeUlkKGJhc2UuZ2V0KCksIG1faWRlbnQsIHZh bHVlLmdldCgpKTsKIH0KIAogUmVnaXN0ZXJJRCogQ29uc3REZWNsTm9kZTo6ZW1pdEJ5dGVjb2Rl KEJ5dGVjb2RlR2VuZXJhdG9yJiBnZW5lcmF0b3IsIFJlZ2lzdGVySUQqKQo=