63095 2011-06-21 14:04:17 -0700 [Qt] Add an API for accessing the QGraphicsView. 2011-06-21 14:34:13 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yael webkit-unassigned oldest_to_newest 424739 0 yael 2011-06-21 14:04:17 -0700 This was requested by 2 reviewers in https://bugs.webkit.org/show_bug.cgi?id=62838. 424744 1 98055 yael 2011-06-21 14:09:05 -0700 Created attachment 98055 Patch. 424749 2 98055 kenneth 2011-06-21 14:12:47 -0700 Comment on attachment 98055 Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=98055&action=review > Source/WebKit2/ChangeLog:5 > + [Qt] Add an API for accessing the QGraphicsView. internal API* > Source/WebKit2/UIProcess/API/qt/qwkpage.cpp:316 > + if (views.size() > 1) > + qWarning("Cannot support multiple views"); Not sure this is the right way to handle it, but I guess it is fine. 424757 3 yael 2011-06-21 14:20:58 -0700 (In reply to comment #2) > (From update of attachment 98055 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=98055&action=review > > > Source/WebKit2/ChangeLog:5 > > + [Qt] Add an API for accessing the QGraphicsView. > > internal API* > > > Source/WebKit2/UIProcess/API/qt/qwkpage.cpp:316 > > + if (views.size() > 1) > > + qWarning("Cannot support multiple views"); > > Not sure this is the right way to handle it, but I guess it is fine. Thank you for reviewing :) 424765 4 yael 2011-06-21 14:34:13 -0700 Committed r89384: <http://trac.webkit.org/changeset/89384> 98055 2011-06-21 14:09:05 -0700 2011-06-21 14:12:47 -0700 Patch. 63095.patch text/plain 1846 yael SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg5Mzc3KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDYtMjEgIFlhZWwgQWhh cm9uICA8eWFlbC5haGFyb25Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gQWRkIGFuIEFQSSBmb3IgYWNjZXNzaW5nIHRoZSBR R3JhcGhpY3NWaWV3LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NjMwOTUKKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvcXdrcGFnZS5jcHA6Cisg ICAgICAgIChRV0tQYWdlUHJpdmF0ZTo6b3duZXJXaWRnZXQpOgorICAgICAgICAqIFVJUHJvY2Vz cy9BUEkvcXQvcXdrcGFnZV9wLmg6CisKIDIwMTEtMDYtMjEgIEx1a2FzeiBTbGFjaGNpYWsgIDxs LnNsYWNoY2lha0BzYW1zdW5nLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2Vpbmln LgpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xd2twYWdlLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3a3BhZ2UuY3BwCShy ZXZpc2lvbiA4OTI1MykKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXdrcGFn ZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMwNiw2ICszMDYsMTggQEAgdm9pZCBRV0tQYWdlUHJp dmF0ZTo6Zmxhc2hCYWNraW5nU3RvcmVVcAogICAgIG5vdEltcGxlbWVudGVkKCk7CiB9CiAKK1FX aWRnZXQqIFFXS1BhZ2VQcml2YXRlOjpvd25lcldpZGdldCgpCit7CisgICAgaWYgKCF2aWV3IHx8 ICF2aWV3LT5zY2VuZSgpIHx8IHZpZXctPnNjZW5lKCktPnZpZXdzKCkuaXNFbXB0eSgpKQorICAg ICAgICByZXR1cm4gMDsKKworICAgIFFMaXN0PFFHcmFwaGljc1ZpZXcqPiB2aWV3cyA9IHZpZXct PnNjZW5lKCktPnZpZXdzKCk7CisgICAgaWYgKHZpZXdzLnNpemUoKSA+IDEpCisgICAgICAgIHFX YXJuaW5nKCJDYW5ub3Qgc3VwcG9ydCBtdWx0aXBsZSB2aWV3cyIpOworCisgICAgcmV0dXJuIHZp ZXdzLmF0KDApOworfQorCiB2b2lkIFFXS1BhZ2VQcml2YXRlOjpwYWludChRUGFpbnRlciogcGFp bnRlciwgUVJlY3QgYXJlYSkKIHsKICAgICBpZiAocGFnZS0+aXNWYWxpZCgpICYmIHBhZ2UtPmRy YXdpbmdBcmVhKCkpIHsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXdr cGFnZV9wLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9x d2twYWdlX3AuaAkocmV2aXNpb24gODkyNTMpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL3F0L3F3a3BhZ2VfcC5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMTYsNiArMTE2LDggQEAgcHVi bGljOgogICAgIHZvaWQgdXBkYXRlTmF2aWdhdGlvbkFjdGlvbnMoKTsKICAgICB2b2lkIHVwZGF0 ZUVkaXRvckFjdGlvbnMoKTsKIAorICAgIFFXaWRnZXQqIG93bmVyV2lkZ2V0KCk7CisKICAgICB2 b2lkIF9xX3dlYkFjdGlvblRyaWdnZXJlZChib29sIGNoZWNrZWQpOwogCiAgICAgdm9pZCB0b3Vj aEV2ZW50KFFUb3VjaEV2ZW50Kik7Cg==