63087 2011-06-21 12:45:12 -0700 IndexedDB: IDBObjectStore methods should throw TypeError if required arguments are missing 2011-06-21 14:20:32 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 pilgrim webkit-unassigned abarth dgrogan fishd hans tony webkit.review.bot oldest_to_newest 424677 0 pilgrim 2011-06-21 12:45:12 -0700 http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#idl-def-IDBObjectStore lists required arguments to put(), add(), delete(), get(), createIndex(), index(), and deleteIndex(). As per the WebIDL spec, calling functions with missing required arguments should throw a TypeError. This test calls these functions with no arguments, or with too few arguments, to see what happens. Expected behavior: throw TypeError Actual behavior: no exception thrown Patch included. The fix is to remove the LegacyDefaultOptionalArguments flag from IDBObjectStore.idl, which will force the code generator to check for required arguments and throw TypeError when they are missing. 424683 1 98045 pilgrim 2011-06-21 12:48:13 -0700 Created attachment 98045 Patch 424717 2 98045 abarth 2011-06-21 13:45:34 -0700 Comment on attachment 98045 Patch These patches are so beautiful. Thanks! 424755 3 98045 webkit.review.bot 2011-06-21 14:20:27 -0700 Comment on attachment 98045 Patch Clearing flags on attachment: 98045 Committed r89383: <http://trac.webkit.org/changeset/89383> 424756 4 webkit.review.bot 2011-06-21 14:20:32 -0700 All reviewed patches have been landed. Closing bug. 98045 2011-06-21 12:48:13 -0700 2011-06-21 14:20:27 -0700 Patch bug-63087-20110621154814.patch text/plain 6236 pilgrim SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg5MzcxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDYtMjEgIE1hcmsgUGls Z3JpbSAgPHBpbGdyaW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEluZGV4ZWREQjogSURCT2JqZWN0U3RvcmUgbWV0aG9kcyBz aG91bGQgdGhyb3cgVHlwZUVycm9yIGlmIHJlcXVpcmVkIGFyZ3VtZW50cyBhcmUgbWlzc2luZwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjMwODcKKwor ICAgICAgICBUZXN0OiBzdG9yYWdlL2luZGV4ZWRkYi9vYmplY3RTdG9yZS1yZXF1aXJlZC1hcmd1 bWVudHMuaHRtbAorCisgICAgICAgICogc3RvcmFnZS9JREJPYmplY3RTdG9yZS5pZGw6IFJlbW92 ZSBMZWdhY3lEZWZhdWx0T3B0aW9uYWxBcmd1bWVudHMgZmxhZworICAgICAgICBzbyBtaXNzaW5n IHJlcXVpcmVkIGFyZ3VtZW50cyB3aWxsIHRocm93IFR5cGVFcnJvciwgYXMgcGVyIFdlYklETCBz cGVjLgorCiAyMDExLTA2LTIxICBWc2V2b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IFBhdmVsIEZlbGRtYW4uCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9zdG9yYWdlL0lEQk9iamVjdFN0b3JlLmlkbAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9zdG9yYWdlL0lEQk9iamVjdFN0b3JlLmlkbAkocmV2aXNpb24gODkzMjEpCisrKyBTb3Vy Y2UvV2ViQ29yZS9zdG9yYWdlL0lEQk9iamVjdFN0b3JlLmlkbAkod29ya2luZyBjb3B5KQpAQCAt MjYsNyArMjYsNiBAQAogbW9kdWxlIHN0b3JhZ2UgewogCiAgICAgaW50ZXJmYWNlIFsKLSAgICAg ICAgTGVnYWN5RGVmYXVsdE9wdGlvbmFsQXJndW1lbnRzLAogICAgICAgICBDb25kaXRpb25hbD1J TkRFWEVEX0RBVEFCQVNFCiAgICAgXSBJREJPYmplY3RTdG9yZSB7CiAgICAgICAgIHJlYWRvbmx5 IGF0dHJpYnV0ZSBbQ29udmVydE51bGxTdHJpbmdUbz1OdWxsXSBET01TdHJpbmcgbmFtZTsKSW5k ZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cJKHJldmlzaW9uIDg5MzcxKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDYtMjEgIE1hcmsgUGlsZ3JpbSAgPHBpbGdy aW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEluZGV4ZWREQjogSURCT2JqZWN0U3RvcmUgbWV0aG9kcyBzaG91bGQgdGhyb3cg VHlwZUVycm9yIGlmIHJlcXVpcmVkIGFyZ3VtZW50cyBhcmUgbWlzc2luZworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjMwODcKKworICAgICAgICAqIHN0 b3JhZ2UvaW5kZXhlZGRiL29iamVjdFN0b3JlLXJlcXVpcmVkLWFyZ3VtZW50cy1leHBlY3RlZC50 eHQ6IEFkZGVkLgorICAgICAgICAqIHN0b3JhZ2UvaW5kZXhlZGRiL29iamVjdFN0b3JlLXJlcXVp cmVkLWFyZ3VtZW50cy5odG1sOiBBZGRlZC4KKwogMjAxMS0wNi0yMSAgRGlyayBTY2h1bHplICA8 a3JpdEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFJvYiBCdWlzLgpJbmRleDog TGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvb2JqZWN0U3RvcmUtcmVxdWlyZWQtYXJndW1l bnRzLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4 ZWRkYi9vYmplY3RTdG9yZS1yZXF1aXJlZC1hcmd1bWVudHMtZXhwZWN0ZWQudHh0CShyZXZpc2lv biAwKQorKysgTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvb2JqZWN0U3RvcmUtcmVxdWly ZWQtYXJndW1lbnRzLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwzMCBAQAor VGVzdCBJbmRleGVkREIgb2JqZWN0IHN0b3JlIHJlcXVpcmVkIGFyZ3VtZW50cworCitPbiBzdWNj ZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBi eSAiVEVTVCBDT01QTEVURSIuCisKKworaW5kZXhlZERCID0gd2luZG93LmluZGV4ZWREQiB8fCB3 aW5kb3cud2Via2l0SW5kZXhlZERCIHx8IHdpbmRvdy5tb3pJbmRleGVkREI7CitQQVNTIGluZGV4 ZWREQiA9PSBudWxsIGlzIGZhbHNlCitJREJEYXRhYmFzZUV4Y2VwdGlvbiA9IHdpbmRvdy5JREJE YXRhYmFzZUV4Y2VwdGlvbiB8fCB3aW5kb3cud2Via2l0SURCRGF0YWJhc2VFeGNlcHRpb247CitQ QVNTIElEQkRhdGFiYXNlRXhjZXB0aW9uID09IG51bGwgaXMgZmFsc2UKK0lEQkN1cnNvciA9IHdp bmRvdy5JREJDdXJzb3IgfHwgd2luZG93LndlYmtpdElEQkN1cnNvcjsKK1BBU1MgSURCQ3Vyc29y ID09IG51bGwgaXMgZmFsc2UKK0lEQktleVJhbmdlID0gd2luZG93LklEQktleVJhbmdlIHx8IHdp bmRvdy53ZWJraXRJREJLZXlSYW5nZTsKK1BBU1MgSURCS2V5UmFuZ2UgPT0gbnVsbCBpcyBmYWxz ZQoraW5kZXhlZERCLm9wZW4obmFtZSwgZGVzY3JpcHRpb24pCitkYiA9IGV2ZW50LnRhcmdldC5y ZXN1bHQKK3JlcXVlc3QgPSBkYi5zZXRWZXJzaW9uKCcxJykKK0RlbGV0ZWQgYWxsIG9iamVjdCBz dG9yZXMuCitvYmplY3RTdG9yZSA9IGRiLmNyZWF0ZU9iamVjdFN0b3JlKCdmb28nKTsKK1BBU1Mg b2JqZWN0U3RvcmUucHV0KCk7IHRocmV3IGV4Y2VwdGlvbiBUeXBlRXJyb3I6IE5vdCBlbm91Z2gg YXJndW1lbnRzLgorUEFTUyBvYmplY3RTdG9yZS5hZGQoKTsgdGhyZXcgZXhjZXB0aW9uIFR5cGVF cnJvcjogTm90IGVub3VnaCBhcmd1bWVudHMuCitQQVNTIG9iamVjdFN0b3JlLmRlbGV0ZSgpOyB0 aHJldyBleGNlcHRpb24gVHlwZUVycm9yOiBOb3QgZW5vdWdoIGFyZ3VtZW50cy4KK1BBU1Mgb2Jq ZWN0U3RvcmUuZ2V0KCk7IHRocmV3IGV4Y2VwdGlvbiBUeXBlRXJyb3I6IE5vdCBlbm91Z2ggYXJn dW1lbnRzLgorUEFTUyBvYmplY3RTdG9yZS5jcmVhdGVJbmRleCgpOyB0aHJldyBleGNlcHRpb24g VHlwZUVycm9yOiBOb3QgZW5vdWdoIGFyZ3VtZW50cy4KK1BBU1Mgb2JqZWN0U3RvcmUuY3JlYXRl SW5kZXgoJ2ZvbycpOyB0aHJldyBleGNlcHRpb24gVHlwZUVycm9yOiBOb3QgZW5vdWdoIGFyZ3Vt ZW50cy4KK1BBU1Mgb2JqZWN0U3RvcmUuaW5kZXgoKTsgdGhyZXcgZXhjZXB0aW9uIFR5cGVFcnJv cjogTm90IGVub3VnaCBhcmd1bWVudHMuCitQQVNTIG9iamVjdFN0b3JlLmRlbGV0ZUluZGV4KCk7 IHRocmV3IGV4Y2VwdGlvbiBUeXBlRXJyb3I6IE5vdCBlbm91Z2ggYXJndW1lbnRzLgorUEFTUyBz dWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKSW5kZXg6IExheW91 dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL29iamVjdFN0b3JlLXJlcXVpcmVkLWFyZ3VtZW50cy5o dG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL29iamVjdFN0 b3JlLXJlcXVpcmVkLWFyZ3VtZW50cy5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMv c3RvcmFnZS9pbmRleGVkZGIvb2JqZWN0U3RvcmUtcmVxdWlyZWQtYXJndW1lbnRzLmh0bWwJKHJl dmlzaW9uIDApCkBAIC0wLDAgKzEsNjcgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVh ZD4KKzxsaW5rIHJlbD0ic3R5bGVzaGVldCIgaHJlZj0iLi4vLi4vZmFzdC9qcy9yZXNvdXJjZXMv anMtdGVzdC1zdHlsZS5jc3MiPgorPHNjcmlwdCBzcmM9Ii4uLy4uL2Zhc3QvanMvcmVzb3VyY2Vz L2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9mYXN0L2pzL3Jl c291cmNlcy9qcy10ZXN0LXBvc3QtZnVuY3Rpb24uanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9 InJlc291cmNlcy9zaGFyZWQuanMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8cCBpZD0i ZGVzY3JpcHRpb24iPjwvcD4KKzxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorPHNjcmlwdD4KKwor ZGVzY3JpcHRpb24oIlRlc3QgSW5kZXhlZERCIG9iamVjdCBzdG9yZSByZXF1aXJlZCBhcmd1bWVu dHMiKTsKK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgbGF5b3V0VGVzdENv bnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOworCitmdW5jdGlvbiB0ZXN0KCkKK3sKKyAgICBpbmRl eGVkREIgPSBldmFsQW5kTG9nKCJpbmRleGVkREIgPSB3aW5kb3cuaW5kZXhlZERCIHx8IHdpbmRv dy53ZWJraXRJbmRleGVkREIgfHwgd2luZG93Lm1vekluZGV4ZWREQjsiKTsKKyAgICBzaG91bGRC ZUZhbHNlKCJpbmRleGVkREIgPT0gbnVsbCIpOworICAgIElEQkRhdGFiYXNlRXhjZXB0aW9uID0g ZXZhbEFuZExvZygiSURCRGF0YWJhc2VFeGNlcHRpb24gPSB3aW5kb3cuSURCRGF0YWJhc2VFeGNl cHRpb24gfHwgd2luZG93LndlYmtpdElEQkRhdGFiYXNlRXhjZXB0aW9uOyIpOworICAgIHNob3Vs ZEJlRmFsc2UoIklEQkRhdGFiYXNlRXhjZXB0aW9uID09IG51bGwiKTsKKyAgICBJREJDdXJzb3Ig PSBldmFsQW5kTG9nKCJJREJDdXJzb3IgPSB3aW5kb3cuSURCQ3Vyc29yIHx8IHdpbmRvdy53ZWJr aXRJREJDdXJzb3I7Iik7CisgICAgc2hvdWxkQmVGYWxzZSgiSURCQ3Vyc29yID09IG51bGwiKTsK KyAgICBJREJLZXlSYW5nZSA9IGV2YWxBbmRMb2coIklEQktleVJhbmdlID0gd2luZG93LklEQktl eVJhbmdlIHx8IHdpbmRvdy53ZWJraXRJREJLZXlSYW5nZTsiKTsKKyAgICBzaG91bGRCZUZhbHNl KCJJREJLZXlSYW5nZSA9PSBudWxsIik7CisKKyAgICBuYW1lID0gd2luZG93LmxvY2F0aW9uLnBh dGhuYW1lOworICAgIGRlc2NyaXB0aW9uID0gIk15IFRlc3QgRGF0YWJhc2UiOworICAgIHJlcXVl c3QgPSBldmFsQW5kTG9nKCJpbmRleGVkREIub3BlbihuYW1lLCBkZXNjcmlwdGlvbikiKTsKKyAg ICByZXF1ZXN0Lm9uc3VjY2VzcyA9IG9wZW5TdWNjZXNzOworICAgIHJlcXVlc3Qub25lcnJvciA9 IHVuZXhwZWN0ZWRFcnJvckNhbGxiYWNrOworfQorCitmdW5jdGlvbiBvcGVuU3VjY2VzcygpCit7 CisgICAgZGIgPSBldmFsQW5kTG9nKCJkYiA9IGV2ZW50LnRhcmdldC5yZXN1bHQiKTsKKworICAg IHJlcXVlc3QgPSBldmFsQW5kTG9nKCJyZXF1ZXN0ID0gZGIuc2V0VmVyc2lvbignMScpIik7Cisg ICAgcmVxdWVzdC5vbnN1Y2Nlc3MgPSBjcmVhdGVBbmRQb3B1bGF0ZU9iamVjdFN0b3JlOworICAg IHJlcXVlc3Qub25lcnJvciA9IHVuZXhwZWN0ZWRFcnJvckNhbGxiYWNrOworfQorCitmdW5jdGlv biBjcmVhdGVBbmRQb3B1bGF0ZU9iamVjdFN0b3JlKCkKK3sKKyAgICBkZWxldGVBbGxPYmplY3RT dG9yZXMoZGIpOworCisgICAgb2JqZWN0U3RvcmUgPSBldmFsQW5kTG9nKCJvYmplY3RTdG9yZSA9 IGRiLmNyZWF0ZU9iamVjdFN0b3JlKCdmb28nKTsiKTsKKyAgICBzaG91bGRUaHJvdygib2JqZWN0 U3RvcmUucHV0KCk7Iik7CisgICAgc2hvdWxkVGhyb3coIm9iamVjdFN0b3JlLmFkZCgpOyIpOwor ICAgIHNob3VsZFRocm93KCJvYmplY3RTdG9yZS5kZWxldGUoKTsiKTsKKyAgICBzaG91bGRUaHJv dygib2JqZWN0U3RvcmUuZ2V0KCk7Iik7CisgICAgc2hvdWxkVGhyb3coIm9iamVjdFN0b3JlLmNy ZWF0ZUluZGV4KCk7Iik7CisgICAgc2hvdWxkVGhyb3coIm9iamVjdFN0b3JlLmNyZWF0ZUluZGV4 KCdmb28nKTsiKTsKKyAgICBzaG91bGRUaHJvdygib2JqZWN0U3RvcmUuaW5kZXgoKTsiKTsKKyAg ICBzaG91bGRUaHJvdygib2JqZWN0U3RvcmUuZGVsZXRlSW5kZXgoKTsiKTsKKyAgICBkb25lKCk7 Cit9CisKK3ZhciBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOworCit0ZXN0KCk7CisKKzwvc2Ny aXB0PgorPC9ib2R5PgorPC9odG1sPgo=